[GitHub] geode pull request #344: Fix the Native Client Build on Ubuntu

2017-01-18 Thread davinash
GitHub user davinash opened a pull request:

https://github.com/apache/geode/pull/344

Fix the Native Client Build on Ubuntu

verified on Ubuntu and centos

Change is 

```
 ~/source/open/geode/build (next-gen-native-client-software-grant) $ git 
diff
diff --git a/src/cppcache/src/CMakeLists.txt 
b/src/cppcache/src/CMakeLists.txt
index 04c51a0..35b3799 100644
--- a/src/cppcache/src/CMakeLists.txt
+++ b/src/cppcache/src/CMakeLists.txt
@@ -78,11 +78,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL "SunOS")
 set(SOURCES ${SOURCES} $)
   endif()
 endif()
-if (${UNIX})
-  target_link_libraries(_gfcppcache INTERFACE
-  z
-  )
-elseif (${WIN32})
+if (${WIN32})
   target_link_libraries(_gfcppcache INTERFACE
   Dbghelp
   )
@@ -91,6 +87,7 @@ endif()
 target_link_libraries(_gfcppcache INTERFACE
   ACE
   libxml2
+  z
 )
 target_compile_definitions(_gfcppcache INTERFACE
 # TODO replace BUILD_CPPCACHE with built-in _DLL

```

I am not sure why   bc7fa36 is showing in the PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/geode 
next-gen-native-client-software-grant

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #344


commit bc7fa368f987c41a69732e1f452949349acb038f
Author: Jacob Barrett 
Date:   2017-01-17T06:45:45Z

GEODE-2309: Replace Pivotal Copyright and add Apache License notice.

commit 4b3fdbdc08064e56dd11c63115dc64e857dad698
Author: adongre 
Date:   2017-01-18T10:58:10Z

GEODE-2319: change the order of libz for linking




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Native client build fails linking shared library?

2017-01-18 Thread Avinash Dongre
I have fixed and PR is https://github.com/apache/geode/pull/344

Thanks
Avinash


On Wed, Jan 18, 2017 at 10:58 AM, Dan Smith  wrote:

> Update - I found part of the problem - the c++ command that is constructed
> has -lz before /libxml2.a. If I put -lz at the end, it works. From man c++
>
> "Thus, foo.o -lz bar.o searches library z after file foo.o but before
> bar.o.  If bar.o refers to functions in z, those functions may not be
> loaded."
>
> I'm new to cmake so I'm not quite sure how it's constructing this command.
>
> -Dan
>
>
>
> On Tue, Jan 17, 2017 at 7:43 PM, Avinash Dongre 
> wrote:
>
> > I also face the same problem on my Ubuntu box. I have libz installed. But
> > It looks like the way libxml is getting build in external is problem.
> Same
> > work fine on CentOS.
> >
> > When I enabled VERBOSE on for dependencies/libxml2, I do not see
> -lpthread
> > -lz -lm in the CCLD command. [1]
> >
> >
> > Thanks
> > Avinash
> >
> > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=396416
> >
> >
> > On Wed, Jan 18, 2017 at 9:09 AM, Vishal Rao  wrote:
> >
> > > You might need the dev package of libz, something like libz-dev to be
> > > installed.
> > >
> > > On Wed, Jan 18, 2017 at 6:48 AM, Hitesh Khamesra <
> > > hitesh...@yahoo.com.invalid> wrote:
> > >
> > > > see if this link helps "http://stackoverflow.com/
> > > > questions/32036372/ubuntu-14-04-rails-missing-file"
> > > >
> > > >
> > > >   From: Dan Smith 
> > > >  To: dev@geode.apache.org
> > > >  Sent: Tuesday, January 17, 2017 5:04 PM
> > > >  Subject: Re: Native client build fails linking shared library?
> > > >
> > > > Here's the results of the VERBOSE make. I do see a -lz in the linker
> > > line.
> > > >
> > > > [ 28%] Linking CXX executable gfcppcache_unittests
> > > > cd /home/dan/MyStuff/Code/gemfire/native/cppcache/test &&
> > /usr/bin/cmake
> > > > -E cmake_link_script CMakeFiles/gfcppcache_unittests.dir/link.txt
> > > > --verbose=1
> > > > /usr/bin/c++   -g   -m64 CMakeFiles/gfcppcache_unittests.dir/
> > > ByteArrayFixture.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/ExpirationActionTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/PdxLocalReaderTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/DataInputTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/DataOutputTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/ByteArrayTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/NanoTimerTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/AutoDeleteTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/SharedPtrTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/DiskPolicyTypeTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/CacheXmlParserTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/SharedBaseTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/gfcppBannerTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/CacheableKeysTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/TcrMessage_unittest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/InterestResultPolicyTest.cpp.o
> > > > CMakeFiles/gfcppcache_unittests.dir/ByteArray.cpp.o  -o
> > > > gfcppcache_unittests -rdynamic ../src/libgfcppcache-static.a -lz
> > > > ../../dependencies/ACE/ACE-extern-prefix/lib/libACE.a -lpthread -ldl
> > > -lrt
> > > > ../../dependencies/libxml2/libxml2-extern-prefix/lib/libxml2.a
> > > > ../../dependencies/gtest/gtest-extern-prefix/src/gtest-
> > > extern-build//libgtest.a
> > > > ../../dependencies/gtest/gtest-extern-prefix/src/gtest-
> > > > extern-build//libgtest_main.a
> > > > ../../dependencies/libxml2/libxml2-extern-prefix/lib/
> > libxml2.a(xmlIO.o):
> > > > In function `xmlGzfileOpen_real':
> > > > xmlIO.c:(.text+0xf9d): undefined reference to `gzdopen'
> > > >
> > > > -Dan
> > > >
> > > > On Tue, Jan 17, 2017 at 4:43 PM, Jacob Barrett 
> > > > wrote:
> > > >
> > > > Dan,
> > > >
> > > > Add VERBOSE=1 to your make command.
> > > >
> > > > make -j8 VERBOSE=1
> > > >
> > > > To see details of the compile commands. Some of the third party
> > > > dependencies won't show them but give it a try.
> > > >
> > > > -Jake
> > > >
> > > >
> > > > On Tue, Jan 17, 2017 at 4:34 PM Michael William Dodge <
> > mdo...@pivotal.io
> > > >
> > > > wrote:
> > > >
> > > > > Do you see -lz in the link line?
> > > > >
> > > > > Sarge
> > > > >
> > > > > > On 17 Jan, 2017, at 16:24, Dan Smith  wrote:
> > > > > >
> > > > > > I tried building the next-gen-native-client- software-grant
> branch
> > on
> > > > an
> > > > > > ubuntu 16.04 box. It gets about halfway through and then fails
> with
> > > > these
> > > > > > errors. Any ideas?
> > > > > >
> > > > > > [ 49%] Building CXX object
> > > > > > cppcache/src/CMakeFiles/ gfcppcache.dir/PdxLocalWriter. cpp.o
> > > > > > [ 49%] Building CXX object
> > > > > > cppcache/src/CMakeFiles/ gfcppcache.dir/ CacheStatistics.cpp.o
> > > > > > [ 49%] Linking CXX shared library libgfcppcache.so
> > > > > > ../../dependencies/libxml2/ libxml2-extern-prefix/lib/
> > > > libxml2.a(xmlI

[jira] [Created] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Jens Deppe (JIRA)
Jens Deppe created GEODE-2320:
-

 Summary: Update message for minimum JDK version required
 Key: GEODE-2320
 URL: https://issues.apache.org/jira/browse/GEODE-2320
 Project: Geode
  Issue Type: Bug
  Components: build
Reporter: Jens Deppe


The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is required 
as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe reassigned GEODE-2320:
-

Assignee: Jens Deppe

> Update message for minimum JDK version required
> ---
>
> Key: GEODE-2320
> URL: https://issues.apache.org/jira/browse/GEODE-2320
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is 
> required as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe updated GEODE-2320:
--
Affects Version/s: 1.1.0
   1.0.0-incubating

> Update message for minimum JDK version required
> ---
>
> Key: GEODE-2320
> URL: https://issues.apache.org/jira/browse/GEODE-2320
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Minor
>
> The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is 
> required as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe updated GEODE-2320:
--
Priority: Minor  (was: Major)

> Update message for minimum JDK version required
> ---
>
> Key: GEODE-2320
> URL: https://issues.apache.org/jira/browse/GEODE-2320
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Minor
>
> The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is 
> required as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-2321) Pulse application works incorrectly in some locales

2017-01-18 Thread Vadim Lotarev (JIRA)
Vadim Lotarev created GEODE-2321:


 Summary: Pulse application works incorrectly in some locales
 Key: GEODE-2321
 URL: https://issues.apache.org/jira/browse/GEODE-2321
 Project: Geode
  Issue Type: Bug
  Components: pulse
Reporter: Vadim Lotarev


I noticed that Pulse application is not able to show cluster view in my locale. 
Doing some investigations I revealed the warning messages like: 

{{serviceException \[for service ClusterDetails\] = For input string: "2,71"}}
{{serviceException \[for service ClusterMembersRGraph\] = For input string: 
"58,27"}}

I guess the reason is in parsing numeric values - it looks like coma "," is 
hard coded in Pulse as a decimal separator; so if your region settings have 
separate value (like mine - ".") you'll get such a problem. The workaround 
could be to force usage of US region starting locator: {{--J=-Duser.region=US}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Anthony Baker (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828255#comment-15828255
 ] 

Anthony Baker commented on GEODE-2320:
--

Jens, I thought I deleted {{MinimumSystemRequirements}}?

> Update message for minimum JDK version required
> ---
>
> Key: GEODE-2320
> URL: https://issues.apache.org/jira/browse/GEODE-2320
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Minor
>
> The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is 
> required as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

2017-01-18 Thread PivotalSarge
Github user PivotalSarge commented on the issue:

https://github.com/apache/geode/pull/344
  
Elegant. Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Jenkins build is back to normal : Geode-nightly #720

2017-01-18 Thread Apache Jenkins Server
See 



[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

2017-01-18 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode/pull/344
  
I've been down this ordering road before. Pretty sure this change will 
break on Windows and possibly Solaris. If the known to work platforms in the 
BUILDING doc, which have you tested this pull against?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Jens Deppe (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828358#comment-15828358
 ] 

Jens Deppe commented on GEODE-2320:
---

Yes, you're right - I was looking on the wrong branch.

> Update message for minimum JDK version required
> ---
>
> Key: GEODE-2320
> URL: https://issues.apache.org/jira/browse/GEODE-2320
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Minor
>
> The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is 
> required as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe resolved GEODE-2320.
---
   Resolution: Not A Problem
Fix Version/s: 1.1.0

> Update message for minimum JDK version required
> ---
>
> Key: GEODE-2320
> URL: https://issues.apache.org/jira/browse/GEODE-2320
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Minor
> Fix For: 1.1.0
>
>
> The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is 
> required as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (GEODE-2320) Update message for minimum JDK version required

2017-01-18 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe closed GEODE-2320.
-

> Update message for minimum JDK version required
> ---
>
> Key: GEODE-2320
> URL: https://issues.apache.org/jira/browse/GEODE-2320
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Minor
> Fix For: 1.1.0
>
>
> The `MinimumSystemRequirements ` class indicates that JDK 1.7.0_72 is 
> required as a minimum for Geode. This needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-2311) Add CSharp Project for securityImpl for Building Native Client .NET Security Quickstarts

2017-01-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828373#comment-15828373
 ] 

ASF GitHub Bot commented on GEODE-2311:
---

GitHub user mmartell opened a pull request:

https://github.com/apache/geode/pull/345

GEODE-2311: Add cmake support for building the C# security dll used b…

…y the C# security quickstarts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmartell/geode feature/GEODE-2311

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #345


commit 63ff4e528b2398cc6093ba3d04658dfba01db446
Author: Mike Martell 
Date:   2017-01-18T05:08:48Z

GEODE-2311: Add cmake support for building the C# security dll used by the 
C# security quickstarts.




> Add CSharp Project for securityImpl for Building Native Client .NET Security 
> Quickstarts
> 
>
> Key: GEODE-2311
> URL: https://issues.apache.org/jira/browse/GEODE-2311
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>
> Since cmake doesn't yet support C#, we should provide a CSharp project 
> (.csproj file) for easily building the 
> GemStone.GemFire.Templates.Cache.Security.dll, which is needed by the native 
> client C# security quickstarts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] geode pull request #345: GEODE-2311: Add cmake support for building the C# s...

2017-01-18 Thread mmartell
GitHub user mmartell opened a pull request:

https://github.com/apache/geode/pull/345

GEODE-2311: Add cmake support for building the C# security dll used b…

…y the C# security quickstarts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmartell/geode feature/GEODE-2311

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #345


commit 63ff4e528b2398cc6093ba3d04658dfba01db446
Author: Mike Martell 
Date:   2017-01-18T05:08:48Z

GEODE-2311: Add cmake support for building the C# security dll used by the 
C# security quickstarts.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


ApacheCon CFP closing soon (11 February)

2017-01-18 Thread Rich Bowen
Hello, fellow Apache enthusiast. Thanks for your participation, and
interest in, the projects of the Apache Software Foundation.

I wanted to remind you that the Call For Papers (CFP) for ApacheCon
North America, and Apache: Big Data North America, closes in less than a
month. If you've been putting it off because there was lots of time
left, it's time to dig for that inspiration and get those talk proposals in.

It's also time to discuss with your developer and user community whether
there's a track of talks that you might want to propose, so that you
have more complete coverage of your project than a talk or two.

We're looking for talks directly, and indirectly, related to projects at
the Apache Software Foundation. These can be anything from in-depth
technical discussions of the projects you work with, to talks about
community, documentation, legal issues, marketing, and so on. We're also
very interested in talks about projects and services built on top of
Apache projects, and case studies of how you use Apache projects to
solve real-world problems.

We are particularly interested in presentations from Apache projects
either in the Incubator, or recently graduated. ApacheCon is where
people come to find out what technology they'll be using this time next
year.

Important URLs are:

To submit a talk for Apache: Big Data -
http://events.linuxfoundation.org/events/apache-big-data-north-america/program/cfp
To submit a talk for ApacheCon -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp

To register for Apache: Big Data -
http://events.linuxfoundation.org/events/apache-big-data-north-america/attend/register-
To register for ApacheCon -
http://events.linuxfoundation.org/events/apachecon-north-america/attend/register-

Early Bird registration rates end March 12th, but if you're a committer
on an Apache project, you get the low committer rate, which is less than
half of the early bird rate!

For further updated about ApacheCon, follow us on Twitter, @ApacheCon,
or drop by our IRC channel, #apachecon on the Freenode IRC network. Or
contact me - rbo...@apache.org - with any questions or concerns.

Thanks!

Rich Bowen, VP Conferences, Apache Software Foundation

-- 
(You've received this email because you're on a dev@ or users@ mailing
list of an Apache Software Foundation project. For subscription and
unsubscription information, consult the headers of this email message,
as this varies from one list to another.)


Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-18 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55440/#review162131
---


Ship it!




Ship It!

- Dan Smith


On Jan. 18, 2017, 4:19 a.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55440/
> ---
> 
> (Updated Jan. 18, 2017, 4:19 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
> zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Issue(Steps are using GFSH as mentioned in the ticket):
> 1. Indexes are created, and documents are inserted into a persistent region.
> 2. Server is restarted.
> 3. Immediately displaying the lucene index stats shows no documents are 
> indexed
> 4. Run a lucene query, which gets executed successfully.
> 5. Now, displaying index stats with "list lucene index --with-stats" shows 
> the actual number of documents indexed.
> 
> 
> Reason:
> Number of documents indexed is taken from the IndexWriter, which is created 
> lazily when a lucene query is executed. Hence when a persistent server is 
> restarted or a rebalance occurs we lose the stats for number of documents 
> indexed until the IndexWriter is created when a lucene query is executed.
> 
> Solution:
> We attached a listener to each chunk bucket so that when a bucket becomes 
> primary, it initiates the process to create the IndexReposity for the bucket 
> which creates the IndexWriter, thus we get stat for number of documents 
> immediately after a rebalance or a restart occurs.
> When a bucket becomes secondary, it removes its document count from the stats.
> 
> 
> NOTE: IndexWriter can be created only when we have both chuck and file 
> primary bucket present. There can be a possibility that chuck bucket became 
> primary but the file bucket was still in the process of becoming primary 
> hence the IndexRepository creation will result in BucketNotFoundException. If 
> this happens we log a warning and defer the index repository to be created 
> lazily during query excution. Rather than shutting the system down with an 
> exception we give it second chance.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  c760726 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  572b5ea 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
>  5c0c0a0 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java
>  dd52258 
> 
> Diff: https://reviews.apache.org/r/55440/diff/
> 
> 
> Testing
> ---
> 
> 1. Precheckin
> 2. Running gfsh commands to create a persistent server and restarting it and 
> checking the stats are correct.
> 3. Running gfsh command to create two servers and shutting / restarting them 
> alternatively and checking if the stats remain correct after the primary 
> buckets are moved around.
> 
> 
> Thanks,
> 
> nabarun nag
> 
>



[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

2017-01-18 Thread davinash
Github user davinash commented on the issue:

https://github.com/apache/geode/pull/344
  
@pivotal-jbarrett  Yes you are correct, previous change will break windows. 
I have updated PR. Tested on ubuntu and CentOS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

2017-01-18 Thread upthewaterspout
Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/344
  
This PR fixed the issue for me on ubuntu.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-2277) client cache fails to deserialize a PdxInstance due to InternalGemFireError

2017-01-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828442#comment-15828442
 ] 

ASF subversion and git services commented on GEODE-2277:


Commit dc2588bd9ff079ecd74a5190c75442a42bf3b771 in geode's branch 
refs/heads/develop from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=dc2588b ]

GEODE-2277 Now pdxEvent from gateway added through pdx Type registry

This make sure that we have one mechanism to add pdx type into pdx
registry. Added test for it.


> client cache fails to deserialize a PdxInstance due to InternalGemFireError
> ---
>
> Key: GEODE-2277
> URL: https://issues.apache.org/jira/browse/GEODE-2277
> Project: Geode
>  Issue Type: Bug
>  Components: serialization
>Reporter: Bruce Schuchardt
> Fix For: 1.1.0
>
>
> In a WAN configuration using partitioned regions and parallel gateways a 
> client in one of the clusters failed to deserialize a PdxInstance received 
> from one of the other clusters.
> {noformat}
> [error 2016/12/09 22:59:00.930 EST 
> edgegemfire_4_2_rs-intTest-rhel7-2016-12-09-21-33-28-client-12_28424  Client Updater Thread  on 
> rs-intTest-rhel7-2016-12-09-21-33-28-client-12(bridgegemfire_4_4_rs-intTest-rhel7-2016-12-09-21-33-28-client-12_28256:28256):1032
>  port 29079> tid=0x33] Exception occurred in CacheListener
> org.apache.geode.InternalGemFireError: Unable to determine PDXType for id 
> 64307729
> at 
> org.apache.geode.pdx.internal.ClientTypeRegistration.returnCorrectExceptionForFailure(ClientTypeRegistration.java:305)
> at 
> org.apache.geode.pdx.internal.ClientTypeRegistration.getEnumById(ClientTypeRegistration.java:208)
> at 
> org.apache.geode.pdx.internal.LonerTypeRegistration.getEnumById(LonerTypeRegistration.java:133)
> at 
> org.apache.geode.pdx.internal.TypeRegistry.getEnumInfoById(TypeRegistry.java:430)
> at 
> org.apache.geode.pdx.internal.TypeRegistry.getEnumById(TypeRegistry.java:406)
> at 
> org.apache.geode.internal.InternalDataSerializer.readPdxEnum(InternalDataSerializer.java:2258)
> at 
> org.apache.geode.internal.InternalDataSerializer.basicReadObject(InternalDataSerializer.java:3007)
> at 
> org.apache.geode.DataSerializer.readObject(DataSerializer.java:2897)
> at 
> org.apache.geode.pdx.internal.PdxInputStream.readObject(PdxInputStream.java:251)
> at 
> org.apache.geode.pdx.internal.PdxInputStream.readObject(PdxInputStream.java:96)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.readObject(PdxReaderImpl.java:332)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.readObject(PdxReaderImpl.java:325)
> at util.VersionedValueHolder.myFromData(VersionedValueHolder.java:610)
> at 
> util.PdxVersionedValueHolder.fromData(PdxVersionedValueHolder.java:117)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.basicGetObject(PdxReaderImpl.java:737)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.getObject(PdxReaderImpl.java:682)
> at 
> org.apache.geode.internal.InternalDataSerializer.readPdxSerializable(InternalDataSerializer.java:3218)
> at 
> org.apache.geode.internal.InternalDataSerializer.basicReadObject(InternalDataSerializer.java:3005)
> at 
> org.apache.geode.DataSerializer.readObject(DataSerializer.java:2897)
> at 
> org.apache.geode.internal.util.BlobHelper.deserializeBlob(BlobHelper.java:90)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.deserialize(EntryEventImpl.java:1891)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.deserialize(EntryEventImpl.java:1884)
> at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.getDeserializedValue(OffHeapStoredObject.java:447)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.lambda$getNewValue$1(EntryEventImpl.java:951)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.callWithOffHeapLock(EntryEventImpl.java:980)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.getNewValue(EntryEventImpl.java:946)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GEODE-2277) client cache fails to deserialize a PdxInstance due to InternalGemFireError

2017-01-18 Thread Hitesh Khamesra (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hitesh Khamesra resolved GEODE-2277.

Resolution: Fixed

> client cache fails to deserialize a PdxInstance due to InternalGemFireError
> ---
>
> Key: GEODE-2277
> URL: https://issues.apache.org/jira/browse/GEODE-2277
> Project: Geode
>  Issue Type: Bug
>  Components: serialization
>Reporter: Bruce Schuchardt
>Assignee: Hitesh Khamesra
> Fix For: 1.1.0
>
>
> In a WAN configuration using partitioned regions and parallel gateways a 
> client in one of the clusters failed to deserialize a PdxInstance received 
> from one of the other clusters.
> {noformat}
> [error 2016/12/09 22:59:00.930 EST 
> edgegemfire_4_2_rs-intTest-rhel7-2016-12-09-21-33-28-client-12_28424  Client Updater Thread  on 
> rs-intTest-rhel7-2016-12-09-21-33-28-client-12(bridgegemfire_4_4_rs-intTest-rhel7-2016-12-09-21-33-28-client-12_28256:28256):1032
>  port 29079> tid=0x33] Exception occurred in CacheListener
> org.apache.geode.InternalGemFireError: Unable to determine PDXType for id 
> 64307729
> at 
> org.apache.geode.pdx.internal.ClientTypeRegistration.returnCorrectExceptionForFailure(ClientTypeRegistration.java:305)
> at 
> org.apache.geode.pdx.internal.ClientTypeRegistration.getEnumById(ClientTypeRegistration.java:208)
> at 
> org.apache.geode.pdx.internal.LonerTypeRegistration.getEnumById(LonerTypeRegistration.java:133)
> at 
> org.apache.geode.pdx.internal.TypeRegistry.getEnumInfoById(TypeRegistry.java:430)
> at 
> org.apache.geode.pdx.internal.TypeRegistry.getEnumById(TypeRegistry.java:406)
> at 
> org.apache.geode.internal.InternalDataSerializer.readPdxEnum(InternalDataSerializer.java:2258)
> at 
> org.apache.geode.internal.InternalDataSerializer.basicReadObject(InternalDataSerializer.java:3007)
> at 
> org.apache.geode.DataSerializer.readObject(DataSerializer.java:2897)
> at 
> org.apache.geode.pdx.internal.PdxInputStream.readObject(PdxInputStream.java:251)
> at 
> org.apache.geode.pdx.internal.PdxInputStream.readObject(PdxInputStream.java:96)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.readObject(PdxReaderImpl.java:332)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.readObject(PdxReaderImpl.java:325)
> at util.VersionedValueHolder.myFromData(VersionedValueHolder.java:610)
> at 
> util.PdxVersionedValueHolder.fromData(PdxVersionedValueHolder.java:117)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.basicGetObject(PdxReaderImpl.java:737)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.getObject(PdxReaderImpl.java:682)
> at 
> org.apache.geode.internal.InternalDataSerializer.readPdxSerializable(InternalDataSerializer.java:3218)
> at 
> org.apache.geode.internal.InternalDataSerializer.basicReadObject(InternalDataSerializer.java:3005)
> at 
> org.apache.geode.DataSerializer.readObject(DataSerializer.java:2897)
> at 
> org.apache.geode.internal.util.BlobHelper.deserializeBlob(BlobHelper.java:90)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.deserialize(EntryEventImpl.java:1891)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.deserialize(EntryEventImpl.java:1884)
> at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.getDeserializedValue(OffHeapStoredObject.java:447)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.lambda$getNewValue$1(EntryEventImpl.java:951)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.callWithOffHeapLock(EntryEventImpl.java:980)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.getNewValue(EntryEventImpl.java:946)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (GEODE-2277) client cache fails to deserialize a PdxInstance due to InternalGemFireError

2017-01-18 Thread Hitesh Khamesra (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hitesh Khamesra reassigned GEODE-2277:
--

Assignee: Hitesh Khamesra

> client cache fails to deserialize a PdxInstance due to InternalGemFireError
> ---
>
> Key: GEODE-2277
> URL: https://issues.apache.org/jira/browse/GEODE-2277
> Project: Geode
>  Issue Type: Bug
>  Components: serialization
>Reporter: Bruce Schuchardt
>Assignee: Hitesh Khamesra
> Fix For: 1.1.0
>
>
> In a WAN configuration using partitioned regions and parallel gateways a 
> client in one of the clusters failed to deserialize a PdxInstance received 
> from one of the other clusters.
> {noformat}
> [error 2016/12/09 22:59:00.930 EST 
> edgegemfire_4_2_rs-intTest-rhel7-2016-12-09-21-33-28-client-12_28424  Client Updater Thread  on 
> rs-intTest-rhel7-2016-12-09-21-33-28-client-12(bridgegemfire_4_4_rs-intTest-rhel7-2016-12-09-21-33-28-client-12_28256:28256):1032
>  port 29079> tid=0x33] Exception occurred in CacheListener
> org.apache.geode.InternalGemFireError: Unable to determine PDXType for id 
> 64307729
> at 
> org.apache.geode.pdx.internal.ClientTypeRegistration.returnCorrectExceptionForFailure(ClientTypeRegistration.java:305)
> at 
> org.apache.geode.pdx.internal.ClientTypeRegistration.getEnumById(ClientTypeRegistration.java:208)
> at 
> org.apache.geode.pdx.internal.LonerTypeRegistration.getEnumById(LonerTypeRegistration.java:133)
> at 
> org.apache.geode.pdx.internal.TypeRegistry.getEnumInfoById(TypeRegistry.java:430)
> at 
> org.apache.geode.pdx.internal.TypeRegistry.getEnumById(TypeRegistry.java:406)
> at 
> org.apache.geode.internal.InternalDataSerializer.readPdxEnum(InternalDataSerializer.java:2258)
> at 
> org.apache.geode.internal.InternalDataSerializer.basicReadObject(InternalDataSerializer.java:3007)
> at 
> org.apache.geode.DataSerializer.readObject(DataSerializer.java:2897)
> at 
> org.apache.geode.pdx.internal.PdxInputStream.readObject(PdxInputStream.java:251)
> at 
> org.apache.geode.pdx.internal.PdxInputStream.readObject(PdxInputStream.java:96)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.readObject(PdxReaderImpl.java:332)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.readObject(PdxReaderImpl.java:325)
> at util.VersionedValueHolder.myFromData(VersionedValueHolder.java:610)
> at 
> util.PdxVersionedValueHolder.fromData(PdxVersionedValueHolder.java:117)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.basicGetObject(PdxReaderImpl.java:737)
> at 
> org.apache.geode.pdx.internal.PdxReaderImpl.getObject(PdxReaderImpl.java:682)
> at 
> org.apache.geode.internal.InternalDataSerializer.readPdxSerializable(InternalDataSerializer.java:3218)
> at 
> org.apache.geode.internal.InternalDataSerializer.basicReadObject(InternalDataSerializer.java:3005)
> at 
> org.apache.geode.DataSerializer.readObject(DataSerializer.java:2897)
> at 
> org.apache.geode.internal.util.BlobHelper.deserializeBlob(BlobHelper.java:90)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.deserialize(EntryEventImpl.java:1891)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.deserialize(EntryEventImpl.java:1884)
> at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.getDeserializedValue(OffHeapStoredObject.java:447)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.lambda$getNewValue$1(EntryEventImpl.java:951)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.callWithOffHeapLock(EntryEventImpl.java:980)
> at 
> org.apache.geode.internal.cache.EntryEventImpl.getNewValue(EntryEventImpl.java:946)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GEODE-2296) GetFunctionAttribute command is throwing an Anonymouse User Exception

2017-01-18 Thread Hitesh Khamesra (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hitesh Khamesra resolved GEODE-2296.

Resolution: Fixed

> GetFunctionAttribute command is throwing an Anonymouse User Exception
> -
>
> Key: GEODE-2296
> URL: https://issues.apache.org/jira/browse/GEODE-2296
> Project: Geode
>  Issue Type: Bug
>  Components: docs, management, security
>Reporter: Jinmei Liao
> Fix For: 1.1.0
>
>
> When trying to execute a function from a client, we sometimes would get this 
> exception. This is because GetFunctionAttribute is regarded as an internal 
> message, so it's not getting the subject bound to the executing thread, but 
> the cmdExecute method of this command is checking for authorization. Need to 
> remove that check and update the docs to not include this client command.
> [error 2017/01/12 15:25:20.968567 Pacific Standard Time mmartell-Win10:3084 
> 7460] Region::GET_FUNCTION_ATTRIBUTES: An exception 
> (org.apache.geode.security.GemFireSecurityException: Error: Anonymous User
>at 
> org.apache.geode.internal.security.IntegratedSecurityService.getSubject(IntegratedSecurityService.java:114)
>at 
> org.apache.geode.internal.security.IntegratedSecurityService.authorize(IntegratedSecurityService.java:273)
>at 
> org.apache.geode.internal.security.IntegratedSecurityService.authorize(IntegratedSecurityService.java:269)
>at 
> org.apache.geode.internal.security.IntegratedSecurityService.authorize(IntegratedSecurityService.java:264)
>at 
> org.apache.geode.internal.security.IntegratedSecurityService.authorize(IntegratedSecurityService.java:260)
>at 
> org.apache.geode.internal.security.IntegratedSecurityService.authorizeClusterRead(IntegratedSecurityService.java:220)
>at 
> org.apache.geode.internal.cache.tier.sockets.command.GetFunctionAttribute.cmdExecute(GetFunctionAttribute.java:60)
>at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
>at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:776)
>at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:904)
>at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1160)
>at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:519)
>at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-1793) Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL

2017-01-18 Thread Galen O'Sullivan (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828472#comment-15828472
 ] 

Galen O'Sullivan commented on GEODE-1793:
-

Sometimes, there is a RMIException thrown to the actual caller as a result of 
the connect failing, rather than it happening asynchronously. I haven't gone 
deep enough into the locator to find the reason for this, but a fix for the 
test is to catch the exception before it propagates as an RMIException.

> Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL
> ---
>
> Key: GEODE-1793
> URL: https://issues.apache.org/jira/browse/GEODE-1793
> Project: Geode
>  Issue Type: Bug
>  Components: locator
>Reporter: Udo Kohlmeyer
>Priority: Minor
>
> This test fails due to something not cleaning itself properly. Undetermined 
> what the problem is, but it will run perfectly by itself everytime, but once 
> run inside of the TestClass it fails



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (GEODE-1793) Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL

2017-01-18 Thread Galen O'Sullivan (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828477#comment-15828477
 ] 

Galen O'Sullivan edited comment on GEODE-1793 at 1/18/17 6:02 PM:
--

Of note: the Locator makes two socket connections, one to get the header, and 
then one to get the rest of the connection. I feel that this could be better if 
we didn't make so many connections, but that would break backward compatibility.


was (Author: gosullivan):
Of note: the Locator makes two socket connections, one to get the header, and 
then one to get the rest of the connection. I feel that thi

> Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL
> ---
>
> Key: GEODE-1793
> URL: https://issues.apache.org/jira/browse/GEODE-1793
> Project: Geode
>  Issue Type: Bug
>  Components: locator
>Reporter: Udo Kohlmeyer
>Priority: Minor
>
> This test fails due to something not cleaning itself properly. Undetermined 
> what the problem is, but it will run perfectly by itself everytime, but once 
> run inside of the TestClass it fails



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-1793) Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL

2017-01-18 Thread Galen O'Sullivan (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828477#comment-15828477
 ] 

Galen O'Sullivan commented on GEODE-1793:
-

Of note: the Locator makes two socket connections, one to get the header, and 
then one to get the rest of the connection. I feel that thi

> Flaky: LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL
> ---
>
> Key: GEODE-1793
> URL: https://issues.apache.org/jira/browse/GEODE-1793
> Project: Geode
>  Issue Type: Bug
>  Components: locator
>Reporter: Udo Kohlmeyer
>Priority: Minor
>
> This test fails due to something not cleaning itself properly. Undetermined 
> what the problem is, but it will run perfectly by itself everytime, but once 
> run inside of the TestClass it fails



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-2322) Add null parameter with a junction tests to HashIndexQueryIntegrationTest

2017-01-18 Thread Jason Huynh (JIRA)
Jason Huynh created GEODE-2322:
--

 Summary: Add null parameter with a junction tests to 
HashIndexQueryIntegrationTest
 Key: GEODE-2322
 URL: https://issues.apache.org/jira/browse/GEODE-2322
 Project: Geode
  Issue Type: Improvement
  Components: querying
Reporter: Jason Huynh


We should add a queries similar to those found below to 
HashIndexQueryIntegrationTest 
"SELECT * FROM /portfolios p WHERE p.status != null and p.id =1"
"SELECT * FROM /portfolios p WHERE p.status = null and p.id =1"

"SELECT * FROM /portfolios WHERE status = null and id =1"
"SELECT * FROM /portfolios WHERE status != null and id =1"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-2293) The AckReaderThread incorrectly shuts down when an IllegalStateException is thrown while releasing an off-heap object

2017-01-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828510#comment-15828510
 ] 

ASF subversion and git services commented on GEODE-2293:


Commit ad02e975c0cc4f6753dc1edb27926ade49ea8dcb in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ad02e97 ]

GEODE-2293: Queue now handles illegalStateException if thrown when releasing 
off-heap object


> The AckReaderThread incorrectly shuts down when an IllegalStateException is 
> thrown while releasing an off-heap object
> -
>
> Key: GEODE-2293
> URL: https://issues.apache.org/jira/browse/GEODE-2293
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Assignee: Jason Huynh
>  Labels: regression
>
> The regression test run showed the following severe message:
> {noformat}
> [severe 2017/01/07 09:14:40.789 UTC 
> bridgegemfire_1_1_rs-QueuesBTTest-2017-01-06-14-07-15-client-12_3912 
>  GatewaySender_sender_bridgeds_1_to_bridgeds_2_0> tid=0x97] Stopping the 
> processor because the following exception occurred while processing a batch:
> java.lang.IllegalStateException: It looks like off heap memory @7f33a8000238 
> was already freed. rawBits=0 history=null
>   at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.release(OffHeapStoredObject.java:675)
>   at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.release(OffHeapStoredObject.java:659)
>   at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.release(OffHeapStoredObject.java:373)
>   at 
> org.apache.geode.internal.offheap.OffHeapHelper.releaseAndTrackOwner(OffHeapHelper.java:138)
>   at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventImpl.release(GatewaySenderEventImpl.java:1213)
>   at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.remove(ParallelGatewaySenderQueue.java:1096)
>   at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.remove(ParallelGatewaySenderQueue.java:1531)
>   at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.eventQueueRemove(AbstractGatewaySenderEventProcessor.java:231)
>   at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.handleSuccessBatchAck(AbstractGatewaySenderEventProcessor.java:981)
>   at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:636)
> {noformat}
> This exception shows that the {{AckReaderThread}} was processing a successful 
> batch acknowledgement, and an {{IllegalStateException}} was thrown while 
> releasing a {{GatewaySenderEventImpl}} from off-heap memory. This caused the 
> {{AckReaderThread}} to shut down. It looks like the 
> {{GatewaySenderEventImpl}} had already been released and is being released 
> again. I'm not sure how the {{GatewaySenderEventImpl}} got into this state, 
> but the {{AckReaderThread}} should not shut down because of this 
> {{IllegalStateException}}.
> The code in question is in the finally block of 
> {{ParallelGatewaySenderQueue.remove}}:
> {noformat}
> } finally {
>   event.release();
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-1733) Lucene indexes stats are zeroed after recovering from indexes from disk

2017-01-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828643#comment-15828643
 ] 

ASF subversion and git services commented on GEODE-1733:


Commit cae9495aaafbdde4e24110e99aa8a242d9834b76 in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cae9495 ]

GEODE-1733: Lucene stats are displayed correctly.

* Lucene stats are displayed correctly when rebalancing occurs or a 
server is reinstantiated
* Listener added which creates the LuceneIndexRepository when a bucket 
becomes primary.
* LuceneIndexRepository no longer being created lazily.


> Lucene indexes stats are zeroed after recovering from indexes from disk
> ---
>
> Key: GEODE-1733
> URL: https://issues.apache.org/jira/browse/GEODE-1733
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: William Markito Oliveira
>Assignee: nabarun
> Fix For: 1.1.0
>
>
> When recovering from disk the indexes stats are zeroed until a query is 
> executed. 
> {code}
> 
> gfsh>list lucene indexes --with-stats
>Index Name | Region Path |  Indexed Fields  | Field 
> Analyzer |   Status| Query Executions | Updates | Commits | Documents
> - | --- |  | 
> -- | --- |  | --- | --- | 
> -
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionID  | /customer   | [id] | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionID  | /customer   | [id] | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionID  | /customer   | [id] | {}   
>   | Initialized | 0| 0   | 0   | 0
> 
> After query: 
> gfsh>list lucene indexes --with-stats
>Index Name | Region Path |  Indexed Fields  | Field 
> Analyzer |   Status| Query Executions | Updates | Commits | Documents
> - | --- |  | 
> -- | --- |  | --- | --- | 
> -
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionID  | /customer   | [id] | {}   
>   | Initialized | 114  | 0   | 0   | 20644274
> customerRegionID  | /customer   | [id] | {}   
>   | Initialized | 111  | 0   | 0   | 20103890
> customerRegionID  | /customer   | [id] | {}   
>   | Initialized | 114  | 0   | 0   | 20637846
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GEODE-2236) Attempting to remove all CacheListeners from a Region using gfsh throws NullPointerException

2017-01-18 Thread Kevin Duling (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling resolved GEODE-2236.
-
Resolution: Fixed

> Attempting to remove all CacheListeners from a Region using gfsh throws 
> NullPointerException
> 
>
> Key: GEODE-2236
> URL: https://issues.apache.org/jira/browse/GEODE-2236
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Kevin Duling
>Assignee: Deepak Dixit
>
> The --cache-listener option to the alter region command replaces the existing 
> CacheListeners with the ones set in the option.
> What happens in RegionAlterFunction is that the existing CacheListeners not 
> included in the new list are removed, then the new ones are added.
> So, in theory, to remove all CacheListeners, an empty string could be passed 
> into the --cache-listener option like:
> {noformat}
> alter region --name=data --cache-listener=''
> Executing - alter region --name=data --cache-listener=""
> Member  | Status
> --- | 
> --
> server2 | ERROR: java.lang.NullPointerException
>   at com.gemstone.gemfire.manag..
> server1 | ERROR: java.lang.NullPointerException
>   at com.gemstone.gemfire.manag..
> {noformat}
> This actually works but it throws the NPE below.
> {noformat}
> [error 2016/09/13 09:48:59.943 PDT server1  
> tid=0x40] 
> java.lang.NullPointerException
>   at 
> com.gemstone.gemfire.management.internal.cli.functions.RegionAlterFunction.newInstance(RegionAlterFunction.java:320)
>   at 
> com.gemstone.gemfire.management.internal.cli.functions.RegionAlterFunction.alterRegion(RegionAlterFunction.java:228)
>   at 
> com.gemstone.gemfire.management.internal.cli.functions.RegionAlterFunction.execute(RegionAlterFunction.java:64)
>   at 
> com.gemstone.gemfire.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:185)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:386)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:457)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:692)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1149)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}
> A work-around to this issue is to set a non-existent CacheListener in the 
> --cache-listener option like:
> {noformat}
> alter region --name=data --cache-listener=Fred
> Executing - alter region --name=data --cache-listener=Fred
> Member  | Status
> --- | --
> server1 | ERROR: Could not find class "Fred" specified for "cache-listener".
> server2 | ERROR: Could not find class "Fred" specified for "cache-listener".
> {noformat}
> This correctly throws the ClassNotFoundException below and also removes all 
> the existing CacheListeners.
> {noformat}
> [error 2016/09/13 09:46:40.537 PDT server1  
> tid=0x40] Could not find class "Fred" specified for "cache-listener".
> java.lang.RuntimeException: Could not find class "Fred" specified for 
> "cache-listener".
>   at 
> com.gemstone.gemfire.management.internal.cli.functions.RegionAlterFunction.forName(RegionAlterFunction.java:306)
>   at 
> com.gemstone.gemfire.management.internal.cli.functions.RegionAlterFunction.alterRegion(RegionAlterFunction.java:227)
>   at 
> com.gemstone.gemfire.management.internal.cli.functions.RegionAlterFunction.execute(RegionAlterFunction.java:64)
>   at 
> com.gemstone.gemfire.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:185)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:386)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:457)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:692)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1149)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.ClassNotFoundException: Fre

[jira] [Commented] (GEODE-2273) Display the server name while listing the Lucene index stats

2017-01-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828703#comment-15828703
 ] 

ASF subversion and git services commented on GEODE-2273:


Commit edae4abf4def82fd3827a1bd0b7b688b2145294a in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=edae4ab ]

GEODE-2273: Server name is displayed in lucene index stats.

* In gfsh while listing Lucene index stats, it will now display where 
the indexes are hosted.


> Display the server name while listing the Lucene index stats
> 
>
> Key: GEODE-2273
> URL: https://issues.apache.org/jira/browse/GEODE-2273
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Display the server's name hosting the Lucene indexes while listing the Lucene 
> index stats in gfsh.
> Currently we can't distinguish between the listed pairs.
> {noformat}
> 
> gfsh>list lucene indexes --with-stats
>Index Name | Region Path |  Indexed Fields  | Field 
> Analyzer |   Status| Query Executions | Updates | Commits | Documents
> - | --- |  | 
> -- | --- |  | --- | --- | 
> -
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GEODE-2273) Display the server name while listing the Lucene index stats

2017-01-18 Thread nabarun (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun resolved GEODE-2273.

Resolution: Fixed

> Display the server name while listing the Lucene index stats
> 
>
> Key: GEODE-2273
> URL: https://issues.apache.org/jira/browse/GEODE-2273
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
> Fix For: 1.1.0
>
>
> Display the server's name hosting the Lucene indexes while listing the Lucene 
> index stats in gfsh.
> Currently we can't distinguish between the listed pairs.
> {noformat}
> 
> gfsh>list lucene indexes --with-stats
>Index Name | Region Path |  Indexed Fields  | Field 
> Analyzer |   Status| Query Executions | Updates | Commits | Documents
> - | --- |  | 
> -- | --- |  | --- | --- | 
> -
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-2273) Display the server name while listing the Lucene index stats

2017-01-18 Thread nabarun (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun updated GEODE-2273:
---
Fix Version/s: 1.1.0

> Display the server name while listing the Lucene index stats
> 
>
> Key: GEODE-2273
> URL: https://issues.apache.org/jira/browse/GEODE-2273
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
> Fix For: 1.1.0
>
>
> Display the server's name hosting the Lucene indexes while listing the Lucene 
> index stats in gfsh.
> Currently we can't distinguish between the listed pairs.
> {noformat}
> 
> gfsh>list lucene indexes --with-stats
>Index Name | Region Path |  Indexed Fields  | Field 
> Analyzer |   Status| Query Executions | Updates | Commits | Documents
> - | --- |  | 
> -- | --- |  | --- | --- | 
> -
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> customerRegionAll | /customer   | [lastUpdateDateTime, displayNa.. | {}   
>   | Initialized | 0| 0   | 0   | 0
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-1435) Update LICENSE for native client bundled dependencies

2017-01-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828714#comment-15828714
 ] 

ASF subversion and git services commented on GEODE-1435:


Commit 0c9cc052cf9fd6877d2e790019733e42663094be in geode's branch 
refs/heads/next-gen-native-client-software-grant from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0c9cc05 ]

GEODE-1435 Update LICENSE and NOTICE

This closes #343


> Update LICENSE for native client bundled dependencies
> -
>
> Key: GEODE-1435
> URL: https://issues.apache.org/jira/browse/GEODE-1435
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>
> We need to declare attribution for any bundled dependencies in the native 
> client source code.  If we choose to include the native client in the binary 
> distribution, we will need to declare those bundled libraries as well.
> See 
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors.
> Affected files:
> - LICENSE, NOTICE (source distribution)
> - geode-assembly/src/main/dist/LICENSE, NOTICE (binary distribution)
> Initial list of bundled source dependencies:
> - MersenneTwister (src/tests/cpp/fwklib/MersenneTwister.*pp)
> The binary dependencies can be reviewed in 
> geode-client-native/src/dependencies (some of these are not shipped though):
> - libxml2
> - xerces-c
> - openssl
> - ACE
> - antlr
> - sqlite
> - doxygen
> - gtest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] geode pull request #343: GEODE-1435 Update LICENCE and NOTICE

2017-01-18 Thread metatype
Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/343


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-1435) Update LICENSE for native client bundled dependencies

2017-01-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828735#comment-15828735
 ] 

ASF GitHub Bot commented on GEODE-1435:
---

Github user metatype closed the pull request at:

https://github.com/apache/geode/pull/343


> Update LICENSE for native client bundled dependencies
> -
>
> Key: GEODE-1435
> URL: https://issues.apache.org/jira/browse/GEODE-1435
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>
> We need to declare attribution for any bundled dependencies in the native 
> client source code.  If we choose to include the native client in the binary 
> distribution, we will need to declare those bundled libraries as well.
> See 
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors.
> Affected files:
> - LICENSE, NOTICE (source distribution)
> - geode-assembly/src/main/dist/LICENSE, NOTICE (binary distribution)
> Initial list of bundled source dependencies:
> - MersenneTwister (src/tests/cpp/fwklib/MersenneTwister.*pp)
> The binary dependencies can be reviewed in 
> geode-client-native/src/dependencies (some of these are not shipped though):
> - libxml2
> - xerces-c
> - openssl
> - ACE
> - antlr
> - sqlite
> - doxygen
> - gtest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Addressing OOM while recovering overflow regions.

2017-01-18 Thread Anilkumar Gingade
Thanks for all the comments...

As suggested we will go with option#1 and additionally add a system
property to support reading values for lru regions.

-Anil.


On Tue, Jan 17, 2017 at 9:07 PM, Nilkanth Patel 
wrote:

> Anil, option 1 looks good. Just have a small question.
> Will the option 1 implementation going to replace the existing
> implementation where we recover everything?
> Or will this be a default and still user will be able to use old/existing
> way based on some configuration where recovering everything. This may be
> helpful in cases where large heap available.
>
> Nilkanth.
>
> On Wed, Jan 18, 2017 at 10:04 AM, Michael Stolz  wrote:
>
> > Can I assume all options load keys?
> > If so, yes skip loading values.
> >
> > --
> > Mike Stolz
> > Principal Engineer - Gemfire Product Manager
> > Mobile: 631-835-4771
> > On Jan 17, 2017 5:48 PM, "Anilkumar Gingade" 
> wrote:
> >
> > > Hi Geode Devs,
> > >
> > > We are working on ticket GEODE-1672, related to out of memory during
> > > recovery with overflow regions (heap LRU configured).
> > >
> > > https://issues.apache.org/jira/browse/GEODE-1672
> > >
> > > When recovering the persistent files, GEODE stores the values into temp
> > > maps (for regions) using a background thread, as these maps are not
> > actual
> > > regions,  these are not considered/included for LRU eviction, which
> > causes
> > > the system to run OOM.
> > >
> > > We are thinking about following approaches to address this issue...Let
> us
> > > know if you have any comments/suggestion about the solutions.
> > >
> > > 1. Skip recovering the regions marked with LRU eviction.
> > > - This keeps the code changes to minimal.
> > > - Accessing the most recently used values first time, will be
> expensive.
> > > But this is true even if the values are recovered, as Geode doesn't
> > > guarantee the recently/most used values will be in memory after
> recovery.
> > > - This may impact the use-cases where regions are set with LRU
> eviction,
> > > even though there is no  memory pressure (system configured to handle
> > > unexpected events)
> > >
> > > 2. Include temp maps (these are AbstractRegionMap) for eviction during
> > > recovery.
> > > - May involve lots of code change. The size estimation code in bucket
> > > regions need to be moved to AbstractRegionMap.
> > > - Need to handle the rate of recovery thread to throttle based on the
> > > eviction rate, which could impact the recovery of regions without
> > eviction.
> > > We can think of overriding the default eviction rate during recovery...
> > > - The regions will be in the similar state (number of entries), when
> > system
> > > is recovered.
> > >
> > > 3. Stop recovery when system hits critical-heap-memory
> > > - This requires setting/recommending critical-heap-percentage. Throwing
> > > LowMemoryException during recovery, if system is low on memory.
> > > - This may impact the first read on the region whose values are not
> > > recovered.
> > >
> > > Thanks,
> > > -Anil.
> > >
> >
>


[jira] [Resolved] (GEODE-1435) Update LICENSE for native client bundled dependencies

2017-01-18 Thread Anthony Baker (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-1435.
--
Resolution: Fixed

> Update LICENSE for native client bundled dependencies
> -
>
> Key: GEODE-1435
> URL: https://issues.apache.org/jira/browse/GEODE-1435
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>
> We need to declare attribution for any bundled dependencies in the native 
> client source code.  If we choose to include the native client in the binary 
> distribution, we will need to declare those bundled libraries as well.
> See 
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors.
> Affected files:
> - LICENSE, NOTICE (source distribution)
> - geode-assembly/src/main/dist/LICENSE, NOTICE (binary distribution)
> Initial list of bundled source dependencies:
> - MersenneTwister (src/tests/cpp/fwklib/MersenneTwister.*pp)
> The binary dependencies can be reviewed in 
> geode-client-native/src/dependencies (some of these are not shipped though):
> - libxml2
> - xerces-c
> - openssl
> - ACE
> - antlr
> - sqlite
> - doxygen
> - gtest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-2303) Review openssl linking

2017-01-18 Thread Ernest Burghardt (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828753#comment-15828753
 ] 

Ernest Burghardt commented on GEODE-2303:
-

Native Client does not link openssl; however, it does provide example code that 
when compiled (against user provided an openssl library) will link openssl. 
The resulting example library (we call securityImpl) can be dynamically loaded 
at runtime; see the "security quickstarts".
Native Client does not link openssl into any binary, but has the capability to 
utilize cryptography, which [~jbarrett] tells me qualifies to have an ECCN.  
Given this is apart of geode, we should be able to just use geode's ECCN.

> Review openssl linking
> --
>
> Key: GEODE-2303
> URL: https://issues.apache.org/jira/browse/GEODE-2303
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>
> Since we link to the openssl library, we should assess whether an ECCN is 
> required.
> https://www.apache.org/licenses/exports/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-2303) Review openssl linking

2017-01-18 Thread Jacob S. Barrett (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828815#comment-15828815
 ] 

Jacob S. Barrett commented on GEODE-2303:
-

While it is true that we don't ship OpenSSL we are dependent on it for SSL 
connections to the server. It is also true that we don't currently link 
directly to OpenSSL but we link to ACE_SSL which in turn is dynamically linked 
to OpenSSL. What this means for including license statements is an exercise for 
the lawyers but should be similar in nature to Apache httpd. Apache httpd 
project does not call out OpenSSL in its LICENSE or NOTICE files.

In my previous experiences any use of crypto, directly or indirectly, requires 
export control. We should be able to just consider ourselves in the Geode 
Project ECCN.

> Review openssl linking
> --
>
> Key: GEODE-2303
> URL: https://issues.apache.org/jira/browse/GEODE-2303
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Anthony Baker
>
> Since we link to the openssl library, we should assess whether an ECCN is 
> required.
> https://www.apache.org/licenses/exports/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GEODE-2323) JSONFormatter refactor/improvements

2017-01-18 Thread Hitesh Khamesra (JIRA)
Hitesh Khamesra created GEODE-2323:
--

 Summary: JSONFormatter refactor/improvements
 Key: GEODE-2323
 URL: https://issues.apache.org/jira/browse/GEODE-2323
 Project: Geode
  Issue Type: Improvement
  Components: serialization
Reporter: Hitesh Khamesra


1. Maybe this could be a little "smarter". Maybe you have a DataMapperFactory 
or PDXDataMapperFactory. Then this could return you the correct dataMapper.
This is also a pattern that would allow us to be more extendable.

2. The add**Field method all follow a simple pattern... log method and field 
information  add field to a field list

Could we not get a generic method out of this and instead of "copy paste" the 
same logic over and over again... rather call the generic method:

insertField(parentMethodName,fieldName,value,FieldType)

3. maybe a very niche "improvement" but could we be "smart" and order the 
fields in alphabetical AND maybe data types? In ReflectionPdxSerializer we try 
and do fixed length fields before we do variable length. Might be a "nice" 
improvement.

4. Maybe as part of a refactor the Factory can be held onto. According to the 
docs they are reusable and thread-safe.
 An issue was opened.  Fixed  Drop
 
5. Maybe we can have a "getJSONParser(Object input)" method that would return a 
jsonParser. Then we can merge the two fromJson methods or at least not 
duplicate the internals.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 55687: GEODE-2199: be able to deploy jars without running servers

2017-01-18 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55687/
---

Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

* renamed the CliUtils.findAllMatchingServers to findMembersOrThrow to better 
describe the behavior


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
5b9a6bd63350dd753c66fd25e6058ddea45f9325 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
 5154b75e85a42e6d97f5563effe3a7600369126a 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 7df4112950cefcc1ae18bdd88cb752cdec5b7de1 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
 f076cec670a4c787fbe4002edfdacde4b025d1bf 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 14114cff2febf0e1ba7ae67427549ad4fd19ed85 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java
 053f3ebcc74638f992854cdd96d9c586aa33818a 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
 9a9ece952110e90b32e65cbff8ea2319779c4aff 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
 bc436ba40e107b931e8d0d10082e26cf068dd56b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 88a9919802f3d32822f20d3a1c8cfcc4ffa5a6c4 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
 095bd68f54d0f06d9f9439fcaffbca72e49083fc 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java
 78a28d68ea7aa75ab2cda0c01b5a567e3d0d9475 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java
 cbf589185e94345be6fd64ebd630f76e84cc2a09 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/CliUtilDUnitTest.java
 d7d59b71cd54ca23c716e72da413bae6a05e75fd 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java
 c2d511d1c4d34aea434751c2bb5b7e9b924482ad 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java
 51a77d2f4454a772251039a465ab00655a9bea98 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 13442fd68ce2855561fc724bf73cd8c21d2317af 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c 

Diff: https://reviews.apache.org/r/55687/diff/


Testing
---

precheckin running


Thanks,

Jinmei Liao



[jira] [Assigned] (GEODE-2313) PulseDataExportTest.dataBrowserExportWorksAsExpected fails with ConditionTimeoutException

2017-01-18 Thread Jared Stewart (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart reassigned GEODE-2313:


Assignee: Jared Stewart

> PulseDataExportTest.dataBrowserExportWorksAsExpected fails with 
> ConditionTimeoutException
> -
>
> Key: GEODE-2313
> URL: https://issues.apache.org/jira/browse/GEODE-2313
> Project: Geode
>  Issue Type: Bug
>  Components: pulse, tests
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>
> {noformat}
> org.apache.geode.tools.pulse.tests.PulseDataExportTest > 
> dataBrowserExportWorksAsExpected FAILED
> com.jayway.awaitility.core.ConditionTimeoutException: Condition with 
> lambda expression in org.apache.geode.tools.pulse.tests.PulseDataExportTest 
> was not fulfilled within 2 minutes.
> at 
> com.jayway.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:122)
> at 
> com.jayway.awaitility.core.CallableCondition.await(CallableCondition.java:79)
> at 
> com.jayway.awaitility.core.CallableCondition.await(CallableCondition.java:27)
> at 
> com.jayway.awaitility.core.ConditionFactory.until(ConditionFactory.java:764)
> at 
> com.jayway.awaitility.core.ConditionFactory.until(ConditionFactory.java:741)
> at 
> org.apache.geode.tools.pulse.tests.PulseDataExportTest.before(PulseDataExportTest.java:99)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-2294) When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-18 Thread Kevin Duling (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling updated GEODE-2294:

Component/s: management

> When attempting to execute a function via Dev Rest API, error messages are 
> being lost
> -
>
> Key: GEODE-2294
> URL: https://issues.apache.org/jira/browse/GEODE-2294
> Project: Geode
>  Issue Type: Bug
>  Components: management, rest (dev)
>Reporter: Kevin Duling
>
> In FunctionAccessController:
> While debugging the execution of a function via the REST API, a null-pointer 
> exception was thrown and should have returned the error:
> {{Specified key is null and this region does not permit null keys!}}
> instead, an error code of 0 is returned with the message:
> {code}
> {
>   "error": "no response from server"
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-2298) Executing a Function via Swagger without parameters throws an exception

2017-01-18 Thread Kevin Duling (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Duling updated GEODE-2298:

Component/s: management

> Executing a Function via Swagger without parameters throws an exception
> ---
>
> Key: GEODE-2298
> URL: https://issues.apache.org/jira/browse/GEODE-2298
> Project: Geode
>  Issue Type: Bug
>  Components: management, rest (dev)
>Reporter: Kevin Duling
>
> When executing a function with Swagger, if no arguments are specified, the 
> {{FunctionAccessController}} will throw an exception because it incorrectly 
> identifies the JSON of {{"{}"}} to be arguments.
> The solution is to change the test to treat {{"{}"}} as "no arguments".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (GEODE-2306) Update native client BUILDING.md to reflect changes for Geode

2017-01-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828869#comment-15828869
 ] 

ASF GitHub Bot commented on GEODE-2306:
---

Github user PivotalSarge closed the pull request at:

https://github.com/apache/geode/pull/341


> Update native client BUILDING.md to reflect changes for Geode
> -
>
> Key: GEODE-2306
> URL: https://issues.apache.org/jira/browse/GEODE-2306
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Michael Dodge
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] geode pull request #341: GEODE-2306: Update native client BUILDING.md to ref...

2017-01-18 Thread PivotalSarge
Github user PivotalSarge closed the pull request at:

https://github.com/apache/geode/pull/341


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GEODE-2306) Update native client BUILDING.md to reflect changes for Geode

2017-01-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828868#comment-15828868
 ] 

ASF GitHub Bot commented on GEODE-2306:
---

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode/pull/341
  
This closes #341 


> Update native client BUILDING.md to reflect changes for Geode
> -
>
> Key: GEODE-2306
> URL: https://issues.apache.org/jira/browse/GEODE-2306
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Michael Dodge
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] geode issue #341: GEODE-2306: Update native client BUILDING.md to reflect ch...

2017-01-18 Thread PivotalSarge
Github user PivotalSarge commented on the issue:

https://github.com/apache/geode/pull/341
  
This closes #341 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55688/
---

Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-1965
https://issues.apache.org/jira/browse/GEODE-1965


Repository: geode


Description
---

The DUnit distributed unit test framework is extended to have 
Host.getHost(x).getVM(version, vmNumber), allowing you to launch a managed JVM 
running the given version of Geode.

A new class, VersionManager, loads the versions available to test against and 
can be used to parameterize a class to run against all available versions or to 
check whether a version is available for testing.  I've modified a 
client/server test to show how this is done.

Available versions are created as Gradle source-sets in the new 
geode-old-versions submodule.  This submodule has no source files at present.  
All test classes are compiled against the current version of Geode but are run 
with old versions when run in a VM obtained through 
Host.getHost(x).getVM(oldVersion, vmNumber).  Versions are of the form "100", 
"110", "120" etc.  The current version is VersionManager.CURRENT_VERSION, which 
has the value "000".

The DUnit Locator process has been modified to allow peers to start up using 
old versions of Geode.  This isn't normally allowed, but this modification 
makes it easier to test peer-to-peer algorithms that have been modified or 
peer-to-peer messages that have a new on-wire format.


Diffs
-

  geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 7da9de439e28756815e0c5ce3539578c02f22e8f 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 391653cf1f1b9dbcc7bca5232bf6f230d81dc230 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscSelectorDUnitTest.java
 e177b793cc252038cd8e892be07181ec867d44ed 
  geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 
efc196f7998a4ed7410c44346c421e1d8b07d854 
  geode-core/src/test/java/org/apache/geode/test/dunit/Host.java 
43cbccf931e43b1f98c42f82955f824c67279109 
  geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java 
a09f5ff965ec5e705b41b9b94927be919c07afc7 
  geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 
04d29511201fb52b4347c6287f427c3d1a81595f 
  geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 
b85d0b55705ba040f6f954a9847ac00f3a334252 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
 8587ea5e34df82036dbca94602ed2276cef73ca8 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
 c3c33d04014b173d45bf4bbf7c74a10fc0cc1335 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/StandAloneDUnitEnv.java
 3d554edf30c3f703d891f624035c6e918ab16a5b 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
 PRE-CREATION 
  geode-old-versions/build.gradle PRE-CREATION 
  settings.gradle 8e2673a7750ffaf03d9b00778b93fde7831fa0e4 

Diff: https://reviews.apache.org/r/55688/diff/


Testing
---


Thanks,

Bruce Schuchardt



Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55688/
---

(Updated Jan. 18, 2017, 10:32 p.m.)


Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Changes
---

added sample test output


Bugs: GEODE-1965
https://issues.apache.org/jira/browse/GEODE-1965


Repository: geode


Description (updated)
---

The DUnit distributed unit test framework is extended to have 
Host.getHost(x).getVM(version, vmNumber), allowing you to launch a managed JVM 
running the given version of Geode.

A new class, VersionManager, loads the versions available to test against and 
can be used to parameterize a class to run against all available versions or to 
check whether a version is available for testing.  I've modified a 
client/server test to show how this is done.

Available versions are created as Gradle source-sets in the new 
geode-old-versions submodule.  This submodule has no source files at present.  
All test classes are compiled against the current version of Geode but are run 
with old versions when run in a VM obtained through 
Host.getHost(x).getVM(oldVersion, vmNumber).  Versions are of the form "100", 
"110", "120" etc.  The current version is VersionManager.CURRENT_VERSION, which 
has the value "000".

The DUnit Locator process has been modified to allow peers to start up using 
old versions of Geode.  This isn't normally allowed, but this modification 
makes it easier to test peer-to-peer algorithms that have been modified or 
peer-to-peer messages that have a new on-wire format.

Test output looks like this:

[vm_3] [info 2017/01/18 14:08:18.849 PST  tid=0x132] Initializing region 
_gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
 9.0)_1_queue

[vm_3] [info 2017/01/18 14:08:18.850 PST  tid=0x132] Initialization of region 
_gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
 9.0)_1_queue completed

[vm_3] [info 2017/01/18 14:08:18.851 PST  tid=0x132] Entry expiry tasks disabled because the queue became 
primary. Old messageTimeToLive was: 180

[vm_1_v100] [info 2017/01/18 14:08:18.852 PST  tid=0x14] Pool ClientServerMiscDUnitTestPool 
started with multiuser-authentication=false

[vm_1_v100] [info 2017/01/18 14:08:18.855 PST :32771(version:UNKNOWN[ordinal=50]) port 26399> 
tid=0x2b] Cache Client Updater Thread  on 
PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399 
(PIVOTAL-1127.ad.pivotal.io:26399) : ready to process messages.


Diffs
-

  geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 7da9de439e28756815e0c5ce3539578c02f22e8f 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 391653cf1f1b9dbcc7bca5232bf6f230d81dc230 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscSelectorDUnitTest.java
 e177b793cc252038cd8e892be07181ec867d44ed 
  geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 
efc196f7998a4ed7410c44346c421e1d8b07d854 
  geode-core/src/test/java/org/apache/geode/test/dunit/Host.java 
43cbccf931e43b1f98c42f82955f824c67279109 
  geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java 
a09f5ff965ec5e705b41b9b94927be919c07afc7 
  geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 
04d29511201fb52b4347c6287f427c3d1a81595f 
  geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 
b85d0b55705ba040f6f954a9847ac00f3a334252 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
 8587ea5e34df82036dbca94602ed2276cef73ca8 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
 c3c33d04014b173d45bf4bbf7c74a10fc0cc1335 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/StandAloneDUnitEnv.java
 3d554edf30c3f703d891f624035c6e918ab16a5b 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
 PRE-CREATION 
  geode-old-versions/build.gradle PRE-CREATION 
  settings.gradle 8e2673a7750ffaf03d9b00778b93fde7831fa0e4 

Diff: https://reviews.apache.org/r/55688/diff/


Testing
---


Thanks,

Bruce Schuchardt



[jira] [Resolved] (GEODE-2293) The AckReaderThread incorrectly shuts down when an IllegalStateException is thrown while releasing an off-heap object

2017-01-18 Thread Jason Huynh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2293.

   Resolution: Fixed
Fix Version/s: 1.1.0

> The AckReaderThread incorrectly shuts down when an IllegalStateException is 
> thrown while releasing an off-heap object
> -
>
> Key: GEODE-2293
> URL: https://issues.apache.org/jira/browse/GEODE-2293
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Assignee: Jason Huynh
>  Labels: regression
> Fix For: 1.1.0
>
>
> The regression test run showed the following severe message:
> {noformat}
> [severe 2017/01/07 09:14:40.789 UTC 
> bridgegemfire_1_1_rs-QueuesBTTest-2017-01-06-14-07-15-client-12_3912 
>  GatewaySender_sender_bridgeds_1_to_bridgeds_2_0> tid=0x97] Stopping the 
> processor because the following exception occurred while processing a batch:
> java.lang.IllegalStateException: It looks like off heap memory @7f33a8000238 
> was already freed. rawBits=0 history=null
>   at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.release(OffHeapStoredObject.java:675)
>   at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.release(OffHeapStoredObject.java:659)
>   at 
> org.apache.geode.internal.offheap.OffHeapStoredObject.release(OffHeapStoredObject.java:373)
>   at 
> org.apache.geode.internal.offheap.OffHeapHelper.releaseAndTrackOwner(OffHeapHelper.java:138)
>   at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventImpl.release(GatewaySenderEventImpl.java:1213)
>   at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.remove(ParallelGatewaySenderQueue.java:1096)
>   at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.remove(ParallelGatewaySenderQueue.java:1531)
>   at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.eventQueueRemove(AbstractGatewaySenderEventProcessor.java:231)
>   at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.handleSuccessBatchAck(AbstractGatewaySenderEventProcessor.java:981)
>   at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:636)
> {noformat}
> This exception shows that the {{AckReaderThread}} was processing a successful 
> batch acknowledgement, and an {{IllegalStateException}} was thrown while 
> releasing a {{GatewaySenderEventImpl}} from off-heap memory. This caused the 
> {{AckReaderThread}} to shut down. It looks like the 
> {{GatewaySenderEventImpl}} had already been released and is being released 
> again. I'm not sure how the {{GatewaySenderEventImpl}} got into this state, 
> but the {{AckReaderThread}} should not shut down because of this 
> {{IllegalStateException}}.
> The code in question is in the finally block of 
> {{ParallelGatewaySenderQueue.remove}}:
> {noformat}
> } finally {
>   event.release();
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #443 has FAILED (11 tests failed, no failures were new)

2017-01-18 Thread Spring CI

---
Spring Data GemFire > Nightly-ApacheGeode > #443 failed.
---
Scheduled
11/1614 tests failed, no failures were new.

https://build.spring.io/browse/SGF-NAG-443/

-
Currently Responsible
-

John Blum 



--
Failing Jobs
--
  - Default Job (Default Stage): 11 of 1614 tests failed.




--
Tests
--
Existing Test Failures (11)
   - ClientSubRegionTest: Org.springframework.data.gemfire.client. client sub 
region test
   - GemFireDataSourceTest: Org.springframework.data.gemfire.client. gem fire 
data source test
   - GemFireDataSourceWithLocalRegionTest: 
Org.springframework.data.gemfire.client. gem fire data source with local region 
test
   - ContinuousQueryListenerContainerNamespaceTest: 
Org.springframework.data.gemfire.config.xml. continuous query listener 
container namespace test
   - ClientCacheFunctionExecutionWithPdxIntegrationTest: 
Org.springframework.data.gemfire.function. client cache function execution with 
pdx integration test
   - FunctionExecutionTests: 
Org.springframework.data.gemfire.function.execution. function execution tests
   - FunctionIntegrationTests: 
Org.springframework.data.gemfire.function.execution. function integration tests
   - GemfireFunctionTemplateTests: 
Org.springframework.data.gemfire.function.execution. gemfire function template 
tests
   - ListenerContainerTests: Org.springframework.data.gemfire.listener. 
listener container tests
   - ContainerXmlSetupTest: Org.springframework.data.gemfire.listener.adapter. 
container xml setup test
   - RepositoryClientRegionTests: 
Org.springframework.data.gemfire.repository.config. repository client region 
tests

--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55688/
---

(Updated Jan. 18, 2017, 10:58 p.m.)


Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-1965
https://issues.apache.org/jira/browse/GEODE-1965


Repository: geode


Description (updated)
---

The DUnit distributed unit test framework is extended to have 
Host.getHost(x).getVM(version, vmNumber), allowing you to launch a managed JVM 
running the given version of Geode.

A new class, VersionManager, loads the versions available to test against and 
can be used to parameterize a class to run against all available versions or to 
check whether a version is available for testing.  I've modified a 
client/server test to show how this is done.

Available versions are created as Gradle source-sets in the new 
geode-old-versions submodule.  This submodule has no source files at present.  
All test classes in geode-core and other modules are compiled against the 
current version of Geode but are run with old versions when run in a VM 
obtained through Host.getHost(x).getVM(oldVersion, vmNumber).  Versions are of 
the form "100", "110", "120" etc.  The current version is 
VersionManager.CURRENT_VERSION, which has the value "000".

The DUnit Locator process has been modified to allow peers to start up using 
old versions of Geode.  This isn't normally allowed, but this modification 
makes it easier to test peer-to-peer algorithms that have been modified or 
peer-to-peer messages that have a new on-wire format.

Test output looks like this:

[vm_3] [info 2017/01/18 14:08:18.849 PST  tid=0x132] Initializing region 
_gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
 9.0)_1_queue

[vm_3] [info 2017/01/18 14:08:18.850 PST  tid=0x132] Initialization of region 
_gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
 9.0)_1_queue completed

[vm_3] [info 2017/01/18 14:08:18.851 PST  tid=0x132] Entry expiry tasks disabled because the queue became 
primary. Old messageTimeToLive was: 180

[vm_1_v100] [info 2017/01/18 14:08:18.852 PST  tid=0x14] Pool ClientServerMiscDUnitTestPool 
started with multiuser-authentication=false

[vm_1_v100] [info 2017/01/18 14:08:18.855 PST :32771(version:UNKNOWN[ordinal=50]) port 26399> 
tid=0x2b] Cache Client Updater Thread  on 
PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399 
(PIVOTAL-1127.ad.pivotal.io:26399) : ready to process messages.


Diffs
-

  geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 7da9de439e28756815e0c5ce3539578c02f22e8f 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 391653cf1f1b9dbcc7bca5232bf6f230d81dc230 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscSelectorDUnitTest.java
 e177b793cc252038cd8e892be07181ec867d44ed 
  geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 
efc196f7998a4ed7410c44346c421e1d8b07d854 
  geode-core/src/test/java/org/apache/geode/test/dunit/Host.java 
43cbccf931e43b1f98c42f82955f824c67279109 
  geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java 
a09f5ff965ec5e705b41b9b94927be919c07afc7 
  geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 
04d29511201fb52b4347c6287f427c3d1a81595f 
  geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 
b85d0b55705ba040f6f954a9847ac00f3a334252 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
 8587ea5e34df82036dbca94602ed2276cef73ca8 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
 c3c33d04014b173d45bf4bbf7c74a10fc0cc1335 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/StandAloneDUnitEnv.java
 3d554edf30c3f703d891f624035c6e918ab16a5b 
  
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
 PRE-CREATION 
  geode-old-versions/build.gradle PRE-CREATION 
  settings.gradle 8e2673a7750ffaf03d9b00778b93fde7831fa0e4 

Diff: https://reviews.apache.org/r/55688/diff/


Testing
---


Thanks,

Bruce Schuchardt



[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

2017-01-18 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode/pull/344
  
Looking at this a little more... I don't think that gfppcache directly 
depends on -lz. If it is just a transitive dependency from libxml2 then we 
should move the -lz to target library definition for libxml2 and remove it from 
here. @davinash are you interested in taking a stab at that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Udo Kohlmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55688/#review162199
---




geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
 (line 574)


Would a default constructor not make more sense here? An empty string does 
indicate that something was supposed to go here. Is it a place holder?


- Udo Kohlmeyer


On Jan. 18, 2017, 10:58 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55688/
> ---
> 
> (Updated Jan. 18, 2017, 10:58 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-1965
> https://issues.apache.org/jira/browse/GEODE-1965
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The DUnit distributed unit test framework is extended to have 
> Host.getHost(x).getVM(version, vmNumber), allowing you to launch a managed 
> JVM running the given version of Geode.
> 
> A new class, VersionManager, loads the versions available to test against and 
> can be used to parameterize a class to run against all available versions or 
> to check whether a version is available for testing.  I've modified a 
> client/server test to show how this is done.
> 
> Available versions are created as Gradle source-sets in the new 
> geode-old-versions submodule.  This submodule has no source files at present. 
>  All test classes in geode-core and other modules are compiled against the 
> current version of Geode but are run with old versions when run in a VM 
> obtained through Host.getHost(x).getVM(oldVersion, vmNumber).  Versions are 
> of the form "100", "110", "120" etc.  The current version is 
> VersionManager.CURRENT_VERSION, which has the value "000".
> 
> The DUnit Locator process has been modified to allow peers to start up using 
> old versions of Geode.  This isn't normally allowed, but this modification 
> makes it easier to test peer-to-peer algorithms that have been modified or 
> peer-to-peer messages that have a new on-wire format.
> 
> Test output looks like this:
> 
> [vm_3] [info 2017/01/18 14:08:18.849 PST  Thread 1> tid=0x132] Initializing region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue
> 
> [vm_3] [info 2017/01/18 14:08:18.850 PST  Thread 1> tid=0x132] Initialization of region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue completed
> 
> [vm_3] [info 2017/01/18 14:08:18.851 PST  Thread 1> tid=0x132] Entry expiry tasks disabled because the queue became 
> primary. Old messageTimeToLive was: 180
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.852 PST  Connection(1)-10.118.33.195> tid=0x14] Pool ClientServerMiscDUnitTestPool 
> started with multiuser-authentication=false
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.855 PST  on PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399> 
> tid=0x2b] Cache Client Updater Thread  on 
> PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399 
> (PIVOTAL-1127.ad.pivotal.io:26399) : ready to process messages.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  7da9de439e28756815e0c5ce3539578c02f22e8f 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  391653cf1f1b9dbcc7bca5232bf6f230d81dc230 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscSelectorDUnitTest.java
>  e177b793cc252038cd8e892be07181ec867d44ed 
>   geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 
> efc196f7998a4ed7410c44346c421e1d8b07d854 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Host.java 
> 43cbccf931e43b1f98c42f82955f824c67279109 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java 
> a09f5ff965ec5e705b41b9b94927be919c07afc7 
>   geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 
> 04d29511201fb52b4347c6287f427c3d1a81595f 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 
> b85d0b55705ba040f6f954a9847ac00f3a334252 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
>  8587ea5e34df82036dbca94602ed2276cef73ca8 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
>  c3c33d04014b173d45bf4bbf7c74a10fc0cc1335 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/StandAloneDUnitEnv.java
>  3d554edf30c

backward-compatibility testing

2017-01-18 Thread Bruce Schuchardt
I've extended the distributedTest framework to let us do 
backward-compatibility testing.  Once it is reviewed and committed 
people will be needed to modify existing tests to run against multiple 
versions of Geode.


Here is the RB review: https://reviews.apache.org/r/55688/

The diff in this review includes a client/server test modified to run 
against multiple versions.  Basically you just need to parameterize an 
existing distributedTest case to run against multiple versions using 
Host.getHost(0).getVM(testVersion, vmNumber).  That give you a JVM 
that's set up to use the requested version.  You can then use the normal 
method/lambda invocation methods to run code in that JVM.


Currently version "100" (1.0.0-incubating) is available for 
backward-compatibility testing.  Versions to be tested are configured in 
geode-old-versions/build.gradle as source-sets. Adding a new version is 
trivial.


Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Bruce Schuchardt


> On Jan. 18, 2017, 11 p.m., Udo Kohlmeyer wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java,
> >  line 581
> > 
> >
> > Would a default constructor not make more sense here? An empty string 
> > does indicate that something was supposed to go here. Is it a place holder?

I agree with you but JUnit only allows a test to have one constructor.  The 
test needs to create an instance of the class in static methods in order to 
engage the correct superclass methods to get caches and regions.  This doesn't 
involve Host.getHost(x).getVM() calls so it doesn't need a version.


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55688/#review162199
---


On Jan. 18, 2017, 10:58 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55688/
> ---
> 
> (Updated Jan. 18, 2017, 10:58 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-1965
> https://issues.apache.org/jira/browse/GEODE-1965
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The DUnit distributed unit test framework is extended to have 
> Host.getHost(x).getVM(version, vmNumber), allowing you to launch a managed 
> JVM running the given version of Geode.
> 
> A new class, VersionManager, loads the versions available to test against and 
> can be used to parameterize a class to run against all available versions or 
> to check whether a version is available for testing.  I've modified a 
> client/server test to show how this is done.
> 
> Available versions are created as Gradle source-sets in the new 
> geode-old-versions submodule.  This submodule has no source files at present. 
>  All test classes in geode-core and other modules are compiled against the 
> current version of Geode but are run with old versions when run in a VM 
> obtained through Host.getHost(x).getVM(oldVersion, vmNumber).  Versions are 
> of the form "100", "110", "120" etc.  The current version is 
> VersionManager.CURRENT_VERSION, which has the value "000".
> 
> The DUnit Locator process has been modified to allow peers to start up using 
> old versions of Geode.  This isn't normally allowed, but this modification 
> makes it easier to test peer-to-peer algorithms that have been modified or 
> peer-to-peer messages that have a new on-wire format.
> 
> Test output looks like this:
> 
> [vm_3] [info 2017/01/18 14:08:18.849 PST  Thread 1> tid=0x132] Initializing region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue
> 
> [vm_3] [info 2017/01/18 14:08:18.850 PST  Thread 1> tid=0x132] Initialization of region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue completed
> 
> [vm_3] [info 2017/01/18 14:08:18.851 PST  Thread 1> tid=0x132] Entry expiry tasks disabled because the queue became 
> primary. Old messageTimeToLive was: 180
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.852 PST  Connection(1)-10.118.33.195> tid=0x14] Pool ClientServerMiscDUnitTestPool 
> started with multiuser-authentication=false
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.855 PST  on PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399> 
> tid=0x2b] Cache Client Updater Thread  on 
> PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399 
> (PIVOTAL-1127.ad.pivotal.io:26399) : ready to process messages.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  7da9de439e28756815e0c5ce3539578c02f22e8f 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  391653cf1f1b9dbcc7bca5232bf6f230d81dc230 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscSelectorDUnitTest.java
>  e177b793cc252038cd8e892be07181ec867d44ed 
>   geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 
> efc196f7998a4ed7410c44346c421e1d8b07d854 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Host.java 
> 43cbccf931e43b1f98c42f82955f824c67279109 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java 
> a09f5ff965ec5e705b41b9b94927be919c07afc7 
>   geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 
> 04d29511201fb52b4347c6287f427c3d1a81595f 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 
> b85d0b55705ba040f6f954a9847ac00

Re: backward-compatibility testing

2017-01-18 Thread Udo Kohlmeyer

+1 Nice work Bruce


On 1/18/17 15:11, Bruce Schuchardt wrote:
I've extended the distributedTest framework to let us do 
backward-compatibility testing.  Once it is reviewed and committed 
people will be needed to modify existing tests to run against multiple 
versions of Geode.


Here is the RB review: https://reviews.apache.org/r/55688/

The diff in this review includes a client/server test modified to run 
against multiple versions.  Basically you just need to parameterize an 
existing distributedTest case to run against multiple versions using 
Host.getHost(0).getVM(testVersion, vmNumber).  That give you a JVM 
that's set up to use the requested version.  You can then use the 
normal method/lambda invocation methods to run code in that JVM.


Currently version "100" (1.0.0-incubating) is available for 
backward-compatibility testing.  Versions to be tested are configured 
in geode-old-versions/build.gradle as source-sets. Adding a new 
version is trivial.




Re: backward-compatibility testing

2017-01-18 Thread Michael Stolz
+1 I like this

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: 631-835-4771

On Wed, Jan 18, 2017 at 6:22 PM, Udo Kohlmeyer 
wrote:

> +1 Nice work Bruce
>
>
>
> On 1/18/17 15:11, Bruce Schuchardt wrote:
>
>> I've extended the distributedTest framework to let us do
>> backward-compatibility testing.  Once it is reviewed and committed people
>> will be needed to modify existing tests to run against multiple versions of
>> Geode.
>>
>> Here is the RB review: https://reviews.apache.org/r/55688/
>>
>> The diff in this review includes a client/server test modified to run
>> against multiple versions.  Basically you just need to parameterize an
>> existing distributedTest case to run against multiple versions using
>> Host.getHost(0).getVM(testVersion, vmNumber).  That give you a JVM
>> that's set up to use the requested version.  You can then use the normal
>> method/lambda invocation methods to run code in that JVM.
>>
>> Currently version "100" (1.0.0-incubating) is available for
>> backward-compatibility testing.  Versions to be tested are configured in
>> geode-old-versions/build.gradle as source-sets. Adding a new version is
>> trivial.
>>
>
>


[jira] [Created] (GEODE-2324) If AcceptorImpl is interrupted during shutdown, it does not clean up properly.

2017-01-18 Thread Galen O'Sullivan (JIRA)
Galen O'Sullivan created GEODE-2324:
---

 Summary: If AcceptorImpl is interrupted during shutdown, it does 
not clean up properly.
 Key: GEODE-2324
 URL: https://issues.apache.org/jira/browse/GEODE-2324
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Galen O'Sullivan


In `AcceptorImpl,close()`, the call to 
`this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, TimeUnit.MILLISECONDS))` 
can throw an `InterruptedException`, in which case the pool (nor `hsPool`, or 
anything else that comes after) is properly closed and an error message is 
logged.

I believe that the thread will be interrupted if a shutdown command is issued 
(for example, through gfsh), though I haven't created a reproduction yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Udo Kohlmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55688/#review162209
---


Ship it!




Ship It!

- Udo Kohlmeyer


On Jan. 18, 2017, 10:58 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55688/
> ---
> 
> (Updated Jan. 18, 2017, 10:58 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-1965
> https://issues.apache.org/jira/browse/GEODE-1965
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The DUnit distributed unit test framework is extended to have 
> Host.getHost(x).getVM(version, vmNumber), allowing you to launch a managed 
> JVM running the given version of Geode.
> 
> A new class, VersionManager, loads the versions available to test against and 
> can be used to parameterize a class to run against all available versions or 
> to check whether a version is available for testing.  I've modified a 
> client/server test to show how this is done.
> 
> Available versions are created as Gradle source-sets in the new 
> geode-old-versions submodule.  This submodule has no source files at present. 
>  All test classes in geode-core and other modules are compiled against the 
> current version of Geode but are run with old versions when run in a VM 
> obtained through Host.getHost(x).getVM(oldVersion, vmNumber).  Versions are 
> of the form "100", "110", "120" etc.  The current version is 
> VersionManager.CURRENT_VERSION, which has the value "000".
> 
> The DUnit Locator process has been modified to allow peers to start up using 
> old versions of Geode.  This isn't normally allowed, but this modification 
> makes it easier to test peer-to-peer algorithms that have been modified or 
> peer-to-peer messages that have a new on-wire format.
> 
> Test output looks like this:
> 
> [vm_3] [info 2017/01/18 14:08:18.849 PST  Thread 1> tid=0x132] Initializing region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue
> 
> [vm_3] [info 2017/01/18 14:08:18.850 PST  Thread 1> tid=0x132] Initialization of region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue completed
> 
> [vm_3] [info 2017/01/18 14:08:18.851 PST  Thread 1> tid=0x132] Entry expiry tasks disabled because the queue became 
> primary. Old messageTimeToLive was: 180
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.852 PST  Connection(1)-10.118.33.195> tid=0x14] Pool ClientServerMiscDUnitTestPool 
> started with multiuser-authentication=false
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.855 PST  on PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399> 
> tid=0x2b] Cache Client Updater Thread  on 
> PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399 
> (PIVOTAL-1127.ad.pivotal.io:26399) : ready to process messages.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  7da9de439e28756815e0c5ce3539578c02f22e8f 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  391653cf1f1b9dbcc7bca5232bf6f230d81dc230 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscSelectorDUnitTest.java
>  e177b793cc252038cd8e892be07181ec867d44ed 
>   geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 
> efc196f7998a4ed7410c44346c421e1d8b07d854 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Host.java 
> 43cbccf931e43b1f98c42f82955f824c67279109 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java 
> a09f5ff965ec5e705b41b9b94927be919c07afc7 
>   geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 
> 04d29511201fb52b4347c6287f427c3d1a81595f 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 
> b85d0b55705ba040f6f954a9847ac00f3a334252 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
>  8587ea5e34df82036dbca94602ed2276cef73ca8 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
>  c3c33d04014b173d45bf4bbf7c74a10fc0cc1335 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/StandAloneDUnitEnv.java
>  3d554edf30c3f703d891f624035c6e918ab16a5b 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
>  PRE-CREATION 
>   geode-old-versions/build.gradle PRE-CREATION 
>   settings.gradle 8e2673a7750ffaf03d9b00778b93fde7831fa0e4 
> 
> Diff: https://reviews.apache.org/r/55688/d

[jira] [Assigned] (GEODE-2324) If AcceptorImpl is interrupted during shutdown, it does not clean up properly.

2017-01-18 Thread Galen O'Sullivan (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan reassigned GEODE-2324:
---

Assignee: Galen O'Sullivan

> If AcceptorImpl is interrupted during shutdown, it does not clean up properly.
> --
>
> Key: GEODE-2324
> URL: https://issues.apache.org/jira/browse/GEODE-2324
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.0.0-incubating
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> In {{AcceptorImpl,close()}}, the call to 
> {{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, 
> TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which 
> case neither {pool} nor {{hsPool}} or anything else that comes after is 
> properly closed and an error message is logged.
> I believe that the thread will be interrupted if a shutdown command is issued 
> (for example, through gfsh), though I haven't created a reproduction yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-2324) If AcceptorImpl is interrupted during shutdown, it does not clean up properly.

2017-01-18 Thread Galen O'Sullivan (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-2324:

Affects Version/s: 1.0.0-incubating

> If AcceptorImpl is interrupted during shutdown, it does not clean up properly.
> --
>
> Key: GEODE-2324
> URL: https://issues.apache.org/jira/browse/GEODE-2324
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.0.0-incubating
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> In {{AcceptorImpl,close()}}, the call to 
> {{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, 
> TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which 
> case neither {pool} nor {{hsPool}} or anything else that comes after is 
> properly closed and an error message is logged.
> I believe that the thread will be interrupted if a shutdown command is issued 
> (for example, through gfsh), though I haven't created a reproduction yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GEODE-2324) If AcceptorImpl is interrupted during shutdown, it does not clean up properly.

2017-01-18 Thread Galen O'Sullivan (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-2324:

Description: 
In {{AcceptorImpl,close()}}, the call to 
{{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, 
TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which case 
neither {pool} nor {{hsPool}} or anything else that comes after is properly 
closed and an error message is logged.

I believe that the thread will be interrupted if a shutdown command is issued 
(for example, through gfsh), though I haven't created a reproduction yet.

  was:
In `AcceptorImpl,close()`, the call to 
`this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, TimeUnit.MILLISECONDS))` 
can throw an `InterruptedException`, in which case the pool (nor `hsPool`, or 
anything else that comes after) is properly closed and an error message is 
logged.

I believe that the thread will be interrupted if a shutdown command is issued 
(for example, through gfsh), though I haven't created a reproduction yet.


> If AcceptorImpl is interrupted during shutdown, it does not clean up properly.
> --
>
> Key: GEODE-2324
> URL: https://issues.apache.org/jira/browse/GEODE-2324
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.0.0-incubating
>Reporter: Galen O'Sullivan
>
> In {{AcceptorImpl,close()}}, the call to 
> {{this.pool.awaitTermination(PoolImpl.SHUTDOWN_TIMEOUT, 
> TimeUnit.MILLISECONDS))}} can throw an {{InterruptedException}}, in which 
> case neither {pool} nor {{hsPool}} or anything else that comes after is 
> properly closed and an error message is logged.
> I believe that the thread will be interrupted if a shutdown command is issued 
> (for example, through gfsh), though I haven't created a reproduction yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 55688: GEODE-1965 Create backward-compatibility unit test framework

2017-01-18 Thread Hitesh Khamesra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55688/#review162211
---


Ship it!




Ship It!

- Hitesh Khamesra


On Jan. 18, 2017, 10:58 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55688/
> ---
> 
> (Updated Jan. 18, 2017, 10:58 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-1965
> https://issues.apache.org/jira/browse/GEODE-1965
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The DUnit distributed unit test framework is extended to have 
> Host.getHost(x).getVM(version, vmNumber), allowing you to launch a managed 
> JVM running the given version of Geode.
> 
> A new class, VersionManager, loads the versions available to test against and 
> can be used to parameterize a class to run against all available versions or 
> to check whether a version is available for testing.  I've modified a 
> client/server test to show how this is done.
> 
> Available versions are created as Gradle source-sets in the new 
> geode-old-versions submodule.  This submodule has no source files at present. 
>  All test classes in geode-core and other modules are compiled against the 
> current version of Geode but are run with old versions when run in a VM 
> obtained through Host.getHost(x).getVM(oldVersion, vmNumber).  Versions are 
> of the form "100", "110", "120" etc.  The current version is 
> VersionManager.CURRENT_VERSION, which has the value "000".
> 
> The DUnit Locator process has been modified to allow peers to start up using 
> old versions of Geode.  This isn't normally allowed, but this modification 
> makes it easier to test peer-to-peer algorithms that have been modified or 
> peer-to-peer messages that have a new on-wire format.
> 
> Test output looks like this:
> 
> [vm_3] [info 2017/01/18 14:08:18.849 PST  Thread 1> tid=0x132] Initializing region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue
> 
> [vm_3] [info 2017/01/18 14:08:18.850 PST  Thread 1> tid=0x132] Initialization of region 
> _gfe_non_durable_client_with_id_10.118.33.195(12164:loner):51232:7e979fb3(version:GFE
>  9.0)_1_queue completed
> 
> [vm_3] [info 2017/01/18 14:08:18.851 PST  Thread 1> tid=0x132] Entry expiry tasks disabled because the queue became 
> primary. Old messageTimeToLive was: 180
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.852 PST  Connection(1)-10.118.33.195> tid=0x14] Pool ClientServerMiscDUnitTestPool 
> started with multiuser-authentication=false
> 
> [vm_1_v100] [info 2017/01/18 14:08:18.855 PST  on PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399> 
> tid=0x2b] Cache Client Updater Thread  on 
> PIVOTAL-1127(17212):32771(version:UNKNOWN[ordinal=50]) port 26399 
> (PIVOTAL-1127.ad.pivotal.io:26399) : ready to process messages.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  7da9de439e28756815e0c5ce3539578c02f22e8f 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
>  391653cf1f1b9dbcc7bca5232bf6f230d81dc230 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscSelectorDUnitTest.java
>  e177b793cc252038cd8e892be07181ec867d44ed 
>   geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 
> efc196f7998a4ed7410c44346c421e1d8b07d854 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Host.java 
> 43cbccf931e43b1f98c42f82955f824c67279109 
>   geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java 
> a09f5ff965ec5e705b41b9b94927be919c07afc7 
>   geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 
> 04d29511201fb52b4347c6287f427c3d1a81595f 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java 
> b85d0b55705ba040f6f954a9847ac00f3a334252 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
>  8587ea5e34df82036dbca94602ed2276cef73ca8 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
>  c3c33d04014b173d45bf4bbf7c74a10fc0cc1335 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/StandAloneDUnitEnv.java
>  3d554edf30c3f703d891f624035c6e918ab16a5b 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
>  PRE-CREATION 
>   geode-old-versions/build.gradle PRE-CREATION 
>   settings.gradle 8e2673a7750ffaf03d9b00778b93fde7831fa0e4 
> 
> Diff: https://reviews.apache.org/r/55688

[jira] [Created] (GEODE-2325) Improve tests for JarDeployer

2017-01-18 Thread Jared Stewart (JIRA)
Jared Stewart created GEODE-2325:


 Summary: Improve tests for JarDeployer
 Key: GEODE-2325
 URL: https://issues.apache.org/jira/browse/GEODE-2325
 Project: Geode
  Issue Type: Bug
  Components: management
Reporter: Jared Stewart


org.apache.geode.internal.JarDeployer only has a DUnit test right now.  Many of 
those test methods are really just unit tests, and should be extracted to run 
as such.  The tests can also be cleaned up a lot with AssertJ.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (GEODE-2325) Improve tests for JarDeployer

2017-01-18 Thread Jared Stewart (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart reassigned GEODE-2325:


Assignee: Jared Stewart

> Improve tests for JarDeployer
> -
>
> Key: GEODE-2325
> URL: https://issues.apache.org/jira/browse/GEODE-2325
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> org.apache.geode.internal.JarDeployer only has a DUnit test right now.  Many 
> of those test methods are really just unit tests, and should be extracted to 
> run as such.  The tests can also be cleaned up a lot with AssertJ.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: backward-compatibility testing

2017-01-18 Thread William Markito Oliveira
Huge +1

Sent from my iPhone

> On Jan 18, 2017, at 5:45 PM, Michael Stolz  wrote:
> 
> +1 I like this
> 
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: 631-835-4771
> 
> On Wed, Jan 18, 2017 at 6:22 PM, Udo Kohlmeyer 
> wrote:
> 
>> +1 Nice work Bruce
>> 
>> 
>> 
>>> On 1/18/17 15:11, Bruce Schuchardt wrote:
>>> 
>>> I've extended the distributedTest framework to let us do
>>> backward-compatibility testing.  Once it is reviewed and committed people
>>> will be needed to modify existing tests to run against multiple versions of
>>> Geode.
>>> 
>>> Here is the RB review: https://reviews.apache.org/r/55688/
>>> 
>>> The diff in this review includes a client/server test modified to run
>>> against multiple versions.  Basically you just need to parameterize an
>>> existing distributedTest case to run against multiple versions using
>>> Host.getHost(0).getVM(testVersion, vmNumber).  That give you a JVM
>>> that's set up to use the requested version.  You can then use the normal
>>> method/lambda invocation methods to run code in that JVM.
>>> 
>>> Currently version "100" (1.0.0-incubating) is available for
>>> backward-compatibility testing.  Versions to be tested are configured in
>>> geode-old-versions/build.gradle as source-sets. Adding a new version is
>>> trivial.
>>> 
>> 
>> 


Re: Review Request 55687: GEODE-2199: be able to deploy jars without running servers

2017-01-18 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55687/
---

(Updated Jan. 19, 2017, 1:35 a.m.)


Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

* renamed the CliUtils.findAllMatchingServers to findMembersOrThrow to better 
describe the behavior


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
5b9a6bd63350dd753c66fd25e6058ddea45f9325 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
 5154b75e85a42e6d97f5563effe3a7600369126a 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 7df4112950cefcc1ae18bdd88cb752cdec5b7de1 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
 f076cec670a4c787fbe4002edfdacde4b025d1bf 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 14114cff2febf0e1ba7ae67427549ad4fd19ed85 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java
 053f3ebcc74638f992854cdd96d9c586aa33818a 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
 9a9ece952110e90b32e65cbff8ea2319779c4aff 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
 bc436ba40e107b931e8d0d10082e26cf068dd56b 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
 88a9919802f3d32822f20d3a1c8cfcc4ffa5a6c4 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
 095bd68f54d0f06d9f9439fcaffbca72e49083fc 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java
 78a28d68ea7aa75ab2cda0c01b5a567e3d0d9475 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java
 cbf589185e94345be6fd64ebd630f76e84cc2a09 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/CliUtilDUnitTest.java
 d7d59b71cd54ca23c716e72da413bae6a05e75fd 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java
 c2d511d1c4d34aea434751c2bb5b7e9b924482ad 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java
 51a77d2f4454a772251039a465ab00655a9bea98 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 13442fd68ce2855561fc724bf73cd8c21d2317af 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java
 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c 

Diff: https://reviews.apache.org/r/55687/diff/


Testing (updated)
---

precheckin successful


Thanks,

Jinmei Liao



[jira] [Created] (GEODE-2326) Fix broken integration test testLogger

2017-01-18 Thread David Kimura (JIRA)
David Kimura created GEODE-2326:
---

 Summary: Fix broken integration test testLogger
 Key: GEODE-2326
 URL: https://issues.apache.org/jira/browse/GEODE-2326
 Project: Geode
  Issue Type: Test
  Components: native client
Reporter: David Kimura


Banner length is hardcoded in this test.  This led to test broking after 
changing to banner to Apache License.

Test can be fixed by adjusting the hardcoded length like so..
{noformat}
$ git diff
diff --git a/src/cppcache/integration-test/testLogger.cpp 
b/src/cppcache/integration-test/testLogger.cpp
index 6de4e68..8695bf1 100644
--- a/src/cppcache/integration-test/testLogger.cpp
+++ b/src/cppcache/integration-test/testLogger.cpp
@@ -24,7 +24,7 @@
 #include 
 #endif

-#define LENGTH_OF_BANNER 9
+#define LENGTH_OF_BANNER 16

 using namespace gemfire;
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


New Committer And PMC Member: Kevin Duling

2017-01-18 Thread Mark Bretl
The Apache Geode Project Management Committee has invited Kevin Duling to
be committer on the project and join the Geode PMC. We are pleased to
announce he has accepted.

Please join me in welcoming Kevin!

Sincerely,

Mark Bretl
On behalf of the Apache Geode PMC


New PMC Member: Ken Howe

2017-01-18 Thread Mark Bretl
The Apache Geode Project Management Committee has invited Ken Howe to join
the Geode PMC. We are pleased to announce he has accepted.

Please join me in welcoming Ken!

Sincerely,

Mark Bretl
On behalf of the Apache Geode PMC


ApacheCon/Big Data 2017 - Anyone attending or submitting talks ?

2017-01-18 Thread William Markito Oliveira
CFP closes on Feb 11th.

http://events.linuxfoundation.org/events/apache-big-data-north-america/program/cfp
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp