Re: [PR] [experiment] Deterministic Hash Function for Upsert Type-4 UUID Primary Keys [pinot]
codecov-commenter commented on PR #12538: URL: https://github.com/apache/pinot/pull/12538#issuecomment-1974701871 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `18 lines` in your changes are missing coverage. Please review. > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5d19f6d`)](https://app.codecov.io/gh/apache/pinot/pull/12538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 40 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/pinot/pull/12538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/pinot/segment/local/utils/HashUtils.java](https://app.codecov.io/gh/apache/pinot/pull/12538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91dGlscy9IYXNoVXRpbHMuamF2YQ==) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/pinot/spi/config/table/HashFunction.java](https://app.codecov.io/gh/apache/pinot/pull/12538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL0hhc2hGdW5jdGlvbi5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12538 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2374 -62 Lines133233 129819 -3414 Branches 2063620136 -500 = - Hits 822740-82274 - Misses44911 129819+84908 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.75%)` | :arrow_down: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/12538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=co
[PR] bugfix: do not move src ByteBuffer position for LZ4 length prefixed decompress [pinot]
itschrispeck opened a new pull request, #12539: URL: https://github.com/apache/pinot/pull/12539 Addresses https://github.com/apache/pinot/issues/12534 Based on my understanding, calling `_decompressor.decompress(compressedInput, decompressedOutput)` is problematic because it [moves the position](https://javadoc.io/doc/org.lz4/lz4-java/1.6.0/net/jpountz/lz4/LZ4DecompressorWithLength.html#decompress(java.nio.ByteBuffer,%20java.nio.ByteBuffer)) of the src and dest ByteBuffers. It is possible to move the position of the src buffer beyond the limit of the buffer (see issue for details). The change calls the [same underlying method](https://github.com/lz4/lz4-java/blob/master/src/java/net/jpountz/lz4/LZ4DecompressorWithLength.java#L246), but only moves the position of the dest buffer. The reason why this was a V4 raw index writer/reader version is that this only happens with the length prefixed LZ4 library, and this code path is not used for other raw index writer versions. Testing: Unit tested, now able to read a previously broken segment when loading it using PinotSegmentRecordReader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] bugfix: do not move src ByteBuffer position for LZ4 length prefixed decompress [pinot]
codecov-commenter commented on PR #12539: URL: https://github.com/apache/pinot/pull/12539#issuecomment-1974741659 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12539?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `3 lines` in your changes are missing coverage. Please review. > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`055aa92`)](https://app.codecov.io/gh/apache/pinot/pull/12539?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 40 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/pinot/pull/12539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ocal/io/compression/LZ4WithLengthDecompressor.java](https://app.codecov.io/gh/apache/pinot/pull/12539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9pby9jb21wcmVzc2lvbi9MWjRXaXRoTGVuZ3RoRGVjb21wcmVzc29yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12539 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2374 -62 Lines133233 129804 -3429 Branches 2063620135 -501 = - Hits 822740-82274 - Misses44911 129804+84893 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.75%)` | :arrow_down: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.76%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit
Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]
codecov-commenter commented on PR #12537: URL: https://github.com/apache/pinot/pull/12537#issuecomment-1974751774 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `28 lines` in your changes are missing coverage. Please review. > Project coverage is 0.00%. Comparing base [(`640ebe5`)](https://app.codecov.io/gh/apache/pinot/commit/640ebe52cf19922530b67f354126d007e3b650a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`49119d8`)](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 142 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...t/controller/api/resources/PinotQueryResource.java](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90UXVlcnlSZXNvdXJjZS5qYXZh) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/pinot/sql/parsers/parser/SqlShowTables.java](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9wYXJzZXIvU3FsU2hvd1RhYmxlcy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12537 +/- ## = - Coverage 61.58%0.00% -61.59% = Files 2415 2375 -40 Lines131502 129828 -1674 Branches 2031020137 -173 = - Hits 809880-80988 - Misses44587 129828+85241 + Partials 59270 -5927 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12537/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.48%)` | :arrow_down: | | [skip-bytebuffers-false](https:/
Re: [PR] DRAFT: Adding SHOW TABLES/DESCRIBE table support [pinot]
xiangfu0 commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1509943974
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##
@@ -243,10 +246,17 @@ private String getQueryResponse(String query, @Nullable
SqlNode sqlNode, String
// Get resource table name.
String tableName;
try {
- String inputTableName =
- sqlNode != null ?
RequestUtils.getTableNames(CalciteSqlParser.compileSqlNodeToPinotQuery(sqlNode)).iterator()
- .next() :
CalciteSqlCompiler.compileToBrokerRequest(query).getQuerySource().getTableName();
- tableName =
_pinotHelixResourceManager.getActualTableName(inputTableName);
+ if (sqlNode != null) {
+PinotQuery pinotQuery =
CalciteSqlParser.compileSqlNodeToPinotQuery(sqlNode);
+if (pinotQuery.isShowTables()) {
+ return showTablesResponse();
+}
+String inputTableName =
RequestUtils.getTableNames(pinotQuery).iterator().next();
+tableName =
_pinotHelixResourceManager.getActualTableName(inputTableName);
Review Comment:
this is for pinot controller only, what if the query is sent to pinot broker?
I feel you can call getTables API for response then wrap it as query
response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[PR] maven-compiler-plugin 3.12.1 [pinot]
sullis opened a new pull request, #12540: URL: https://github.com/apache/pinot/pull/12540 https://maven.apache.org/plugins/maven-compiler-plugin/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[PR] scala-maven-plugin 4.8.1 [pinot]
sullis opened a new pull request, #12541: URL: https://github.com/apache/pinot/pull/12541 https://mvnrepository.com/artifact/net.alchim31.maven/scala-maven-plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[PR] s3mock 3.5.1 [pinot]
sullis opened a new pull request, #12542: URL: https://github.com/apache/pinot/pull/12542 https://github.com/adobe/S3Mock https://mvnrepository.com/artifact/com.adobe.testing/s3mock-testcontainers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] maven-compiler-plugin 3.12.1 [pinot]
codecov-commenter commented on PR #12540: URL: https://github.com/apache/pinot/pull/12540#issuecomment-1974866415 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b42d70a`)](https://app.codecov.io/gh/apache/pinot/pull/12540?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 40 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12540 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2374 -62 Lines133233 129802 -3431 Branches 2063620135 -501 = - Hits 822740-82274 - Misses44911 129802+84891 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.75%)` | :arrow_down: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-27.73%)` | :arrow_down: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.76%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12540?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr
Re: [PR] scala-maven-plugin 4.8.1 [pinot]
codecov-commenter commented on PR #12541: URL: https://github.com/apache/pinot/pull/12541#issuecomment-1974867556 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`235242e`)](https://app.codecov.io/gh/apache/pinot/pull/12541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 40 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12541 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2374 -62 Lines133233 129802 -3431 Branches 2063620135 -501 = - Hits 822740-82274 - Misses44911 129802+84891 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-27.73%)` | :arrow_down: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.76%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12541/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=r
Re: [PR] s3mock 3.5.1 [pinot]
codecov-commenter commented on PR #12542: URL: https://github.com/apache/pinot/pull/12542#issuecomment-1974868463 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12542?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ce6c33d`)](https://app.codecov.io/gh/apache/pinot/pull/12542?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 40 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12542 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2374 -62 Lines133233 129802 -3431 Branches 2063620135 -501 = - Hits 822740-82274 - Misses44911 129802+84891 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.75%)` | :arrow_down: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.76%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12542?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=r
[PR] remove duplicate scala.version [pinot]
sullis opened a new pull request, #12543: URL: https://github.com/apache/pinot/pull/12543 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] maven-compiler-plugin 3.12.1 [pinot]
sullis commented on PR #12540: URL: https://github.com/apache/pinot/pull/12540#issuecomment-1974870365 Ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [I] [Flaky test] CaseTransformFunctionTest. testCaseTransformFunctionWithIntResults() [pinot]
aditya0811 commented on issue #12367: URL: https://github.com/apache/pinot/issues/12367#issuecomment-1974871309 Hey Jackie, sorry I am not able to follow. Lets say `_floatSVValues[INDEX_TO_COMPARE] = 0.1f`. In the case block in L721 in `CaseTransformFunctionTest` we are considering this as float `0.1f`. Lets say `_floatSVValues[i]=0.2f`. So the comparison is happening in the case block as, considering `GREATER_THAN_OR_EQUAL` `0.2f >= 0.1f` The `_floatSVValues[INDEX_TO_COMPARE]` when considered as `LiteralTransformFunction` is getting parsed as double i.e. `0.1d`. So now the comparison is happening as `(double) 0.2f >= 0.1d` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] mockito 5.11.0 [pinot]
sullis commented on PR #12536: URL: https://github.com/apache/pinot/pull/12536#issuecomment-1974877481 ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] remove duplicate scala.version [pinot]
codecov-commenter commented on PR #12543: URL: https://github.com/apache/pinot/pull/12543#issuecomment-1974877630 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12543?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3fc4954`)](https://app.codecov.io/gh/apache/pinot/pull/12543?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 40 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12543 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2374 -62 Lines133233 129802 -3431 Branches 2063620135 -501 = - Hits 822740-82274 - Misses44911 129802+84891 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-27.73%)` | :arrow_down: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (-61.76%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12543?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=r
Re: [PR] Added /uptime and /start-time for all components. Addressed comments and fixed tests from pull request 12389. [pinot]
suyashpatel98 commented on PR #12512: URL: https://github.com/apache/pinot/pull/12512#issuecomment-1974897213 ForwardIndexHandlerTest.testAddOtherIndexForForwardIndexDisabledColumn() is a flaky test. There is an existing open issue - #11928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] bugfix: do not move src ByteBuffer position for LZ4 length prefixed decompress [pinot]
richardstartin commented on PR #12539: URL: https://github.com/apache/pinot/pull/12539#issuecomment-1974909646 This is a good catch. I have a couple of remarks: 1. It would be good to add a test because this is a subtle bug that has been hiding in plain sight for over two years, and it could regress in refactoring 2. Whilst I introduced this bug and am a committer, I’m not really involved in the project any more and can only rubber stamp this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] remove duplicate scala.version [pinot]
sullis commented on PR #12543: URL: https://github.com/apache/pinot/pull/12543#issuecomment-1974926663 ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]
tibrewalpratik17 opened a new pull request, #12544: URL: https://github.com/apache/pinot/pull/12544 label: `bugfix` Potential fix for #12397 As called out in the issue: ``` With Partial Upserts, say we had 4 events for a given primary-key in the Mutable Segment: R0, R1, R2, R3. Let's also assume that the comparison column value of these events is: R0 < R1 < (R2 = R3). If after applying the sorted column, their order changes to: R0, R1, R3, R2, then the UMM will start pointing to R2 as the valid doc. ``` Now based on the assumption that R3's docId will be greater than R2's docId, raising this fix as an echancement to fix in #12395 where in case of same comparison column value we also check the docID value to know for a particular segment which one to keep. cc @ankitsultana @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]
codecov-commenter commented on PR #12544: URL: https://github.com/apache/pinot/pull/12544#issuecomment-1974945339 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `3 lines` in your changes are missing coverage. Please review. > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5a5878c`)](https://app.codecov.io/gh/apache/pinot/pull/12544?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 40 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/pinot/pull/12544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...cal/upsert/BasePartitionUpsertMetadataManager.java](https://app.codecov.io/gh/apache/pinot/pull/12544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91cHNlcnQvQmFzZVBhcnRpdGlvblVwc2VydE1ldGFkYXRhTWFuYWdlci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12544 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2374 -62 Lines133233 129804 -3429 Branches 2063620136 -500 = - Hits 822740-82274 - Misses44911 129804+84893 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.75%)` | :arrow_down: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-61.76%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12544/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit
Re: [PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]
ankitsultana commented on code in PR #12544:
URL: https://github.com/apache/pinot/pull/12544#discussion_r1510117525
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##
@@ -640,7 +640,10 @@ protected static Iterator
resolveComparisonTies(
return recordInfo;
}
int comparisonResult =
newComparisonValue.compareTo(maxComparisonValueRecordInfo.getComparisonValue());
-if (comparisonResult >= 0) {
+if (comparisonResult > 0) {
+ return recordInfo;
+}
+if (comparisonResult == 0 && recordInfo.getDocId() >
maxComparisonValueRecordInfo.getDocId()) {
Review Comment:
I think this is incorrect.
recordInfoIterator and this function iterates over the new segment. We can't
pick the record with the latest doc-id in the new segment.
To fix this, for each docId in the new segment, you need to get the docId in
the old segment, and keep the record which had the highest docId in the old
segment.
That is a bit of an involved problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
svn commit: r67670 - /dev/pinot/apache-pinot-1.1.0-rc0/
Author: vvivekiyer Date: Sun Mar 3 01:00:00 2024 New Revision: 67670 Log: Delete release-1.1.0-rc0 Removed: dev/pinot/apache-pinot-1.1.0-rc0/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
(pinot) annotated tag release-1.1.0-rc0 deleted (was 37bd7be690)
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0-rc0 was deleted! *** tag was 37bd7be690 The revisions that were on this annotated tag are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
(pinot) branch local-release-1.1.0-rc created (now ce94496e2e)
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to branch local-release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git at ce94496e2e Update license & notice for release 1.1.0 No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
(pinot) branch local-release-1.1.0-rc deleted (was ce94496e2e)
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to branch local-release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git was ce94496e2e Update license & notice for release 1.1.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
(pinot) branch release-1.1.0-rc updated (64f9d792f1 -> ce94496e2e)
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard 64f9d792f1 [maven-release-plugin] prepare for next development iteration discard 49ee95a75b [maven-release-plugin] prepare release release-1.1.0-rc0 This update removed existing revisions from the reference, leaving the reference pointing at a previous point in the repository history. * -- * -- N refs/heads/release-1.1.0-rc (ce94496e2e) \ O -- O -- O (64f9d792f1) Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: contrib/pinot-fmpp-maven-plugin/pom.xml| 6 ++- pinot-broker/pom.xml | 5 ++- pinot-clients/pinot-java-client/pom.xml| 5 ++- pinot-clients/pinot-jdbc-client/pom.xml| 8 ++-- pinot-clients/pom.xml | 6 ++- pinot-common/pom.xml | 43 +++--- pinot-compatibility-verifier/pom.xml | 5 ++- pinot-connectors/pinot-flink-connector/pom.xml | 6 ++- pinot-connectors/pinot-spark-2-connector/pom.xml | 5 ++- pinot-connectors/pinot-spark-3-connector/pom.xml | 5 ++- pinot-connectors/pinot-spark-common/pom.xml| 5 ++- pinot-connectors/pom.xml | 6 ++- pinot-controller/pom.xml | 5 ++- pinot-core/pom.xml | 5 ++- pinot-distribution/pom.xml | 9 +++-- pinot-integration-test-base/pom.xml| 5 ++- pinot-integration-tests/pom.xml| 5 ++- pinot-minion/pom.xml | 5 ++- pinot-perf/pom.xml | 5 ++- .../pinot-batch-ingestion-common/pom.xml | 6 ++- .../pinot-batch-ingestion-hadoop/pom.xml | 6 ++- .../pinot-batch-ingestion-spark-2.4/pom.xml| 6 ++- .../pinot-batch-ingestion-spark-3/pom.xml | 6 ++- .../pinot-batch-ingestion-standalone/pom.xml | 6 ++- pinot-plugins/pinot-batch-ingestion/pom.xml| 6 ++- .../pinot-environment/pinot-azure/pom.xml | 6 ++- pinot-plugins/pinot-environment/pom.xml| 6 ++- pinot-plugins/pinot-file-system/pinot-adls/pom.xml | 5 ++- pinot-plugins/pinot-file-system/pinot-gcs/pom.xml | 6 ++- pinot-plugins/pinot-file-system/pinot-hdfs/pom.xml | 5 ++- pinot-plugins/pinot-file-system/pinot-s3/pom.xml | 9 +++-- pinot-plugins/pinot-file-system/pom.xml| 6 ++- .../pinot-input-format/pinot-avro-base/pom.xml | 5 ++- .../pinot-input-format/pinot-avro/pom.xml | 5 ++- .../pinot-input-format/pinot-clp-log/pom.xml | 5 ++- .../pinot-confluent-avro/pom.xml | 5 ++- pinot-plugins/pinot-input-format/pinot-csv/pom.xml | 5 ++- .../pinot-input-format/pinot-json/pom.xml | 5 ++- pinot-plugins/pinot-input-format/pinot-orc/pom.xml | 6 ++- .../pinot-input-format/pinot-parquet/pom.xml | 5 ++- .../pinot-input-format/pinot-protobuf/pom.xml | 5 ++- .../pinot-input-format/pinot-thrift/pom.xml| 5 ++- pinot-plugins/pinot-input-format/pom.xml | 6 ++- .../pinot-metrics/pinot-dropwizard/pom.xml | 5 ++- pinot-plugins/pinot-metrics/pinot-yammer/pom.xml | 5 ++- pinot-plugins/pinot-metrics/pom.xml| 6 ++- .../pinot-minion-builtin-tasks/pom.xml | 5 ++- pinot-plugins/pinot-minion-tasks/pom.xml | 6 ++- .../pinot-segment-uploader-default/pom.xml | 6 ++- pinot-plugins/pinot-segment-uploader/pom.xml | 6 ++- .../pinot-segment-writer-file-based/pom.xml| 6 ++- pinot-plugins/pinot-segment-writer/pom.xml | 6 ++- .../pinot-stream-ingestion/pinot-kafka-2.0/pom.xml | 6 ++- .../pinot-kafka-base/pom.xml | 6 ++- .../pinot-stream-ingestion/pinot-kinesis/pom.xml | 12 -- .../pinot-stream-ingestion/pinot-pulsar/pom.xml| 6 ++- pinot-plugins/pinot-stream-ingestion/pom.xml | 6 ++- pinot-plugins/pom.xml | 11 -- pinot-query-planner/pom.xml| 5 ++- pinot-query-runtime/pom.xml| 5 ++- pinot-segment-local/pom.xml| 5 ++- pinot-segment-spi/pom.xml | 5 ++- pinot-server/pom.xml | 5 ++- pinot-spi/pom.xml | 5 ++- pinot-tools/pom.xml| 5 ++- pom.xml| 11 +++--- 66 files changed, 262 insertions(+), 162 deletions(-) - To unsubscribe, e-mail
(pinot) branch release-1.1.0-rc updated: [maven-release-plugin] prepare release release-1.1.0-rc0
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.1.0-rc by this push: new b10b4dd249 [maven-release-plugin] prepare release release-1.1.0-rc0 b10b4dd249 is described below commit b10b4dd249e99b3939729d0af7e53e6a829b7f1c Author: Vivek Iyer Vaidyanathan AuthorDate: Sat Mar 2 18:19:10 2024 -0800 [maven-release-plugin] prepare release release-1.1.0-rc0 --- contrib/pinot-fmpp-maven-plugin/pom.xml| 6 +-- pinot-broker/pom.xml | 5 +-- pinot-clients/pinot-java-client/pom.xml| 5 +-- pinot-clients/pinot-jdbc-client/pom.xml| 8 ++-- pinot-clients/pom.xml | 6 +-- pinot-common/pom.xml | 43 +++--- pinot-compatibility-verifier/pom.xml | 5 +-- pinot-connectors/pinot-flink-connector/pom.xml | 6 +-- pinot-connectors/pinot-spark-2-connector/pom.xml | 5 +-- pinot-connectors/pinot-spark-3-connector/pom.xml | 5 +-- pinot-connectors/pinot-spark-common/pom.xml| 5 +-- pinot-connectors/pom.xml | 6 +-- pinot-controller/pom.xml | 5 +-- pinot-core/pom.xml | 5 +-- pinot-distribution/pom.xml | 9 ++--- pinot-integration-test-base/pom.xml| 5 +-- pinot-integration-tests/pom.xml| 5 +-- pinot-minion/pom.xml | 5 +-- pinot-perf/pom.xml | 5 +-- .../pinot-batch-ingestion-common/pom.xml | 6 +-- .../pinot-batch-ingestion-hadoop/pom.xml | 6 +-- .../pinot-batch-ingestion-spark-2.4/pom.xml| 6 +-- .../pinot-batch-ingestion-spark-3/pom.xml | 6 +-- .../pinot-batch-ingestion-standalone/pom.xml | 6 +-- pinot-plugins/pinot-batch-ingestion/pom.xml| 6 +-- .../pinot-environment/pinot-azure/pom.xml | 6 +-- pinot-plugins/pinot-environment/pom.xml| 6 +-- pinot-plugins/pinot-file-system/pinot-adls/pom.xml | 5 +-- pinot-plugins/pinot-file-system/pinot-gcs/pom.xml | 6 +-- pinot-plugins/pinot-file-system/pinot-hdfs/pom.xml | 5 +-- pinot-plugins/pinot-file-system/pinot-s3/pom.xml | 9 ++--- pinot-plugins/pinot-file-system/pom.xml| 6 +-- .../pinot-input-format/pinot-avro-base/pom.xml | 5 +-- .../pinot-input-format/pinot-avro/pom.xml | 5 +-- .../pinot-input-format/pinot-clp-log/pom.xml | 5 +-- .../pinot-confluent-avro/pom.xml | 5 +-- pinot-plugins/pinot-input-format/pinot-csv/pom.xml | 5 +-- .../pinot-input-format/pinot-json/pom.xml | 5 +-- pinot-plugins/pinot-input-format/pinot-orc/pom.xml | 6 +-- .../pinot-input-format/pinot-parquet/pom.xml | 5 +-- .../pinot-input-format/pinot-protobuf/pom.xml | 5 +-- .../pinot-input-format/pinot-thrift/pom.xml| 5 +-- pinot-plugins/pinot-input-format/pom.xml | 6 +-- .../pinot-metrics/pinot-dropwizard/pom.xml | 5 +-- pinot-plugins/pinot-metrics/pinot-yammer/pom.xml | 5 +-- pinot-plugins/pinot-metrics/pom.xml| 6 +-- .../pinot-minion-builtin-tasks/pom.xml | 5 +-- pinot-plugins/pinot-minion-tasks/pom.xml | 6 +-- .../pinot-segment-uploader-default/pom.xml | 6 +-- pinot-plugins/pinot-segment-uploader/pom.xml | 6 +-- .../pinot-segment-writer-file-based/pom.xml| 6 +-- pinot-plugins/pinot-segment-writer/pom.xml | 6 +-- .../pinot-stream-ingestion/pinot-kafka-2.0/pom.xml | 6 +-- .../pinot-kafka-base/pom.xml | 6 +-- .../pinot-stream-ingestion/pinot-kinesis/pom.xml | 12 ++ .../pinot-stream-ingestion/pinot-pulsar/pom.xml| 6 +-- pinot-plugins/pinot-stream-ingestion/pom.xml | 6 +-- pinot-plugins/pom.xml | 11 ++ pinot-query-planner/pom.xml| 5 +-- pinot-query-runtime/pom.xml| 5 +-- pinot-segment-local/pom.xml| 5 +-- pinot-segment-spi/pom.xml | 5 +-- pinot-server/pom.xml | 5 +-- pinot-spi/pom.xml | 5 +-- pinot-tools/pom.xml| 5 +-- pom.xml| 13 +++ 66 files changed, 163 insertions(+), 263 deletions(-) diff --git a/contrib/pinot-fmpp-maven-plugin/pom.xml b/contrib/pinot-fmpp-maven-plugin/pom.xml index 94df4afc49..94fc21d142 100644 --- a/contrib/pinot-fmpp-maven-plugin/pom.xml +++ b/contrib/pinot-fmpp-maven-plugin/pom.xml @@ -19,14 +19,12 @@ under the License. --> -http://maven.apache.org/POM/4.0.0"; -
(pinot) annotated tag release-1.1.0-rc0 updated (b10b4dd249 -> 5c1f08d2cc)
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0-rc0 was modified! *** from b10b4dd249 (commit) to 5c1f08d2cc (tag) tagging b10b4dd249e99b3939729d0af7e53e6a829b7f1c (commit) by Vivek Iyer Vaidyanathan on Sat Mar 2 18:19:30 2024 -0800 - Log - [maven-release-plugin] copy for tag release-1.1.0-rc0 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
(pinot) branch release-1.1.0-rc updated: [maven-release-plugin] prepare for next development iteration
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.1.0-rc by this push: new d3d3089e37 [maven-release-plugin] prepare for next development iteration d3d3089e37 is described below commit d3d3089e3757db9fd6d963d2aa8c72bc1c0dcc04 Author: Vivek Iyer Vaidyanathan AuthorDate: Sat Mar 2 18:19:43 2024 -0800 [maven-release-plugin] prepare for next development iteration --- contrib/pinot-fmpp-maven-plugin/pom.xml | 2 +- pinot-broker/pom.xml | 2 +- pinot-clients/pinot-java-client/pom.xml | 2 +- pinot-clients/pinot-jdbc-client/pom.xml | 2 +- pinot-clients/pom.xml | 2 +- pinot-common/pom.xml | 2 +- pinot-compatibility-verifier/pom.xml | 2 +- pinot-connectors/pinot-flink-connector/pom.xml| 2 +- pinot-connectors/pinot-spark-2-connector/pom.xml | 2 +- pinot-connectors/pinot-spark-3-connector/pom.xml | 2 +- pinot-connectors/pinot-spark-common/pom.xml | 2 +- pinot-connectors/pom.xml | 2 +- pinot-controller/pom.xml | 2 +- pinot-core/pom.xml| 2 +- pinot-distribution/pom.xml| 2 +- pinot-integration-test-base/pom.xml | 2 +- pinot-integration-tests/pom.xml | 2 +- pinot-minion/pom.xml | 2 +- pinot-perf/pom.xml| 2 +- .../pinot-batch-ingestion/pinot-batch-ingestion-common/pom.xml| 2 +- .../pinot-batch-ingestion/pinot-batch-ingestion-hadoop/pom.xml| 2 +- .../pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/pom.xml | 2 +- .../pinot-batch-ingestion/pinot-batch-ingestion-spark-3/pom.xml | 2 +- .../pinot-batch-ingestion/pinot-batch-ingestion-standalone/pom.xml| 2 +- pinot-plugins/pinot-batch-ingestion/pom.xml | 2 +- pinot-plugins/pinot-environment/pinot-azure/pom.xml | 2 +- pinot-plugins/pinot-environment/pom.xml | 2 +- pinot-plugins/pinot-file-system/pinot-adls/pom.xml| 2 +- pinot-plugins/pinot-file-system/pinot-gcs/pom.xml | 2 +- pinot-plugins/pinot-file-system/pinot-hdfs/pom.xml| 2 +- pinot-plugins/pinot-file-system/pinot-s3/pom.xml | 2 +- pinot-plugins/pinot-file-system/pom.xml | 2 +- pinot-plugins/pinot-input-format/pinot-avro-base/pom.xml | 2 +- pinot-plugins/pinot-input-format/pinot-avro/pom.xml | 2 +- pinot-plugins/pinot-input-format/pinot-clp-log/pom.xml| 2 +- pinot-plugins/pinot-input-format/pinot-confluent-avro/pom.xml | 2 +- pinot-plugins/pinot-input-format/pinot-csv/pom.xml| 2 +- pinot-plugins/pinot-input-format/pinot-json/pom.xml | 2 +- pinot-plugins/pinot-input-format/pinot-orc/pom.xml| 2 +- pinot-plugins/pinot-input-format/pinot-parquet/pom.xml| 2 +- pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml | 2 +- pinot-plugins/pinot-input-format/pinot-thrift/pom.xml | 2 +- pinot-plugins/pinot-input-format/pom.xml | 2 +- pinot-plugins/pinot-metrics/pinot-dropwizard/pom.xml | 2 +- pinot-plugins/pinot-metrics/pinot-yammer/pom.xml | 2 +- pinot-plugins/pinot-metrics/pom.xml | 2 +- pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/pom.xml | 2 +- pinot-plugins/pinot-minion-tasks/pom.xml | 2 +- .../pinot-segment-uploader/pinot-segment-uploader-default/pom.xml | 2 +- pinot-plugins/pinot-segment-uploader/pom.xml | 2 +- .../pinot-segment-writer/pinot-segment-writer-file-based/pom.xml | 2 +- pinot-plugins/pinot-segment-writer/pom.xml| 2 +- pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/pom.xml | 2 +- pinot-plugins/pinot-stream-ingestion/pinot-kafka-base/pom.xml | 2 +- pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml| 2 +- pinot-plugins/pinot-stream-ingestion/pinot-pulsar/pom.xml | 2 +- pinot-plugins/pinot-stream-ingestion/pom.xml
svn commit: r67672 - /dev/pinot/apache-pinot-1.1.0-rc0/
Author: vvivekiyer Date: Sun Mar 3 06:18:35 2024 New Revision: 67672 Log: Update apache-pinot-1.1.0-rc0 Added: dev/pinot/apache-pinot-1.1.0-rc0/ dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz (with props) dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.asc dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.sha512 dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz (with props) dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.asc dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.sha512 Added: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz == Binary file - no diff available. Propchange: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz -- svn:mime-type = application/octet-stream Added: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.asc == --- dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.asc (added) +++ dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.asc Sun Mar 3 06:18:35 2024 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIzBAABCgAdFiEENiqOdbaORSx9yMhgHStvc66iVoIFAmXkDdsACgkQHStvc66i +VoIE4xAA1wpMlvsB1qej0fkbjBJqLEqEQWFYMj9uh3uaetJF68Y7k3FFHJL9AGCC +WKF2MdTKzqpqHVirA6wqpXJPC5KYFrK+7ud4ckPKRV75yLt5wDlmyak1SuYp7nFw +F5Q+rqN9Iid8nUrJATPap4vPSdvM2h5eROJqSXThe0ZbPOcrd7QIrxnGftNUzSf2 +F3wGyOPVoGiblVVBZxUGoMl0/OnEhpPG5g9USoZIew7JkfGOcNDxVZypRbqwfq4R ++5E3j+kAdP3T7kErIRv6+qoxTc5kFhX+Jr74yp3lckfa+cQVsNfMx6OjL6i6OOdn +stobHKdusa0fwYlO2yavcGJaoR5TyAu7x2Yq6Ni2do/l8aQtoxAG0LgZAeqd9aXk +Vwy5vakoYBiuDTWkb8iX9LNC6AJtFVf5NjwG6UwemOLpgGCTUsHTnoElIjURaDsK +qmsv1H7q9OFzdRJqPnqs3AN6J542tCeRFZJlsUDf5U9OewP43vdK2vUCDWBzqVBv +SvmAVgGLMKxFr8TZ3R1j/JXKU5CL6/nL+1vgNb+1/m9+8yDyaHAw3oDGL64lalqt +56OrjyUD4DOL3QSrCwFQ+tPTEcQ+lvGxg5idNvpbczE7cTIMxapZ1+R63b6TTQBS +6lehjKqc9jBDYGw5Qowz3p531+DkqfCfqHP25geooXZ9G0o0zJs= +=I4c8 +-END PGP SIGNATURE- Added: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.sha512 == --- dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.sha512 (added) +++ dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-bin.tar.gz.sha512 Sun Mar 3 06:18:35 2024 @@ -0,0 +1 @@ +0a821972dec7953c79d4c7a8736a1677210fa4397c3322d195464953f0d5afef0227a222c07f2b81ef59bbea1fd3233d2e15d59f316041af9d8bf50fd92116b2 \ No newline at end of file Added: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz == Binary file - no diff available. Propchange: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz -- svn:mime-type = application/octet-stream Added: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.asc == --- dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.asc (added) +++ dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.asc Sun Mar 3 06:18:35 2024 @@ -0,0 +1,16 @@ +-BEGIN PGP SIGNATURE- + +iQIyBAABCAAdFiEENiqOdbaORSx9yMhgHStvc66iVoIFAmXkEC4ACgkQHStvc66i +VoINWg/3aQTsopufssZtlTZq9RZ3mh0XwMqltfeXDGQC1TsabCSoDGmTRDj3A5Nq +KkVdlPqpwh/80JjSkQfElBfOvnnrOCIXIE4ASXm8wX3CjQMP8zSAr4RR0NkW +a/z5LEF2IfkB+d6HqUerNq8IiHIjB8egHJD64/4bkBkKOEbdoN53UcbqZ3qONUno +mQ0Lh5mZi2qjDDa0yeni7yMY8YrlznB8RRRIpf+V2XW/aZYuMIxhSu2TOHHmHKsn +YjClxr/gje8FogmbsvWIaUkCp4KFX/QX2ts4dOIIZCKtH6lvF8tizTAfZBJ3osSS +im6Q/2oaZFpRvurdfOBeale8+saUZ7BNr0/4hz1ji0NlzAu8PGAOgfROuI9DANWX +etJ0Xg/ImMhkCGo7XePsAvIg3TfTdTwdz140O2BYblBPt7Yo7mscYs2BRBYPvlDl +1VSGSqepQP8r9O/BgAFSVSd9nGmcpJ8yZ7qQx7NdNp8eQJcmg3Svgknz2f8bUNBu +XGkIUmwPkizSeXSW8zI2nyPLZZb8JcQtllXYD1kpsjpnTIlFpBqiUAEPPSxr/z7p +rz6N1XDX+J07A1r3BPd4rTOmZNprWrsWOdh8dOFwTCamswul1J69s0ahugiv3eVX +M+rMYofpTAfGW2Q2hu3DAIwnb758iVzJhHBvbmT2iRERI/bWug== +=L6ey +-END PGP SIGNATURE- Added: dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.sha512 == --- dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.sha512 (added) +++ dev/pinot/apache-pinot-1.1.0-rc0/apache-pinot-1.1.0-src.tar.gz.sha512 Sun Mar 3 06:18:35 2024 @@ -0,0 +1 @@ +62324e6ecf2cdc7d07baa279bbc9fa1ed51276ccf73a7939b09473b8ceabe626f0ddc48a53470af011954ae464efe97d5265ae571a62cf11580b290a864d1ef1 \ No newline at end of file - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
