richardstartin commented on PR #12539: URL: https://github.com/apache/pinot/pull/12539#issuecomment-1974909646
This is a good catch. I have a couple of remarks: 1. It would be good to add a test because this is a subtle bug that has been hiding in plain sight for over two years, and it could regress in refactoring 2. Whilst I introduced this bug and am a committer, I’m not really involved in the project any more and can only rubber stamp this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
