Re: [PR] branch-2.1: [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … #49677 [doris]
hello-stephen commented on PR #49724: URL: https://github.com/apache/doris/pull/49724#issuecomment-2767876791 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [fix](test) Complete the missing db name in check_before_quit test #49674 [doris]
github-actions[bot] opened a new pull request, #49726: URL: https://github.com/apache/doris/pull/49726 Cherry-picked from #49674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-2.1: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 [doris]
github-actions[bot] opened a new pull request, #49725: URL: https://github.com/apache/doris/pull/49725 Cherry-picked from #49678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](shutdown) Fix coredump due to shutdown in the wrong order (#49700)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 476f7349391 [fix](shutdown) Fix coredump due to shutdown in the wrong
order (#49700)
476f7349391 is described below
commit 476f7349391abf58e5d269807476df10526a3e78
Author: Gabriel
AuthorDate: Tue Apr 1 09:02:23 2025 +0800
[fix](shutdown) Fix coredump due to shutdown in the wrong order (#49700)
### What problem does this PR solve?
When a BE is down, global object should shut down following a specific
order to ensure BE will not crash. Because all running queries will
finish once fragment mgr finished, stream mgr must be released before it
because it may wake up some blocked tasks.
#0 __GI___pthread_sigmask (how=2, newmask=, oldmask=0x0)
at ./nptl/pthread_sigmask.c:43
#1 0x7f842b2bb71e in PosixSignals::chained_handler(int, siginfo*,
void*) [clone .part.0] () from
/usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
#2 0x7f842b2bc206 in JVM_handle_linux_signal () from
/usr/lib/jvm/java-17-openjdk-amd64/lib/server/libjvm.so
#3
#4 ___pthread_mutex_lock (mutex=0x1b8) at ./nptl/pthread_mutex_lock.c:80
#5 0x55c5f03edcca in __gthread_mutex_lock (__mutex=0x1b8) at
/var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/x86_64-linux-gnu/c++/11/bits/gthr-default.h:749
#6 std::mutex::lock (this=0x1b8) at
/var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_mutex.h:100
#7 std::lock_guard::lock_guard (__m=..., this=) at
/var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_mutex.h:229
#8 doris::RuntimeProfile::add_info_string (this=0x0, key=..., value=...)
at
/home/zcp/repo_center/doris_master/doris/be/src/util/runtime_profile.cpp:354
#9 0x55c5f9cccaa7 in
doris::pipeline::PipelineTask::_state_transition (this=0x7f84015b4000,
new_state=doris::pipeline::PipelineTask::State::RUNNABLE) at
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_task.h:339
#10 0x55c5fa53aec5 in doris::pipeline::PipelineTask::wake_up
(this=0x7fffbd28a8e8, dep=) at
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_task.cpp:748
#11 0x55c5f9cba3f5 in doris::pipeline::Dependency::set_ready
(this=0x7f832f848310) at
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/dependency.cpp:72
#12 0x55c5f9c53bcd in
doris::vectorized::VDataStreamRecvr::SenderQueue::set_source_ready
(this=0x7f839d485880) at
/home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.cpp:142
#13 doris::vectorized::VDataStreamRecvr::SenderQueue::close
(this=0x7f839d485880) at
/home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.cpp:301
#14 0x55c5f9c55b39 in doris::vectorized::VDataStreamRecvr::close
(this=0x7f83fbe78940) at
/home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_recvr.cpp:488
#15 0x55c5f9c4dc68 in
doris::vectorized::VDataStreamMgr::~VDataStreamMgr (this=0x7f83f6d99da0)
at
/home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vdata_stream_mgr.cpp:58
#16 0x55c5f00cb651 in doris::ExecEnv::destroy (this=0x55c5fdf7a198
) at
/home/zcp/repo_center/doris_master/doris/be/src/runtime/exec_env_init.cpp:796
#17 0x55c5ef387909 in main (argc=, argv=) at
/home/zcp/repo_center/doris_master/doris/be/src/service/doris_main.cpp:635
---
be/src/runtime/exec_env_init.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp
index 55f05a69ae2..a260bbd1092 100644
--- a/be/src/runtime/exec_env_init.cpp
+++ b/be/src/runtime/exec_env_init.cpp
@@ -772,6 +772,7 @@ void ExecEnv::destroy() {
SAFE_DELETE(_bfd_parser);
SAFE_DELETE(_result_cache);
+SAFE_DELETE(_vstream_mgr);
SAFE_DELETE(_fragment_mgr);
SAFE_DELETE(_workload_sched_mgr);
SAFE_DELETE(_workload_group_manager);
@@ -793,7 +794,6 @@ void ExecEnv::destroy() {
SAFE_DELETE(_backend_client_cache);
SAFE_DELETE(_result_queue_mgr);
-SAFE_DELETE(_vstream_mgr);
SAFE_DELETE(_external_scan_context_mgr);
SAFE_DELETE(_user_function_cache);
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 [doris]
Thearas commented on PR #49725: URL: https://github.com/apache/doris/pull/49725#issuecomment-2767877096 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Compaction) Cumulative Points Not Incrementing After Delete Operation [doris]
luwei16 commented on code in PR #47282: URL: https://github.com/apache/doris/pull/47282#discussion_r1959557421 ## be/src/cloud/cloud_cumulative_compaction_policy.cpp: ## @@ -209,10 +209,9 @@ int64_t CloudSizeBasedCumulativeCompactionPolicy::new_cumulative_point( config::compaction_promotion_version_count; // if rowsets have delete version, move to the last directly. // if rowsets have no delete version, check output_rowset total disk size satisfies promotion size. -return output_rowset->start_version() == last_cumulative_point && - (last_delete_version.first != -1 || -output_rowset->total_disk_size() >= cloud_promotion_size(tablet) || -satisfy_promotion_version) +return (last_delete_version.first != -1 || Review Comment: This issue is better tested through unit tests; add some unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](test) Complete the missing db name in check_before_quit test [doris]
dataroaring merged PR #49674: URL: https://github.com/apache/doris/pull/49674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … #49677 [doris]
github-actions[bot] opened a new pull request, #49722: URL: https://github.com/apache/doris/pull/49722 Cherry-picked from #49677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](test) Complete the missing db name in check_before_quit test #49674 [doris]
dataroaring closed pull request #49726: branch-3.0: [fix](test) Complete the missing db name in check_before_quit test #49674 URL: https://github.com/apache/doris/pull/49726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](test) Complete the missing db name in check_before_quit test #49674 [doris]
Thearas commented on PR #49726: URL: https://github.com/apache/doris/pull/49726#issuecomment-2767878371 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](case) Fix cold data compaction fault injection case [doris]
dataroaring merged PR #49699: URL: https://github.com/apache/doris/pull/49699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49677-branch-2.1 created (now ed8531b99ad)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49677-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git at ed8531b99ad branch-2.1: [feat](regression) inject debug points need run in nonConcurrent or docker suites #49581 (#49618) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … #49677 [doris]
hello-stephen commented on PR #49722: URL: https://github.com/apache/doris/pull/49722#issuecomment-2767875499 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … #49677 [doris]
hello-stephen commented on PR #49722: URL: https://github.com/apache/doris/pull/49722#issuecomment-2767875390 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](microbench) Fix some file cache microbench compile bug [doris]
BiteThet merged PR #49269: URL: https://github.com/apache/doris/pull/49269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (fbd0b380d1d -> a2a495083f2)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from fbd0b380d1d [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … (#49677) add a2a495083f2 [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… (#49678) No new revisions were added by this update. Summary of changes: .../java/org/apache/doris/common/ThriftServer.java | 51 +- 1 file changed, 49 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 [doris]
dataroaring closed pull request #49725: branch-2.1: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 URL: https://github.com/apache/doris/pull/49725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49678-branch-2.1 updated (ed8531b99ad -> 5e3fc332beb)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49678-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from ed8531b99ad branch-2.1: [feat](regression) inject debug points need run in nonConcurrent or docker suites #49581 (#49618) add 5e3fc332beb [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… (#49678) No new revisions were added by this update. Summary of changes: .../java/org/apache/doris/common/ThriftServer.java | 51 +- 1 file changed, 49 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… [doris]
dataroaring merged PR #49678: URL: https://github.com/apache/doris/pull/49678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 [doris]
dataroaring closed pull request #49723: branch-3.0: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 URL: https://github.com/apache/doris/pull/49723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch vector-index-dev created (now 9bcbf33d3b1)
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch vector-index-dev in repository https://gitbox.apache.org/repos/asf/doris.git at 9bcbf33d3b1 [fix](test) Complete the missing db name in check_before_quit test (#49674) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Fix inaccurate memory size for metadata [doris]
wangbo commented on PR #49147: URL: https://github.com/apache/doris/pull/49147#issuecomment-2767901021 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improve](string) remove check for string type can't as distributed hash key [doris]
zhangstar333 opened a new pull request, #49727: URL: https://github.com/apache/doris/pull/49727 ### What problem does this PR solve? Problem Summary: remove check for string type can't as distributed hash key ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement unlockTablesCommand in nereids [doris]
starocean999 merged PR #49664: URL: https://github.com/apache/doris/pull/49664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](terminate) add terminate interface [doris]
doris-robot commented on PR #49638: URL: https://github.com/apache/doris/pull/49638#issuecomment-2768357935 TPC-DS: Total hot run time: 193509 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit bf88de086dc84380e9c6b8feaf48cf1d0f735299, data reload: false query1 1387103510221022 query2 6124188018781878 query3 11018 465444754475 query4 53989 25182 23202 23202 query5 5136566 469 469 query6 356 209 197 197 query7 4898501 288 288 query8 307 238 221 221 query9 5804254625512546 query10 422 311 261 261 query11 15259 15045 14857 14857 query12 169 112 104 104 query13 1053524 421 421 query14 10160 634764066347 query15 206 195 181 181 query16 7050699 515 515 query17 1100744 612 612 query18 1542418 343 343 query19 199 202 180 180 query20 137 140 121 121 query21 211 133 108 108 query22 4312462044034403 query23 34153 33149 33310 33149 query24 6671247324832473 query25 454 473 410 410 query26 701 295 159 159 query27 2337510 340 340 query28 3174244124932441 query29 566 562 426 426 query30 275 220 191 191 query31 867 842 771 771 query32 72 66 59 59 query33 467 387 310 310 query34 764 868 516 516 query35 784 869 758 758 query36 945 990 928 928 query37 125 103 80 80 query38 4263427941224122 query39 1473145414501450 query40 210 120 104 104 query41 54 51 51 51 query42 123 119 108 108 query43 498 526 480 480 query44 1336816 813 813 query45 193 175 169 169 query46 861 1042655 655 query47 1831186018131813 query48 387 416 300 300 query49 675 523 431 431 query50 662 694 417 417 query51 4236432842464246 query52 111 112 101 101 query53 239 263 191 191 query54 584 596 527 527 query55 93 88 82 82 query56 299 306 289 289 query57 1163122111441144 query58 277 268 271 268 query59 2670272527252725 query60 331 333 327 327 query61 138 132 131 131 query62 750 726 659 659 query63 234 190 186 186 query64 15451051709 709 query65 4487436845094368 query66 782 416 317 317 query67 15940 15662 15484 15484 query68 6667874 510 510 query69 526 311 264 264 query70 1211112211391122 query71 505 314 284 284 query72 6031491049784910 query73 1439677 346 346 query74 9396893690518936 query75 4030321927182718 query76 43071187754 754 query77 660 374 336 336 query78 995710192 92899289 query79 2023812 572 572 query80 664 509 459 459 query81 500 253 220 220 query82 450 125 101 101 query83 329 247 229 229 query84 290 101 95 95 query85 867 378 314 314 query86 351 310 279 279 query87 4332442544284425 query88 3360218821802180 query89 390 318 285 285 query90 1968214 208 208 query91 145 142 113 113 query92 69 60 58 58 query93 1184957 587 587 query94 677 419 317 317 query95 375 297 290 290 query96 482 561 273 273 query97 3138321331343134 query98 226 212 196 196 query99 1410142512761276 Total cold run time: 297598 ms Total hot run time: 193509 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
(doris) branch master updated (3ef6312e478 -> 0ec64a68467)
This is an automated email from the ASF dual-hosted git repository.
starocean999 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from 3ef6312e478 [Fix](Compaction) Cumulative Points Not Incrementing After
Delete Operation (#47282)
add 0ec64a68467 [Enhancement] (nereids)implement unlockTablesCommand in
nereids (#49664)
No new revisions were added by this update.
Summary of changes:
.../antlr4/org/apache/doris/nereids/DorisParser.g4 | 4 +--
.../doris/nereids/parser/LogicalPlanBuilder.java | 7 +
.../apache/doris/nereids/trees/plans/PlanType.java | 1 +
.../{SyncCommand.java => UnlockTablesCommand.java} | 24 ++--
.../trees/plans/visitor/CommandVisitor.java| 5
.../test_unlock_tables_command.groovy} | 32 +++---
6 files changed, 39 insertions(+), 34 deletions(-)
copy
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/{SyncCommand.java
=> UnlockTablesCommand.java} (76%)
copy regression-test/suites/{ddl_p0/test_createtable_strlen.groovy =>
nereids_p0/test_unlock_tables_command.groovy} (64%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](runtime-filter) enlarge default value of runtimeBloomFilterMaxSize, runtimeFilterMaxInNum [doris]
github-actions[bot] commented on PR #49689: URL: https://github.com/apache/doris/pull/49689#issuecomment-2767879255 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement alterStoragePlicyCommand in nereids [doris]
doris-robot commented on PR #48164: URL: https://github.com/apache/doris/pull/48164#issuecomment-2766875475 ClickBench: Total hot run time: 31.65 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1dd80e575295d7222cfc5d030e4d0c79ff0e084f, data reload: false query1 0.040.030.03 query2 0.130.100.11 query3 0.250.190.20 query4 1.600.190.19 query5 0.580.580.60 query6 1.170.720.71 query7 0.020.020.02 query8 0.050.030.04 query9 0.570.520.51 query10 0.580.590.56 query11 0.160.110.11 query12 0.150.110.11 query13 0.620.600.60 query14 2.672.702.67 query15 0.930.860.85 query16 0.390.370.38 query17 1.041.081.08 query18 0.210.200.20 query19 1.911.911.94 query20 0.010.010.01 query21 15.38 0.920.54 query22 0.751.230.65 query23 14.91 1.380.66 query24 7.711.470.99 query25 0.450.240.14 query26 0.630.150.13 query27 0.050.060.05 query28 9.260.880.43 query29 12.58 4.173.45 query30 0.260.090.06 query31 2.810.610.40 query32 3.220.560.47 query33 3.023.103.08 query34 15.70 5.134.53 query35 4.494.494.47 query36 0.650.500.47 query37 0.090.070.06 query38 0.050.040.03 query39 0.030.020.02 query40 0.170.140.13 query41 0.080.020.02 query42 0.030.020.02 query43 0.040.030.02 Total cold run time: 105.44 s Total hot run time: 31.65 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](terminate) add terminate interface [doris]
HappenLee commented on code in PR #49638:
URL: https://github.com/apache/doris/pull/49638#discussion_r2022237096
##
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##
@@ -222,24 +231,25 @@ Status HashJoinBuildSinkLocalState::close(RuntimeState*
state, Status exec_statu
}
}};
-if (!_runtime_filter_producer_helper || state->is_cancelled() || !_eos) {
-return Base::close(state, exec_status);
-}
-
try {
-RETURN_IF_ERROR(_runtime_filter_producer_helper->process(
-state, _shared_state->build_block.get(),
p._use_shared_hash_table,
-p._runtime_filters));
+if (!_terminated && _runtime_filter_producer_helper &&
!state->is_cancelled()) {
Review Comment:
not keep origin `eos` check ?
1. what situation the `eos == false` we call close?
2. if not eos, should we build hash table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](case) Fix cold data compaction fault injection case [doris]
dataroaring merged PR #49702: URL: https://github.com/apache/doris/pull/49702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe [doris]
suxiaogang223 commented on PR #49645: URL: https://github.com/apache/doris/pull/49645#issuecomment-2767899126 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](mtmv) optimize mtmv rewrite performance [doris]
doris-robot commented on PR #49514: URL: https://github.com/apache/doris/pull/49514#issuecomment-2768341106 TPC-DS: Total hot run time: 185492 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit db6808aba751117d15f73cf389578eaa9af4bbc6, data reload: false query1 1035477 467 467 query2 6580185418531853 query3 6748224 223 223 query4 26183 23216 23107 23107 query5 4340623 444 444 query6 294 203 188 188 query7 4625494 276 276 query8 296 232 228 228 query9 8617257225562556 query10 486 341 261 261 query11 15338 15089 14823 14823 query12 171 113 108 108 query13 1644504 400 400 query14 8983614961016101 query15 217 182 167 167 query16 7169660 487 487 query17 1193734 545 545 query18 1962401 309 309 query19 183 180 165 165 query20 123 117 110 110 query21 208 126 106 106 query22 4123426540084008 query23 33966 33039 33015 33015 query24 8446236523482348 query25 536 448 397 397 query26 1271264 148 148 query27 2764508 329 329 query28 4388240723912391 query29 744 563 426 426 query30 288 220 193 193 query31 939 847 815 815 query32 78 66 64 64 query33 566 391 313 313 query34 831 843 507 507 query35 793 834 735 735 query36 956 1021901 901 query37 117 97 77 77 query38 4362414340854085 query39 1614137013751370 query40 214 122 110 110 query41 58 52 52 52 query42 127 107 104 104 query43 486 496 468 468 query44 1288821 795 795 query45 187 182 175 175 query46 827 1018619 619 query47 1744178016991699 query48 383 405 292 292 query49 773 525 432 432 query50 643 679 393 393 query51 4224420441064106 query52 105 111 101 101 query53 232 249 179 179 query54 570 574 499 499 query55 94 85 92 85 query56 300 316 283 283 query57 1143114210641064 query58 263 263 273 263 query59 2581273725082508 query60 337 333 320 320 query61 157 149 150 149 query62 777 729 654 654 query63 226 186 192 186 query64 44161096774 774 query65 4347427242354235 query66 1151456 328 328 query67 15896 15623 15105 15105 query68 7889885 516 516 query69 470 302 285 285 query70 1221114411411141 query71 461 346 300 300 query72 5719472448804724 query73 707 623 351 351 query74 8968921186458645 query75 3810320927542754 query76 36921186737 737 query77 791 385 301 301 query78 999210191 91789178 query79 2587821 568 568 query80 653 502 459 459 query81 493 256 224 224 query82 464 130 102 102 query83 295 261 253 253 query84 302 106 85 85 query85 818 361 316 316 query86 385 285 277 277 query87 4407446343634363 query88 3548220522152205 query89 392 313 293 293 query90 1841207 211 207 query91 143 139 115 115 query92 80 60 58 58 query93 1908956 584 584 query94 670 385 302 302 query95 381 294 292 292 query96 478 554 274 274 query97 3208326331223122 query98 226 207 200 200 query99 1457141012371237 Total cold run time: 275182 ms Total hot run time: 185492 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [chore] Fix unhandled exceptions thrown by stoi on streamload [doris]
Tech-Circle-48 commented on PR #49714: URL: https://github.com/apache/doris/pull/49714#issuecomment-2768346564 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](terminate) add terminate interface [doris]
doris-robot commented on PR #49638: URL: https://github.com/apache/doris/pull/49638#issuecomment-2768370259 ClickBench: Total hot run time: 31.98 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit bf88de086dc84380e9c6b8feaf48cf1d0f735299, data reload: false query1 0.030.030.03 query2 0.120.100.10 query3 0.240.190.19 query4 1.590.180.19 query5 0.610.580.58 query6 1.180.710.70 query7 0.020.020.02 query8 0.040.030.04 query9 0.570.510.52 query10 0.590.600.57 query11 0.160.100.10 query12 0.140.110.12 query13 0.610.600.60 query14 2.802.712.81 query15 0.900.830.84 query16 0.370.380.38 query17 0.990.991.00 query18 0.210.190.20 query19 1.921.911.86 query20 0.020.000.01 query21 15.35 0.920.55 query22 0.751.160.91 query23 14.75 1.360.61 query24 6.581.801.44 query25 0.470.280.07 query26 0.620.150.13 query27 0.050.050.05 query28 10.40 0.790.44 query29 12.54 4.043.39 query30 0.240.090.07 query31 2.820.600.38 query32 3.250.540.46 query33 3.073.033.16 query34 15.69 5.114.47 query35 4.524.504.52 query36 0.660.500.49 query37 0.080.060.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.170.140.12 query41 0.080.030.02 query42 0.040.020.03 query43 0.030.040.03 Total cold run time: 105.35 s Total hot run time: 31.98 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ut) Fix UT compiling [doris]
doris-robot commented on PR #49692: URL: https://github.com/apache/doris/pull/49692#issuecomment-2765512530 TPC-H: Total hot run time: 34192 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2d931d38a7cab0658616107c2b22c330f35fc4d3, data reload: false -- Round 1 -- q1 26029 514250125012 q2 2055284 162 162 q3 11759 1231686 686 q4 10215 986 520 520 q5 7536237523402340 q6 193 171 135 135 q7 926 731 614 614 q8 9608131110931093 q9 8158529453435294 q10 6972231419441944 q11 495 289 265 265 q12 369 357 227 227 q13 18234 370430713071 q14 237 225 211 211 q15 1055493 500 493 q16 687 608 578 578 q17 568 857 332 332 q18 7416722471607160 q19 1991961 544 544 q20 314 329 194 194 q21 3817328523642364 q22 10141023953 953 Total cold run time: 119648 ms Total hot run time: 34192 ms - Round 2, with runtime_filter_mode=off - q1 5171515750805080 q2 238 318 229 229 q3 2151261523032303 q4 1492187114201420 q5 4453435143464346 q6 213 168 131 131 q7 1978189017451745 q8 2575264425122512 q9 7281691372886913 q10 2968312126872687 q11 578 512 480 480 q12 659 752 611 611 q13 3567391332903290 q14 300 302 260 260 q15 538 483 473 473 q16 641 713 662 662 q17 1140152413891389 q18 7816746973577357 q19 777 743 736 736 q20 1931202818921892 q21 5270483248364832 q22 1070102410081008 Total cold run time: 52807 ms Total hot run time: 50356 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](functions) impl function next_day [doris]
doris-robot commented on PR #49119: URL: https://github.com/apache/doris/pull/49119#issuecomment-2767165303 # BE UT Coverage Report Increment line coverage `87.06% (74/85)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1037b7d4c965bb737c76186f9f68d41d6f60a605_1037b7d4c965bb737c76186f9f68d41d6f60a605/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1037b7d4c965bb737c76186f9f68d41d6f60a605_1037b7d4c965bb737c76186f9f68d41d6f60a605/report/index.html) | Category | Coverage | |---|| | Function Coverage | 51.23% (13709/26759) | | Line Coverage | 40.56% (119263/294023) | | Region Coverage | 39.26% (60641/154467) | | Branch Coverage | 34.03% (30410/89350) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch asf-site updated (220259800a7 -> 456ca6d7788)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git discard 220259800a7 Automated deployment with doris branch @ 1847e9f039b67a226281dda3abb79012b2f125cb new 456ca6d7788 Automated deployment with doris branch @ 1847e9f039b67a226281dda3abb79012b2f125cb This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (220259800a7) \ N -- N -- N refs/heads/asf-site (456ca6d7788) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/2.0/search-index.json | 2 +- docs/3.0/search-index.json | 2 +- docs/dev/search-index.json | 2 +- search-index.json| 2 +- zh-CN/docs/2.0/search-index.json | 2 +- zh-CN/docs/3.0/search-index.json | 2 +- zh-CN/docs/dev/search-index.json | 2 +- zh-CN/search-index.json | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](profile) Provide a new profile display for the refactored RF [doris]
BiteThet merged PR #49690: URL: https://github.com/apache/doris/pull/49690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49269-branch-3.0 created (now d5f639d401e)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49269-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at d5f639d401e branch-3.0: [enhancement](compaction) replace hardcoded compaction thresholds with config #49662 (#49681) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (c8eb43d60d8 -> c5910ea3a46)
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c8eb43d60d8 Revert "[opt](nereids) remove redundant hash join condition (#48363)" (#49628) add c5910ea3a46 [fix](microbench) Fix some file cache microbench compile bug (#49269) No new revisions were added by this update. Summary of changes: be/CMakeLists.txt | 1 + be/src/io/tools/file_cache_microbench.cpp | 27 +-- build.sh | 2 +- 3 files changed, 19 insertions(+), 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](microbench) Fix some file cache microbench compile bug #49269 [doris]
hello-stephen commented on PR #49720: URL: https://github.com/apache/doris/pull/49720#issuecomment-2767842431 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch asf-site updated (d364dce0e5c -> b15d760f0b1)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git discard d364dce0e5c Automated deployment with doris branch @ 1847e9f039b67a226281dda3abb79012b2f125cb new b15d760f0b1 Automated deployment with doris branch @ 1847e9f039b67a226281dda3abb79012b2f125cb This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d364dce0e5c) \ N -- N -- N refs/heads/asf-site (b15d760f0b1) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/2.0/search-index.json | 2 +- docs/3.0/search-index.json | 2 +- docs/dev/search-index.json | 2 +- search-index.json| 2 +- zh-CN/docs/2.0/search-index.json | 2 +- zh-CN/docs/3.0/search-index.json | 2 +- zh-CN/docs/dev/search-index.json | 2 +- zh-CN/search-index.json | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](microbench) Fix some file cache microbench compile bug #49269 [doris]
hello-stephen commented on PR #49720: URL: https://github.com/apache/doris/pull/49720#issuecomment-2767842507 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49269-branch-3.0 updated (d5f639d401e -> ebea17e0c96)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49269-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git from d5f639d401e branch-3.0: [enhancement](compaction) replace hardcoded compaction thresholds with config #49662 (#49681) add ebea17e0c96 [fix](microbench) Fix some file cache microbench compile bug (#49269) No new revisions were added by this update. Summary of changes: be/CMakeLists.txt | 1 + be/src/io/tools/file_cache_microbench.cpp | 27 +-- build.sh | 2 +- 3 files changed, 19 insertions(+), 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](gson) Missing the serialization of the partition's storage policy [doris]
Thearas commented on PR #49721: URL: https://github.com/apache/doris/pull/49721#issuecomment-2767843316 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: Revert "[opt](nereids) remove redundant hash join condition (#48363)" (#49628)
This is an automated email from the ASF dual-hosted git repository.
englefly pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c8eb43d60d8 Revert "[opt](nereids) remove redundant hash join
condition (#48363)" (#49628)
c8eb43d60d8 is described below
commit c8eb43d60d8369d3a7d06de545717da289fc3a71
Author: minghong
AuthorDate: Tue Apr 1 09:44:39 2025 +0800
Revert "[opt](nereids) remove redundant hash join condition (#48363)"
(#49628)
This reverts commit 77a2b22ba6e3e41864bdf87d17abdb071f24b726.
---
.../java/org/apache/doris/mtmv/MTMVPlanUtil.java | 1 -
.../doris/nereids/jobs/executor/Rewriter.java | 8 +-
.../org/apache/doris/nereids/rules/RuleType.java | 1 -
.../exploration/mv/MaterializedViewUtils.java | 3 +-
.../rewrite/EliminateConstHashJoinCondition.java | 91 -
.../nereids/trees/plans/logical/LogicalJoin.java | 7 --
.../joinorder/hypergraph/PullupExpressionTest.java | 10 +--
.../exploration/mv/MaterializedViewUtilsTest.java | 2 +-
.../EliminateConstHashJoinConditionTest.java | 58 -
.../nereids_p0/runtime_filter/runtime_filter.out | Bin 742 -> 868 bytes
.../extend_infer_equal_predicate.out | Bin 30195 -> 30317 bytes
.../infer_predicate/pull_up_predicate_literal.out | Bin 78088 -> 82024 bytes
.../infer_predicate/pull_up_predicate_set_op.out | Bin 19652 -> 19703 bytes
.../data/nereids_rules_p0/pkfk/eliminate_inner.out | Bin 6965 -> 7333 bytes
.../nereids_p0/cte/test_cte_filter_pushdown.groovy | 2 -
.../cte/test_cte_filter_pushdown.groovy| 2 +-
.../filter_push_down/push_filter_through.groovy| 2 +-
.../pull_up_predicate_literal.groovy | 2 +-
.../agg_optimize_when_uniform.groovy | 10 +--
.../agg_with_roll_up/aggregate_with_roll_up.groovy | 1 -
.../aggregate_without_roll_up.groovy | 3 +-
.../mv/dimension/dimension_1.groovy| 1 -
.../mv/dimension/dimension_2_full_join.groovy | 1 -
.../mv/dimension/dimension_2_inner_join.groovy | 1 -
.../mv/dimension/dimension_2_left_join.groovy | 1 -
.../mv/dimension/dimension_2_right_join.groovy | 1 -
.../mv/join/dphyp_inner/inner_join_dphyp.groovy| 1 -
.../mv/join/dphyp_outer/outer_join_dphyp.groovy| 2 -
.../mv/join/inner/inner_join.groovy| 1 -
.../mv/join/left_outer/outer_join.groovy | 1 -
.../inner_join_infer_and_derive.groovy | 1 -
.../mv/nested/nested_materialized_view.groovy | 1 -
.../predicate_infer/infer_predicate.groovy | 2 +-
33 files changed, 15 insertions(+), 202 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java
b/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java
index f6face9c3c9..13a58d82901 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java
@@ -78,7 +78,6 @@ public class MTMVPlanUtil {
ctx.getSessionVariable().setDisableNereidsRules(
String.join(",", ImmutableSet.of(
"COMPRESSED_MATERIALIZE_AGG",
"COMPRESSED_MATERIALIZE_SORT",
-"ELIMINATE_CONST_JOIN_CONDITION",
RuleType.ADD_DEFAULT_LIMIT.name(;
ctx.setStartTime();
if (parentContext != null) {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
index ede35d2909e..80c8760d0e5 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
@@ -60,7 +60,6 @@ import
org.apache.doris.nereids.rules.rewrite.DeferMaterializeTopNResult;
import org.apache.doris.nereids.rules.rewrite.EliminateAggCaseWhen;
import org.apache.doris.nereids.rules.rewrite.EliminateAggregate;
import org.apache.doris.nereids.rules.rewrite.EliminateAssertNumRows;
-import org.apache.doris.nereids.rules.rewrite.EliminateConstHashJoinCondition;
import org.apache.doris.nereids.rules.rewrite.EliminateDedupJoinCondition;
import org.apache.doris.nereids.rules.rewrite.EliminateEmptyRelation;
import org.apache.doris.nereids.rules.rewrite.EliminateFilter;
@@ -489,14 +488,11 @@ public class Rewriter extends AbstractBatchJobExecutor {
custom(RuleType.ADD_PROJECT_FOR_JOIN,
AddProjectForJoin::new),
topDown(new MergeProjects())
),
-topic("adjust topN project",
+topic("Adjust topN project",
topDown(new MergeProjects(),
new PullUpProjectBetweenTopNAndAgg()
Re: [PR] branch-3.0: [fix](lock) Fix `~VDataStreamMgr` lock _receiver_map #48057 [doris]
dataroaring closed pull request #49719: branch-3.0: [fix](lock) Fix `~VDataStreamMgr` lock _receiver_map #48057 URL: https://github.com/apache/doris/pull/49719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (dc93118b9eb -> b10701ef52e)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from dc93118b9eb [feature](profile) Provide a new profile display for the
refactored RF (#49690)
add b10701ef52e [feat](test)add some be ut for orc/parquet reader (#49418)
No new revisions were added by this update.
Summary of changes:
be/src/vec/exec/format/orc/vorc_reader.cpp | 8 +-
.../exec/format/parquet/parquet_column_convert.cpp | 59 +-
.../exec/format/parquet/parquet_column_convert.h | 73 +-
be/test/vec/exec/column_type_convert_test.cpp | 897 +++--
be/test/vec/exec/orc/orc_convert_dict_test.cpp | 237 ++
.../exec/orc/orc_convert_to_orc_literal_test.cpp | 525
.../exec/{format => }/orc/orc_file_reader_test.cpp | 0
be/test/vec/exec/orc/orc_memory_stream_test.h | 102 +++
be/test/vec/exec/orc/orc_reader_fill_data_test.cpp | 475 +++
.../vec/exec/orc/orc_reader_init_column_test.cpp | 359 +
10 files changed, 2362 insertions(+), 373 deletions(-)
create mode 100644 be/test/vec/exec/orc/orc_convert_dict_test.cpp
create mode 100644 be/test/vec/exec/orc/orc_convert_to_orc_literal_test.cpp
rename be/test/vec/exec/{format => }/orc/orc_file_reader_test.cpp (100%)
create mode 100644 be/test/vec/exec/orc/orc_memory_stream_test.h
create mode 100644 be/test/vec/exec/orc/orc_reader_fill_data_test.cpp
create mode 100644 be/test/vec/exec/orc/orc_reader_init_column_test.cpp
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](test)add some be ut for orc/parquet reader [doris]
morningman merged PR #49418: URL: https://github.com/apache/doris/pull/49418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49418-branch-3.0 created (now d5f639d401e)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49418-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at d5f639d401e branch-3.0: [enhancement](compaction) replace hardcoded compaction thresholds with config #49662 (#49681) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49418-branch-2.1 deleted (was ed8531b99ad)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49418-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git was ed8531b99ad branch-2.1: [feat](regression) inject debug points need run in nonConcurrent or docker suites #49581 (#49618) The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49418-branch-3.0 deleted (was d5f639d401e)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49418-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git was d5f639d401e branch-3.0: [enhancement](compaction) replace hardcoded compaction thresholds with config #49662 (#49681) The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-49418-branch-2.1 created (now ed8531b99ad)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-49418-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git at ed8531b99ad branch-2.1: [feat](regression) inject debug points need run in nonConcurrent or docker suites #49581 (#49618) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-48057-branch-3.0 created (now d5f639d401e)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-48057-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at d5f639d401e branch-3.0: [enhancement](compaction) replace hardcoded compaction thresholds with config #49662 (#49681) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](runtime-filter) support rf on set operator: be part [doris]
BiteThet commented on PR #49679: URL: https://github.com/apache/doris/pull/49679#issuecomment-2767840114 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [fix](microbench) Fix some file cache microbench compile bug #49269 [doris]
github-actions[bot] opened a new pull request, #49720: URL: https://github.com/apache/doris/pull/49720 Cherry-picked from #49269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Compaction) Add cumulative compaction delay strategy [doris]
github-actions[bot] commented on PR #48759: URL: https://github.com/apache/doris/pull/48759#issuecomment-2767864740 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (b10701ef52e -> 3e5efb7a4b4)
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b10701ef52e [feat](test)add some be ut for orc/parquet reader (#49418) add 3e5efb7a4b4 [Chore](gutil) remove all unused include integral_types.h (#49630) No new revisions were added by this update. Summary of changes: be/src/agent/agent_server.cpp | 3 --- be/src/agent/utils.cpp | 9 - be/src/cloud/cloud_schema_change_job.cpp | 1 - be/src/common/dwarf.cpp| 2 -- be/src/exec/es/es_scroll_parser.cpp| 1 - be/src/exprs/bitmapfilter_predicate.h | 1 - be/src/gutil/strings/util.h| 1 - be/src/io/fs/hdfs_file_system.cpp | 1 - be/src/olap/delta_writer_v2.cpp| 1 - be/src/olap/memtable.h | 6 +- be/src/olap/memtable_writer.h | 7 +-- be/src/olap/rowset/beta_rowset_writer_v2.cpp | 1 - be/src/olap/rowset/segment_v2/bloom_filter.h | 1 - .../inverted_index/query_v2/roaring_query.h| 1 - .../rowset/segment_v2/inverted_index_reader.cpp| 1 - be/src/olap/schema_change.cpp | 1 - be/src/olap/tablet_manager.cpp | 1 - be/src/olap/tablet_meta.cpp| 1 - be/src/olap/task/index_builder.cpp | 1 - be/src/pipeline/dependency.h | 1 - be/src/pipeline/exec/data_queue.cpp| 1 - be/src/runtime/cache/result_cache.h| 1 - be/src/runtime/cache/result_node.h | 1 - be/src/runtime/define_primitive_type.h | 3 +-- be/src/runtime/exec_env_init.cpp | 1 - be/src/runtime/load_stream_writer.cpp | 1 - be/src/runtime/runtime_query_statistics_mgr.h | 1 - be/src/runtime/runtime_state.h | 1 - be/src/service/internal_service.cpp| 1 - be/src/service/point_query_executor.cpp| 1 - be/src/service/point_query_executor.h | 1 - be/src/util/bitmap_value.h | 1 - be/src/util/memcpy_inlined.h | 1 - be/src/util/runtime_profile.cpp| 1 - be/src/util/zlib.cpp | 7 ++- .../aggregate_function_retention.h | 1 - .../aggregate_function_window.h| 1 - be/src/vec/columns/column.h| 7 --- be/src/vec/columns/column_decimal.h| 1 - be/src/vec/columns/column_string.h | 1 - be/src/vec/columns/column_vector.h | 1 - be/src/vec/common/custom_allocator.h | 6 +- be/src/vec/common/hash_table/hash_map_context.h| 5 + be/src/vec/common/hash_table/hash_map_util.h | 2 ++ be/src/vec/exec/format/parquet/schema_desc.h | 4 ++-- be/src/vec/exprs/vbitmap_predicate.cpp | 1 - be/src/vec/exprs/vcompound_pred.h | 1 - be/src/vec/functions/function_bit_count.cpp| 1 - be/src/vec/functions/function_bit_shift.cpp| 1 - be/src/vec/functions/function_case.h | 1 - be/src/vec/functions/functions_logical.cpp | 2 -- be/src/vec/functions/multiply.cpp | 3 --- be/src/vec/olap/olap_data_convertor.h | 1 - be/src/vec/sink/vmysql_result_writer.cpp | 22 -- be/src/vec/sink/vrow_distribution.h| 1 + be/test/olap/storage_types_test.cpp| 1 - be/test/runtime/cache/partition_cache_test.cpp | 1 - be/test/vec/function/function_bitmap_test.cpp | 1 - be/test/vec/function/function_string_test.cpp | 1 - 59 files changed, 20 insertions(+), 112 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg function) upport corr_welford agg function [doris]
doris-robot commented on PR #49712: URL: https://github.com/apache/doris/pull/49712#issuecomment-2767869289 TPC-DS: Total hot run time: 192217 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 92c60770d87fe149f37d6528efbf3b011138d6df, data reload: false query1 1382107910481048 query2 6081193619111911 query3 11091 449044764476 query4 54071 24010 22744 22744 query5 5047640 468 468 query6 320 193 177 177 query7 4857511 281 281 query8 308 229 221 221 query9 5478257425792574 query10 419 297 259 259 query11 15056 14943 14911 14911 query12 165 113 105 105 query13 1044514 400 400 query14 10001 633562336233 query15 203 190 180 180 query16 7047642 494 494 query17 1106733 588 588 query18 1566420 315 315 query19 203 195 182 182 query20 131 131 119 119 query21 212 126 115 115 query22 4418452043244324 query23 34064 33146 33296 33146 query24 6640246724272427 query25 483 479 410 410 query26 722 272 153 153 query27 2530519 323 323 query28 3175245124172417 query29 591 594 431 431 query30 282 221 186 186 query31 873 900 802 802 query32 75 67 74 67 query33 466 360 324 324 query34 774 855 501 501 query35 813 810 771 771 query36 966 1004910 910 query37 123 103 81 81 query38 4304416741714167 query39 1495145914411441 query40 209 115 106 106 query41 54 54 54 54 query42 125 108 108 108 query43 512 520 506 506 query44 1290801 802 801 query45 182 176 169 169 query46 840 1035642 642 query47 1886192717821782 query48 383 412 314 314 query49 727 532 441 441 query50 707 760 423 423 query51 4227430942734273 query52 111 111 97 97 query53 215 260 178 178 query54 482 500 435 435 query55 85 86 84 84 query56 271 270 256 256 query57 1195121111351135 query58 263 260 246 246 query59 2724286227482748 query60 298 285 271 271 query61 129 130 164 130 query62 738 739 689 689 query63 226 184 182 182 query64 20281034684 684 query65 4443431843284318 query66 759 397 290 290 query67 16169 15531 15309 15309 query68 7223870 511 511 query69 525 289 273 273 query70 1159109710881088 query71 490 312 268 268 query72 5920481548894815 query73 1504673 353 353 query74 9240903489768976 query75 4040323327362736 query76 42711181761 761 query77 725 358 288 288 query78 995910136 92759275 query79 2269814 559 559 query80 611 520 443 443 query81 497 255 228 228 query82 467 127 93 93 query83 180 184 159 159 query84 289 96 74 74 query85 878 353 325 325 query86 372 323 283 283 query87 4341457042514251 query88 3924228022842280 query89 407 313 287 287 query90 1883209 212 209 query91 157 142 112 112 query92 75 58 61 58 query93 17511075581 581 query94 669 408 312 312 query95 355 279 280 279 query96 491 566 274 274 query97 3192323231293129 query98 230 205 202 202 query99 1477140913821382 Total cold run time: 299431 ms Total hot run time: 192217 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [refactor](terminate) add terminate interface [doris]
Gabriel39 commented on PR #49638: URL: https://github.com/apache/doris/pull/49638#issuecomment-2767866730 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (3e5efb7a4b4 -> d0519559eb1)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 3e5efb7a4b4 [Chore](gutil) remove all unused include integral_types.h (#49630) add d0519559eb1 [Fix](case) Fix cold data compaction fault injection case (#49699) No new revisions were added by this update. Summary of changes: be/src/olap/tablet.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … [doris]
dataroaring merged PR #49677: URL: https://github.com/apache/doris/pull/49677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … #49677 [doris]
dataroaring closed pull request #49722: branch-3.0: [improve](thrift) Config thrift_max_message_size for THREAD_POOL and … #49677 URL: https://github.com/apache/doris/pull/49722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 [doris]
Thearas commented on PR #49723: URL: https://github.com/apache/doris/pull/49723#issuecomment-2767876040 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [improve](thrift) Config thrift_max_message_size for FE SIMPLE and TH… #49678 [doris]
github-actions[bot] opened a new pull request, #49723: URL: https://github.com/apache/doris/pull/49723 Cherry-picked from #49678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](functions) Impl printf powered by fmt::sprintf [doris]
morrySnow commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2022203768
##
regression-test/suites/query_p0/sql_functions/string_functions/test_printf.groovy:
##
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_printf") {
+sql "drop table if exists printf_args;"
+sql """
+create table printf_args (
+k0 int,
+format_str_not_null string not null,
Review Comment:
should test hll, bitmap, quantile_state, variant, json, ipv4, ipv6,
datetimev1, datetimev2, datev1, datev2, agg_state, array, map, struct, timev1,
timev2, decimalv2
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Printf.java:
##
@@ -0,0 +1,82 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.functions.scalar;
+
+import org.apache.doris.catalog.FunctionSignature;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import
org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
+import org.apache.doris.nereids.trees.expressions.functions.ExpressionTrait;
+import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.DataType;
+import org.apache.doris.nereids.types.DoubleType;
+import org.apache.doris.nereids.types.StringType;
+import org.apache.doris.nereids.util.ExpressionUtils;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+/**
+ * Printf function
+ * printf(strfmt[, obj1, ...])
+ * - strfmt: A STRING expression.
+ * - objN: A STRING or numeric expression.
+ * Returns a formatted string from printf-style format strings.
+ */
+public class Printf extends ScalarFunction
+implements ExplicitlyCastableSignature, PropagateNullable {
+
+/**
+ * constructor with 1 or more arguments.
+ */
+public Printf(Expression arg0, Expression... varArgs) {
+super("Printf", ExpressionUtils.mergeArguments(arg0, varArgs));
+}
+
+/**
+ * withChildren.
+ */
+@Override
+public Printf withChildren(List children) {
+Preconditions.checkArgument(children.size() >= 1);
+return new Printf(children.get(0), children.subList(1,
children.size()).toArray(new Expression[0]));
+}
+
+@Override
+public R accept(ExpressionVisitor visitor, C context) {
+return visitor.visitPrintf(this, context);
+}
+
+@Override
+public List getSignatures() {
+// replace decimal with double
+Function replaceDecimalWithDouble = dataType -> {
+return dataType.isDecimalLikeType() ? DoubleType.INSTANCE :
dataType;
+};
Review Comment:
why replace decimal with double? add a comment to explain. what about the
decimal type in array, map and struct?
you can use
`org.apache.doris.nereids.util.TypeCoercionUtils#replaceSpecifiedType` to do
replace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this
Re: [PR] [Enhancement](Compaction) Add cumulative compaction delay strategy [doris]
doris-robot commented on PR #48759: URL: https://github.com/apache/doris/pull/48759#issuecomment-2768247464 ClickBench: Total hot run time: 31.21 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 2ba0a3335225dcd169a4fbe907b0ba258a333227, data reload: false query1 0.040.040.03 query2 0.120.110.11 query3 0.250.200.19 query4 1.590.190.19 query5 0.600.570.58 query6 1.200.720.71 query7 0.030.020.02 query8 0.040.030.03 query9 0.590.520.53 query10 0.600.600.58 query11 0.160.110.10 query12 0.150.110.11 query13 0.610.610.60 query14 2.662.692.68 query15 0.910.860.85 query16 0.390.370.39 query17 1.031.071.03 query18 0.220.200.19 query19 1.921.911.85 query20 0.010.010.02 query21 15.39 0.890.54 query22 0.761.210.61 query23 14.97 1.390.60 query24 7.171.170.92 query25 0.460.220.13 query26 0.670.160.13 query27 0.050.060.05 query28 9.170.850.44 query29 12.59 4.013.36 query30 0.240.090.06 query31 2.820.600.38 query32 3.230.540.46 query33 2.973.113.05 query34 15.75 5.064.47 query35 4.524.494.52 query36 0.660.490.48 query37 0.080.060.07 query38 0.060.040.03 query39 0.030.030.02 query40 0.170.140.13 query41 0.090.030.02 query42 0.040.030.02 query43 0.040.030.02 Total cold run time: 105.05 s Total hot run time: 31.21 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [events] Fix events status [doris-website]
KassieZ opened a new pull request, #2250: URL: https://github.com/apache/doris-website/pull/2250 ## Versions - [ ] dev - [ ] 3.0 - [ ] 2.1 - [ ] 2.0 ## Languages - [ ] Chinese - [ ] English ## Docs Checklist - [ ] Checked by AI - [ ] Test Cases Built -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](bi) support default_init_catalog user property for external catalog [doris]
cambyzju commented on code in PR #49658:
URL: https://github.com/apache/doris/pull/49658#discussion_r202317
##
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java:
##
@@ -349,6 +357,15 @@ public void update(List> properties,
boolean isReplay) thro
} catch (NumberFormatException e) {
throw new DdlException(PROP_USER_INSERT_TIMEOUT + " is not
number");
}
+} else if (keyArr[0].equalsIgnoreCase(PROP_DEFAULT_INIT_CATALOG)) {
+if (keyArr.length != 1) {
+throw new DdlException(PROP_DEFAULT_INIT_CATALOG + "
format error");
+}
+CatalogIf catalog =
Env.getCurrentEnv().getCatalogMgr().getCatalog(value);
+if (catalog == null) {
Review Comment:
这个函数目前只是抛 DdlException 异常，通过：
try {
getCatalogOrAnalysisException()
} catch {
throw new DdlException
}
跟现在的判断 catalog 是否为 null，感觉差别不大。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve](test) add structured streaming case [doris-spark-connector]
JNSimba merged PR #302: URL: https://github.com/apache/doris-spark-connector/pull/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](mtmv) optimize mtmv rewrite performance [doris]
seawinde commented on PR #49514: URL: https://github.com/apache/doris/pull/49514#issuecomment-2768262437 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] data loss when enable 2pc [doris-spark-connector]
JNSimba commented on issue #205: URL: https://github.com/apache/doris-spark-connector/issues/205#issuecomment-2768261286 https://github.com/apache/doris-spark-connector/pull/303 Maybe this PR can solve this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch asf-site updated (fa59c5417a8 -> e9152cf32cb)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git discard fa59c5417a8 Automated deployment with doris branch @ 5a3477cb6511f4d41781a712f8e00dde7fa9a436 new e9152cf32cb Automated deployment with doris branch @ 5a3477cb6511f4d41781a712f8e00dde7fa9a436 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (fa59c5417a8) \ N -- N -- N refs/heads/asf-site (e9152cf32cb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/2.0/search-index.json | 2 +- docs/3.0/search-index.json | 2 +- docs/dev/search-index.json | 2 +- search-index.json| 2 +- zh-CN/docs/2.0/search-index.json | 2 +- zh-CN/docs/3.0/search-index.json | 2 +- zh-CN/docs/dev/search-index.json | 2 +- zh-CN/search-index.json | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](mtmv) optimize mtmv rewrite performance [doris]
doris-robot commented on PR #49514: URL: https://github.com/apache/doris/pull/49514#issuecomment-2768316274 TPC-H: Total hot run time: 35350 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit db6808aba751117d15f73cf389578eaa9af4bbc6, data reload: false -- Round 1 -- q1 26310 519751085108 q2 2084290 192 192 q3 10479 1258732 732 q4 10256 1011538 538 q5 8130239524412395 q6 193 162 134 134 q7 916 775 617 617 q8 9333131810871087 q9 6812518151455145 q10 6936231819311931 q11 489 289 276 276 q12 361 363 228 228 q13 17785 368231383138 q14 224 230 208 208 q15 538 480 486 480 q16 638 616 601 601 q17 627 860 408 408 q18 7544734970457045 q19 1289951 573 573 q20 350 361 240 240 q21 4524381432973297 q22 10401027977 977 Total cold run time: 116858 ms Total hot run time: 35350 ms - Round 2, with runtime_filter_mode=off - q1 5227517352335173 q2 241 321 233 233 q3 2165264322532253 q4 1549197814811481 q5 4538440643664366 q6 221 170 127 127 q7 2006188317681768 q8 2620260325622562 q9 7158716571637163 q10 2970317427602760 q11 573 505 488 488 q12 673 773 621 621 q13 3570388433213321 q14 273 304 283 283 q15 520 485 480 480 q16 636 689 642 642 q17 1166151214851485 q18 7869757875407540 q19 825 820 817 817 q20 2037200918461846 q21 5193479946044604 q22 10531048995 995 Total cold run time: 53083 ms Total hot run time: 51008 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe [doris]
github-actions[bot] commented on PR #49645: URL: https://github.com/apache/doris/pull/49645#issuecomment-2768308761 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](paimon) Covert Paimon DeletionFile Path to StoragePath in fe [doris]
github-actions[bot] commented on PR #49645: URL: https://github.com/apache/doris/pull/49645#issuecomment-2768308868 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg function) upport corr_welford agg function [doris]
hello-stephen commented on PR #49712: URL: https://github.com/apache/doris/pull/49712#issuecomment-2767109268 # BE UT Coverage Report Increment line coverage `92.50% (111/120)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2cefe51093ee3b141564e8abe6373c2386134122_2cefe51093ee3b141564e8abe6373c2386134122/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2cefe51093ee3b141564e8abe6373c2386134122_2cefe51093ee3b141564e8abe6373c2386134122/report/index.html) | Category | Coverage | |---|| | Function Coverage | 51.30% (13727/26760) | | Line Coverage | 40.59% (119344/294012) | | Region Coverage | 39.31% (60714/154448) | | Branch Coverage | 34.05% (30426/89344) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [Fix](Compaction) Cumulative Points Not Incrementing After Delete Operation #47282 [doris]
dataroaring closed pull request #49732: branch-3.0: [Fix](Compaction) Cumulative Points Not Incrementing After Delete Operation #47282 URL: https://github.com/apache/doris/pull/49732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement unlockTablesCommand in nereids [doris]
github-actions[bot] commented on PR #49664: URL: https://github.com/apache/doris/pull/49664#issuecomment-2768120112 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) Clear inverted index cache from file cache [doris]
doris-robot commented on PR #49685: URL: https://github.com/apache/doris/pull/49685#issuecomment-2768121345 TPC-DS: Total hot run time: 193023 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 77503b06b05a443eac40716871a619bc6234f895, data reload: false query1 1416106410561056 query2 6242199419731973 query3 11055 463246434632 query4 26054 23774 22888 22888 query5 4757601 454 454 query6 318 220 208 208 query7 3992521 285 285 query8 305 262 253 253 query9 8524259025742574 query10 462 334 260 260 query11 15556 15110 14909 14909 query12 169 120 106 106 query13 1555519 388 388 query14 9211630961936193 query15 213 190 167 167 query16 7282654 461 461 query17 1161796 619 619 query18 2003441 340 340 query19 210 210 171 171 query20 131 133 122 122 query21 210 132 115 115 query22 4602465641544154 query23 34312 33586 33374 33374 query24 8609238524332385 query25 525 475 414 414 query26 1201274 157 157 query27 3136508 340 340 query28 4801248024442444 query29 728 637 448 448 query30 285 247 199 199 query31 917 869 787 787 query32 76 62 64 62 query33 537 365 312 312 query34 798 887 550 550 query35 837 879 790 790 query36 983 1017894 894 query37 130 100 75 75 query38 4223445342214221 query39 1477149414221422 query40 229 129 114 114 query41 54 55 54 54 query42 125 104 120 104 query43 532 528 485 485 query44 1347833 815 815 query45 183 178 168 168 query46 849 1018655 655 query47 1837185817891789 query48 394 443 318 318 query49 786 546 462 462 query50 662 694 409 409 query51 4258425642614256 query52 111 108 106 106 query53 232 268 191 191 query54 608 609 512 512 query55 85 80 91 80 query56 310 323 300 300 query57 1187122211331133 query58 266 278 276 276 query59 2780293827272727 query60 351 341 306 306 query61 138 147 135 135 query62 763 738 673 673 query63 235 195 198 195 query64 40581085759 759 query65 4541436843654365 query66 1179441 313 313 query67 16176 15550 15340 15340 query68 8222905 515 515 query69 516 324 280 280 query70 1240114711211121 query71 459 327 300 300 query72 5608484149264841 query73 715 669 357 357 query74 8946882593708825 query75 3921324626992699 query76 37551198750 750 query77 800 377 295 295 query78 993610224 92819281 query79 1996872 571 571 query80 654 527 451 451 query81 480 258 225 225 query82 431 131 100 100 query83 270 255 231 231 query84 260 111 91 91 query85 871 365 326 326 query86 332 315 275 275 query87 4495443942774277 query88 32852240 query89 408 323 284 284 query90 1959216 213 213 query91 147 150 115 115 query92 77 65 61 61 query93 1077953 597 597 query94 669 407 282 282 query95 378 298 292 292 query96 490 566 274 274 query97 3291320331403140 query98 228 215 193 193 query99 1449135512971297 Total cold run time: 280644 ms Total hot run time: 193023 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [Enhancement] (nereids)implement unlockTablesCommand in nereids [doris]
github-actions[bot] commented on PR #49664: URL: https://github.com/apache/doris/pull/49664#issuecomment-2768120067 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](prepared statement)Fix prepareCommand couldn't get fields metadata bug. [doris]
doris-robot commented on PR #49206: URL: https://github.com/apache/doris/pull/49206#issuecomment-2768037628 TPC-DS: Total hot run time: 192765 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f4b4afb09339e041f90b48dfc845aa5b05b5345e, data reload: false query1 1378106310191019 query2 6173188918931889 query3 11020 451945384519 query4 54537 24570 22901 22901 query5 5045594 445 445 query6 338 193 186 186 query7 4922506 286 286 query8 315 257 238 238 query9 5567253725222522 query10 431 329 267 267 query11 15148 15170 15015 15015 query12 162 113 103 103 query13 1053503 394 394 query14 9996631363516313 query15 202 183 174 174 query16 7091641 503 503 query17 1057721 605 605 query18 1528428 320 320 query19 207 200 174 174 query20 134 126 123 123 query21 207 138 111 111 query22 4274456541704170 query23 33750 33547 33671 33547 query24 6530245424142414 query25 504 495 422 422 query26 661 289 155 155 query27 2144511 338 338 query28 3264251824502450 query29 592 592 446 446 query30 273 225 193 193 query31 847 867 808 808 query32 78 69 62 62 query33 459 361 298 298 query34 755 863 513 513 query35 811 843 748 748 query36 951 991 907 907 query37 121 96 74 74 query38 4254434741014101 query39 1488149814331433 query40 206 117 107 107 query41 52 53 51 51 query42 122 110 106 106 query43 505 504 481 481 query44 1301806 810 806 query45 176 172 169 169 query46 844 1037642 642 query47 1834192617711771 query48 393 432 303 303 query49 727 528 422 422 query50 689 706 413 413 query51 4274435542574257 query52 114 112 98 98 query53 233 256 181 181 query54 587 574 526 526 query55 88 84 83 83 query56 314 318 293 293 query57 1187118211121112 query58 268 265 261 261 query59 2846270627102706 query60 333 320 299 299 query61 134 127 122 122 query62 756 746 703 703 query63 235 186 193 186 query64 14881038689 689 query65 4418437944114379 query66 764 410 306 306 query67 16054 15581 15571 15571 query68 6976881 509 509 query69 526 297 258 258 query70 1236106411491064 query71 500 327 281 281 query72 5730485750544857 query73 1490694 338 338 query74 9063906087008700 query75 4104318226882688 query76 42651182742 742 query77 757 369 275 275 query78 995010102 92189218 query79 2074824 559 559 query80 591 522 491 491 query81 485 255 219 219 query82 453 128 98 98 query83 252 250 242 242 query84 303 111 88 88 query85 792 349 306 306 query86 363 325 280 280 query87 4419448643494349 query88 3563221021972197 query89 402 318 290 290 query90 1950212 217 212 query91 140 146 115 115 query92 73 58 55 55 query93 1286960 589 589 query94 655 415 305 305 query95 380 289 294 289 query96 483 565 275 275 query97 3127325431603160 query98 233 202 199 199 query99 1659140912881288 Total cold run time: 297489 ms Total hot run time: 192765 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](Nereids) fix regression framework compare issue and fix code point count [doris]
doris-robot commented on PR #49575: URL: https://github.com/apache/doris/pull/49575#issuecomment-2768040664 TPC-DS: Total hot run time: 186409 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c83459c5d7a308837a084932a9b59a2decbea8ca, data reload: false query1 1020494 465 465 query2 6549189018511851 query3 6793219 225 219 query4 26166 23324 23470 23324 query5 4375675 489 489 query6 331 209 211 209 query7 4614494 279 279 query8 306 239 239 239 query9 8606257125862571 query10 489 333 262 262 query11 15354 15056 14892 14892 query12 161 110 103 103 query13 1677530 417 417 query14 9321619762716197 query15 208 190 164 164 query16 7285656 460 460 query17 1205715 579 579 query18 1974409 312 312 query19 194 187 158 158 query20 123 119 122 119 query21 213 122 108 108 query22 4289422041904190 query23 33770 32941 33011 32941 query24 7268243324162416 query25 557 464 408 408 query26 1240265 147 147 query27 2590487 324 324 query28 4379241623922392 query29 783 592 433 433 query30 285 221 186 186 query31 975 845 771 771 query32 74 67 68 67 query33 577 377 313 313 query34 802 831 506 506 query35 774 827 758 758 query36 948 1014894 894 query37 124 98 80 80 query38 4291418440844084 query39 1464140313941394 query40 212 123 104 104 query41 57 52 54 52 query42 147 104 102 102 query43 483 487 481 481 query44 1326797 795 795 query45 179 174 167 167 query46 861 999 646 646 query47 1759179817341734 query48 368 430 315 315 query49 788 527 404 404 query50 689 739 431 431 query51 4166418941544154 query52 107 107 98 98 query53 224 264 181 181 query54 494 504 427 427 query55 92 81 83 81 query56 288 282 275 275 query57 1135117910991099 query58 278 255 251 251 query59 2533269924972497 query60 295 286 277 277 query61 137 132 127 127 query62 782 725 675 675 query63 235 189 184 184 query64 44091007703 703 query65 4307425442834254 query66 1155404 296 296 query67 15952 15490 15307 15307 query68 8033868 552 552 query69 477 305 264 264 query70 1199112411031103 query71 473 309 279 279 query72 5512471247654712 query73 704 607 348 348 query74 8821885888848858 query75 4038323827652765 query76 37251183767 767 query77 807 390 287 287 query78 10049 10010 92549254 query79 2567809 569 569 query80 705 520 462 462 query81 495 256 221 221 query82 473 127 102 102 query83 193 182 162 162 query84 260 92 76 76 query85 823 354 402 354 query86 392 290 272 272 query87 4410442442884288 query88 3620226122682261 query89 388 311 279 279 query90 1802213 217 213 query91 144 142 110 110 query92 82 62 59 59 query93 20201059578 578 query94 678 469 299 299 query95 363 275 268 268 query96 487 560 274 274 query97 3212323730493049 query98 229 215 204 204 query99 1442142212821282 Total cold run time: 274235 ms Total hot run time: 186409 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
[PR] [regression-test](framework) add multi cluster result compare on cloud mode. [doris]
shuke987 opened a new pull request, #49735: URL: https://github.com/apache/doris/pull/49735 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](inverted index) Clear inverted index cache from file cache [doris]
doris-robot commented on PR #49685: URL: https://github.com/apache/doris/pull/49685#issuecomment-2768128209 ClickBench: Total hot run time: 31.02 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 77503b06b05a443eac40716871a619bc6234f895, data reload: false query1 0.040.040.03 query2 0.120.110.10 query3 0.260.200.20 query4 1.600.190.19 query5 0.610.580.61 query6 1.210.720.72 query7 0.030.020.02 query8 0.040.040.04 query9 0.600.520.55 query10 0.570.590.58 query11 0.170.100.11 query12 0.150.110.12 query13 0.600.610.59 query14 2.662.812.73 query15 0.920.840.85 query16 0.390.380.39 query17 1.011.071.06 query18 0.210.200.19 query19 1.932.081.81 query20 0.010.010.02 query21 15.35 0.930.55 query22 0.741.150.62 query23 15.11 1.420.60 query24 6.981.560.72 query25 0.460.250.09 query26 0.490.170.13 query27 0.050.050.05 query28 9.840.880.43 query29 12.52 4.003.29 query30 0.250.090.06 query31 2.810.590.39 query32 3.230.550.48 query33 3.023.003.10 query34 15.66 5.074.52 query35 4.514.544.49 query36 0.670.500.48 query37 0.090.060.07 query38 0.060.040.03 query39 0.030.030.03 query40 0.170.150.13 query41 0.090.040.02 query42 0.040.030.02 query43 0.040.030.03 Total cold run time: 105.34 s Total hot run time: 31.02 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](cloud-mow) Check partition's version to avoid wrongly update visible versions' delete bitmaps [doris]
doris-robot commented on PR #49710: URL: https://github.com/apache/doris/pull/49710#issuecomment-2768124199 TPC-H: Total hot run time: 35348 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1c945bb46538c430e018f9ac70a6d8fbda3761bc, data reload: false -- Round 1 -- q1 26140 508050575057 q2 2069273 194 194 q3 10446 1242707 707 q4 10250 1020554 554 q5 7615244123702370 q6 190 166 135 135 q7 941 771 617 617 q8 9328130811541154 q9 6864514251595142 q10 6880231019291929 q11 486 303 283 283 q12 368 365 224 224 q13 17781 374931043104 q14 242 246 211 211 q15 531 484 477 477 q16 626 653 586 586 q17 624 858 406 406 q18 7654713671397136 q19 22691089568 568 q20 339 335 242 242 q21 4426355932713271 q22 10901031981 981 Total cold run time: 117159 ms Total hot run time: 35348 ms - Round 2, with runtime_filter_mode=off - q1 5355512451825124 q2 252 326 233 233 q3 2186268422712271 q4 1537195015161516 q5 4507445544014401 q6 218 172 128 128 q7 1998192117471747 q8 2655252025752520 q9 7357710073247100 q10 3035322127752775 q11 570 508 499 499 q12 704 745 631 631 q13 3543386833833383 q14 279 299 272 272 q15 541 507 483 483 q16 672 681 634 634 q17 1197148913951395 q18 7901757275697569 q19 808 831 863 831 q20 1915196418291829 q21 5481500449834983 q22 1150109410191019 Total cold run time: 53861 ms Total hot run time: 51343 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](framework) add multi cluster result compare on cloud mode. [doris]
shuke987 commented on PR #49735: URL: https://github.com/apache/doris/pull/49735#issuecomment-2768132244 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](framework) add multi cluster result compare on cloud mode. [doris]
Thearas commented on PR #49735: URL: https://github.com/apache/doris/pull/49735#issuecomment-2768131799 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](cast) support cast string to double nan/inf [doris]
doris-robot commented on PR #49734: URL: https://github.com/apache/doris/pull/49734#issuecomment-2768135700 TPC-H: Total hot run time: 34189 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b74e1ae4e7937f3368490917739c2675ca40853d, data reload: false -- Round 1 -- q1 26144 502650435026 q2 2076275 189 189 q3 10399 1233706 706 q4 10229 999 553 553 q5 7958237923832379 q6 185 164 132 132 q7 932 741 596 596 q8 9305128510781078 q9 6913510651615106 q10 6803231018921892 q11 471 280 276 276 q12 344 353 218 218 q13 1 371930483048 q14 223 229 216 216 q15 543 483 499 483 q16 613 621 595 595 q17 613 855 388 388 q18 7939726369506950 q19 1213976 551 551 q20 346 344 236 236 q21 4484354225902590 q22 10801053981 981 Total cold run time: 116590 ms Total hot run time: 34189 ms - Round 2, with runtime_filter_mode=off - q1 5115510551205105 q2 232 327 234 234 q3 2168262222272227 q4 1444181714851485 q5 4599443244554432 q6 213 168 128 128 q7 1976192017391739 q8 2604267126212621 q9 7137714672687146 q10 3000316427542754 q11 590 502 490 490 q12 698 760 623 623 q13 3526386832883288 q14 280 313 279 279 q15 517 473 465 465 q16 651 696 646 646 q17 1170151014161416 q18 7764747973727372 q19 812 805 952 805 q20 2071195517901790 q21 5149467247804672 q22 1071104710111011 Total cold run time: 52787 ms Total hot run time: 50728 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](mtmv) optimize mtmv rewrite performance [doris]
seawinde commented on PR #49514: URL: https://github.com/apache/doris/pull/49514#issuecomment-2767908040 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](materialized-view) check duplicate expr when create mv stmt not have groupby exprs (#49595) [doris]
BiteThet commented on PR #49696: URL: https://github.com/apache/doris/pull/49696#issuecomment-2765465701 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](gutil) remove all unused include integral_types.h [doris]
BiteThet merged PR #49630: URL: https://github.com/apache/doris/pull/49630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch master updated: [docs]add not for workload group (#2248)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 5a3477cb651 [docs]add not for workload group (#2248) 5a3477cb651 is described below commit 5a3477cb6511f4d41781a712f8e00dde7fa9a436 Author: wangbo AuthorDate: Tue Apr 1 12:25:41 2025 +0800 [docs]add not for workload group (#2248) ## Versions - [x] dev - [x] 3.0 - [x] 2.1 - [ ] 2.0 ## Languages - [x] Chinese - [x] English ## Docs Checklist - [ ] Checked by AI - [ ] Test Cases Built --- docs/admin-manual/workload-management/workload-group.md | 6 ++ .../current/admin-manual/workload-management/workload-group.md | 9 + .../admin-manual/workload-management/workload-group.md | 8 .../admin-manual/workload-management/workload-group.md | 8 .../admin-manual/workload-management/workload-group.md | 6 ++ .../admin-manual/workload-management/workload-group.md | 6 ++ 6 files changed, 43 insertions(+) diff --git a/docs/admin-manual/workload-management/workload-group.md b/docs/admin-manual/workload-management/workload-group.md index 0d52f52e00b..89667f11494 100644 --- a/docs/admin-manual/workload-management/workload-group.md +++ b/docs/admin-manual/workload-management/workload-group.md @@ -37,6 +37,12 @@ The currently supported isolation capabilities include: * Managing memory resources, with support for both memory hard limit and memory soft limit; * Managing IO resources, including IO generated by reading local and remote files. +:::tip +Workload Group provides in-process resource isolation capabilities, which differ from inter-process resource isolation methods (such as Resource Group and Compute Group) in the following ways: + +1. In-process resource isolation cannot achieve complete isolation. For example, when high-load and low-load queries run within the same process, even if CPU usage for the high-load group is restricted using Workload Group to keep overall CPU usage within a reasonable range, the latency of the low-load group may still be affected. However, it will perform better compared to having no CPU control at all. This limitation arises because certain shared components within the process, such as [...] +2. The choice of a resource isolation strategy depends on the trade-off between isolation and cost. If some degree of latency can be tolerated while prioritizing lower costs, the Workload Group isolation approach may be suitable. On the other hand, if complete isolation is required and higher costs are acceptable, an inter-process resource isolation approach (i.e., placing isolated workloads in separate processes) should be considered. For example, using Resource Group or Compute Group t [...] +::: ## Version Notes diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-management/workload-group.md b/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-management/workload-group.md index f9a143e7f63..5b839f95c93 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-management/workload-group.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/workload-management/workload-group.md @@ -34,6 +34,15 @@ Workload Group 是一种进程内实现的对负载进行逻辑隔离的机制 * 管理内存资源，支持内存硬限和内存软限; * 管理 IO 资源，包括读本地文件和远程文件产生的 IO。 +:::tip +Workload Group 提供进程内的资源隔离能力，与进程间的资源隔离方式（ Resource Group, Compute Group ）存在以下区别： + +1. 进程内的资源隔离无法做到彻底的隔离性，比如高负载查询和低负载查询在同一个进程内运行，即使通过 Workload Group 对高负载分组的 CPU 使用进行限制使得整体的 CPU 使用在合理范围内， +那么低负载分组的延迟也难免会受到影响，但相比于不做 CPU 管控的情况会有更好的表现。这是由于进程内部难免存在一些无法隔离的公共组件，比如公共的缓存和公共的 RPC 线程池。 +2. 在做资源隔离方案的选择时，具体使用 Workload Group 还是基于进程的资源隔离方案（也就是把需要隔离的负载放到不同的进程），主要取决于隔离性和成本的权衡，可以容忍一定的延迟但是偏好低成本的场景，可以选择 Workload Group 的隔离方案； + 期望完全的隔离性同时可以接受更高的成本，那么可以选择基于进程的资源隔离方案，例如 Resource Group 或者 Compute Group，把高优负载划分到独立的 BE 节点上就可以做到比较彻底的隔离。 +::: + ## 版本说明 diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/workload-management/workload-group.md b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/workload-management/workload-group.md index f9a143e7f63..3550cda2464 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/workload-management/workload-group.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/workload-management/workload-group.md @@ -34,6 +34,14 @@ Workload Group 是一种进程内实现的对负载进行逻辑隔离的机制 * 管理内存资源，支持内存硬限和内存软限; * 管理 IO 资源，包括读本地文件和远程文件产生的 IO。 +:::tip +Workload Group 提供进程内的资源隔离能力，与进程间的资源隔离方式（ Resource Group, Compute Group ）存在以下区别： + +1. 进程内的资源隔离无法做到彻底的隔离性，比如高负载查询和低负载查询在同一个进程内运行，即使通过 Workload Group 对高负载分组的 CPU 使用进行限制使得整体的 CPU 使用在合理范围内， + 那么低负载分组的延迟也难免会受到影响，但相比于不做 CPU
Re: [PR] [improve](string) remove check for string type can't as distributed hash key [doris]
doris-robot commented on PR #49727: URL: https://github.com/apache/doris/pull/49727#issuecomment-2768055676 ClickBench: Total hot run time: 31.25 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 44f694871cbb867e7dce65f58125808c4dad9282, data reload: false query1 0.040.030.03 query2 0.130.100.11 query3 0.250.190.19 query4 1.600.190.19 query5 0.600.560.59 query6 1.210.720.71 query7 0.030.020.01 query8 0.040.040.03 query9 0.580.510.54 query10 0.580.560.56 query11 0.150.110.11 query12 0.140.110.12 query13 0.620.610.60 query14 2.682.732.73 query15 0.910.850.85 query16 0.390.380.39 query17 1.021.001.04 query18 0.210.200.20 query19 1.891.911.95 query20 0.010.010.01 query21 15.36 0.880.54 query22 0.751.140.66 query23 15.03 1.400.63 query24 7.010.831.63 query25 0.480.070.21 query26 0.550.170.14 query27 0.050.050.05 query28 10.08 0.890.42 query29 12.53 4.093.37 query30 0.240.080.06 query31 2.840.580.39 query32 3.230.540.48 query33 3.173.023.03 query34 15.85 5.064.52 query35 4.544.494.49 query36 0.660.490.48 query37 0.080.070.06 query38 0.050.040.03 query39 0.020.020.02 query40 0.160.130.13 query41 0.080.030.02 query42 0.030.020.03 query43 0.030.030.03 Total cold run time: 105.9 s Total hot run time: 31.25 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement kill connection and query command in nereids [doris]
doris-robot commented on PR #46882: URL: https://github.com/apache/doris/pull/46882#issuecomment-2768127230 TPC-DS: Total hot run time: 186677 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9c26c2c9b2669ffefd3618ccbff7fc356fc3fe7c, data reload: false query1 1017487 480 480 query2 6570187318961873 query3 6767228 220 220 query4 26499 23675 23283 23283 query5 4307641 485 485 query6 316 207 197 197 query7 4630489 286 286 query8 302 252 241 241 query9 8656254925542549 query10 470 322 262 262 query11 15659 14985 14913 14913 query12 176 110 102 102 query13 1644521 405 405 query14 9823617162276171 query15 209 200 161 161 query16 7637649 480 480 query17 1201738 597 597 query18 2016407 315 315 query19 204 189 163 163 query20 125 118 118 118 query21 212 125 105 105 query22 4183413940394039 query23 34191 33196 33038 33038 query24 8445243524022402 query25 568 496 419 419 query26 1234270 156 156 query27 2741496 341 341 query28 4342239923992399 query29 766 587 466 466 query30 291 225 195 195 query31 975 906 759 759 query32 72 64 69 64 query33 565 370 317 317 query34 789 853 543 543 query35 808 815 775 775 query36 944 980 912 912 query37 121 101 77 77 query38 4163427640314031 query39 1466139313821382 query40 215 121 105 105 query41 62 54 53 53 query42 121 113 107 107 query43 490 502 474 474 query44 1337806 801 801 query45 177 171 220 171 query46 859 1022637 637 query47 1729177817121712 query48 373 413 305 305 query49 798 518 450 450 query50 657 698 395 395 query51 4161424241364136 query52 113 105 102 102 query53 228 252 189 189 query54 587 590 498 498 query55 88 84 78 78 query56 314 288 291 288 query57 1151116510771077 query58 269 259 269 259 query59 2694266627172666 query60 319 317 309 309 query61 135 128 135 128 query62 815 739 661 661 query63 226 188 202 188 query64 4324997 686 686 query65 4372427942424242 query66 1079408 338 338 query67 15962 15664 15356 15356 query68 9043890 516 516 query69 467 305 266 266 query70 1209112010211021 query71 483 339 299 299 query72 5782466646274627 query73 708 572 340 340 query74 8996922486568656 query75 4285320827152715 query76 36981167753 753 query77 799 397 310 310 query78 10041 10141 93409340 query79 2432814 553 553 query80 613 509 462 462 query81 471 254 225 225 query82 473 129 97 97 query83 279 336 240 240 query84 290 106 84 84 query85 789 356 314 314 query86 389 302 275 275 query87 4439454845214521 query88 3387225422022202 query89 396 317 275 275 query90 1876215 220 215 query91 225 142 123 123 query92 79 57 57 57 query93 1818942 576 576 query94 663 421 294 294 query95 384 293 293 293 query96 480 556 275 275 query97 3190324031133113 query98 229 211 205 205 query99 1453139513031303 Total cold run time: 278625 ms Total hot run time: 186677 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [refactor](terminate) add terminate interface [doris]
Gabriel39 commented on PR #49638: URL: https://github.com/apache/doris/pull/49638#issuecomment-2768183911 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](terminate) add terminate interface [doris]
BiteThet commented on code in PR #49638:
URL: https://github.com/apache/doris/pull/49638#discussion_r2022199135
##
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##
@@ -222,24 +231,25 @@ Status HashJoinBuildSinkLocalState::close(RuntimeState*
state, Status exec_statu
}
}};
-if (!_runtime_filter_producer_helper || state->is_cancelled() || !_eos) {
-return Base::close(state, exec_status);
-}
-
try {
-RETURN_IF_ERROR(_runtime_filter_producer_helper->process(
-state, _shared_state->build_block.get(),
p._use_shared_hash_table,
-p._runtime_filters));
+if (!_terminated && _runtime_filter_producer_helper &&
!state->is_cancelled()) {
+if (_should_build_hash_table) {
+RETURN_IF_ERROR(_runtime_filter_producer_helper->build(
Review Comment:
这里的逻辑最好尽可能收敛到helper内部
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Compaction) Add cumulative compaction delay strategy [doris]
doris-robot commented on PR #48759: URL: https://github.com/apache/doris/pull/48759#issuecomment-2768196845 TPC-DS: Total hot run time: 186088 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2ba0a3335225dcd169a4fbe907b0ba258a333227, data reload: false query1 1007485 483 483 query2 6563188818841884 query3 6742219 220 219 query4 26300 23567 22968 22968 query5 4363644 481 481 query6 297 207 191 191 query7 4624496 290 290 query8 304 247 242 242 query9 8634259225952592 query10 466 332 260 260 query11 15271 15006 14933 14933 query12 159 110 112 110 query13 1656520 398 398 query14 9370606261676062 query15 213 183 165 165 query16 7275627 463 463 query17 1183699 572 572 query18 1977388 297 297 query19 184 176 156 156 query20 121 115 115 115 query21 215 120 103 103 query22 4012422241564156 query23 33848 32756 32940 32756 query24 8433239623662366 query25 551 461 402 402 query26 1234262 153 153 query27 2743501 339 339 query28 4378246324422442 query29 804 593 460 460 query30 300 224 196 196 query31 942 879 759 759 query32 78 68 68 68 query33 580 376 322 322 query34 805 855 513 513 query35 814 826 746 746 query36 990 977 889 889 query37 122 99 83 83 query38 4195407641284076 query39 1492142613811381 query40 216 122 115 115 query41 60 57 58 57 query42 122 109 109 109 query43 499 535 445 445 query44 1283804 806 804 query45 174 178 165 165 query46 834 1016617 617 query47 1789180617251725 query48 382 407 310 310 query49 772 501 437 437 query50 633 667 412 412 query51 4190416541794165 query52 112 107 97 97 query53 226 246 182 182 query54 564 575 549 549 query55 86 85 84 84 query56 310 299 306 299 query57 1159120410931093 query58 259 265 256 256 query59 2577266625002500 query60 341 325 299 299 query61 134 132 131 131 query62 815 747 669 669 query63 227 184 183 183 query64 43701013700 700 query65 4431423042464230 query66 1150413 313 313 query67 15754 15506 15320 15320 query68 9352896 525 525 query69 470 305 264 264 query70 1206112210751075 query71 469 306 313 306 query72 5483469647764696 query73 720 614 350 350 query74 8854902188308830 query75 4317319827402740 query76 40131187751 751 query77 971 370 287 287 query78 10098 10167 92759275 query79 2381807 618 618 query80 641 520 445 445 query81 481 254 232 232 query82 507 122 96 96 query83 291 250 237 237 query84 298 114 85 85 query85 822 368 316 316 query86 391 308 283 283 query87 4527437143554355 query88 35232227 query89 383 311 279 279 query90 1848216 216 216 query91 147 155 114 114 query92 80 62 55 55 query93 1779957 587 587 query94 666 405 309 309 query95 382 296 347 296 query96 492 558 275 275 query97 3239322531383138 query98 232 212 204 204 query99 1435140912701270 Total cold run time: 277212 ms Total hot run time: 186088 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement] (nereids)implement showRowPolicyCommand in nereids [doris]
github-actions[bot] commented on PR #49123: URL: https://github.com/apache/doris/pull/49123#issuecomment-2767812730 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement alterStoragePlicyCommand in nereids [doris]
github-actions[bot] commented on PR #48164: URL: https://github.com/apache/doris/pull/48164#issuecomment-2767812454 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
