HappenLee commented on code in PR #49638:
URL: https://github.com/apache/doris/pull/49638#discussion_r2022237096
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -222,24 +231,25 @@ Status HashJoinBuildSinkLocalState::close(RuntimeState*
state, Status exec_statu
}
}};
- if (!_runtime_filter_producer_helper || state->is_cancelled() || !_eos) {
- return Base::close(state, exec_status);
- }
-
try {
- RETURN_IF_ERROR(_runtime_filter_producer_helper->process(
- state, _shared_state->build_block.get(),
p._use_shared_hash_table,
- p._runtime_filters));
+ if (!_terminated && _runtime_filter_producer_helper &&
!state->is_cancelled()) {
Review Comment:
not keep origin `eos` check ?
1. what situation the `eos == false` we call close?
2. if not eos, should we build hash table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
