(doris) branch master updated: [Exec](expr) Opt the compound pred performace (#45414)
This is an automated email from the ASF dual-hosted git repository.
lihaopeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0c97e0470f2 [Exec](expr) Opt the compound pred performace (#45414)
0c97e0470f2 is described below
commit 0c97e0470f20a85f27d9d63673f1f3b44a82f164
Author: HappenLee
AuthorDate: Mon Dec 16 10:52:10 2024 +0800
[Exec](expr) Opt the compound pred performace (#45414)
before：
```
mysqlslap -hd3 -uroot -P9130 --create-schema=test_db2 -c 10 -i 500 -q
"SELECT count(k) FROM sbtest1_dup WHERE k BETWEEN 4850578 AND 8454295 OR k
BETWEEN 8776291 AND 29749077;"
Benchmark
Average number of seconds to run all queries: 0.041 seconds
Minimum number of seconds to run all queries: 0.037 seconds
Maximum number of seconds to run all queries: 0.115 seconds
Number of clients running queries: 10
Average number of queries per client: 1
```
after：
```
mysqlslap -hd3 -uroot -P9030 --create-schema=test_db -c 10 -i 500 -q
"SELECT count(k) FROM sbtest1 WHERE k BETWEEN 4850578 AND 8454295 OR k BETWEEN
8776291 AND 29749077;"
Benchmark
Average number of seconds to run all queries: 0.029 seconds
Minimum number of seconds to run all queries: 0.027 seconds
Maximum number of seconds to run all queries: 0.034 seconds
Number of clients running queries: 10
Average number of queries per client: 1
```
---
be/src/vec/exprs/vcompound_pred.h | 82 ---
1 file changed, 60 insertions(+), 22 deletions(-)
diff --git a/be/src/vec/exprs/vcompound_pred.h
b/be/src/vec/exprs/vcompound_pred.h
index 88f3e474b58..8c6832a7a35 100644
--- a/be/src/vec/exprs/vcompound_pred.h
+++ b/be/src/vec/exprs/vcompound_pred.h
@@ -158,12 +158,15 @@ public:
if (_can_fast_execute && fast_execute(context, block,
result_column_id)) {
return Status::OK();
}
-if (get_num_children() == 1 ||
!_all_child_is_compound_and_not_const()) {
+if (get_num_children() == 1 || _has_const_child()) {
return VectorizedFnCall::execute(context, block, result_column_id);
}
int lhs_id = -1;
int rhs_id = -1;
+bool lhs_mem_can_reuse = _children[0]->is_compound_predicate();
+bool rhs_mem_can_reuse = _children[1]->is_compound_predicate();
+
RETURN_IF_ERROR(_children[0]->execute(context, block, &lhs_id));
ColumnPtr lhs_column =
block->get_by_position(lhs_id).column->convert_to_full_column_if_const();
@@ -210,13 +213,22 @@ public:
return Status::OK();
};
-auto return_result_column_id = [&](ColumnPtr res_column, int res_id)
-> int {
+auto return_result_column_id = [&](ColumnPtr res_column, int res_id,
+ bool mem_reuse) -> int {
+if (!mem_reuse) {
+res_column = res_column->clone_resized(size);
+}
+
if (result_is_nullable && !res_column->is_nullable()) {
auto result_column =
ColumnNullable::create(res_column,
ColumnUInt8::create(size, 0));
res_id = block->columns();
block->insert({std::move(result_column), _data_type,
_expr_name});
+} else if (!mem_reuse) {
+res_id = block->columns();
+block->insert({std::move(res_column), _data_type, _expr_name});
}
+
return res_id;
};
@@ -231,6 +243,33 @@ public:
return null_map_data;
};
+auto vector_vector = [&]() {
+if (lhs_mem_can_reuse) {
+*result_column_id = lhs_id;
+} else if (rhs_mem_can_reuse) {
+*result_column_id = rhs_id;
+
+auto tmp_column = rhs_data_column;
+rhs_data_column = lhs_data_column;
+lhs_data_column = tmp_column;
+} else {
+*result_column_id = block->columns();
+
+auto col_res = lhs_column->clone_resized(size);
+lhs_data_column =
assert_cast(col_res.get())->get_data().data();
+block->insert({std::move(col_res), _data_type, _expr_name});
+}
+
+if constexpr (is_and_op) {
+for (size_t i = 0; i < size; ++i) {
+lhs_data_column[i] &= rhs_data_column[i];
+}
+} else {
+for (size_t i = 0; i < size; ++i) {
+lhs_data_column[i] |= rhs_data_column[i];
+}
+}
+};
auto vector_vector_null = [&]() {
auto col_res = ColumnUInt8::create(size);
auto col_nulls = ColumnUInt8::create(size)
(doris) branch auto-pick-45414-branch-2.1 created (now d13241115db)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45414-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git at d13241115db [branch-2.1]downgrade resource tag when there is not queryable repli… (#45387) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
yiguolei commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886082723
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -361,47 +354,44 @@ Status PipelineTask::execute(bool* eos) {
RETURN_IF_ERROR(_sink->revoke_memory(_state));
continue;
}
-*eos = _eos;
DBUG_EXECUTE_IF("fault_inject::PipelineXTask::executing", {
Status status =
Status::Error("fault_inject pipeline_task
executing failed");
return status;
});
-// `_dry_run` means sink operator need no more data
// `_sink->is_finished(_state)` means sink operator should be finished
-if (_dry_run || _sink->is_finished(_state)) {
-*eos = true;
-_eos = true;
-} else {
+if (_sink->is_finished(_state)) {
+set_wake_up_and_dep_ready();
+}
+
+// `_dry_run` means sink operator need no more data
+*eos = wake_up_early() || _dry_run;
+if (!*eos) {
SCOPED_TIMER(_get_block_timer);
_get_block_counter->update(1);
RETURN_IF_ERROR(_root->get_block_after_projects(_state, block,
eos));
}
if (_block->rows() != 0 || *eos) {
SCOPED_TIMER(_sink_timer);
-Status status = Status::OK();
-// Define a lambda function to catch sink exception, because sink
will check
-// return error status with EOF, it is special, could not return
directly.
-auto sink_function = [&]() -> Status {
-Status internal_st;
-internal_st = _sink->sink(_state, block, *eos);
-return internal_st;
-};
-status = sink_function();
-if (!status.is()) {
-RETURN_IF_ERROR(status);
+Status status = _sink->sink(_state, block, *eos);
+
+if (status.is()) {
+set_wake_up_and_dep_ready();
+} else if (!status) {
+return status;
}
-*eos = status.is() ? true : *eos;
+
if (*eos) { // just return, the scheduler will do finish work
-_eos = true;
+RETURN_IF_ERROR(close(status, false));
Review Comment:
这个代码，应该在377 行之前，不能在sink 之后
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45414-branch-3.0 created (now 4e9012fd8e4)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45414-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 4e9012fd8e4 branch-3.0: [fix](hive) fix block decompressor bug #45289 (#45377) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](shuffle)(part III) Use local exchanger for both exchange sink and lo… [doris]
Gabriel39 commented on PR #45375: URL: https://github.com/apache/doris/pull/45375#issuecomment-2544433801 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cluster key) test mow cases in cluster key [doris]
mymeiyi commented on PR #42565: URL: https://github.com/apache/doris/pull/42565#issuecomment-254061 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-38185-branch-3.0 created (now 4e9012fd8e4)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-38185-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 4e9012fd8e4 branch-3.0: [fix](hive) fix block decompressor bug #45289 (#45377) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [doc](update) update concurrent control [doris-website]
KassieZ merged PR #1487: URL: https://github.com/apache/doris-website/pull/1487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch master updated: [doc](update) update concurrent control (#1487)
This is an automated email from the ASF dual-hosted git repository.
kassiez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/master by this push:
new fa45f8c987 [doc](update) update concurrent control (#1487)
fa45f8c987 is described below
commit fa45f8c987017a6ebe0719a12a3f2fcaa8d5c036
Author: zhannngchen
AuthorDate: Mon Dec 16 11:23:41 2024 +0800
[doc](update) update concurrent control (#1487)
1. add overview for `UPDATE` concurrent control
2. change the title and doc name from `update transaction` to `update
concurrent control`
3. update sidebars
4. fix some typos
## Versions
- [x] dev
- [x] 3.0
- [x] 2.1
- [x] 2.0
## Languages
- [x] Chinese
- [x] English
## Docs Checklist
- [x] Checked by AI
- [ ] Test Cases Built
---
.../update/unique-update-concurrent-control.md | 20
docs/data-operate/update/update-overview.md | 2 +-
...action.md => unique-update-concurrent-control.md} | 20 ++--
.../current/data-operate/update/update-overview.md | 2 +-
.../update/unique-update-concurrent-control.md} | 20 ++--
.../data-operate/update/update-overview.md | 2 +-
.../update/unique-update-concurrent-control.md} | 20 ++--
.../data-operate/update/update-overview.md | 2 +-
.../update/unique-update-concurrent-control.md} | 20 ++--
.../data-operate/update/update-overview.md | 2 +-
sidebars.json| 2 +-
.../update/unique-update-concurrent-control.md | 18 +++---
.../data-operate/update/update-overview.md | 2 +-
.../update/unique-update-concurrent-control.md} | 18 +++---
.../data-operate/update/update-overview.md | 2 +-
.../update/unique-update-concurrent-control.md} | 18 +++---
.../data-operate/update/update-overview.md | 2 +-
versioned_sidebars/version-2.0-sidebars.json | 2 +-
versioned_sidebars/version-2.1-sidebars.json | 2 +-
versioned_sidebars/version-3.0-sidebars.json | 2 +-
20 files changed, 129 insertions(+), 49 deletions(-)
diff --git
a/versioned_docs/version-3.0/data-operate/update/unique-update-transaction.md
b/docs/data-operate/update/unique-update-concurrent-control.md
similarity index 84%
rename from
versioned_docs/version-3.0/data-operate/update/unique-update-transaction.md
rename to docs/data-operate/update/unique-update-concurrent-control.md
index 93b58db8fc..68561a2022 100644
---
a/versioned_docs/version-3.0/data-operate/update/unique-update-transaction.md
+++ b/docs/data-operate/update/unique-update-concurrent-control.md
@@ -1,6 +1,6 @@
---
{
-"title": "Updating Transaction",
+"title": "Concurrency Control for Updates in the Primary Key Model",
"language": "en"
}
---
@@ -24,16 +24,28 @@ specific language governing permissions and limitations
under the License.
-->
-## Update Concurrency Control
+## Overview
-By default, concurrent updates on the same table are not allowed in Doris.
+Doris adopts a Multi-Version Concurrency Control (MVCC) mechanism to manage
concurrent updates. Each data load operation is assigned a transaction, which
ensures atomicity (i.e., the operation either fully succeeds or completely
fails). Upon transaction commit, the system assigns a version number. When
using the Unique Key model and loading multiple batches of data with duplicate
primary keys, Doris determines the overwrite order based on the version number:
data with a higher version nu [...]
+
+In certain scenarios, users may need to specify a sequence column in the table
creation statement to customize the order in which data takes effect. For
example, when synchronizing data into Doris using multiple concurrent
processes, the data may arrive out of order. This could lead to older data
overwriting newer data due to its delayed arrival. To address this, users can
assign a lower sequence value to the older data and a higher sequence value to
the newer data, enabling Doris to det [...]
+
+Additionally, `UPDATE` statements differ significantly from updates performed
via data loads at the implementation level. An `UPDATE` operation involves two
steps: reading the data to be updated from the database and writing the updated
data back. By default, `UPDATE` statements use table-level locks to provide
transaction capabilities with Serializable isolation, meaning multiple `UPDATE`
statements must be executed serially. However, users can bypass this
restriction by modifying the c [...]
+
+## UPDATE Concurrency Control
+
+By default, concurrent `UPDATE`s on the same table are not allowed in Doris.
The main reason is that Doris currently supports row-level updates, wh
Re: [PR] [fix](binlog) Fix linking binlog failure due to existing files [doris]
github-actions[bot] commented on PR #45445: URL: https://github.com/apache/doris/pull/45445#issuecomment-2544495832 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feat](Job)Ensure forced failure handling for tasks from previous master node during failover or restart [doris]
CalvinKirs opened a new pull request, #45446:
URL: https://github.com/apache/doris/pull/45446
### What problem does this PR solve?
When the Master node restarts or switches to a new primary, the new Master
must take over task scheduling. In this scenario, tasks running on the previous
Master may remain in an uncertain state (e.g., suspended or incomplete). To
ensure system consistency and accurate task states, the new Master should
enforce failure handling for these tasks after its initialization to clean up
any residual task states.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
```
mysql> create job restart_test_one_time ON SCHEDULE at current_timestamp
do INSERT INTO orders.image values ('2023-03-18','1','12213');
mysql> select * from tasks("type"="insert") where
jobName='restart_test_one_time';
+---+---+---+-+-+--+-+-++-+---+--+
| TaskId| JobId | JobName | Label
| Status | ErrorMsg | CreateTime | StartTime |
FinishTime | TrackingUrl | LoadStatistic | User |
+---+---+---+-+-+--+-+-++-+---+--+
| 3519142268960 | 3518933899123 | restart_test_one_time |
3518933899123_3519142268960 | RUNNING | | 2024-12-16 11:15:22 |
2024-12-16 11:15:22 || | | root |
+---+---+---+-+-+--+-+-++-+---+--+
1 row in set (1.14 sec)
mysql> select * from tasks("type"="insert") where
jobName='restart_test_one_time';
No connection. Trying to reconnect...
Connection id:0
Current database: orders
+---+---+---+-+++-+---+-+-+---+--+
| TaskId| JobId | JobName | Label
| Status | ErrorMsg | CreateTime |
StartTime | FinishTime | TrackingUrl | LoadStatistic | User |
+---+---+---+-+++-+---+-+-+---+--+
| 3519142268960 | 3518933899123 | restart_test_one_time |
3518933899123_3519142268960 | FAILED | task failed because of restart |
2024-12-16 11:15:22 | | 2024-12-16 11:15:48 | |
| root |
+---+---+---+-+++-+---+-+-+---+--+
1 row in set (1.11 sec)
mysql> select * from jobs("type"="insert") where
Name='restart_test_one_time';
+---+---+-+-++--++-+--+-+---+-+
| Id| Name | Definer | ExecuteType |
RecurringStrategy | Status | ExecuteSql
| CreateTime | SucceedTaskCount | FailedTaskCount |
CanceledTaskCount | Comment |
+---+---+-+-++--++-+--+-+---+-+
| 3518933899123 | restart_test_one_time | root| ONE_TIME| AT
2024-12-16 11:15:22 | FINISHED | INSERT INTO orders.image values
('2023-03-18','1','12213') | 2024-12-16 11:15:22 | 0| 1
| 0 | |
+---+---+-+-++--++-+--+-+---+-+
1 row in set (0.07 sec)
```
- Behavior changed:
- [ ] No.
- [ ] Yes.
- Does this need documentation?
- [ ] No.
- [ ] Yes.
### Check List (
Re: [PR] [feature](mtmv)Support iceberg partition refresh. [doris]
Jibing-Li commented on code in PR #44726:
URL: https://github.com/apache/doris/pull/44726#discussion_r1886117447
##
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java:
##
@@ -51,9 +108,63 @@ protected synchronized void makeSureInitialized() {
}
}
+@VisibleForTesting
+public void setTable(Table table) {
+this.table = table;
+}
+
+@VisibleForTesting
+public void setPartitionColumns(List partitionColumns) {
+this.partitionColumns = partitionColumns;
+}
+
+@VisibleForTesting
+public List getSchema() {
+Schema schema = table.schema();
+List columns = schema.columns();
+List tmpSchema =
Lists.newArrayListWithCapacity(columns.size());
+for (Types.NestedField field : columns) {
+tmpSchema.add(new Column(field.name().toLowerCase(Locale.ROOT),
Review Comment:
The code was used for unit test, it is useless now. I removed the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Job)Ensure forced failure handling for tasks from previous master node during failover or restart [doris]
Thearas commented on PR #45446: URL: https://github.com/apache/doris/pull/45446#issuecomment-2544495713 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](function) fix wrong result on group_concat with distinct+order_by+nullable [doris]
github-actions[bot] commented on PR #45313: URL: https://github.com/apache/doris/pull/45313#issuecomment-2544546118 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Bug](function) fix wrong result on group_concat with distinct+order_by+nullable (#45313)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new fe8fa870941 [Bug](function) fix wrong result on group_concat with
distinct+order_by+nullable (#45313)
fe8fa870941 is described below
commit fe8fa8709415025d0da484942e003f9446fecf1b
Author: Pxl
AuthorDate: Mon Dec 16 12:11:09 2024 +0800
[Bug](function) fix wrong result on group_concat with
distinct+order_by+nullable (#45313)
fix wrong result on group_concat with distinct+order_by+nullable
---
.../vec/aggregate_functions/aggregate_function.h | 6 ++-
.../aggregate_function_distinct.h | 16 --
.../aggregate_functions/aggregate_function_null.h | 39 +++---
.../aggregate_functions/aggregate_function_sort.h | 4 +-
.../data/nereids_p0/aggregate/agg_group_concat.out | 4 ++
.../nereids_p0/aggregate/agg_group_concat.groovy | 61 +-
6 files changed, 91 insertions(+), 39 deletions(-)
diff --git a/be/src/vec/aggregate_functions/aggregate_function.h
b/be/src/vec/aggregate_functions/aggregate_function.h
index e0ec2bef62f..d761d40c4c9 100644
--- a/be/src/vec/aggregate_functions/aggregate_function.h
+++ b/be/src/vec/aggregate_functions/aggregate_function.h
@@ -20,6 +20,8 @@
#pragma once
+#include
+
#include "common/exception.h"
#include "common/status.h"
#include "util/defer_op.h"
@@ -81,7 +83,7 @@ using ConstAggregateDataPtr = const char*;
*/
class IAggregateFunction {
public:
-IAggregateFunction(const DataTypes& argument_types_) :
argument_types(argument_types_) {}
+IAggregateFunction(DataTypes argument_types_) :
argument_types(std::move(argument_types_)) {}
/// Get main function name.
virtual String get_name() const = 0;
@@ -225,7 +227,7 @@ public:
virtual void set_version(const int version_) { version = version_; }
-virtual AggregateFunctionPtr transmit_to_stable() { return nullptr; }
+virtual IAggregateFunction* transmit_to_stable() { return nullptr; }
/// Verify function signature
virtual Status verify_result_type(const bool without_key, const DataTypes&
argument_types,
diff --git a/be/src/vec/aggregate_functions/aggregate_function_distinct.h
b/be/src/vec/aggregate_functions/aggregate_function_distinct.h
index 46450394627..a5515145d9d 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_distinct.h
+++ b/be/src/vec/aggregate_functions/aggregate_function_distinct.h
@@ -341,12 +341,22 @@ public:
DataTypePtr get_return_type() const override { return
nested_func->get_return_type(); }
-AggregateFunctionPtr transmit_to_stable() override {
-return AggregateFunctionPtr(new AggregateFunctionDistinct(
-nested_func, IAggregateFunction::argument_types));
+IAggregateFunction* transmit_to_stable() override {
+return new AggregateFunctionDistinct(nested_func,
+
IAggregateFunction::argument_types);
}
};
+template
+struct FunctionStableTransfer {
+using FunctionStable = T;
+};
+
+template typename Data>
+struct FunctionStableTransfer> {
+using FunctionStable = AggregateFunctionDistinct;
+};
+
} // namespace doris::vectorized
#include "common/compile_check_end.h"
diff --git a/be/src/vec/aggregate_functions/aggregate_function_null.h
b/be/src/vec/aggregate_functions/aggregate_function_null.h
index b3fa3b8230d..b46bcbe3537 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_null.h
+++ b/be/src/vec/aggregate_functions/aggregate_function_null.h
@@ -25,6 +25,7 @@
#include "common/logging.h"
#include "common/status.h"
#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/aggregate_functions/aggregate_function_distinct.h"
#include "vec/columns/column_nullable.h"
#include "vec/common/assert_cast.h"
#include "vec/data_types/data_type_nullable.h"
@@ -166,7 +167,7 @@ public:
void insert_result_into(ConstAggregateDataPtr __restrict place, IColumn&
to) const override {
if constexpr (result_is_nullable) {
-ColumnNullable& to_concrete = assert_cast(to);
+auto& to_concrete = assert_cast(to);
if (get_flag(place)) {
nested_function->insert_result_into(nested_place(place),
to_concrete.get_nested_column());
@@ -198,7 +199,7 @@ public:
void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Arena* arena) const override {
-const ColumnNullable* column =
+const auto* column =
assert_cast(columns[0]);
if (!column->is_null_at(row_num)) {
this->set_flag(place);
@@ -207,6 +208,19 @@ public:
}
}
+IAggregateFunction* transmit_to_stable() override {
+
Re: [PR] [feat](Job)Ensure forced failure handling for tasks from previous master node during failover or restart [doris]
github-actions[bot] commented on PR #45446: URL: https://github.com/apache/doris/pull/45446#issuecomment-2544547755 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](function) fix wrong result on group_concat with distinct+order_by+nullable [doris]
BiteThet merged PR #45313: URL: https://github.com/apache/doris/pull/45313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore](ci) tmp remove required of performance [doris]
hello-stephen opened a new pull request, #45448: URL: https://github.com/apache/doris/pull/45448 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of performance [doris]
Thearas commented on PR #45448: URL: https://github.com/apache/doris/pull/45448#issuecomment-2544599780 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch hello-stephen-patch-7 created (now 756f411a0e8)
This is an automated email from the ASF dual-hosted git repository. hellostephen pushed a change to branch hello-stephen-patch-7 in repository https://gitbox.apache.org/repos/asf/doris.git at 756f411a0e8 [chore](ci) tmp remove required of performance No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](test) Fix cumu compaction with delete case fail [doris]
github-actions[bot] commented on PR #45442: URL: https://github.com/apache/doris/pull/45442#issuecomment-2544457222 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](test) Fix cumu compaction with delete case fail [doris]
github-actions[bot] commented on PR #45442: URL: https://github.com/apache/doris/pull/45442#issuecomment-2544457436 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [Bug](function) fix repeat function result length is invalid and cause overflow #45288 [doris]
doris-robot commented on PR #45443: URL: https://github.com/apache/doris/pull/45443#issuecomment-2544499025 TPC-H: Total hot run time: 40544 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3c0262a7b3d11d7716420110b927da01eb289c56, data reload: false -- Round 1 -- q1 17621 801874167416 q2 2063181 166 166 q3 11090 147511521152 q4 11102 824 751 751 q5 7716275927862759 q6 229 143 142 142 q7 960 613 593 593 q8 9580188619751886 q9 8083633563706335 q10 6953228222522252 q11 463 280 265 265 q12 404 223 210 210 q13 17780 297929912979 q14 237 204 213 204 q15 558 522 527 522 q16 690 602 594 594 q17 957 549 475 475 q18 7157652565916525 q19 34771095950 950 q20 456 197 202 197 q21 3844322131883188 q22 1094993 983 983 Total cold run time: 112514 ms Total hot run time: 40544 ms - Round 2, with runtime_filter_mode=off - q1 7453727474027274 q2 336 236 238 236 q3 2987286729132867 q4 2020178417741774 q5 5666566657985666 q6 225 142 138 138 q7 2162173318061733 q8 3303337034623370 q9 8865879287688768 q10 3536349234933492 q11 603 511 496 496 q12 795 600 604 600 q13 16912 315531273127 q14 314 285 270 270 q15 560 523 510 510 q16 702 664 646 646 q17 1830161915981598 q18 8063766775417541 q19 5371152415231523 q20 2088185218531852 q21 5435517152875171 q22 1125102310601023 Total cold run time: 80351 ms Total hot run time: 59675 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](meta-service) Support dynamic configuration for meta service [doris]
TangSiyang2001 commented on PR #45394: URL: https://github.com/apache/doris/pull/45394#issuecomment-2544498875 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](meta-service) Support dynamic configuration for meta service [doris]
github-actions[bot] commented on PR #45394: URL: https://github.com/apache/doris/pull/45394#issuecomment-2544502196 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)Support iceberg partition refresh. [doris]
Jibing-Li commented on PR #44726: URL: https://github.com/apache/doris/pull/44726#issuecomment-2544500704 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #45210 [doris]
doris-robot commented on PR #45444: URL: https://github.com/apache/doris/pull/45444#issuecomment-2544502647 TeamCity be ut coverage result: Function Coverage: 36.48% (9569/26231) Line Coverage: 27.92% (78637/281651) Region Coverage: 26.60% (40386/151828) Branch Coverage: 23.35% (20455/87594) Coverage Report: http://coverage.selectdb-in.cc/coverage/7046871701080ae726b757a921496e373807be6f_7046871701080ae726b757a921496e373807be6f/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-3.0) pick #38185 #42059 #45210 [doris]
github-actions[bot] commented on code in PR #45092:
URL: https://github.com/apache/doris/pull/45092#discussion_r1886123950
##
be/src/runtime/memory/heap_profiler.cpp:
##
@@ -0,0 +1,130 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "runtime/memory/heap_profiler.h"
+
+#ifdef USE_JEMALLOC
+#include "jemalloc/jemalloc.h"
+#endif
+#include "agent/utils.h"
+#include "common/config.h"
+#include "io/fs/local_file_system.h"
+
+namespace doris {
+
+void HeapProfiler::set_prof_active(bool prof) {
+#ifdef USE_JEMALLOC
+std::lock_guard guard(_mutex);
+try {
+int err = mallctl("prof.active", nullptr, nullptr, &prof, 1);
+err |= mallctl("prof.thread_active_init", nullptr, nullptr, &prof, 1);
+if (err) {
+LOG(WARNING) << "jemalloc heap profiling start failed, " << err;
+} else {
+LOG(WARNING) << "jemalloc heap profiling started";
+}
+} catch (...) {
+LOG(WARNING) << "jemalloc heap profiling start failed";
+}
+#endif
+}
+
+bool HeapProfiler::get_prof_dump(const std::string& profile_file_name) {
+#ifdef USE_JEMALLOC
+std::lock_guard guard(_mutex);
+const char* file_name_ptr = profile_file_name.c_str();
+try {
+int err = mallctl("prof.dump", nullptr, nullptr, &file_name_ptr,
sizeof(const char*));
+if (err) {
+LOG(WARNING) << "dump heap profile failed, " << err;
+return false;
Review Comment:
warning: redundant boolean literal in conditional return statement
[readability-simplify-boolean-expr]
be/src/runtime/memory/heap_profiler.cpp:51:
```diff
- if (err) {
- LOG(WARNING) << "dump heap profile failed, " << err;
- return false;
- } else {
- LOG(INFO) << "dump heap profile to " << profile_file_name;
- return true;
- }
+ return err == 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) fix bug when sum0 distinct appear in cte [doris]
Thearas commented on PR #45447: URL: https://github.com/apache/doris/pull/45447#issuecomment-2544569102 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids) fix bug when sum0 distinct appear in cte [doris]
feiniaofeiafei opened a new pull request, #45447: URL: https://github.com/apache/doris/pull/45447 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement KILL COMMAND in nereids [doris]
starocean999 commented on PR #44325: URL: https://github.com/apache/doris/pull/44325#issuecomment-2544692293 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of performance [doris]
xinyiZzz merged PR #45448: URL: https://github.com/apache/doris/pull/45448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [chore](ci) tmp remove required of performance (#45448)
This is an automated email from the ASF dual-hosted git repository. zouxinyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 830b74cf029 [chore](ci) tmp remove required of performance (#45448) 830b74cf029 is described below commit 830b74cf029b4e2dd00ff02ac79bea324262e7aa Author: Dongyang Li AuthorDate: Mon Dec 16 14:14:47 2024 +0800 [chore](ci) tmp remove required of performance (#45448) --- .asf.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.asf.yaml b/.asf.yaml index 7a7d845e4c9..e3d516b35c1 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -63,7 +63,6 @@ github: - COMPILE (DORIS_COMPILE) - Need_2_Approval - Cloud UT (Doris Cloud UT) - - performance (Doris Performance) required_pull_request_reviews: dismiss_stale_reviews: true - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch hello-stephen-patch-7 deleted (was 756f411a0e8)
This is an automated email from the ASF dual-hosted git repository. hellostephen pushed a change to branch hello-stephen-patch-7 in repository https://gitbox.apache.org/repos/asf/doris.git was 756f411a0e8 [chore](ci) tmp remove required of performance The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) fix bug when sum0 distinct appear in cte [doris]
github-actions[bot] commented on PR #45447: URL: https://github.com/apache/doris/pull/45447#issuecomment-2544588363 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) fix bug when sum0 distinct appear in cte [doris]
github-actions[bot] commented on PR #45447: URL: https://github.com/apache/doris/pull/45447#issuecomment-2544588396 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) lock table in ascending order of table IDs [doris]
morrySnow commented on code in PR #45045:
URL: https://github.com/apache/doris/pull/45045#discussion_r1886081704
##
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##
@@ -844,22 +845,28 @@ private static TFetchSchemaTableDataResult
mtmvMetadataResult(TMetadataTableRequ
}
MTMV mv = (MTMV) table;
if (LOG.isDebugEnabled()) {
-LOG.debug("mv: " + mv.toInfoString());
+LOG.debug("mv: {}", mv.toInfoString());
}
TRow trow = new TRow();
-trow.addToColumnValue(new TCell().setLongVal(mv.getId()));
-trow.addToColumnValue(new TCell().setStringVal(mv.getName()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getJobInfo().getJobName()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getStatus().getState().name()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getStatus().getSchemaChangeDetail()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getStatus().getRefreshState().name()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getRefreshInfo().toString()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getQuerySql()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getMvProperties().toString()));
-trow.addToColumnValue(new
TCell().setStringVal(mv.getMvPartitionInfo().toNameString()));
-trow.addToColumnValue(new
TCell().setBoolVal(MTMVPartitionUtil.isMTMVSync(mv)));
-if (LOG.isDebugEnabled()) {
-LOG.debug("mvend: " + mv.getName());
+mv.readLock();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
yiguolei commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886079385
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -320,27 +309,31 @@ Status PipelineTask::execute(bool* eos) {
if (_wait_to_start()) {
return Status::OK();
}
-if (_wake_up_by_downstream) {
-_eos = true;
-*eos = true;
-return Status::OK();
-}
+
// The status must be runnable
if (!_opened && !_fragment_context->is_canceled()) {
+if (_wake_up_early) {
+*eos = true;
+_eos = true;
+return Status::OK();
+}
RETURN_IF_ERROR(_open());
}
+auto set_wake_up_and_dep_ready = [&]() {
+if (wake_up_early()) {
Review Comment:
324 这个代码没有行不行？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Exec](expr) Opt the compound pred performace [doris]
HappenLee merged PR #45414: URL: https://github.com/apache/doris/pull/45414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Fix skip analyze empty table case. [doris]
hello-stephen commented on PR #45441: URL: https://github.com/apache/doris/pull/45441#issuecomment-251460 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Fix skip analyze empty table case. [doris]
Jibing-Li commented on PR #45441: URL: https://github.com/apache/doris/pull/45441#issuecomment-252577 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](case) remove useless test [doris]
wangbo merged PR #45409: URL: https://github.com/apache/doris/pull/45409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Fix](case) remove useless test (#45409)
This is an automated email from the ASF dual-hosted git repository.
wangbo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 4a914fe1b88 [Fix](case) remove useless test (#45409)
4a914fe1b88 is described below
commit 4a914fe1b88c9477b95414ef48880e3f59e0f854
Author: wangbo
AuthorDate: Mon Dec 16 11:17:01 2024 +0800
[Fix](case) remove useless test (#45409)
---
be/src/agent/workload_group_listener.cpp | 1 +
be/src/agent/workload_group_listener.h | 3 +-
.../test_workload_sched_policy.groovy | 57 --
3 files changed, 3 insertions(+), 58 deletions(-)
diff --git a/be/src/agent/workload_group_listener.cpp
b/be/src/agent/workload_group_listener.cpp
index 7b688b7dcdf..0cd5a3ee1ac 100644
--- a/be/src/agent/workload_group_listener.cpp
+++ b/be/src/agent/workload_group_listener.cpp
@@ -17,6 +17,7 @@
#include "agent/workload_group_listener.h"
+#include "runtime/exec_env.h"
#include "runtime/workload_group/workload_group.h"
#include "runtime/workload_group/workload_group_manager.h"
#include "util/mem_info.h"
diff --git a/be/src/agent/workload_group_listener.h
b/be/src/agent/workload_group_listener.h
index f596535908d..9578a36f70d 100644
--- a/be/src/agent/workload_group_listener.h
+++ b/be/src/agent/workload_group_listener.h
@@ -20,10 +20,11 @@
#include
#include "agent/topic_listener.h"
-#include "runtime/exec_env.h"
namespace doris {
+class ExecEnv;
+
class WorkloadGroupListener : public TopicListener {
public:
~WorkloadGroupListener() {}
diff --git
a/regression-test/suites/workload_manager_p0/test_workload_sched_policy.groovy
b/regression-test/suites/workload_manager_p0/test_workload_sched_policy.groovy
index 06e10688397..ca18c5a17e0 100644
---
a/regression-test/suites/workload_manager_p0/test_workload_sched_policy.groovy
+++
b/regression-test/suites/workload_manager_p0/test_workload_sched_policy.groovy
@@ -235,61 +235,4 @@ suite("test_workload_sched_policy") {
sql "drop user test_alter_policy_user"
sql "drop workload policy test_alter_policy"
-
-// daemon thread alter test
-def thread1 = new Thread({
-def startTime = System.currentTimeMillis()
-def curTime = System.currentTimeMillis()
-def totalTime = 30 * 60 * 1000 // 30min
-
-connect('test_policy_user', '12345', context.config.jdbcUrl) {
-sql "set workload_group=policy_group"
-boolean flag = false
-long lastTime = System.currentTimeMillis()
-
-while (curTime - startTime <= totalTime) {
-if (curTime - lastTime > 2) {
-if (flag) {
-connect('root', '', context.config.jdbcUrl) {
-sql "alter workload policy
test_cancel_query_policy properties('workload_group'='policy_group2');"
-sql "alter workload policy
test_cancel_query_policy2 properties('workload_group'='policy_group');"
-}
-flag = false
-} else {
-connect('root', '', context.config.jdbcUrl) {
-sql "alter workload policy
test_cancel_query_policy properties('workload_group'='policy_group');"
-sql "alter workload policy
test_cancel_query_policy2 properties('workload_group'='policy_group2');"
-}
-flag = true
-}
-lastTime = System.currentTimeMillis()
-}
-try {
-sql "select k0 as
policy_test_tag,k1,k2,k3,k4,k5,k6,count(distinct k13) from
regression_test_load_p0_insert.baseall group by k0,k1,k2,k3,k4,k5,k6"
-} catch (Exception e) {
-boolean ret = e.getMessage().contains("cancelled by
workload policy")
-if (!ret) {
-logger.info("policy_test_tag " + e.getMessage())
-}
-assertTrue(ret, "policy daemon check failed")
-}
-
-try {
-sql "select count(1) as policy_test_tag from
regression_test_load_p0_insert.baseall"
-} catch (Exception e) {
-boolean ret = e.getMessage().contains("cancelled by
workload policy")
-if (!ret) {
-logger.info("policy_test_tag " + e.getMessage())
-}
-assertTrue(ret, "policy daemon check failed")
-}
-
-Thread.sleep(1000)
-curTime = System.currentTimeMillis()
-}
-}
-})
-thread1.setDaemon(true)
-thread1.start()
-
}
\ No newline at end of file
-
To
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
BiteThet commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886083527
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -320,27 +309,31 @@ Status PipelineTask::execute(bool* eos) {
if (_wait_to_start()) {
return Status::OK();
}
-if (_wake_up_by_downstream) {
-_eos = true;
-*eos = true;
-return Status::OK();
-}
+
// The status must be runnable
if (!_opened && !_fragment_context->is_canceled()) {
+if (_wake_up_early) {
Review Comment:
没有open，下面执行会有问题，像sink之类的，所以得直接退出
这种情况应该是一个pipeline所有instance被其他downstream做了wake_up，这样处理就是直接不走sink eos就结束
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
yiguolei commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886091992
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -320,27 +309,31 @@ Status PipelineTask::execute(bool* eos) {
if (_wait_to_start()) {
return Status::OK();
}
-if (_wake_up_by_downstream) {
-_eos = true;
-*eos = true;
-return Status::OK();
-}
+
// The status must be runnable
if (!_opened && !_fragment_context->is_canceled()) {
+if (_wake_up_early) {
Review Comment:
我们如果没有open，直接set wake up early，我们rf 那堆eos 是否能正常处理？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [Bug](function) fix repeat function result length is invalid and cause overflow #45288 [doris]
github-actions[bot] opened a new pull request, #45443: URL: https://github.com/apache/doris/pull/45443 Cherry-picked from #45288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45288-branch-3.0 updated (4e9012fd8e4 -> 3c0262a7b3d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45288-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git from 4e9012fd8e4 branch-3.0: [fix](hive) fix block decompressor bug #45289 (#45377) add 3c0262a7b3d [Bug](function) fix repeat function result length is invalid and cause overflow (#45288) No new revisions were added by this update. Summary of changes: be/src/vec/functions/function_string.h | 3 +++ 1 file changed, 3 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45288-branch-2.1 created (now d13241115db)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45288-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git at d13241115db [branch-2.1]downgrade resource tag when there is not queryable repli… (#45387) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45288-branch-3.0 created (now 4e9012fd8e4)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45288-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 4e9012fd8e4 branch-3.0: [fix](hive) fix block decompressor bug #45289 (#45377) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [doc](udf) update some error about java-udf type [doris-website]
zhangstar333 opened a new pull request, #1523: URL: https://github.com/apache/doris-website/pull/1523 ## Versions - [x] dev - [ ] 3.0 - [ ] 2.1 - [ ] 2.0 ## Languages - [x] Chinese - [x] English ## Docs Checklist - [ ] Checked by AI - [ ] Test Cases Built -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](binlog) Fix linking binlog failure due to existing files [doris]
github-actions[bot] commented on PR #45445: URL: https://github.com/apache/doris/pull/45445#issuecomment-2544474822 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) add is_merge tag for data sink [doris]
englefly commented on code in PR #45196:
URL: https://github.com/apache/doris/pull/45196#discussion_r1886107822
##
gensrc/thrift/DataSinks.thrift:
##
@@ -189,6 +189,7 @@ struct TDataStreamSink {
11: optional i64 tablet_sink_txn_id
12: optional Types.TTupleId tablet_sink_tuple_id
13: optional list tablet_sink_exprs
+ 14: optional bool is_merge
Review Comment:
The intuition behind this is sink node must receive reply message from
exchange before starting a new data block transfer. "order" is one of the most
common senario, but not all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) add is_merge tag for data sink [doris]
github-actions[bot] commented on PR #45196: URL: https://github.com/apache/doris/pull/45196#issuecomment-2544475566 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix error in get detached tablet stat [doris]
github-actions[bot] commented on code in PR #45449: URL: https://github.com/apache/doris/pull/45449#discussion_r1886201171 ## cloud/test/meta_service_tablet_stats_test.cpp: ## @@ -0,0 +1,108 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "meta-service/meta_service_tablet_stats.h" Review Comment: warning: 'meta-service/meta_service_tablet_stats.h' file not found [clang-diagnostic-error] ```cpp #include "meta-service/meta_service_tablet_stats.h" ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of performance [doris]
github-actions[bot] commented on PR #45448: URL: https://github.com/apache/doris/pull/45448#issuecomment-2544644336 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) tmp remove required of performance [doris]
github-actions[bot] commented on PR #45448: URL: https://github.com/apache/doris/pull/45448#issuecomment-2544644371 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix error in get detached tablet stat [doris]
gavinchou commented on code in PR #45449: URL: https://github.com/apache/doris/pull/45449#discussion_r1886202479 ## cloud/src/meta-service/meta_service_tablet_stats.cpp: ## @@ -148,8 +149,10 @@ int get_detached_tablet_stats(const std::vector
Re: [PR] [fix](cloud) fix error in get detached tablet stat [doris]
csun5285 commented on PR #45449: URL: https://github.com/apache/doris/pull/45449#issuecomment-2544653992 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) fix error in get detached tablet stat [doris]
csun5285 commented on code in PR #45449: URL: https://github.com/apache/doris/pull/45449#discussion_r1886207012 ## cloud/src/meta-service/meta_service_tablet_stats.cpp: ## @@ -148,8 +149,10 @@ int get_detached_tablet_stats(const std::vector
Re: [PR] [refactor](exchange) remove duplicate code [doris]
Gabriel39 commented on PR #45466: URL: https://github.com/apache/doris/pull/45466#issuecomment-2544850450 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement adminRebalanceDiskCommand in nereids [doris]
DongLiang-0 commented on PR #45108: URL: https://github.com/apache/doris/pull/45108#issuecomment-2544850243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [refactor](exchange) remove duplicate code [doris]
Gabriel39 opened a new pull request, #45466: URL: https://github.com/apache/doris/pull/45466 follow-up: #44850 ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](exchange) remove duplicate code [doris]
Thearas commented on PR #45466: URL: https://github.com/apache/doris/pull/45466#issuecomment-2544850379 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](pipeline) make sink operator process eos signals after wake_up_early [doris]
BiteThet commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1886084997
##
be/src/pipeline/pipeline_task.cpp:
##
@@ -320,27 +309,31 @@ Status PipelineTask::execute(bool* eos) {
if (_wait_to_start()) {
return Status::OK();
}
-if (_wake_up_by_downstream) {
-_eos = true;
-*eos = true;
-return Status::OK();
-}
+
// The status must be runnable
if (!_opened && !_fragment_context->is_canceled()) {
+if (_wake_up_early) {
+*eos = true;
+_eos = true;
+return Status::OK();
+}
RETURN_IF_ERROR(_open());
}
+auto set_wake_up_and_dep_ready = [&]() {
+if (wake_up_early()) {
Review Comment:
这里可能被调多次，所以最好还是加上，防止他一直来回重复的set dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature]Add cpu usage policy to limit big query [doris]
wangbo commented on PR #43406: URL: https://github.com/apache/doris/pull/43406#issuecomment-2544436692 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 [doris]
zhangstar333 closed pull request #45345: branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 URL: https://github.com/apache/doris/pull/45345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [bug](function) fix first/last value return error with ignore null #44996 [doris]
zhangstar333 commented on PR #45344: URL: https://github.com/apache/doris/pull/45344#issuecomment-2544465341 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](meta-service) Support dynamic configuration for meta service [doris]
github-actions[bot] commented on PR #45394: URL: https://github.com/apache/doris/pull/45394#issuecomment-2544467280 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](sql-statement) Refactor 3.0/2.1 sql statement [doris-website]
KassieZ closed pull request #1333: [refactor](sql-statement) Refactor 3.0/2.1 sql statement URL: https://github.com/apache/doris-website/pull/1333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](binlog) Fix linking binlog failure due to existing files [doris]
Thearas commented on PR #45445: URL: https://github.com/apache/doris/pull/45445#issuecomment-2544470620 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [doc](update) modify update-of-unique-model.md [doris-website]
KassieZ merged PR #1438: URL: https://github.com/apache/doris-website/pull/1438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch master updated (fa45f8c987 -> 43a077af6d)
This is an automated email from the ASF dual-hosted git repository. kassiez pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git from fa45f8c987 [doc](update) update concurrent control (#1487) add 43a077af6d [doc](update) modify update-of-unique-model.md (#1438) No new revisions were added by this update. Summary of changes: docs/data-operate/update/update-of-unique-model.md | 63 ++ .../data-operate/update/update-of-unique-model.md | 62 ++--- .../data-operate/update/update-of-unique-model.md | 3 +- .../data-operate/update/update-of-unique-model.md | 58 ++-- .../data-operate/update/update-of-unique-model.md | 59 ++-- .../data-operate/update/update-of-unique-model.md | 3 +- .../data-operate/update/update-of-unique-model.md | 60 ++--- .../data-operate/update/update-of-unique-model.md | 62 ++--- 8 files changed, 168 insertions(+), 202 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](binlog) Fix linking binlog failure due to existing files [doris]
w41ter commented on PR #45445: URL: https://github.com/apache/doris/pull/45445#issuecomment-2544470724 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)Support iceberg partition refresh. [doris]
Jibing-Li commented on code in PR #44726:
URL: https://github.com/apache/doris/pull/44726#discussion_r1886117113
##
fe/fe-core/src/main/java/org/apache/doris/job/extensions/mtmv/MTMVTask.java:
##
@@ -176,6 +177,11 @@ public void run() throws JobException {
this.relation = MTMVPlanUtil.generateMTMVRelation(mtmv, ctx);
beforeMTMVRefresh();
if (mtmv.getMvPartitionInfo().getPartitionType() !=
MTMVPartitionType.SELF_MANAGE) {
+MTMVRelatedTableIf relatedTable =
mtmv.getMvPartitionInfo().getRelatedTable();
+if (!relatedTable.isValidRelatedTable()) {
+throw new JobException("MTMV " + mtmv.getName() + "'s
related table " + relatedTable.getName()
++ " is not a valid related table anymore, stop
refreshing.");
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression](minio) test minio as doris storage vault [doris]
hello-stephen commented on PR #45417: URL: https://github.com/apache/doris/pull/45417#issuecomment-2544536855 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Job)Ensure forced failure handling for tasks from previous master node during failover or restart [doris]
CalvinKirs commented on code in PR #45446:
URL: https://github.com/apache/doris/pull/45446#discussion_r1886133475
##
fe/fe-core/src/main/java/org/apache/doris/job/task/AbstractTask.java:
##
@@ -64,26 +64,22 @@ private static long getNextTaskId() {
@Override
public void onFail() throws JobException {
-status = TaskStatus.FAILED;
-if (!isCallable()) {
-return;
+try {
+status = TaskStatus.FAILED;
+if (!isCallable()) {
+return;
+}
+setFinishTimeMs(System.currentTimeMillis());
+Env.getCurrentEnv().getJobManager().getJob(jobId).onTaskFail(this);
+} finally {
+closeOrReleaseResources();
Review Comment:
Yes, this method must be called at the end of every task. onFail, onSuccess,
and cancel all signify the completion of a task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](function) fix wrong result on group_concat with distinct+order_by+nullable [doris]
github-actions[bot] commented on PR #45313: URL: https://github.com/apache/doris/pull/45313#issuecomment-2544539453 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement KILL COMMAND in nereids [doris]
Yao-MR commented on PR #44325: URL: https://github.com/apache/doris/pull/44325#issuecomment-2544540572 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Job)Ensure forced failure handling for tasks from previous master node during failover or restart [doris]
CalvinKirs commented on code in PR #45446:
URL: https://github.com/apache/doris/pull/45446#discussion_r1886133749
##
fe/fe-core/src/main/java/org/apache/doris/job/base/AbstractJob.java:
##
@@ -461,4 +467,29 @@ public void onReplayCreate() throws JobException {
public void onReplayEnd(AbstractJob replayJob) throws JobException {
log.info(new LogBuilder(LogKey.SCHEDULER_JOB, getJobId()).add("msg",
"replay delete scheduler job").build());
}
+
+public void updateTaskStatusAfterRestart() {
+List tasks = queryAllTasks();
+if (CollectionUtils.isEmpty(tasks)) {
+return;
+}
+List runningTasks = tasks.stream().filter(task ->
task.getStatus().equals(TaskStatus.RUNNING)
Review Comment:
unfinishedTasksQueue? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)Support iceberg partition refresh. [doris]
github-actions[bot] commented on PR #44726: URL: https://github.com/apache/doris/pull/44726#issuecomment-2544520651 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](shuffle)(part III) Use local exchanger for both exchange sink and lo… [doris]
doris-robot commented on PR #45375: URL: https://github.com/apache/doris/pull/45375#issuecomment-2544522314 TeamCity be ut coverage result: Function Coverage: 38.78% (10124/26104) Line Coverage: 29.77% (85114/285947) Region Coverage: 28.82% (43649/151439) Branch Coverage: 25.35% (22167/87432) Coverage Report: http://coverage.selectdb-in.cc/coverage/3dcc0bb78fb6b866f673aba0ed1c211c40137bae_3dcc0bb78fb6b866f673aba0ed1c211c40137bae/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](profile) add profile about filtered rows in analytic operator [doris]
doris-robot commented on PR #44785: URL: https://github.com/apache/doris/pull/44785#issuecomment-2544523314 TeamCity be ut coverage result: Function Coverage: 38.82% (10124/26082) Line Coverage: 29.76% (85079/285875) Region Coverage: 28.81% (43640/151472) Branch Coverage: 25.36% (22169/87428) Coverage Report: http://coverage.selectdb-in.cc/coverage/e4499d065708fa2088dbcc312556e91f27c6746d_e4499d065708fa2088dbcc312556e91f27c6746d/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) lock table in ascending order of table IDs [doris]
morrySnow commented on code in PR #45045: URL: https://github.com/apache/doris/pull/45045#discussion_r1886079285 ## fe/fe-core/src/main/java/org/apache/doris/common/proc/PartitionsProcDir.java: ## @@ -243,6 +243,7 @@ private List, TRow>> getPartitionInfosInrernal() throws An List, TRow>> partitionInfos = new ArrayList, TRow>>(); Map> partitionsUnSyncTables = null; String mtmvPartitionSyncErrorMsg = null; +olapTable.readLock(); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](shuffle)(part III) Use local exchanger for both exchange sink and lo… [doris]
github-actions[bot] commented on PR #45375: URL: https://github.com/apache/doris/pull/45375#issuecomment-2544439351 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [pick](branch-2.1) pick #45210 [doris]
xinyiZzz opened a new pull request, #45444: URL: https://github.com/apache/doris/pull/45444 ### What problem does this PR solve? [fix](memory) Disable Jemalloc Hook #45210 fix: ``` *** Aborted at 1733734087 (unix time) try "date -d @1733734087" if you are using GNU date *** *** Current BE git commitID: 43f06a5e26 *** *** SIGSEGV address not mapped to object (@0x0) received by PID 1671420 (TID 1671420 OR 0x7f4f35f74ac0) from PID 0; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_release/doris/be/src/common/signal_handler.h:421 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /usr/local/jdk-17.0.2/lib/server/libjvm.so 2# JVM_handle_linux_signal in /usr/local/jdk-17.0.2/lib/server/libjvm.so 3# 0x7F4F34340400 in /lib64/libc.so.6 4# je_arena_dalloc_promoted at ../src/arena.c:1277 5# je_free_default at ../src/jemalloc.c:3014 6# __pthread_create_2_1 in /lib64/libpthread.so.0 7# os::create_thread(Thread*, os::ThreadType, unsigned long) in /usr/local/jdk-17.0.2/lib/server/libjvm.so 8# JVM_StartThread in /usr/local/jdk-17.0.2/lib/server/libjvm.so 9# 0x7F4F0A96C918 ``` ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #45210 [doris]
Thearas commented on PR #45444: URL: https://github.com/apache/doris/pull/45444#issuecomment-2544463124 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-2.1) pick #45210 [doris]
xinyiZzz commented on PR #45444: URL: https://github.com/apache/doris/pull/45444#issuecomment-2544463233 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [Bug](function) fix repeat function result length is invalid and cause overflow #45288 [doris]
doris-robot commented on PR #45443: URL: https://github.com/apache/doris/pull/45443#issuecomment-2544533695 TPC-DS: Total hot run time: 195490 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3c0262a7b3d11d7716420110b927da01eb289c56, data reload: false query1 1220937 936 936 query2 6240207320232023 query3 10885 423542094209 query4 67366 28581 23429 23429 query5 5668443 441 441 query6 447 177 189 177 query7 5673312 303 303 query8 305 218 219 218 query9 9397267726572657 query10 511 262 248 248 query11 17862 15189 15832 15189 query12 152 95 106 95 query13 1591424 451 424 query14 10259 701869086908 query15 205 176 181 176 query16 7642479 554 479 query17 1079596 579 579 query18 1955317 306 306 query19 238 156 181 156 query20 114 108 111 108 query21 65 46 43 43 query22 4591455645214521 query23 34611 33999 33908 33908 query24 6119288828702870 query25 544 415 418 415 query26 689 173 174 173 query27 2038298 309 298 query28 4374257324872487 query29 719 486 452 452 query30 249 165 160 160 query31 1010814 857 814 query32 96 55 52 52 query33 404 297 283 283 query34 886 507 498 498 query35 821 736 734 734 query36 1073947 939 939 query37 115 70 72 70 query38 4019405239723972 query39 1511147614591459 query40 150 87 81 81 query41 50 48 47 47 query42 113 99 96 96 query43 531 475 489 475 query44 1156810 832 810 query45 192 172 171 171 query46 1159758 737 737 query47 1997187718971877 query48 476 390 368 368 query49 719 388 388 388 query50 843 422 417 417 query51 7403716971707169 query52 99 95 95 95 query53 260 186 184 184 query54 550 441 449 441 query55 73 72 73 72 query56 248 234 234 234 query57 1209113210971097 query58 205 201 208 201 query59 3250295527602760 query60 278 245 249 245 query61 106 102 104 102 query62 769 658 655 655 query63 207 184 195 184 query64 1745639 618 618 query65 3227316731443144 query66 736 302 295 295 query67 15638 15276 15279 15276 query68 4534558 551 551 query69 418 269 262 262 query70 1143110910931093 query71 422 256 254 254 query72 6638384339023843 query73 753 340 341 340 query74 9334897788808880 query75 3328258326582583 query76 2693117410371037 query77 478 270 259 259 query78 10665 964794649464 query79 8502598 591 591 query80 1952419 414 414 query81 533 241 246 241 query82 1324117 118 117 query83 308 144 141 141 query84 283 78 73 73 query85 1889298 286 286 query86 475 307 297 297 query87 4505428942654265 query88 5497240624122406 query89 550 296 297 296 query90 2047185 182 182 query91 178 143 146 143 query92 67 50 49 49 query93 6604551 540 540 query94 873 291 299 291 query95 350 251 246 246 query96 634 285 284 284 query97 3317312431693124 query98 224 198 197 197 query99 1597129313171293 Total cold run time: 338247 ms Total hot run time: 195490 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 [doris]
doris-robot commented on PR #45345: URL: https://github.com/apache/doris/pull/45345#issuecomment-2544533552 TeamCity be ut coverage result: Function Coverage: 36.48% (9569/26232) Line Coverage: 27.92% (78634/281654) Region Coverage: 26.60% (40385/151836) Branch Coverage: 23.35% (20451/87594) Coverage Report: http://coverage.selectdb-in.cc/coverage/ba844bb4e2e9fd70606c3d18d7ff24a3fdce8109_ba844bb4e2e9fd70606c3d18d7ff24a3fdce8109/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Job)Ensure forced failure handling for tasks from previous master node during failover or restart [doris]
zddr commented on code in PR #45446:
URL: https://github.com/apache/doris/pull/45446#discussion_r1886126541
##
fe/fe-core/src/main/java/org/apache/doris/job/base/AbstractJob.java:
##
@@ -461,4 +467,29 @@ public void onReplayCreate() throws JobException {
public void onReplayEnd(AbstractJob replayJob) throws JobException {
log.info(new LogBuilder(LogKey.SCHEDULER_JOB, getJobId()).add("msg",
"replay delete scheduler job").build());
}
+
+public void updateTaskStatusAfterRestart() {
+List tasks = queryAllTasks();
+if (CollectionUtils.isEmpty(tasks)) {
+return;
+}
+List runningTasks = tasks.stream().filter(task ->
task.getStatus().equals(TaskStatus.RUNNING)
Review Comment:
The name is runningTask, which actually includes running and pending. Would
you consider changing the name?
##
fe/fe-core/src/main/java/org/apache/doris/job/task/AbstractTask.java:
##
@@ -64,26 +64,22 @@ private static long getNextTaskId() {
@Override
public void onFail() throws JobException {
-status = TaskStatus.FAILED;
-if (!isCallable()) {
-return;
+try {
+status = TaskStatus.FAILED;
+if (!isCallable()) {
+return;
+}
+setFinishTimeMs(System.currentTimeMillis());
+Env.getCurrentEnv().getJobManager().getJob(jobId).onTaskFail(this);
+} finally {
+closeOrReleaseResources();
Review Comment:
Did you call `closeOrReleaseResources` when `onSuccess`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Fix skip analyze empty table case. [doris]
Jibing-Li commented on PR #45441: URL: https://github.com/apache/doris/pull/45441#issuecomment-2544533210 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)Support read hive4 transaction tables. [doris]
github-actions[bot] commented on PR #44001: URL: https://github.com/apache/doris/pull/44001#issuecomment-2544817725 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](regression-test) Increase timeout for compaction tasks in some sc cases [doris]
TangSiyang2001 commented on PR #45461: URL: https://github.com/apache/doris/pull/45461#issuecomment-2544814368 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-44726-branch-3.0 updated (1ba9b85863f -> 564b3b67cad)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch auto-pick-44726-branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
from 1ba9b85863f branch-3.0: [fix](nereids)EliminateGroupBy rule should
keep output's datatype unchanged #45359 (#45398)
add 564b3b67cad [feature](mtmv)Support iceberg partition refresh. (#44726)
No new revisions were added by this update.
Summary of changes:
.../apache/doris/catalog/RangePartitionItem.java | 7 +-
.../datasource/iceberg/IcebergExternalTable.java | 439 -
.../doris/datasource/iceberg/IcebergPartition.java | 82
.../datasource/iceberg/IcebergPartitionInfo.java | 71
.../IcebergSchemaCacheValue.java} | 23 +-
.../apache/doris/job/extensions/mtmv/MTMVTask.java | 7 +
.../org/apache/doris/mtmv/MTMVPartitionUtil.java | 2 +-
.../org/apache/doris/mtmv/MTMVRelatedTableIf.java | 9 +
.../iceberg/IcebergExternalTableTest.java | 238 +++
.../iceberg/IcebergPartitionInfoTest.java | 53 +++
regression-test/data/mtmv_p0/test_iceberg_mtmv.out | 98 +
.../suites/mtmv_p0/test_iceberg_mtmv.groovy| 147 +++
12 files changed, 1164 insertions(+), 12 deletions(-)
create mode 100644
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergPartition.java
create mode 100644
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergPartitionInfo.java
copy
fe/fe-core/src/main/java/org/apache/doris/datasource/{hive/HMSSchemaCacheValue.java
=> iceberg/IcebergSchemaCacheValue.java} (62%)
create mode 100644
fe/fe-core/src/test/java/org/apache/doris/datasource/iceberg/IcebergExternalTableTest.java
create mode 100644
fe/fe-core/src/test/java/org/apache/doris/datasource/iceberg/IcebergPartitionInfoTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) merge SimplifyDecimalV3Comparison into SimplifyComparisonPredicate [doris]
yujun777 commented on PR #45459: URL: https://github.com/apache/doris/pull/45459#issuecomment-2544815158 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-2.1: [feature](mtmv)Support iceberg partition refresh. #44726 [doris]
github-actions[bot] opened a new pull request, #45463: URL: https://github.com/apache/doris/pull/45463 Cherry-picked from #44726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)Support read hive4 transaction tables. [doris]
hubgeter commented on PR #44001: URL: https://github.com/apache/doris/pull/44001#issuecomment-2544807655 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](hms table)Some optimizations for hms external table [doris]
wuwenchi commented on PR #44909: URL: https://github.com/apache/doris/pull/44909#issuecomment-2544820321 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](mysql-buffer) fix special buffer size with nested type #45126 [doris]
doris-robot commented on PR #45457: URL: https://github.com/apache/doris/pull/45457#issuecomment-2544828303 TPC-DS: Total hot run time: 195064 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f67b5b01a7b6bc825fe7b5fc56c1d0b8e311cfad, data reload: false query1 1216916 941 916 query2 6234205120192019 query3 10963 423641304130 query4 66038 29288 23536 23536 query5 5253445 455 445 query6 430 174 171 171 query7 5676322 308 308 query8 319 224 232 224 query9 9333264326442643 query10 500 262 253 253 query11 17779 15470 15712 15470 query12 155 102 101 101 query13 1530422 430 422 query14 9986658374676583 query15 214 188 183 183 query16 6745523 502 502 query17 1097604 580 580 query18 1723334 324 324 query19 217 162 155 155 query20 116 112 109 109 query21 64 47 45 45 query22 4660461644734473 query23 34389 33905 33965 33905 query24 5997291628792879 query25 528 394 398 394 query26 676 166 162 162 query27 1737303 303 303 query28 4248248425032484 query29 671 433 427 427 query30 253 161 158 158 query31 1013820 816 816 query32 69 54 56 54 query33 429 268 267 267 query34 886 490 517 490 query35 833 727 742 727 query36 1083926 968 926 query37 112 66 67 66 query38 4098402240244022 query39 1509147614501450 query40 141 89 78 78 query41 49 43 43 43 query42 109 94 98 94 query43 520 507 469 469 query44 1117792 780 780 query45 183 164 164 164 query46 1139734 720 720 query47 1961185518641855 query48 479 370 363 363 query49 731 370 373 370 query50 829 425 406 406 query51 7421716571017101 query52 101 87 89 87 query53 258 189 182 182 query54 553 455 453 453 query55 75 73 72 72 query56 264 252 229 229 query57 1158106711071067 query58 202 201 199 199 query59 3094279326852685 query60 256 248 249 248 query61 106 103 102 102 query62 749 659 651 651 query63 207 186 192 186 query64 1466684 611 611 query65 3255315031743150 query66 712 287 293 287 query67 15818 15314 15285 15285 query68 4611545 551 545 query69 427 252 247 247 query70 1157111511051105 query71 343 248 250 248 query72 6446388340713883 query73 755 343 338 338 query74 10007 888289718882 query75 3312260826512608 query76 1841106410811064 query77 491 271 274 271 query78 10670 967895069506 query79 7183592 597 592 query80 1947440 440 440 query81 556 251 241 241 query82 1032120 116 116 query83 295 143 146 143 query84 293 84 83 83 query85 1516390 292 292 query86 473 290 299 290 query87 4362430542104210 query88 5469237123892371 query89 410 286 288 286 query90 2056180 175 175 query91 177 143 139 139 query92 63 45 47 45 query93 6146537 528 528 query94 897 286 276 276 query95 345 238 243 238 query96 623 282 283 282 query97 3355310030893089 query98 213 215 197 197 query99 1726127712751275 Total cold run time: 330929 ms Total hot run time: 195064 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Fix](ShortCircuit) fix prepared statement with partial arguments prepared [doris]
eldenmoon merged PR #45371: URL: https://github.com/apache/doris/pull/45371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
