Jibing-Li commented on code in PR #44726: URL: https://github.com/apache/doris/pull/44726#discussion_r1886117447
########## fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java: ########## @@ -51,9 +108,63 @@ protected synchronized void makeSureInitialized() { } } + @VisibleForTesting + public void setTable(Table table) { + this.table = table; + } + + @VisibleForTesting + public void setPartitionColumns(List<Column> partitionColumns) { + this.partitionColumns = partitionColumns; + } + + @VisibleForTesting + public List<Column> getSchema() { + Schema schema = table.schema(); + List<Types.NestedField> columns = schema.columns(); + List<Column> tmpSchema = Lists.newArrayListWithCapacity(columns.size()); + for (Types.NestedField field : columns) { + tmpSchema.add(new Column(field.name().toLowerCase(Locale.ROOT), Review Comment: The code was used for unit test, it is useless now. I removed the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org