[PR] [Debug](thrift) add log for thrift transport error [doris]
zclllyybb opened a new pull request, #31366: URL: https://github.com/apache/doris/pull/31366 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
doris-robot commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962293441 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
zclllyybb commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962293479 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
github-actions[bot] commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962295286 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
github-actions[bot] commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962295324 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
github-actions[bot] commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962295330 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression test]Opt Test UniqueModel Schema Key Change [doris]
yiguolei merged PR #31262: URL: https://github.com/apache/doris/pull/31262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [regression test]Opt Test UniqueModel Schema Key Change (#31262)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a71d3a566cc [regression test]Opt Test UniqueModel Schema Key Change
(#31262)
a71d3a566cc is described below
commit a71d3a566cc271b79abbb0425be247454c9a5169
Author: kkop <45192870+cjj2...@users.noreply.github.com>
AuthorDate: Sat Feb 24 16:19:42 2024 +0800
[regression test]Opt Test UniqueModel Schema Key Change (#31262)
* Opt Test UniqueModel Schema Key Change
* Opt Test UniqueModel Schema key Change
---
.../test_unique_model_schema_key_change.out| 10 ---
.../test_unique_model_schema_key_change.groovy | 31 +++---
2 files changed, 9 insertions(+), 32 deletions(-)
diff --git
a/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
b/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
index b8e5753aff9..2419cdd18de 100644
---
a/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
+++
b/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
@@ -99,16 +99,6 @@
789012345 Grace 1997-01-01T00:00Xian29 0
133 No. 222 Street, Xian2022-07-07T22:00
123456689 Alice 2024-01-04T09:00Yaan25 0
13812345678 No. 123 Street, Beijing 2022-01-01T10:00
--- ! --
-123456789 Alice 1997-01-01T00:00Beijing 25 0
13812345678 No. 123 Street, Beijing 2022-01-01T10:00
-234567890 Bob 1997-01-01T00:00Shanghai30 1
13998765432 No. 456 Street, Shanghai2022-02-02T12:00
-345678901 Carol 1997-01-01T00:00Guangzhou 28 0
13724681357 No. 789 Street, Guangzhou 2022-03-03T14:00
-456789012 Dave1997-01-01T00:00Shenzhen35 1
13680864279 No. 987 Street, Shenzhen2022-04-04T16:00
-567890123 Eve 1997-01-01T00:00Chengdu 27 0
13572468091 No. 654 Street, Chengdu 2022-05-05T18:00
-678901234 Frank 1997-01-01T00:00Hangzhou32 1
13467985213 No. 321 Street, Hangzhou2022-06-06T20:00
-789012345 Grace 1997-01-01T00:00Xian29 0
133 No. 222 Street, Xian2022-07-07T22:00
-123456689 Alice 2024-01-04T09:00Yaan25 0
13812345678 No. 123 Street, Beijing 2022-01-01T10:00
-
-- ! --
123456789 Alice F Beijing 25 0 13812345678 No. 123
Street, Beijing 2022-01-01T10:00
234567890 Bob F Shanghai30 1 13998765432
No. 456 Street, Shanghai2022-02-02T12:00
diff --git
a/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
b/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
index deb094fc284..52f211a98e7 100644
---
a/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
+++
b/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
@@ -46,6 +46,7 @@ suite("test_unique_model_schema_key_change","p0") {
" (678901234, 'Frank', 'Hangzhou', 32, 1,
13467985213, 'No. 321 Street, Hangzhou', '2022-06-06 20:00:00')," +
" (789012345, 'Grace', 'Xian', 29, 0, 133,
'No. 222 Street, Xian', '2022-07-07 22:00:00');"
+ //Test the unique model by adding a key column with VARCHAR
sql initTable
sql initTableData
sql """ alter table ${tbName} add column province VARCHAR(20) KEY
DEFAULT "广东省" AFTER username """
@@ -127,8 +128,7 @@ suite("test_unique_model_schema_key_change","p0") {
-
- //Test the unique model by adding a key column with FLOAT
+ //TODO Test the unique model by adding a key column with FLOAT
//java.sql.SQLException: errCode = 2, detailMessage = Float or double can
not used as a key, use decimal instead.
/* sql initTable
sql initTableData
@@ -141,12 +141,11 @@ suite("test_unique_model_schema_key_change","p0") {
-
- //Test the unique model by adding a key column with DOUBLE
+ //TODO Test the unique model by adding a key column with DOUBLE
//java.sql.SQLException: errCode = 2, detailMessage = Float or double can
not used as a key, use decimal instead.
/* sql initTable
sql initTableData
- sql """ alter table ${tbName} add column watch FLOAT KEY DEFAULT
"166.689" AFTER username """
+ sql """ alter table ${tbName} add column watch DOUBLE KEY DEFAULT
"166.689" AFTER username """
insertSql = " insert into ${tbName} values(123456689, 'Alice', 189.479,
'Yaan', 25, 0, 13812345678, 'No. 123 Street, Beijing', '2022-01-01 10:00:00')
Re: [PR] [monir] remove unused cluster code [doris]
github-actions[bot] commented on PR #31360: URL: https://github.com/apache/doris/pull/31360#issuecomment-1962295850 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [monir] remove unused cluster code [doris]
yiguolei merged PR #31360: URL: https://github.com/apache/doris/pull/31360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [monir] remove unused cluster code (#31360)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c2fe99f7c2b [monir] remove unused cluster code (#31360)
c2fe99f7c2b is described below
commit c2fe99f7c2be5351e1b9f117151142041db7ea71
Author: Mingyu Chen
AuthorDate: Sat Feb 24 16:23:20 2024 +0800
[monir] remove unused cluster code (#31360)
* [monir] remove unused cluster code
* 2
---
.../datasource/hive/event/MetastoreEventsProcessor.java | 2 --
.../src/main/java/org/apache/doris/qe/ConnectContext.java| 12 +---
2 files changed, 1 insertion(+), 13 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/event/MetastoreEventsProcessor.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/event/MetastoreEventsProcessor.java
index e5db75ff9f3..5ca94866bb4 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/event/MetastoreEventsProcessor.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/event/MetastoreEventsProcessor.java
@@ -30,7 +30,6 @@ import org.apache.doris.datasource.hive.HMSExternalCatalog;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.MasterOpExecutor;
import org.apache.doris.qe.OriginStatement;
-import org.apache.doris.system.SystemInfoService;
import com.google.common.collect.Maps;
import org.apache.commons.lang3.StringUtils;
@@ -320,7 +319,6 @@ public class MetastoreEventsProcessor extends MasterDaemon {
ctx.setQualifiedUser(UserIdentity.ROOT.getQualifiedUser());
ctx.setCurrentUserIdentity(UserIdentity.ROOT);
ctx.setEnv(Env.getCurrentEnv());
-ctx.setCluster(SystemInfoService.DEFAULT_CLUSTER);
MasterOpExecutor masterOpExecutor = new MasterOpExecutor(originStmt,
ctx,
RedirectStatus.FORWARD_WITH_SYNC, false);
if (LOG.isDebugEnabled()) {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
index dcf618248dd..484d3c47afb 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
@@ -142,8 +142,6 @@ public class ConnectContext {
protected volatile long currentDbId = -1;
// Transaction
protected volatile TransactionEntry txnEntry = null;
-// cluster name
-protected volatile String clusterName = "";
// used for ShowSqlAction which don't allow a user account
protected volatile boolean noAuth = false;
// username@host of current login user
@@ -848,14 +846,6 @@ public class ConnectContext {
return queryId;
}
-public String getClusterName() {
-return clusterName;
-}
-
-public void setCluster(String clusterName) {
-this.clusterName = clusterName;
-}
-
public String getSqlHash() {
return sqlHash;
}
@@ -1126,7 +1116,7 @@ public class ConnectContext {
AtomicBoolean hasAliveBe = new AtomicBoolean(false);
bes.stream().filter(Backend::isAlive).findAny().ifPresent(backend
-> {
if (LOG.isDebugEnabled()) {
-LOG.debug("get a clusterName {}, it's has more than one
alive be {}", clusterName, backend);
+LOG.debug("get a clusterName {}, it's has more than one
alive be {}", cloudClusterName, backend);
}
hasAliveBe.set(true);
});
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](group commit) Fix group commit flink error message [doris]
github-actions[bot] commented on PR #31350: URL: https://github.com/apache/doris/pull/31350#issuecomment-1962297156 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) 02/02: [regression test]Opt Test UniqueModel Schema Key Change (#31262)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 93cbc96141cafce81fb6941b4d1f6a63a45ace07
Author: kkop <45192870+cjj2...@users.noreply.github.com>
AuthorDate: Sat Feb 24 16:19:42 2024 +0800
[regression test]Opt Test UniqueModel Schema Key Change (#31262)
* Opt Test UniqueModel Schema Key Change
* Opt Test UniqueModel Schema key Change
---
.../test_unique_model_schema_key_change.out| 10 ---
.../test_unique_model_schema_key_change.groovy | 31 +++---
2 files changed, 9 insertions(+), 32 deletions(-)
diff --git
a/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
b/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
index b8e5753aff9..2419cdd18de 100644
---
a/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
+++
b/regression-test/data/schema_change_p0/test_unique_model_schema_key_change.out
@@ -99,16 +99,6 @@
789012345 Grace 1997-01-01T00:00Xian29 0
133 No. 222 Street, Xian2022-07-07T22:00
123456689 Alice 2024-01-04T09:00Yaan25 0
13812345678 No. 123 Street, Beijing 2022-01-01T10:00
--- ! --
-123456789 Alice 1997-01-01T00:00Beijing 25 0
13812345678 No. 123 Street, Beijing 2022-01-01T10:00
-234567890 Bob 1997-01-01T00:00Shanghai30 1
13998765432 No. 456 Street, Shanghai2022-02-02T12:00
-345678901 Carol 1997-01-01T00:00Guangzhou 28 0
13724681357 No. 789 Street, Guangzhou 2022-03-03T14:00
-456789012 Dave1997-01-01T00:00Shenzhen35 1
13680864279 No. 987 Street, Shenzhen2022-04-04T16:00
-567890123 Eve 1997-01-01T00:00Chengdu 27 0
13572468091 No. 654 Street, Chengdu 2022-05-05T18:00
-678901234 Frank 1997-01-01T00:00Hangzhou32 1
13467985213 No. 321 Street, Hangzhou2022-06-06T20:00
-789012345 Grace 1997-01-01T00:00Xian29 0
133 No. 222 Street, Xian2022-07-07T22:00
-123456689 Alice 2024-01-04T09:00Yaan25 0
13812345678 No. 123 Street, Beijing 2022-01-01T10:00
-
-- ! --
123456789 Alice F Beijing 25 0 13812345678 No. 123
Street, Beijing 2022-01-01T10:00
234567890 Bob F Shanghai30 1 13998765432
No. 456 Street, Shanghai2022-02-02T12:00
diff --git
a/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
b/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
index deb094fc284..52f211a98e7 100644
---
a/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
+++
b/regression-test/suites/schema_change_p0/test_unique_model_schema_key_change.groovy
@@ -46,6 +46,7 @@ suite("test_unique_model_schema_key_change","p0") {
" (678901234, 'Frank', 'Hangzhou', 32, 1,
13467985213, 'No. 321 Street, Hangzhou', '2022-06-06 20:00:00')," +
" (789012345, 'Grace', 'Xian', 29, 0, 133,
'No. 222 Street, Xian', '2022-07-07 22:00:00');"
+ //Test the unique model by adding a key column with VARCHAR
sql initTable
sql initTableData
sql """ alter table ${tbName} add column province VARCHAR(20) KEY
DEFAULT "广东省" AFTER username """
@@ -127,8 +128,7 @@ suite("test_unique_model_schema_key_change","p0") {
-
- //Test the unique model by adding a key column with FLOAT
+ //TODO Test the unique model by adding a key column with FLOAT
//java.sql.SQLException: errCode = 2, detailMessage = Float or double can
not used as a key, use decimal instead.
/* sql initTable
sql initTableData
@@ -141,12 +141,11 @@ suite("test_unique_model_schema_key_change","p0") {
-
- //Test the unique model by adding a key column with DOUBLE
+ //TODO Test the unique model by adding a key column with DOUBLE
//java.sql.SQLException: errCode = 2, detailMessage = Float or double can
not used as a key, use decimal instead.
/* sql initTable
sql initTableData
- sql """ alter table ${tbName} add column watch FLOAT KEY DEFAULT
"166.689" AFTER username """
+ sql """ alter table ${tbName} add column watch DOUBLE KEY DEFAULT
"166.689" AFTER username """
insertSql = " insert into ${tbName} values(123456689, 'Alice', 189.479,
'Yaan', 25, 0, 13812345678, 'No. 123 Street, Beijing', '2022-01-01 10:00:00');
"
waitForSchemaChangeDone({
sql getTableStatusSql
@@ -193,23 +192,11 @@ suite("test_unique_model_schema_key_change","p0") {
- //Test the unique model by add
(doris) branch branch-2.1 updated (8001f73e521 -> 93cbc96141c)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 8001f73e521 [pipelineX](file scan) Improve parallel tasks if ignore data distribution (#31328) new 09efc92d46e [Fix](regression) make test_index_compaction_with_multi_index_segments nonConcurrent to avoid concurrent be config modify (#31344) new 93cbc96141c [regression test]Opt Test UniqueModel Schema Key Change (#31262) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../test_unique_model_schema_key_change.out| 10 --- ...dex_compaction_with_multi_index_segments.groovy | 2 +- .../test_unique_model_schema_key_change.groovy | 31 +++--- 3 files changed, 10 insertions(+), 33 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) 01/02: [Fix](regression) make test_index_compaction_with_multi_index_segments nonConcurrent to avoid concurrent be config modify (#31344)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 09efc92d46e8bbecdb399209d6072bddd91705be
Author: airborne12
AuthorDate: Sat Feb 24 11:55:47 2024 +0800
[Fix](regression) make test_index_compaction_with_multi_index_segments
nonConcurrent to avoid concurrent be config modify (#31344)
---
.../test_index_compaction_with_multi_index_segments.groovy | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/regression-test/suites/inverted_index_p0/index_compaction/test_index_compaction_with_multi_index_segments.groovy
b/regression-test/suites/inverted_index_p0/index_compaction/test_index_compaction_with_multi_index_segments.groovy
index 693e4aac1b4..4023715c612 100644
---
a/regression-test/suites/inverted_index_p0/index_compaction/test_index_compaction_with_multi_index_segments.groovy
+++
b/regression-test/suites/inverted_index_p0/index_compaction/test_index_compaction_with_multi_index_segments.groovy
@@ -17,7 +17,7 @@
import org.codehaus.groovy.runtime.IOGroovyMethods
-suite("test_index_compaction_with_multi_index_segments", "p0") {
+suite("test_index_compaction_with_multi_index_segments", "nonConcurrent") {
def tableName = "test_index_compaction_with_multi_index_segments"
def backendId_to_backendIP = [:]
def backendId_to_backendHttpPort = [:]
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
doris-robot commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962299745 TeamCity be ut coverage result: Function Coverage: 35.71% (8548/23937) Line Coverage: 27.53% (69365/251985) Region Coverage: 26.68% (35973/134838) Branch Coverage: 23.49% (18392/78296) Coverage Report: http://coverage.selectdb-in.cc/coverage/162a67edf2b24c5c77eabbdb157e5f31773ec8f2_162a67edf2b24c5c77eabbdb157e5f31773ec8f2/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
doris-robot commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962299973 TPC-H: Total hot run time: 40982 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 162a67edf2b24c5c77eabbdb157e5f31773ec8f2, data reload: false -- Round 1 -- q1 17720 497349014901 q2 2058141 133 133 q3 10621 979 977 977 q4 4736952 965 952 q5 7603312031693120 q6 197 128 128 128 q7 1253772 766 766 q8 9341204920692049 q9 7455655565626555 q10 8311266326432643 q11 417 210 200 200 q12 772 326 322 322 q13 17953 358135763576 q14 286 263 256 256 q15 602 517 504 504 q16 481 398 419 398 q17 916 864 814 814 q18 7498669066896689 q19 1557148714831483 q20 565 273 264 264 q21 6503392339523923 q22 863 335 329 329 Total cold run time: 107708 ms Total hot run time: 40982 ms - Round 2, with runtime_filter_mode=off - q1 4867487548434843 q2 291 185 190 185 q3 3578357235673567 q4 2506252425142514 q5 5753576457525752 q6 212 126 123 123 q7 2230169216731673 q8 2992308630923086 q9 8696867186658665 q10 6767421842424218 q11 529 372 380 372 q12 769 542 540 540 q13 4299340333763376 q14 253 237 221 221 q15 632 511 535 511 q16 496 441 440 440 q17 1639160615961596 q18 8379769377157693 q19 1622164416301630 q20 2103181518181815 q21 6595613261396132 q22 572 494 518 494 Total cold run time: 65780 ms Total hot run time: 59446 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](stmt-forward) record query result for proxy query to avoid EOF (#30536) [doris]
TangSiyang2001 commented on PR #31363: URL: https://github.com/apache/doris/pull/31363#issuecomment-1962300401 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [branch-2.1](tracing) Pick pipeline tracing and relative bugfix [doris]
zclllyybb opened a new pull request, #31367: URL: https://github.com/apache/doris/pull/31367 ## Proposed changes Issue Number: close #xxx cherry pick https://github.com/apache/doris/pull/31027, https://github.com/apache/doris/pull/31305 and https://github.com/apache/doris/pull/31357 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](tracing) Pick pipeline tracing and relative bugfix [doris]
doris-robot commented on PR #31367: URL: https://github.com/apache/doris/pull/31367#issuecomment-1962301216 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [branch-2.1](grace-exit) cherry pick master fix [doris]
zclllyybb opened a new pull request, #31368: URL: https://github.com/apache/doris/pull/31368 ## Proposed changes Issue Number: close #xxx https://github.com/apache/doris/pull/31143 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](grace-exit) cherry pick master fix [doris]
doris-robot commented on PR #31368: URL: https://github.com/apache/doris/pull/31368#issuecomment-1962301816 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](grace-exit) cherry pick master fix [doris]
zclllyybb closed pull request #31368: [branch-2.1](grace-exit) cherry pick master fix URL: https://github.com/apache/doris/pull/31368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
doris-robot commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962302087 TPC-DS: Total hot run time: 176003 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 162a67edf2b24c5c77eabbdb157e5f31773ec8f2, data reload: false query1 934 345 339 339 query2 6539176716181618 query3 6701208 208 208 query4 23300 21175 21083 21083 query5 4316374 376 374 query6 249 167 170 167 query7 4593295 297 295 query8 247 195 196 195 query9 8444275527652755 query10 423 236 222 222 query11 15088 14606 14464 14464 query12 144 85 81 81 query13 1716417 427 417 query14 9047750074917491 query15 212 186 191 186 query16 7470254 251 251 query17 1405555 525 525 query18 1943277 273 273 query19 197 145 143 143 query20 89 81 83 81 query21 192 119 113 113 query22 4988476347934763 query23 32397 31593 31451 31451 query24 12698 342134013401 query25 642 384 359 359 query26 1870153 158 153 query27 3054320 317 317 query28 6765181517971797 query29 1116617 608 608 query30 278 137 143 137 query31 914 735 764 735 query32 98 60 58 58 query33 714 237 238 237 query34 1067481 499 481 query35 913 821 828 821 query36 983 943 897 897 query37 161 59 62 59 query38 3335317431703170 query39 1370132113061306 query40 288 108 104 104 query41 37 36 35 35 query42 102 99 96 96 query43 468 438 457 438 query44 1058680 695 680 query45 190 181 173 173 query46 1050768 755 755 query47 1663156015791560 query48 431 347 344 344 query49 1230306 307 306 query50 764 375 364 364 query51 4438431242794279 query52 110 94 97 94 query53 403 295 292 292 query54 296 220 232 220 query55 85 77 79 77 query56 220 205 199 199 query57 1063977 966 966 query58 205 193 197 193 query59 2184209321772093 query60 242 225 220 220 query61 86 87 84 84 query62 599 386 353 353 query63 319 276 287 276 query64 6483300631053006 query65 3274326632273227 query66 1343324 315 315 query67 14439 14511 14101 14101 query68 5114552 576 552 query69 517 352 355 352 query70 1281120612231206 query71 372 252 252 252 query72 6435277526382638 query73 690 313 309 309 query74 6977651064736473 query75 3204257325762573 query76 3279112912061129 query77 352 242 232 232 query78 9432874486988698 query79 957 513 535 513 query80 500 357 348 348 query81 435 207 208 207 query82 167 85 87 85 query83 140 127 120 120 query84 228 77 76 76 query85 1026353 354 353 query86 287 294 310 294 query87 3428336632863286 query88 2696228322852283 query89 445 364 348 348 query90 1911171 162 162 query91 150 130 126 126 query92 54 49 49 49 query93 1009513 500 500 query94 1100184 178 178 query95 433 341 337 337 query96 569 262 264 262 query97 4417424342604243 query98 206 220 199 199 query99 1057762 739 739 Total cold run time: 268550 ms Total hot run time: 176003 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Fix](grace-exit) BE gracefully exit when port conflicts (#31143) [doris]
doris-robot commented on PR #31369: URL: https://github.com/apache/doris/pull/31369#issuecomment-1962302311 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](grace-exit) BE gracefully exit when port conflicts (#31143) [doris]
zclllyybb opened a new pull request, #31369: URL: https://github.com/apache/doris/pull/31369 ## Proposed changes Issue Number: close #xxx https://github.com/apache/doris/pull/31143 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](tracing) Pick pipeline tracing and relative bugfix [doris]
github-actions[bot] commented on code in PR #31367:
URL: https://github.com/apache/doris/pull/31367#discussion_r1501373566
##
be/src/io/fs/file_system.h:
##
@@ -19,8 +19,8 @@
#include
Review Comment:
warning: 'butil/macros.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
##
be/src/pipeline/pipeline_fragment_context.h:
##
@@ -19,13 +19,11 @@
#include
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
##
be/src/pipeline/pipeline_tracing.h:
##
@@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+
+#include "common/config.h"
+#include "util/hash_util.hpp" // IWYU pragma: keep
+#include "util/thrift_util.h"
+#include "util/time.h"
+
+namespace doris::pipeline {
+
+struct ScheduleRecord {
+TUniqueId query_id;
+std::string task_id;
+uint32_t core_id;
+uint64_t thread_id;
+uint64_t start_time;
+uint64_t end_time;
+std::string state_name;
+
+bool operator<(const ScheduleRecord& rhs) const { return start_time <
rhs.start_time; }
+std::string to_string(uint64_t append_value) const {
+return fmt::format("{}|{}|{}|{}|{}|{}|{}|{}\n",
doris::to_string(query_id), task_id,
+ core_id, thread_id, start_time, end_time,
state_name, append_value);
+}
+};
+
+// all tracing datas of ONE specific query
+using OneQueryTraces = moodycamel::ConcurrentQueue;
+
+// belongs to exec_env, for all query, if enable
+class PipelineTracerContext {
+public:
+enum class RecordType {
+None, // disable
+PerQuery, // record per query. one query one file.
+Periodic // record per times. one timeslice one file.
+};
+void record(ScheduleRecord record); // record one schedule record
+void end_query(TUniqueId query_id,
+ uint64_t task_group); // tell context this query is end.
may leads to dump.
+Status change_record_params(const std::map&
params);
Review Comment:
warning: parameter 1 is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
Status change_record_params(std::map& params);
```
##
be/src/pipeline/pipeline_tracing.h:
##
@@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include
Review Comment:
warning: 'concurrentqueue.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
##
be/src/pipeline/pipeline.h:
##
@@ -18,11 +18,11 @@
#pragma once
#include
Review Comment:
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
##
be/src/common/compiler_util.h:
##
@@ -49,3 +49,5 @@
#define MAY_ALIAS __attribute__((__may_alias__))
#define ALIGN_CACHE_LINE __attribute__((aligned(CACHE_LINE_SIZE)))
+
+#define PURE __attribute__((pure))
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define PURE __attribute__((pure))
^
```
##
be/src/util/thrift_util.h:
##
@@ -17,26 +17,24 @@
#p
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
doris-robot commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962303103 ClickBench: Total hot run time: 31.05 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 162a67edf2b24c5c77eabbdb157e5f31773ec8f2, data reload: false query1 0.030.020.03 query2 0.060.020.02 query3 0.230.070.07 query4 1.660.090.08 query5 0.480.470.48 query6 1.390.620.62 query7 0.020.010.02 query8 0.040.030.03 query9 0.520.460.44 query10 0.490.490.48 query11 0.120.090.09 query12 0.120.100.10 query13 0.580.590.59 query14 0.760.790.78 query15 0.820.800.79 query16 0.340.330.32 query17 0.880.890.92 query18 0.170.180.17 query19 1.721.701.63 query20 0.010.010.02 query21 15.42 0.650.60 query22 2.963.682.39 query23 17.28 1.061.03 query24 2.050.750.38 query25 0.650.080.06 query26 0.160.130.14 query27 0.070.040.06 query28 11.79 0.840.80 query29 12.59 3.483.34 query30 0.510.500.50 query31 2.770.360.36 query32 3.380.470.47 query33 3.103.133.14 query34 15.36 4.504.48 query35 4.524.484.52 query36 1.080.950.96 query37 0.070.050.06 query38 0.040.030.03 query39 0.020.020.02 query40 0.180.160.16 query41 0.070.020.03 query42 0.030.020.01 query43 0.030.010.02 Total cold run time: 104.57 s Total hot run time: 31.05 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] The Pair.java in fe-common module exist hidden danger of NullPointException [doris]
ZhongJinHacker opened a new issue, #31370: URL: https://github.com/apache/doris/issues/31370 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version in master branch ### What's Wrong? In the fe project, many place use the Pair.java in fe-common module. And I found this case in the code project. https://github.com/apache/doris/assets/15382560/bd03991e-01e3-4da8-8735-617a1550dd30";> Developers usually input a null value into Pair object, but the Pair.java not support null value with its first and second member correctly. When a Pair object with null value, i would cause the NullPointException by calling its toString method or equals method. (I repeated this case by my unit test) It is very dangerous. And I have fixed it in my forked project. Please assign this issue to me , and then I will pr my commit soon. Thank you very much ### What You Expected? Please assign this issue to me , and then I will pr my commit soon. ### How to Reproduce? Pair firstPair = Pair.of(null, "world"); firstPair.toString(); it will cause NullPointException ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
doris-robot commented on PR #31366: URL: https://github.com/apache/doris/pull/31366#issuecomment-1962303753 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 162a67edf2b24c5c77eabbdb157e5f31773ec8f2 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 16.8 seconds inserted 1000 Rows, about 595K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](grace-exit) BE gracefully exit when port conflicts (#31143) [doris]
github-actions[bot] commented on PR #31369: URL: https://github.com/apache/doris/pull/31369#issuecomment-1962303896 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](fe-common) Fix the Pair.java code about the hidden danger of NullPointException [doris]
ZhongJinHacker opened a new pull request, #31371: URL: https://github.com/apache/doris/pull/31371 ## Proposed changes Issue Number: close #31370 add code in toString method and equals method of Pair.java to avoid the null point exception situation ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](fe-common) Fix the Pair.java code about the hidden danger of NullPointException [doris]
doris-robot commented on PR #31371: URL: https://github.com/apache/doris/pull/31371#issuecomment-1962306312 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore](ci) fix ak sk of cloud regression [doris]
hello-stephen opened a new pull request, #31372: URL: https://github.com/apache/doris/pull/31372 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]
doris-robot commented on PR #31372: URL: https://github.com/apache/doris/pull/31372#issuecomment-1962307723 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]
hello-stephen commented on PR #31372: URL: https://github.com/apache/doris/pull/31372#issuecomment-1962307733 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](simd-json-reader) fix simd json reader lose data and support stream parser [doris]
github-actions[bot] commented on PR #27145: URL: https://github.com/apache/doris/pull/27145#issuecomment-1962310016 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](simd-json-reader) fix simd json reader lose data and support stream parser [doris]
github-actions[bot] commented on PR #27145: URL: https://github.com/apache/doris/pull/27145#issuecomment-1962310244 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment](executor)Add scanbytes/scanrows condition [doris]
yiguolei commented on code in PR #31364:
URL: https://github.com/apache/doris/pull/31364#discussion_r1501379845
##
be/src/runtime/fragment_mgr.cpp:
##
@@ -1514,17 +1514,10 @@ void
FragmentMgr::_setup_shared_hashtable_for_broadcast_join(const TPipelineFrag
void FragmentMgr::get_runtime_query_info(std::vector*
query_info_list) {
{
std::lock_guard lock(_lock);
-// todo: use monotonic time
Review Comment:
那感觉这个方法没用了啊，所有的metric 都是从get_metric_map 拿的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment](executor)Add scanbytes/scanrows condition [doris]
yiguolei commented on code in PR #31364:
URL: https://github.com/apache/doris/pull/31364#discussion_r1501380067
##
be/src/runtime/workload_management/workload_sched_policy_mgr.cpp:
##
@@ -76,6 +77,7 @@ void WorkloadSchedPolicyMgr::_schedule_workload() {
while (!_stop_latch.wait_for(std::chrono::milliseconds(500))) {
// 1 get query info
std::vector list;
+//todo(wb) maybe we can get runtime queryinfo from
RuntimeQueryStatiticsMgr directly
_exec_env->fragment_mgr()->get_runtime_query_info(&list);
Review Comment:
太绕了，直接把这个方法去掉吧， 直接从mgr 里拿到所有的queryid 到 metric map的映射吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix potential bugs relating to discarded [doris]
wyxxxcat commented on PR #31296: URL: https://github.com/apache/doris/pull/31296#issuecomment-1962322363 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
yiguolei opened a new pull request, #31373: URL: https://github.com/apache/doris/pull/31373 ## Proposed changes 1. should always enable workload group because other operations depend on it for example MTMV, and spill to disk. 2. the normal workload group should be created in constructor. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962323249 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
yiguolei commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962323856 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix potential bugs relating to discarded [doris]
doris-robot commented on PR #31296: URL: https://github.com/apache/doris/pull/31296#issuecomment-1962328389 TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23932) Line Coverage: 27.53% (69376/251985) Region Coverage: 26.67% (36014/135034) Branch Coverage: 23.49% (18396/78302) Coverage Report: http://coverage.selectdb-in.cc/coverage/f98d07d0900f592f6cf6d8bd3b746acd5997ca5b_f98d07d0900f592f6cf6d8bd3b746acd5997ca5b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962329340 TPC-H: Total hot run time: 41386 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 12220459529a5d10af34df84629d39c4b4ba6516, data reload: false -- Round 1 -- q1 17724 492248744874 q2 2035138 130 130 q3 11108 1006990 990 q4 4654962 977 962 q5 7630317532143175 q6 196 135 138 135 q7 1249795 756 756 q8 9291205220562052 q9 7408658865786578 q10 8336266926542654 q11 419 208 219 208 q12 765 331 334 331 q13 18182 382137883788 q14 322 299 297 297 q15 636 536 529 529 q16 554 440 457 440 q17 948 871 847 847 q18 7753664066616640 q19 1541147614811476 q20 540 276 278 276 q21 6988397739103910 q22 866 345 338 338 Total cold run time: 109145 ms Total hot run time: 41386 ms - Round 2, with runtime_filter_mode=off - q1 4798478447684768 q2 292 180 180 180 q3 3572355535523552 q4 2546250725202507 q5 5725574657395739 q6 213 130 132 130 q7 2233164716671647 q8 2955302530433025 q9 8655866385948594 q10 6755423442394234 q11 506 372 380 372 q12 767 543 545 543 q13 4855339634153396 q14 272 229 240 229 q15 596 500 498 498 q16 468 430 464 430 q17 1673161915811581 q18 8329770676057605 q19 1635162416311624 q20 2089182318451823 q21 6556625961786178 q22 558 511 505 505 Total cold run time: 66048 ms Total hot run time: 59160 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962331411 TPC-DS: Total hot run time: 175893 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 12220459529a5d10af34df84629d39c4b4ba6516, data reload: false query1 924 348 336 336 query2 6541185817071707 query3 6699210 202 202 query4 23213 21031 21136 21031 query5 4227377 376 376 query6 259 166 172 166 query7 4602303 301 301 query8 248 193 196 193 query9 8435279828122798 query10 413 229 227 227 query11 14928 14510 14433 14433 query12 147 83 80 80 query13 1715410 421 410 query14 9288760876957608 query15 215 183 191 183 query16 7506250 243 243 query17 1426539 516 516 query18 1931260 257 257 query19 191 150 147 147 query20 84 81 81 81 query21 184 121 119 119 query22 4894478145414541 query23 32359 31511 31396 31396 query24 12717 338033433343 query25 637 365 352 352 query26 1875148 162 148 query27 3049319 317 317 query28 6618182718071807 query29 1108620 610 610 query30 280 138 148 138 query31 925 754 753 753 query32 93 62 58 58 query33 711 235 231 231 query34 1062508 497 497 query35 927 832 821 821 query36 983 941 928 928 query37 165 60 65 60 query38 3291319431773177 query39 1360133313121312 query40 280 106 103 103 query41 36 36 35 35 query42 107 96 100 96 query43 473 453 436 436 query44 1070676 691 676 query45 198 180 173 173 query46 1042782 741 741 query47 1595158415621562 query48 413 353 348 348 query49 1221311 299 299 query50 776 368 376 368 query51 4424430843634308 query52 107 100 91 91 query53 395 297 294 294 query54 292 228 226 226 query55 94 82 79 79 query56 222 207 204 204 query57 1024932 937 932 query58 209 189 199 189 query59 2272210422522104 query60 235 231 210 210 query61 81 82 88 82 query62 580 399 370 370 query63 322 285 285 285 query64 6380297130962971 query65 3278325332633253 query66 1351328 325 325 query67 14783 14271 14371 14271 query68 5113546 550 546 query69 523 365 354 354 query70 1217126712231223 query71 437 247 253 247 query72 6293278525862586 query73 702 310 308 308 query74 6917641964826419 query75 3180256925442544 query76 3260111412091114 query77 366 236 240 236 query78 9402879187628762 query79 967 513 510 510 query80 511 358 354 354 query81 435 200 204 200 query82 159 80 80 80 query83 142 126 118 118 query84 228 82 76 76 query85 1022336 332 332 query86 313 315 305 305 query87 3409327932573257 query88 2767231122972297 query89 428 362 364 362 query90 1909167 166 166 query91 153 124 128 124 query92 55 49 49 49 query93 1010516 492 492 query94 1162178 176 176 query95 443 329 338 329 query96 568 263 269 263 query97 4479424842884248 query98 220 205 197 197 query99 1022717 685 685 Total cold run time: 268302 ms Total hot run time: 175893 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962332488 ClickBench: Total hot run time: 31.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 12220459529a5d10af34df84629d39c4b4ba6516, data reload: false query1 0.030.030.02 query2 0.070.030.02 query3 0.220.070.07 query4 1.650.080.08 query5 0.480.480.49 query6 1.330.600.60 query7 0.010.010.02 query8 0.040.030.03 query9 0.520.450.43 query10 0.500.470.49 query11 0.140.090.10 query12 0.120.100.10 query13 0.590.580.58 query14 0.770.770.80 query15 0.820.790.78 query16 0.330.310.32 query17 0.910.900.90 query18 0.180.170.18 query19 1.801.641.62 query20 0.020.010.01 query21 15.43 0.670.59 query22 3.143.823.15 query23 17.44 1.090.93 query24 1.990.560.38 query25 0.600.070.05 query26 0.160.140.14 query27 0.060.050.05 query28 12.08 0.830.83 query29 12.65 3.303.38 query30 0.500.490.48 query31 2.780.340.35 query32 3.370.470.47 query33 3.093.113.17 query34 15.35 4.524.52 query35 4.504.494.49 query36 1.060.960.96 query37 0.070.050.05 query38 0.040.030.03 query39 0.020.020.02 query40 0.170.150.14 query41 0.070.020.02 query42 0.020.010.02 query43 0.030.020.02 Total cold run time: 105.15 s Total hot run time: 31.62 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962333097 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 12220459529a5d10af34df84629d39c4b4ba6516 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 17.3 seconds inserted 1000 Rows, about 578K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-196295 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]
github-actions[bot] commented on code in PR #31214:
URL: https://github.com/apache/doris/pull/31214#discussion_r1501410376
##
be/src/io/fs/hdfs_file_system.cpp:
##
@@ -261,13 +265,42 @@ Status HdfsFileSystem::file_size_impl(const Path& path,
int64_t* file_size) cons
return Status::OK();
}
-Status HdfsFileSystem::list_impl(const Path& path, bool only_file,
std::vector* files,
- bool* exists) {
-RETURN_IF_ERROR(exists_impl(path, exists));
-if (!(*exists)) {
-return Status::OK();
+struct HdfsFileListIterator final : public FileListIterator {
+public:
+HdfsFileListIterator(int numEntries, hdfsFileInfo* hdfs_file_info, bool
only_file)
+: numEntries(numEntries),
+ hdfs_file_info(hdfs_file_info),
+ only_file(only_file),
+ idx(0) {}
+~HdfsFileListIterator() override { hdfsFreeFileInfo(hdfs_file_info,
numEntries); }
+
+bool has_next() const override { return idx < numEntries; }
+
+private:
+Result next() override {
+FileInfo file_info;
+for (; idx < numEntries; idx++) {
+auto& file = hdfs_file_info[idx];
+if (only_file && file.mKind == kObjectKindDirectory) {
+continue;
+}
+file_info.file_name = file.mName;
+file_info.file_size = file.mSize;
+file_info.is_file = (file.mKind != kObjectKindDirectory);
+break;
+}
+return file_info;
}
+int numEntries;
+hdfsFileInfo* hdfs_file_info;
+bool only_file;
+size_t idx;
Review Comment:
warning: use default member initializer for 'idx'
[modernize-use-default-member-init]
be/src/io/fs/hdfs_file_system.cpp:273:
```diff
- idx(0) {}
+ {}
```
```suggestion
size_t idx{0};
```
##
be/src/io/fs/path.h:
##
@@ -17,6 +17,8 @@
#pragma once
+#include
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix potential bugs relating to discarded [doris]
wyxxxcat closed pull request #31296: [Enhancement] fix potential bugs relating to discarded URL: https://github.com/apache/doris/pull/31296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962337283 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962339568 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962346160 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962357654 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]
github-actions[bot] commented on PR #31372: URL: https://github.com/apache/doris/pull/31372#issuecomment-1962358689 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]
github-actions[bot] commented on PR #31372: URL: https://github.com/apache/doris/pull/31372#issuecomment-1962358697 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]
dataroaring merged PR #31372: URL: https://github.com/apache/doris/pull/31372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [chore](ci) fix ak sk of cloud regression (#31372)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 44b35bfe797 [chore](ci) fix ak sk of cloud regression (#31372)
44b35bfe797 is described below
commit 44b35bfe7972b0a1a3b1ab088984c84b6d3c6864
Author: Dongyang Li
AuthorDate: Sat Feb 24 21:08:47 2024 +0800
[chore](ci) fix ak sk of cloud regression (#31372)
Co-authored-by: stephen
---
regression-test/pipeline/cloud_p0/run.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/regression-test/pipeline/cloud_p0/run.sh
b/regression-test/pipeline/cloud_p0/run.sh
index 3825f9f5257..fe27ad08f88 100644
--- a/regression-test/pipeline/cloud_p0/run.sh
+++ b/regression-test/pipeline/cloud_p0/run.sh
@@ -47,8 +47,8 @@ run() {
shopt -s inherit_errexit
cd "${teamcity_build_checkoutDir}" || return 1
-echo "ak=${cos_ak}"
>>"${teamcity_build_checkoutDir}"/regression-test/pipeline/cloud_p0/conf/regression-conf-custom.groovy
-echo "sk=${cos_sk}"
>>"${teamcity_build_checkoutDir}"/regression-test/pipeline/cloud_p0/conf/regression-conf-custom.groovy
+echo "ak='${cos_ak}'"
>>"${teamcity_build_checkoutDir}"/regression-test/pipeline/cloud_p0/conf/regression-conf-custom.groovy
+echo "sk='${cos_sk}'"
>>"${teamcity_build_checkoutDir}"/regression-test/pipeline/cloud_p0/conf/regression-conf-custom.groovy
cp -f
"${teamcity_build_checkoutDir}"/regression-test/pipeline/cloud_p0/conf/regression-conf-custom.groovy
\
"${teamcity_build_checkoutDir}"/regression-test/conf/
if "${teamcity_build_checkoutDir}"/run-regression-test.sh \
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](cloud) enable all p0 case [doris]
dataroaring commented on PR #31240: URL: https://github.com/apache/doris/pull/31240#issuecomment-1962360656 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](fe-common) Fix the Pair.java code about the hidden danger of NullPointException [doris]
github-actions[bot] commented on PR #31371: URL: https://github.com/apache/doris/pull/31371#issuecomment-1962367137 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](fe-common) Fix the Pair.java code about the hidden danger of NullPointException [doris]
github-actions[bot] commented on PR #31371: URL: https://github.com/apache/doris/pull/31371#issuecomment-1962367146 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](datetime) fix hour 24 on be [doris]
github-actions[bot] commented on PR #31304: URL: https://github.com/apache/doris/pull/31304#issuecomment-1962368350 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature] Support to do schema change in cloud mode [doris]
gavinchou commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962380148 run buidlall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature] Support to do schema change in cloud mode [doris]
gavinchou commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962380270 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Debug](thrift) add log for thrift transport error [doris]
morningman merged PR #31366: URL: https://github.com/apache/doris/pull/31366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Debug](thrift) add log for thrift transport error (#31366)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 920540e7d41 [Debug](thrift) add log for thrift transport error (#31366)
920540e7d41 is described below
commit 920540e7d4111729a70fbaa45a5a317dcf1ab96a
Author: zclllyybb
AuthorDate: Sat Feb 24 22:38:25 2024 +0800
[Debug](thrift) add log for thrift transport error (#31366)
---
be/src/util/thrift_rpc_helper.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/be/src/util/thrift_rpc_helper.cpp
b/be/src/util/thrift_rpc_helper.cpp
index 0f9d3fae5c3..285c1a689ab 100644
--- a/be/src/util/thrift_rpc_helper.cpp
+++ b/be/src/util/thrift_rpc_helper.cpp
@@ -73,6 +73,7 @@ Status ThriftRpcHelper::rpc(const std::string& ip, const
int32_t port,
try {
callback(client);
} catch (apache::thrift::transport::TTransportException& e) {
+std::cerr << "thrift error, reason=" << e.what();
LOG(WARNING) << "retrying call frontend service after "
<< config::thrift_client_retry_interval_ms << " ms,
address=" << address
<< ", reason=" << e.what();
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] test regression [doris]
feiniaofeiafei opened a new pull request, #31374: URL: https://github.com/apache/doris/pull/31374 test if the regression has something wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] test regression [doris]
doris-robot commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962390312 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] test regression [doris]
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962390635 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] test regression [doris]
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962390762 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
gavinchou opened a new pull request, #31375: URL: https://github.com/apache/doris/pull/31375 `ParquetReader::parse_thrift_footer` will allocate memory for `_file_metadata`, the original implementation may leak if it returns without reclaiming it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962402808 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
gavinchou commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962402844 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
github-actions[bot] commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962405196 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
github-actions[bot] commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962405699 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
github-actions[bot] commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962405709 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962410098 TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23937) Line Coverage: 27.53% (69361/251984) Region Coverage: 26.68% (35979/134838) Branch Coverage: 23.49% (18391/78296) Coverage Report: http://coverage.selectdb-in.cc/coverage/17f6892d82cf481e84361d6bce7d34d9f59cbc92_17f6892d82cf481e84361d6bce7d34d9f59cbc92/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962410192 TPC-H: Total hot run time: 41127 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 17f6892d82cf481e84361d6bce7d34d9f59cbc92, data reload: false -- Round 1 -- q1 17662 498048614861 q2 2032140 134 134 q3 10577 977 985 977 q4 4655975 962 962 q5 7615312631643126 q6 195 133 128 128 q7 1249772 757 757 q8 9225199420281994 q9 7463656065576557 q10 8313267126742671 q11 415 219 216 216 q12 744 330 340 330 q13 18303 363136293629 q14 296 257 257 257 q15 616 545 504 504 q16 479 411 433 411 q17 929 872 876 872 q18 7489672166636663 q19 1544149914901490 q20 542 269 281 269 q21 6775406839873987 q22 873 346 332 332 Total cold run time: 107991 ms Total hot run time: 41127 ms - Round 2, with runtime_filter_mode=off - q1 4925489948824882 q2 291 184 187 184 q3 3864387939133879 q4 2720276927772769 q5 6176577859185778 q6 219 138 128 128 q7 2283172216651665 q8 2996311431333114 q9 8663867686898676 q10 6786423842094209 q11 525 373 378 373 q12 776 534 535 534 q13 4860342933813381 q14 263 235 233 233 q15 595 501 504 501 q16 474 442 448 442 q17 1647160215891589 q18 8404772775967596 q19 1628163216291629 q20 2091184818461846 q21 6496618266016182 q22 586 509 523 509 Total cold run time: 67268 ms Total hot run time: 60099 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962412915 TPC-DS: Total hot run time: 176141 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 17f6892d82cf481e84361d6bce7d34d9f59cbc92, data reload: false query1 942 350 341 341 query2 6541171716331633 query3 6699205 198 198 query4 23146 21229 21163 21163 query5 4250376 374 374 query6 259 169 178 169 query7 4605289 281 281 query8 256 188 191 188 query9 8435277127302730 query10 413 228 220 220 query11 14886 14576 14436 14436 query12 144 86 83 83 query13 1698419 409 409 query14 9214759075047504 query15 206 189 187 187 query16 7515252 245 245 query17 1415560 525 525 query18 1940275 256 256 query19 184 146 146 146 query20 83 79 86 79 query21 189 128 125 125 query22 4831467446784674 query23 32436 31546 31537 31537 query24 12699 338234133382 query25 646 356 353 353 query26 1865156 155 155 query27 3058308 308 308 query28 6632180917991799 query29 610 603 603 query30 279 140 141 140 query31 907 747 760 747 query32 94 62 57 57 query33 725 223 222 222 query34 1100488 489 488 query35 909 842 834 834 query36 1017921 894 894 query37 156 58 62 58 query38 3322315831663158 query39 1399134113241324 query40 285 107 105 105 query41 37 36 36 36 query42 106 107 98 98 query43 467 428 450 428 query44 1054692 687 687 query45 199 182 174 174 query46 1048777 762 762 query47 1659154915371537 query48 429 342 346 342 query49 1199296 304 296 query50 777 368 366 366 query51 4338440142784278 query52 110 94 95 94 query53 385 307 293 293 query54 286 218 228 218 query55 80 78 81 78 query56 219 205 205 205 query57 1038980 980 980 query58 210 200 190 190 query59 2283217820602060 query60 232 209 217 209 query61 84 83 89 83 query62 582 375 366 366 query63 319 282 276 276 query64 6386300831073008 query65 3321325832663258 query66 1358322 321 321 query67 14655 14322 14316 14316 query68 5120550 555 550 query69 522 362 351 351 query70 1235118512411185 query71 428 249 253 249 query72 6296277326262626 query73 692 327 307 307 query74 6874648164986481 query75 3261260025652565 query76 3288113612041136 query77 353 234 237 234 query78 9308882687588758 query79 941 506 515 506 query80 523 354 338 338 query81 432 207 197 197 query82 161 85 84 84 query83 140 127 119 119 query84 232 77 81 77 query85 1038348 343 343 query86 312 306 309 306 query87 3427324732803247 query88 2716232322872287 query89 435 359 364 359 query90 1919168 162 162 query91 151 128 125 125 query92 53 47 52 47 query93 1019503 496 496 query94 1158182 176 176 query95 430 334 339 334 query96 583 266 264 264 query97 4402426743104267 query98 226 213 191 191 query99 1103685 694 685 Total cold run time: 268130 ms Total hot run time: 176141 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962414229 ClickBench: Total hot run time: 31.17 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 17f6892d82cf481e84361d6bce7d34d9f59cbc92, data reload: false query1 0.020.020.02 query2 0.060.020.02 query3 0.220.080.07 query4 1.640.080.08 query5 0.480.480.48 query6 1.400.620.62 query7 0.020.010.01 query8 0.040.020.02 query9 0.520.460.45 query10 0.490.480.49 query11 0.130.100.09 query12 0.120.100.10 query13 0.590.580.58 query14 0.760.790.78 query15 0.840.800.80 query16 0.340.330.32 query17 0.900.880.89 query18 0.180.170.17 query19 1.811.691.70 query20 0.010.020.01 query21 15.39 0.660.57 query22 2.823.542.47 query23 17.23 0.991.12 query24 2.150.620.37 query25 0.620.070.06 query26 0.140.130.13 query27 0.060.050.05 query28 11.76 0.850.84 query29 12.49 3.293.31 query30 0.540.490.50 query31 2.810.350.37 query32 3.330.490.48 query33 3.153.173.16 query34 15.34 4.534.48 query35 4.524.534.53 query36 1.080.960.95 query37 0.080.050.06 query38 0.040.030.03 query39 0.020.020.02 query40 0.170.140.16 query41 0.080.010.01 query42 0.030.020.02 query43 0.020.020.02 Total cold run time: 104.44 s Total hot run time: 31.17 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
yiguolei commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962414782 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](rpc) test thrift failed and use glog to print [doris]
zclllyybb commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962415791 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](rpc) test thrift rpc fail [doris]
github-actions[bot] commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962417723 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962419401 TPC-H: Total hot run time: 41407 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b6378c5728887583bc7f29c3fc313511c03c4bde, data reload: false -- Round 1 -- q1 18834 523351765176 q2 2491146 138 138 q3 11534 101810201018 q4 5563999 1007999 q5 8034313931833139 q6 195 137 132 132 q7 1262795 763 763 q8 9236208320762076 q9 7470663766086608 q10 8305265326362636 q11 415 222 211 211 q12 762 330 329 329 q13 17964 358335883583 q14 284 253 259 253 q15 632 528 527 527 q16 487 413 404 404 q17 931 869 810 810 q18 7345668465686568 q19 1557149415011494 q20 482 276 274 274 q21 5956393739813937 q22 811 345 332 332 Total cold run time: 110550 ms Total hot run time: 41407 ms - Round 2, with runtime_filter_mode=off - q1 4843486948414841 q2 295 186 187 186 q3 3595358935903589 q4 2544253525422535 q5 5778577157455745 q6 214 123 130 123 q7 2239168616731673 q8 3019308130943081 q9 8704877087528752 q10 6484423542424235 q11 527 370 394 370 q12 768 544 548 544 q13 4200341234333412 q14 275 231 228 228 q15 642 521 498 498 q16 485 444 436 436 q17 1680161916031603 q18 8270760776847607 q19 1657164316501643 q20 2101182618151815 q21 6587622861946194 q22 586 506 523 506 Total cold run time: 65493 ms Total hot run time: 59616 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962421928 TPC-DS: Total hot run time: 176129 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b6378c5728887583bc7f29c3fc313511c03c4bde, data reload: false query1 928 346 358 346 query2 6499170517291705 query3 6701206 203 203 query4 23101 21100 21206 21100 query5 4269371 369 369 query6 259 165 169 165 query7 4618300 286 286 query8 251 190 202 190 query9 8436276927512751 query10 416 216 225 216 query11 14929 14550 14493 14493 query12 134 91 84 84 query13 1692431 420 420 query14 9067751574497449 query15 207 184 190 184 query16 7159253 244 244 query17 1423534 514 514 query18 2102263 260 260 query19 194 146 145 145 query20 85 83 82 82 query21 183 120 115 115 query22 4974480448334804 query23 32571 31515 31477 31477 query24 12683 334033823340 query25 646 354 350 350 query26 1811155 156 155 query27 3051313 315 313 query28 6720183618271827 query29 1169606 636 606 query30 279 136 144 136 query31 928 757 763 757 query32 93 57 55 55 query33 725 235 237 235 query34 1043495 496 495 query35 917 829 817 817 query36 983 898 882 882 query37 138 64 67 64 query38 3284320431533153 query39 1385132713071307 query40 279 104 106 104 query41 38 35 35 35 query42 109 98 102 98 query43 466 445 449 445 query44 1065687 694 687 query45 197 189 175 175 query46 1054769 757 757 query47 1680162615551555 query48 417 345 350 345 query49 1178303 300 300 query50 763 370 364 364 query51 4387432943124312 query52 110 95 91 91 query53 381 302 295 295 query54 300 225 233 225 query55 87 88 80 80 query56 217 192 203 192 query57 1022993 947 947 query58 221 189 199 189 query59 2193221220772077 query60 234 224 212 212 query61 82 83 86 83 query62 597 381 373 373 query63 322 284 293 284 query64 6525297930922979 query65 3275325932323232 query66 1377336 319 319 query67 14386 14293 14155 14155 query68 5016569 544 544 query69 513 358 346 346 query70 1295125512431243 query71 380 246 250 246 query72 6300275726142614 query73 696 321 310 310 query74 6870654965356535 query75 3231258025582558 query76 3269111611811116 query77 338 231 235 231 query78 9472877187328732 query79 967 502 501 501 query80 518 364 341 341 query81 444 212 205 205 query82 165 88 85 85 query83 143 121 123 121 query84 219 76 79 76 query85 1031352 340 340 query86 308 305 300 300 query87 3432332132593259 query88 2685230622992299 query89 431 354 354 354 query90 1958164 165 164 query91 156 132 128 128 query92 51 51 51 51 query93 1002526 500 500 query94 1133174 174 174 query95 435 326 346 326 query96 571 261 271 261 query97 4433425942534253 query98 223 209 203 203 query99 1036739 709 709 Total cold run time: 267736 ms Total hot run time: 176129 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [test](rpc) test thrift rpc fail [doris]
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962421987 TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23937) Line Coverage: 27.53% (69372/251985) Region Coverage: 26.68% (35978/134838) Branch Coverage: 23.50% (18396/78296) Coverage Report: http://coverage.selectdb-in.cc/coverage/2e94ac940d495d68bab1ad30c5fcf5531374b493_2e94ac940d495d68bab1ad30c5fcf5531374b493/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](rpc) test thrift rpc fail [doris]
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962422972 TPC-H: Total hot run time: 41052 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2e94ac940d495d68bab1ad30c5fcf5531374b493, data reload: false -- Round 1 -- q1 17646 497948714871 q2 2054140 130 130 q3 10588 1014987 987 q4 4654957 973 957 q5 7616314031783140 q6 197 134 132 132 q7 1248770 761 761 q8 9246206520622062 q9 7459663965956595 q10 8322263826292629 q11 405 223 225 223 q12 732 337 327 327 q13 17920 359936373599 q14 288 262 253 253 q15 594 528 493 493 q16 474 406 433 406 q17 929 881 860 860 q18 7357671965386538 q19 1555151115061506 q20 543 273 263 263 q21 6847404539783978 q22 873 342 342 342 Total cold run time: 107547 ms Total hot run time: 41052 ms - Round 2, with runtime_filter_mode=off - q1 4900490148354835 q2 297 188 183 183 q3 3599358935773577 q4 2556254525272527 q5 5763573457085708 q6 218 128 124 124 q7 2239163816631638 q8 3001306830813068 q9 8718870587018701 q10 6823423042384230 q11 511 363 358 358 q12 774 541 544 541 q13 4312342034303420 q14 271 231 235 231 q15 620 540 519 519 q16 507 472 463 463 q17 1683160816021602 q18 8350768275737573 q19 1634164216361636 q20 2096186118151815 q21 6612618261436143 q22 572 504 501 501 Total cold run time: 66056 ms Total hot run time: 59393 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962422976 ClickBench: Total hot run time: 30.76 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b6378c5728887583bc7f29c3fc313511c03c4bde, data reload: false query1 0.030.020.02 query2 0.070.030.03 query3 0.230.070.08 query4 1.620.080.09 query5 0.490.490.49 query6 1.330.630.62 query7 0.020.020.01 query8 0.040.030.03 query9 0.530.450.45 query10 0.500.480.48 query11 0.130.100.09 query12 0.120.100.10 query13 0.590.590.58 query14 0.780.780.79 query15 0.810.800.79 query16 0.320.330.34 query17 0.880.900.91 query18 0.180.170.17 query19 1.801.701.70 query20 0.020.020.01 query21 15.40 0.580.58 query22 3.094.602.29 query23 17.64 1.000.99 query24 2.140.270.22 query25 0.580.050.06 query26 0.140.140.14 query27 0.070.040.06 query28 12.35 0.850.80 query29 12.65 3.373.28 query30 0.510.480.48 query31 2.790.360.36 query32 3.320.470.47 query33 3.143.163.15 query34 15.38 4.534.52 query35 4.514.494.47 query36 1.080.970.94 query37 0.070.050.05 query38 0.040.030.02 query39 0.030.010.01 query40 0.170.150.14 query41 0.070.020.01 query42 0.020.010.02 query43 0.030.010.02 Total cold run time: 105.71 s Total hot run time: 30.76 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962423657 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b6378c5728887583bc7f29c3fc313511c03c4bde with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 17.3 seconds inserted 1000 Rows, about 578K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](rpc) test thrift rpc fail [doris]
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962425459 TPC-DS: Total hot run time: 176491 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2e94ac940d495d68bab1ad30c5fcf5531374b493, data reload: false query1 920 353 346 346 query2 6496184917571757 query3 8617219 208 208 query4 23174 21237 21404 21237 query5 4288379 371 371 query6 252 204 186 186 query7 4698329 320 320 query8 256 208 218 208 query9 8581289928812881 query10 562 262 251 251 query11 15447 14714 14479 14479 query12 154 82 85 82 query13 1708417 428 417 query14 11445 749676037496 query15 206 183 184 183 query16 7664256 251 251 query17 1692562 522 522 query18 2172257 260 257 query19 186 145 151 145 query20 84 81 81 81 query21 185 123 119 119 query22 4812473647554736 query23 32378 31502 31513 31502 query24 11051 337434133374 query25 624 364 360 360 query26 1462153 156 153 query27 3053325 309 309 query28 6549183218131813 query29 1012612 617 612 query30 275 135 147 135 query31 930 755 761 755 query32 102 60 57 57 query33 720 237 230 230 query34 1050496 505 496 query35 923 824 836 824 query36 978 898 878 878 query37 135 59 57 57 query38 3291316032023160 query39 1366133213391332 query40 194 105 103 103 query41 39 40 34 34 query42 107 100 101 100 query43 470 429 446 429 query44 1086682 697 682 query45 197 182 179 179 query46 1041778 725 725 query47 1670157415341534 query48 412 352 346 346 query49 1102308 298 298 query50 768 376 368 368 query51 4457436343534353 query52 107 96 93 93 query53 401 298 301 298 query54 266 222 212 212 query55 86 85 86 85 query56 215 220 214 214 query57 1072923 974 923 query58 211 194 192 192 query59 2162207721322077 query60 228 207 214 207 query61 81 83 83 83 query62 583 371 384 371 query63 324 285 280 280 query64 6383301631033016 query65 3276324632223222 query66 1151327 324 324 query67 14574 14435 14203 14203 query68 5125532 557 532 query69 515 349 344 344 query70 1298123312651233 query71 445 254 256 254 query72 6359277626152615 query73 715 317 312 312 query74 6774649363946394 query75 3246254925382538 query76 3292114412131144 query77 484 242 244 242 query78 9444878887518751 query79 986 505 512 505 query80 657 354 346 346 query81 456 204 204 204 query82 126686 83 83 query83 236 121 121 121 query84 224 76 82 76 query85 1110338 338 338 query86 296 309 312 309 query87 3467330232563256 query88 2668229823032298 query89 432 361 349 349 query90 1958165 164 164 query91 153 131 125 125 query92 51 53 47 47 query93 1039531 500 500 query94 1245176 175 175 query95 423 330 345 330 query96 570 267 265 265 query97 4460425442304230 query98 223 207 192 192 query99 1081688 692 688 Total cold run time: 272859 ms Total hot run time: 176491 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [test](rpc) test thrift rpc fail [doris]
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962426676 ClickBench: Total hot run time: 31.52 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 2e94ac940d495d68bab1ad30c5fcf5531374b493, data reload: false query1 0.030.030.02 query2 0.060.020.02 query3 0.230.060.07 query4 1.660.090.08 query5 0.490.480.48 query6 1.360.610.61 query7 0.020.010.02 query8 0.040.020.02 query9 0.510.440.45 query10 0.490.470.50 query11 0.140.100.10 query12 0.120.100.10 query13 0.590.590.58 query14 0.760.790.78 query15 0.820.800.80 query16 0.330.330.34 query17 0.910.920.87 query18 0.160.190.15 query19 1.731.631.65 query20 0.010.020.02 query21 15.39 0.650.61 query22 2.893.203.66 query23 17.49 1.080.96 query24 2.160.360.17 query25 0.530.070.05 query26 0.150.140.13 query27 0.070.050.05 query28 12.37 0.830.81 query29 12.52 3.373.38 query30 0.530.500.48 query31 2.780.350.36 query32 3.380.470.48 query33 3.133.133.17 query34 15.36 4.504.52 query35 4.504.504.46 query36 1.070.940.95 query37 0.070.050.05 query38 0.040.030.03 query39 0.020.020.01 query40 0.170.140.14 query41 0.070.020.01 query42 0.020.020.01 query43 0.030.020.02 Total cold run time: 105.2 s Total hot run time: 31.52 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](rpc) test thrift rpc fail [doris]
zclllyybb commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962427313 run p1 50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](rpc) test thrift rpc fail [doris]
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962427358 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 2e94ac940d495d68bab1ad30c5fcf5531374b493 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 16.7 seconds inserted 1000 Rows, about 598K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch asf-site updated: Automated deployment with doris branch @ b6c38b73962a6d14baa807bccd20d3bdbbf540f5
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new a0dcb27a6fb Automated deployment with doris branch @
b6c38b73962a6d14baa807bccd20d3bdbbf540f5
a0dcb27a6fb is described below
commit a0dcb27a6fbe393f9c824adc891097f4eebdb489
Author: github-actions[bot]
AuthorDate: Sun Feb 25 01:45:36 2024 +
Automated deployment with doris branch @
b6c38b73962a6d14baa807bccd20d3bdbbf540f5
---
docs/1.2/search-index.json | 2 +-
docs/dev/search-index.json | 2 +-
search-index.json| 2 +-
zh-CN/docs/1.2/search-index.json | 2 +-
zh-CN/docs/dev/search-index.json | 2 +-
zh-CN/search-index.json | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/1.2/search-index.json b/docs/1.2/search-index.json
index d1b281bc2a4..292babfed9c 100644
--- a/docs/1.2/search-index.json
+++ b/docs/1.2/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":21358,"t":"Elastic
scaling","u":"/docs/1.2/admin-manual/cluster-management/elastic-expansion","b":["Admin
Manual","cluster management"]},{"i":21374,"t":"TLS
certificate","u":"/docs/1.2/admin-manual/certificate","b":["Admin
Manual"]},{"i":21379,"t":"Cluster
upgrade","u":"/docs/1.2/admin-manual/cluster-management/upgrade","b":["Admin
Manual","cluster management"]},{"i":21393,"t":"BE
Configuration","u":"/docs/1.2/admin-manual/config/be-config","b":["Admin
Manual","Config [...]
\ No newline at end of file
+[{"documents":[{"i":21358,"t":"Elastic
scaling","u":"/docs/1.2/admin-manual/cluster-management/elastic-expansion","b":["Admin
Manual","cluster management"]},{"i":21374,"t":"TLS
certificate","u":"/docs/1.2/admin-manual/certificate","b":["Admin
Manual"]},{"i":21379,"t":"FQDN","u":"/docs/1.2/admin-manual/cluster-management/fqdn","b":["Admin
Manual","cluster management"]},{"i":21391,"t":"Cluster
upgrade","u":"/docs/1.2/admin-manual/cluster-management/upgrade","b":["Admin
Manual","cluster man [...]
\ No newline at end of file
diff --git a/docs/dev/search-index.json b/docs/dev/search-index.json
index 26d5dcfabfb..fec5a1f88cb 100644
--- a/docs/dev/search-index.json
+++ b/docs/dev/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":1,"t":"TLS
certificate","u":"/docs/dev/admin-manual/certificate","b":["Admin
Manual"]},{"i":6,"t":"Elastic
scaling","u":"/docs/dev/admin-manual/cluster-management/elastic-expansion","b":["Admin
Manual","cluster
management"]},{"i":22,"t":"FQDN","u":"/docs/dev/admin-manual/cluster-management/fqdn","b":["Admin
Manual","cluster management"]},{"i":37,"t":"Cluster
upgrade","u":"/docs/dev/admin-manual/cluster-management/upgrade","b":["Admin
Manual","cluster management"]},{"i [...]
\ No newline at end of file
+[{"documents":[{"i":1,"t":"FQDN","u":"/docs/dev/admin-manual/cluster-management/fqdn","b":["Admin
Manual","cluster management"]},{"i":16,"t":"TLS
certificate","u":"/docs/dev/admin-manual/certificate","b":["Admin
Manual"]},{"i":21,"t":"Elastic
scaling","u":"/docs/dev/admin-manual/cluster-management/elastic-expansion","b":["Admin
Manual","cluster management"]},{"i":37,"t":"load
balancing","u":"/docs/dev/admin-manual/cluster-management/load-balancing","b":["Admin
Manual","cluster management [...]
\ No newline at end of file
diff --git a/search-index.json b/search-index.json
index 5e5954f12dd..c158533b330 100644
--- a/search-index.json
+++ b/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":10744,"t":"Doris Storage File Format
Optimization","u":"/community/design/doris_storage_optimization","b":["Design
Documents"]},{"i":10770,"t":"Metadata Design
Document","u":"/community/design/metadata-design","b":["Design
Documents"]},{"i":10786,"t":"GROUPING SETS
DESIGN","u":"/community/design/grouping_sets_design","b":["Design
Documents"]},{"i":10816,"t":"Development and Debugging of Apache Doris BE --
Clion","u":"/community/developer-guide/be-clion-dev","b":["Deve [...]
\ No newline at end of file
+[{"documents":[{"i":10744,"t":"Doris Storage File Format
Optimization","u":"/community/design/doris_storage_optimization","b":["Design
Documents"]},{"i":10770,"t":"Metadata Design
Document","u":"/community/design/metadata-design","b":["Design
Documents"]},{"i":10786,"t":"Spark
Load","u":"/community/design/spark_load","b":["Design
Documents"]},{"i":10799,"t":"GROUPING SETS
DESIGN","u":"/community/design/grouping_sets_design","b":["Design
Documents"]},{"i":10829,"t":"Development and Debugg [...]
\ No newline at end of file
diff --git a/zh-CN/docs/1.2/search-index.json b/zh-CN/docs/1.2/search-index.json
index f9aa0735c72..ec22157d7e9 100644
--- a/zh-CN/docs/1.2/search-index.json
+++ b/zh-CN/docs/1.2/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":51210,"t":"SSL密钥证书配置","u":"/zh-CN/docs/1.2/admin-manual/certificate","b":["管理手册"]},{"i":51214,"t":"弹性扩缩容","u":"/zh-CN/docs/1.2/admin-ma
Re: [PR] [Feature] Support to do schema change in cloud mode [doris]
dataroaring commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962785082 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](parquet) Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]
dataroaring merged PR #31375: URL: https://github.com/apache/doris/pull/31375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](parquet) Fix possible memory leak if ParquetReader::parse_thrift_footer failed (#31375)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 41f88ee18a7 [fix](parquet) Fix possible memory leak if
ParquetReader::parse_thrift_footer failed (#31375)
41f88ee18a7 is described below
commit 41f88ee18a7f9c7903c85092a1c91e44816aa55e
Author: Gavin Chou
AuthorDate: Sun Feb 25 10:04:35 2024 +0800
[fix](parquet) Fix possible memory leak if
ParquetReader::parse_thrift_footer failed (#31375)
---
be/src/vec/exec/format/parquet/vparquet_reader.cpp | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/be/src/vec/exec/format/parquet/vparquet_reader.cpp
b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
index dd8d01f4bb1..250604e218f 100644
--- a/be/src/vec/exec/format/parquet/vparquet_reader.cpp
+++ b/be/src/vec/exec/format/parquet/vparquet_reader.cpp
@@ -246,11 +246,10 @@ Status ParquetReader::_open_file() {
}
size_t meta_size = 0;
if (_meta_cache == nullptr) {
-RETURN_IF_ERROR(
-parse_thrift_footer(_file_reader, &_file_metadata,
&meta_size, _io_ctx));
+auto st = parse_thrift_footer(_file_reader, &_file_metadata,
&meta_size, _io_ctx);
// wrap it with unique ptr, so that it can be released finally.
_file_metadata_ptr.reset(_file_metadata);
-_file_metadata = _file_metadata_ptr.get();
+RETURN_IF_ERROR(st);
_column_statistics.read_bytes += meta_size;
// parse magic number & parse meta data
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature] Support to do schema change in cloud mode [doris]
doris-robot commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962793223 TPC-H: Total hot run time: 41455 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 4c39df9bc6dab64b7fb1910d6f85b4de075672c3, data reload: false -- Round 1 -- q1 17668 503249184918 q2 2068147 144 144 q3 10623 101810031003 q4 4740100910091009 q5 7677312632193126 q6 203 142 145 142 q7 1275793 792 792 q8 9370208720762076 q9 7488661766066606 q10 8338265326682653 q11 415 211 230 211 q12 797 345 343 343 q13 17942 360836343608 q14 302 260 258 258 q15 601 515 509 509 q16 480 415 423 415 q17 938 878 839 839 q18 7535671766556655 q19 1566152415031503 q20 560 285 293 285 q21 6832403240104010 q22 894 362 350 350 Total cold run time: 108312 ms Total hot run time: 41455 ms - Round 2, with runtime_filter_mode=off - q1 4927488148744874 q2 302 189 194 189 q3 3637361336283613 q4 2552252725472527 q5 5793578557815781 q6 218 133 134 133 q7 2286168216771677 q8 3060316831503150 q9 8757874487128712 q10 6876425542494249 q11 511 398 385 385 q12 788 559 553 553 q13 4349343034083408 q14 280 237 228 228 q15 663 550 513 513 q16 482 467 451 451 q17 1738163016321630 q18 8326767475547554 q19 1652165016611650 q20 2144184618511846 q21 6676630662826282 q22 584 525 531 525 Total cold run time: 66601 ms Total hot run time: 59930 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
