ZhongJinHacker opened a new issue, #31370:
URL: https://github.com/apache/doris/issues/31370

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Version
   
   in master branch
   
   ### What's Wrong?
   
   In the fe project, many place use the Pair.java in fe-common module. And I 
found this case in the code project.
   <img width="933" alt="image" 
src="https://github.com/apache/doris/assets/15382560/bd03991e-01e3-4da8-8735-617a1550dd30";>
   
   Developers usually input a null value into Pair object, but the Pair.java 
not support null value with its first and second member correctly.
   
   When a Pair object with null value, i would cause the NullPointException by 
calling its toString method or equals method.
   (I repeated this case by my unit test)
   
   It is very dangerous. 
   And I have fixed it in my forked project. Please assign this issue to me , 
and then I will pr my commit soon.
   
   Thank you very much
   
   ### What You Expected?
   
   Please assign this issue to me , and then I will pr my commit soon.
   
   ### How to Reproduce?
   
    Pair<String, Object> firstPair = Pair.of(null, "world");
   firstPair.toString();
   
   it will cause NullPointException
   
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to