[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

2022-03-28 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added a comment.

Yes, I believe the issue with the circular dependency was already fixed by my 
latest commit. Sorry for first committing the wrong fix (just removing the 
headers without checking that they were needed to pull in raw_ostream header 
transitively).
So if you apply my fix, you should be able to land this again (or just revert 
the revert).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121984/new/

https://reviews.llvm.org/D121984

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124995: [clang] Add static_cast to fix Bazel build.

2022-05-05 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel created this revision.
Herald added a project: All.
akuegel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124995

Files:
  clang/lib/ExtractAPI/ExtractAPIConsumer.cpp


Index: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
===
--- clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
+++ clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
@@ -927,7 +927,8 @@
 HeaderContents += "\"\n";
   else
 HeaderContents += ">\n";
-  KnownInputFiles.emplace_back(*RelativeName, IsQuoted);
+  KnownInputFiles.emplace_back(static_cast>(*RelativeName),
+   IsQuoted);
 } else {
   HeaderContents += " \"";
   HeaderContents += FilePath;


Index: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
===
--- clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
+++ clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
@@ -927,7 +927,8 @@
 HeaderContents += "\"\n";
   else
 HeaderContents += ">\n";
-  KnownInputFiles.emplace_back(*RelativeName, IsQuoted);
+  KnownInputFiles.emplace_back(static_cast>(*RelativeName),
+   IsQuoted);
 } else {
   HeaderContents += " \"";
   HeaderContents += FilePath;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124995: [clang] Add static_cast to fix Bazel build.

2022-05-05 Thread Adrian Kuegel via Phabricator via cfe-commits 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcc344d262a2e: [clang] Add static_cast to fix Bazel build. 
(authored by akuegel).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124995/new/

https://reviews.llvm.org/D124995

Files:
  clang/lib/ExtractAPI/ExtractAPIConsumer.cpp


Index: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
===
--- clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
+++ clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
@@ -927,7 +927,8 @@
 HeaderContents += "\"\n";
   else
 HeaderContents += ">\n";
-  KnownInputFiles.emplace_back(*RelativeName, IsQuoted);
+  KnownInputFiles.emplace_back(static_cast>(*RelativeName),
+   IsQuoted);
 } else {
   HeaderContents += " \"";
   HeaderContents += FilePath;


Index: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
===
--- clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
+++ clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
@@ -927,7 +927,8 @@
 HeaderContents += "\"\n";
   else
 HeaderContents += ">\n";
-  KnownInputFiles.emplace_back(*RelativeName, IsQuoted);
+  KnownInputFiles.emplace_back(static_cast>(*RelativeName),
+   IsQuoted);
 } else {
   HeaderContents += " \"";
   HeaderContents += FilePath;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D107760: [lldb] Fix warning -Wnon-virtual-dtor.

2021-08-09 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel created this revision.
akuegel added a reviewer: bkramer.
akuegel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

When making the emit function virtual, the destructor needs to become
virtual as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107760

Files:
  clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp


Index: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
===
--- clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
+++ clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
@@ -238,6 +238,7 @@
 public:
   OpenCLBuiltinFileEmitterBase(RecordKeeper &Records, raw_ostream &OS)
   : Records(Records), OS(OS) {}
+  virtual ~OpenCLBuiltinFileEmitterBase() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.
@@ -307,6 +308,7 @@
 public:
   OpenCLBuiltinTestEmitter(RecordKeeper &Records, raw_ostream &OS)
   : OpenCLBuiltinFileEmitterBase(Records, OS) {}
+  virtual ~OpenCLBuiltinTestEmitter() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.


Index: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
===
--- clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
+++ clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
@@ -238,6 +238,7 @@
 public:
   OpenCLBuiltinFileEmitterBase(RecordKeeper &Records, raw_ostream &OS)
   : Records(Records), OS(OS) {}
+  virtual ~OpenCLBuiltinFileEmitterBase() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.
@@ -307,6 +308,7 @@
 public:
   OpenCLBuiltinTestEmitter(RecordKeeper &Records, raw_ostream &OS)
   : OpenCLBuiltinFileEmitterBase(Records, OS) {}
+  virtual ~OpenCLBuiltinTestEmitter() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

2021-08-09 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added a comment.

Already landed as 
https://github.com/llvm/llvm-project/commit/19bd806a1a443e4ce45ccc670861848fb1579022,
 I will close this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107760/new/

https://reviews.llvm.org/D107760

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

2021-08-12 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added a comment.

It seems this patch caused a test failure in MLIR:
test/Target/LLVMIR/llvm-intrinsics.mlir


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107349/new/

https://reviews.llvm.org/D107349

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

2021-11-09 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added inline comments.



Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:381
+ (IsNolintBegin ? "END" : "BEGIN") + "' comment";
+  Error.Message = tooling::DiagnosticMessage(Message.str(), SM, Loc);
   return Error;

tooling::DiagnosticMessage expects a StringRef. If you pass it a str() from a 
local string, this can lead to bad pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113472/new/

https://reviews.llvm.org/D113472

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51650: Implement target_clones multiversioning

2021-11-12 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added a comment.

Since it is not clear whether the semantic change was intended, I think it 
makes sense to revert the patch for now. If it is intended, it might be good to 
mention it in the change description, so that people are warned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51650/new/

https://reviews.llvm.org/D51650

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

2022-11-17 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added a comment.

This introduced a dependency cycle:

.-> @llvm-project//llvm:Analysis 
(2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767)

| @llvm-project//llvm:ProfileData 
(2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767) |
| @llvm-project//llvm:Symbolize 
(2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767)   |
| @llvm-project//llvm:Object 
(2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767)  |
| @llvm-project//llvm:IRPrinter 
(2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767)   |
|

`-- @llvm-project//llvm:Analysis 
(2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137768/new/

https://reviews.llvm.org/D137768

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

2022-11-17 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added a comment.

Fixed it in https://reviews.llvm.org/D138266


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137768/new/

https://reviews.llvm.org/D137768

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

2022-06-13 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added a comment.

It seems this change triggers a warning:

https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1

llvm-project/llvm/lib/Transforms/Utils/CodeExtractor.cpp:901:15: error: 
enumeration value 'PresplitCoroutine' not handled in switch [-Werror,-Wswitch]

  switch (Attr.getKindAsEnum()) {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127471/new/

https://reviews.llvm.org/D127471

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76272: Fix memtag test.

2020-03-17 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
akuegel added a reviewer: bkramer.
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.

Right, we don't have names for values in release builds.


Matching %x makes the test fail.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76272

Files:
  clang/test/Driver/memtag.c


Index: clang/test/Driver/memtag.c
===
--- clang/test/Driver/memtag.c
+++ clang/test/Driver/memtag.c
@@ -17,7 +17,7 @@
 int foo() { int x; use(&x); return x; }
 
 // CHECK-NO-SAFETY: define dso_local i32 @foo()
-// CHECK-NO-SAFETY: %x = alloca i32, align 4{{$}}
+// CHECK-NO-SAFETY: %{{.*}} = alloca i32, align 4{{$}}
 
 // CHECK-SAFETY: define dso_local i32 @foo()
-// CHECK-SAFETY: %x = alloca i32, align 4, !stack-safe
+// CHECK-SAFETY: %{{.*}} = alloca i32, align 4, !stack-safe


Index: clang/test/Driver/memtag.c
===
--- clang/test/Driver/memtag.c
+++ clang/test/Driver/memtag.c
@@ -17,7 +17,7 @@
 int foo() { int x; use(&x); return x; }
 
 // CHECK-NO-SAFETY: define dso_local i32 @foo()
-// CHECK-NO-SAFETY: %x = alloca i32, align 4{{$}}
+// CHECK-NO-SAFETY: %{{.*}} = alloca i32, align 4{{$}}
 
 // CHECK-SAFETY: define dso_local i32 @foo()
-// CHECK-SAFETY: %x = alloca i32, align 4, !stack-safe
+// CHECK-SAFETY: %{{.*}} = alloca i32, align 4, !stack-safe
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76272: Fix memtag test.

2020-03-17 Thread Adrian Kuegel via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5156e38eb1d3: Fix memtag test. (authored by akuegel).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76272/new/

https://reviews.llvm.org/D76272

Files:
  clang/test/Driver/memtag.c


Index: clang/test/Driver/memtag.c
===
--- clang/test/Driver/memtag.c
+++ clang/test/Driver/memtag.c
@@ -17,7 +17,7 @@
 int foo() { int x; use(&x); return x; }
 
 // CHECK-NO-SAFETY: define dso_local i32 @foo()
-// CHECK-NO-SAFETY: %x = alloca i32, align 4{{$}}
+// CHECK-NO-SAFETY: %{{.*}} = alloca i32, align 4{{$}}
 
 // CHECK-SAFETY: define dso_local i32 @foo()
-// CHECK-SAFETY: %x = alloca i32, align 4, !stack-safe
+// CHECK-SAFETY: %{{.*}} = alloca i32, align 4, !stack-safe


Index: clang/test/Driver/memtag.c
===
--- clang/test/Driver/memtag.c
+++ clang/test/Driver/memtag.c
@@ -17,7 +17,7 @@
 int foo() { int x; use(&x); return x; }
 
 // CHECK-NO-SAFETY: define dso_local i32 @foo()
-// CHECK-NO-SAFETY: %x = alloca i32, align 4{{$}}
+// CHECK-NO-SAFETY: %{{.*}} = alloca i32, align 4{{$}}
 
 // CHECK-SAFETY: define dso_local i32 @foo()
-// CHECK-SAFETY: %x = alloca i32, align 4, !stack-safe
+// CHECK-SAFETY: %{{.*}} = alloca i32, align 4, !stack-safe
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

2021-10-18 Thread Adrian Kuegel via Phabricator via cfe-commits 
akuegel added inline comments.



Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:15
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Option/ArgList.h"
+#include "llvm/Support/Error.h"

Would it be possible to avoid the usage of ArgList in a target that belongs to 
Support?
This introduces a dependency cycle, since Option already depends on Support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits