from:"Carl Schwan"

D16721: Use Krita toolbar in Karbon

2018-11-06 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  I copied all KoToolBox* file and KissKineticScroller (renamed to 
KoKineticScroller) from Krita repo.

TEST PLAN
  Compile and run

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-06 Thread Carl Schwan

ognarb edited the summary of this revision.
ognarb added reviewers: Krita, Calligra: 3.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-06 Thread Carl Schwan

ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb updated this revision to Diff 45016.
ognarb marked an inline comment as done.
ognarb added a comment.


  Revert some change more to come

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=44995&id=45016

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb updated this revision to Diff 45018.
ognarb added a comment.


  Rever foreach

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45016&id=45018

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb updated this revision to Diff 45020.
ognarb added a comment.


  Revert foreach and remove whitespace

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45018&id=45020

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb updated this revision to Diff 45021.
ognarb added a comment.


  Revert more change

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45020&id=45021

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb updated this revision to Diff 45031.
ognarb marked 3 inline comments as done.
ognarb added a comment.


  Fix some indentation problem

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45021&id=45031

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb added a comment.


  In D16721#355367 , @anthonyfieroni 
wrote:
  
  > > I'm adding Krita as reviewer, because Karbon is unmaintained and I hope 
someone at Krita as some experience with the toolbox
  >
  > I'm the maintainer of Karbon, for now.
  
  
  Good to know :D
  
  > Please revert foreach -> Q_FOREACH changes, it should be done in separate 
patch. Clean dead / commented code, white-space changes, don't remove QObject 
macro, unless you have a good reason for that. Override is good feature but in 
separate patch for old code, for new one it's good.
  
  I reverted all the 'cosmetic' change. I just have a problem with  the 
Q_OBJECT macro in KoToolBoxLayout_p.h. If I try to add the Q_OBJECT macro I 
have then a linking error. I tried to search when this Q_OBJECT were added and 
I found this commit: R8:703df9162bab8db8a168cca6e4dfec27b8347095 

  
  > Back-porting patches from Krita are welcome but in accepted condition to 
other part of the project.

INLINE COMMENTS

> anthonyfieroni wrote in KoToolBoxDocker.cpp:39
> Why empty or white-space label?

No idea was already like this in the original krita file.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb updated this revision to Diff 45082.
ognarb marked 8 inline comments as done.
ognarb added a comment.


  Remove bad code

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45031&id=45082

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb updated this revision to Diff 45085.
ognarb added a comment.


  Removing useless arg

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45082&id=45085

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.cpp
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-07 Thread Carl Schwan

ognarb marked 3 inline comments as done.
ognarb added a comment.

  In D16721#355600 , @anthonyfieroni 
wrote:

  > Return QObjects, if you have problems copy linker output here.

  `make clean` solved the issue

INLINE COMMENTS

> anthonyfieroni wrote in KoToolBoxDocker.cpp:39
> We should know what it is. It used a label instead of KoDockWidgetTitleBar 
> why? Can you revert KoDockWidgetTitleBar, remove this and see how it looks?

I found out that this QLabel is, it's the small draggable zone at the top of 
the docker. Actual it's still a bit buggy in krita and karbon F6397172: 
krita_toolbar_to.png . I should fix this 
before commiting. :D

Edit: It's not a bug, it's a feature :D If I try to center the label, it's look 
a lot less good looking then not zooming on it. I added a small comment for 
future reference. :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Carl Schwan

ognarb marked 2 inline comments as done.
ognarb added a comment.


  About the config for the KoKineticScroller. Do you perhaps know where to find 
the .kcfg file from calligra?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Carl Schwan

ognarb added a comment.


  In D16721#356162 , @anthonyfieroni 
wrote:
  
  > Config, if it's not set explicitly,  + "rc" 
https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607
  
  
  So I propose I add in a later diff the same config windows as in krita. 
F6397990: krita_kine.png 

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-08 Thread Carl Schwan

ognarb updated this revision to Diff 45113.
ognarb added a comment.


  Revert a bit more

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45085&id=45113

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

ognarb updated this revision to Diff 45169.
ognarb marked 9 inline comments as done.
ognarb added a comment.


  Apply change according to review

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45113&id=45169

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

ognarb added a comment.

  In D16721#356595 , @anthonyfieroni 
wrote:

  > Can you test my suggestions, it's looks good to me.

  Yes work also for me :)

  About the title bar for the dock, I'm not a fan of KoDockWidgetTitleBar for 
the tool bar. Because most of the time the tool bar is too slim to have a 
draggable zone and you can't drag it like the other toolbar. So you need to 
click on the button and then drag it.

INLINE COMMENTS

> anthonyfieroni wrote in KoToolBoxDocker.cpp:39
> Please remove label and return KoDockWidgetTitleBar it looks better.

F6402717: karbon_kotoolbarheader.png  My 
problem with this is that the bar is too slim and you can drag it around by 
dragging the title bar because you can only click on the button

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

ognarb updated this revision to Diff 45173.
ognarb marked 5 inline comments as done.
ognarb added a comment.


  Fix

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45169&id=45173

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

ognarb added a comment.


  In D16721#356755 , @anthonyfieroni 
wrote:
  
  > Can you add screenshots of horizontal and vertical version, add it to test, 
just to have how it looks. I see some gestures that i cannot test, did you can, 
touchscreen, tablet or something that this code works :)
  
  
  I did some testing with my drawing tablet at home and it's working. I also 
have a touchscreen on my laptop but I was never able to get it working with qt 
apps.

INLINE COMMENTS

> anthonyfieroni wrote in KoToolBoxLayout_p.h:221-228
> Try this code
> 
>   const QSize minSize = minimumSize();
>   if (!minSize.isValid()) {
>   return minSize;
>   }
>   if (m_orientation == Qt::Vertical) {
>   return QSize(minSize.width(), minSize.height() * 2 + spacing());
>   } else {
>   return QSize(minSize.height() * 2 + spacing(), minSize.width());
>   }

Changed to just one row/column per default, because Karbon doesn't have for the 
moment a lot of tools :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #krita, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

ognarb removed a reviewer: Krita.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #calligra:_3.0, #krita
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

ognarb updated this revision to Diff 45181.
ognarb marked an inline comment as done.
ognarb added a comment.


  Remove all whitespace

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45173&id=45181

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #calligra:_3.0, anthonyfieroni
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:a7ee6f871af2: Use Krita toolbar in Karbon (authored by 
ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16721?vs=45181&id=45182

REVISION DETAIL
  https://phabricator.kde.org/D16721

AFFECTED FILES
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxButton_p.h
  libs/widgets/KoToolBoxDocker.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBoxScrollArea_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgetutils/CMakeLists.txt
  libs/widgetutils/KoKineticScroller.cpp
  libs/widgetutils/KoKineticScroller.h

To: ognarb, #calligra:_3.0, anthonyfieroni
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

2018-11-09 Thread Carl Schwan

ognarb added a comment.


  In D16721#356813 , @anthonyfieroni 
wrote:
  
  > Please, remove all white space changes before commit. It will be better if 
you test the patch some time without crash or other downsides. If you notice 
something wrong write here. If all is good you can commit in few days. Thank 
you for patch, other patches are welcome.
  
  
  Sorry, I just landed the commit without reading entirely your message, I just 
saw the comment about fixing the white space problem and not the one about 
waiting a few days. If I see a problem in the next days I will open a new 
revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16721

To: ognarb, #calligra:_3.0, anthonyfieroni
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16784: Remove whitespace created by D16721

2018-11-09 Thread Carl Schwan

ognarb created this revision.
ognarb added a reviewer: anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  :(

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16784

AFFECTED FILES
  libs/widgets/KoToolBoxLayout_p.h

To: ognarb, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16784: Remove whitespace created by D16721

2018-11-09 Thread Carl Schwan

ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D16784

To: ognarb, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-12 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  Use less vertical space, don't change anything in vertical Mode

TEST PLAN
  Compile, run, no bug found yet :D.
  
  Note: I wasn't able to run calligra with master (crash at startup) so this 
work isn't tested with master and only the calligra/3.1 branch

REPOSITORY
  R8 Calligra

BRANCH
  calligra/3.1

REVISION DETAIL
  https://phabricator.kde.org/D18963

AFFECTED FILES
  libs/widgets/KoModeBox.cpp

To: ognarb
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-12 Thread Carl Schwan

ognarb edited the summary of this revision.
ognarb added reviewers: Calligra: 3.0, VDG.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-12 Thread Carl Schwan

ognarb updated this revision to Diff 51523.
ognarb added a comment.


  Remove debug output

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18963?vs=51522&id=51523

BRANCH
  calligra/3.1

REVISION DETAIL
  https://phabricator.kde.org/D18963

AFFECTED FILES
  libs/widgets/KoModeBox.cpp

To: ognarb, #calligra:_3.0, #vdg
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-12 Thread Carl Schwan

ognarb added a comment.


  Ok thanks for the review, I will retry to compile calligra master and see if 
it's still work and then land this diff. 😄

REPOSITORY
  R8 Calligra

BRANCH
  calligra/3.1

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, 
cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-13 Thread Carl Schwan

ognarb updated this revision to Diff 51589.
ognarb added a comment.


  remove trailing whitespace

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18963?vs=51523&id=51589

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18963

AFFECTED FILES
  libs/widgets/KoModeBox.cpp

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, 
dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-13 Thread Carl Schwan

ognarb updated this revision to Diff 51594.
ognarb added a comment.


  remove more trailing whitespace

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18963?vs=51589&id=51594

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18963

AFFECTED FILES
  libs/widgets/KoModeBox.cpp

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, 
dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-13 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:ede08705548e: Improve KoModeBox display in horizontal Mode 
(authored by ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18963?vs=51594&id=51596

REVISION DETAIL
  https://phabricator.kde.org/D18963

AFFECTED FILES
  libs/widgets/KoModeBox.cpp

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, 
dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

2019-02-13 Thread Carl Schwan

ognarb edited the test plan for this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, 
dcaliste, cochise, vandenoever

D18989: Remove minor duplicate code and fix related bug

2019-02-13 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  I forgot to change the icon size at one place in the last commit. Fix it and 
use a small function to avoid duplicate code and a similar bug in the futur.

REPOSITORY
  R8 Calligra

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D18989

AFFECTED FILES
  libs/widgets/KoModeBox.cpp
  libs/widgets/KoModeBox_p.h

To: ognarb
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18989: Remove minor duplicate code and fix related bug

2019-02-13 Thread Carl Schwan

ognarb added a reviewer: Calligra: 3.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18989

To: ognarb, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18989: Remove minor duplicate code and fix related bug

2019-02-13 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:791535d78da5: Remove minor duplicate code and fix related 
bug (authored by ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18989?vs=51624&id=51627

REVISION DETAIL
  https://phabricator.kde.org/D18989

AFFECTED FILES
  libs/widgets/KoModeBox.cpp
  libs/widgets/KoModeBox_p.h

To: ognarb, #calligra:_3.0, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18994: Update screenshots for Callibra 3.1

2019-02-13 Thread Carl Schwan

ognarb created this revision.
Herald added projects: Calligra: 3.0, Documentation.
Herald added subscribers: kde-doc-english, Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  Update screenshots for Callibra 3.1 also reflect change in a menu name. Only 
the hidecells screenshots aren't updated. I wasn't able to reproduce the steps.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18994

AFFECTED FILES
  doc/sheets/advanced.docbook
  doc/sheets/cellformat0.png
  doc/sheets/cellformat1.png
  doc/sheets/cellformat2.png
  doc/sheets/cellformat3.png
  doc/sheets/cellformat4.png
  doc/sheets/cellformat5.png
  doc/sheets/cellformat6.png
  doc/sheets/cellprotection1.png
  doc/sheets/cellprotection2.png
  doc/sheets/chart1.png
  doc/sheets/configure2.png
  doc/sheets/configure3.png
  doc/sheets/configure4.png
  doc/sheets/configure5.png
  doc/sheets/configure6.png
  doc/sheets/copy1.png
  doc/sheets/index.docbook
  doc/sheets/newdocument.png
  doc/sheets/pivot2.png
  doc/sheets/pivot3.png
  doc/sheets/pivot4.png
  doc/sheets/sheetproperties.png
  doc/sheets/shortcut1.png
  doc/sheets/sort1.png
  doc/sheets/starting1.png

To: ognarb
Cc: Calligra-Devel-list, kde-doc-english, gennad, dcaliste, skadinna, cochise, 
vandenoever

D18994: Update screenshots for Callibra 3.1

2019-02-13 Thread Carl Schwan

ognarb added reviewers: Calligra: 3.0, Documentation.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18994

To: ognarb, #calligra:_3.0, #documentation
Cc: Calligra-Devel-list, kde-doc-english, gennad, dcaliste, skadinna, cochise, 
vandenoever

D18994: Update screenshots for Callibra 3.1

2019-02-13 Thread Carl Schwan

ognarb updated this revision to Diff 51639.
ognarb added a comment.


  Now compile with checkXML5

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18994?vs=51638&id=51639

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18994

AFFECTED FILES
  doc/sheets/advanced.docbook
  doc/sheets/cellformat0.png
  doc/sheets/cellformat1.png
  doc/sheets/cellformat2.png
  doc/sheets/cellformat3.png
  doc/sheets/cellformat4.png
  doc/sheets/cellformat5.png
  doc/sheets/cellformat6.png
  doc/sheets/cellprotection1.png
  doc/sheets/cellprotection2.png
  doc/sheets/chart1.png
  doc/sheets/configure2.png
  doc/sheets/configure3.png
  doc/sheets/configure4.png
  doc/sheets/configure5.png
  doc/sheets/configure6.png
  doc/sheets/copy1.png
  doc/sheets/index.docbook
  doc/sheets/newdocument.png
  doc/sheets/pivot2.png
  doc/sheets/pivot3.png
  doc/sheets/pivot4.png
  doc/sheets/sheetproperties.png
  doc/sheets/shortcut1.png
  doc/sheets/sort1.png
  doc/sheets/starting1.png

To: ognarb, #calligra:_3.0, #documentation
Cc: Calligra-Devel-list, kde-doc-english, gennad, dcaliste, skadinna, cochise, 
vandenoever

D18994: Update screenshots for Callibra 3.1

2019-02-13 Thread Carl Schwan

ognarb edited the test plan for this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18994

To: ognarb, #calligra:_3.0, #documentation
Cc: Calligra-Devel-list, kde-doc-english, gennad, dcaliste, skadinna, cochise, 
vandenoever

D18994: Update screenshots for Callibra sheets 3.1

2019-02-14 Thread Carl Schwan

ognarb retitled this revision from "Update screenshots for Callibra 3.1" to 
"Update screenshots for Callibra sheets 3.1".
ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18994

To: ognarb, #calligra:_3.0, #documentation
Cc: Calligra-Devel-list, kde-doc-english, gennad, dcaliste, skadinna, cochise, 
vandenoever

D18994: Update screenshots for Calligra sheets 3.1

2019-02-14 Thread Carl Schwan

ognarb retitled this revision from "Update screenshots for Callibra sheets 3.1" 
to "Update screenshots for Calligra sheets 3.1".
ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18994

To: ognarb, #calligra:_3.0, #documentation, yurchor
Cc: yurchor, leinir, Calligra-Devel-list, kde-doc-english, gennad, dcaliste, 
skadinna, cochise, vandenoever

D18994: Update screenshots for Calligra sheets 3.1

2019-02-14 Thread Carl Schwan

ognarb added a comment.


  In D18994#412049 , @leinir wrote:
  
  > A quick note that you kind of got the name of the suite wrong in a few 
places, it's called Calligra, not Callibra :)
  
  
  Sorry, I think I mixed up calligra and calibre.  :)

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18994

To: ognarb, #calligra:_3.0, #documentation, yurchor
Cc: yurchor, leinir, Calligra-Devel-list, kde-doc-english, gennad, dcaliste, 
skadinna, cochise, vandenoever

D18994: Update screenshots for Calligra sheets 3.1

2019-02-14 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:8c076253c674: Update screenshots for Calligra sheets 3.1 
(authored by ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18994?vs=51639&id=51707

REVISION DETAIL
  https://phabricator.kde.org/D18994

AFFECTED FILES
  doc/sheets/advanced.docbook
  doc/sheets/cellformat0.png
  doc/sheets/cellformat1.png
  doc/sheets/cellformat2.png
  doc/sheets/cellformat3.png
  doc/sheets/cellformat4.png
  doc/sheets/cellformat5.png
  doc/sheets/cellformat6.png
  doc/sheets/cellprotection1.png
  doc/sheets/cellprotection2.png
  doc/sheets/chart1.png
  doc/sheets/configure2.png
  doc/sheets/configure3.png
  doc/sheets/configure4.png
  doc/sheets/configure5.png
  doc/sheets/configure6.png
  doc/sheets/copy1.png
  doc/sheets/index.docbook
  doc/sheets/newdocument.png
  doc/sheets/pivot2.png
  doc/sheets/pivot3.png
  doc/sheets/pivot4.png
  doc/sheets/sheetproperties.png
  doc/sheets/shortcut1.png
  doc/sheets/sort1.png
  doc/sheets/starting1.png

To: ognarb, #calligra:_3.0, #documentation, yurchor
Cc: yurchor, leinir, Calligra-Devel-list, kde-doc-english, gennad, dcaliste, 
skadinna, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-18 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  Use clang-tidy to:
  
  - Use default wenn possible for constructor and destructor
  - Use nullptr instead of 0 or NULL
  - Use for (type &element : list) when already using std iterator (.begin() 
.end() )
  
  if this patch is acepted, if will do the same for the entire calligra 
codebase.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

AFFECTED FILES
  CMakeLists.txt
  libs/widgets/KoAspectButton.h
  libs/widgets/KoColorPatch.h
  libs/widgets/KoColorPopupAction.h
  libs/widgets/KoColorPopupButton.cpp
  libs/widgets/KoColorPopupButton.h
  libs/widgets/KoColorSetWidget.h
  libs/widgets/KoColorSlider.cpp
  libs/widgets/KoColorSlider.h
  libs/widgets/KoConfigAuthorPage.h
  libs/widgets/KoContextBarButton.cpp
  libs/widgets/KoContextBarButton.h
  libs/widgets/KoCsvImportDialog.h
  libs/widgets/KoDialog.h
  libs/widgets/KoDialog_p.h
  libs/widgets/KoDockWidgetTitleBar.cpp
  libs/widgets/KoDockWidgetTitleBar.h
  libs/widgets/KoDockWidgetTitleBarButton.h
  libs/widgets/KoDocumentInfoDlg.cpp
  libs/widgets/KoDocumentInfoDlg.h
  libs/widgets/KoDocumentInfoPropsPage.cpp
  libs/widgets/KoDocumentInfoPropsPage.h
  libs/widgets/KoDpi.cpp
  libs/widgets/KoDpi.h
  libs/widgets/KoDualColorButton.h
  libs/widgets/KoEditColorSetDialog.cpp
  libs/widgets/KoEditColorSetDialog.h
  libs/widgets/KoFillConfigWidget.cpp
  libs/widgets/KoFillConfigWidget.h
  libs/widgets/KoGenericRegistryModel.h
  libs/widgets/KoGlobal.cpp
  libs/widgets/KoGradientEditWidget.cpp
  libs/widgets/KoGradientEditWidget.h
  libs/widgets/KoIconToolTip.h
  libs/widgets/KoItemToolTip.h
  libs/widgets/KoLineStyleItemDelegate_p.h
  libs/widgets/KoLineStyleModel_p.h
  libs/widgets/KoLineStyleSelector.h
  libs/widgets/KoMarkerItemDelegate.cpp
  libs/widgets/KoMarkerItemDelegate.h
  libs/widgets/KoMarkerModel.cpp
  libs/widgets/KoMarkerModel.h
  libs/widgets/KoMarkerSelector.cpp
  libs/widgets/KoMarkerSelector.h
  libs/widgets/KoModeBoxDocker.cpp
  libs/widgets/KoModeBoxDocker_p.h
  libs/widgets/KoModeBoxFactory.h
  libs/widgets/KoModeBox_p.h
  libs/widgets/KoPageLayoutWidget.h
  libs/widgets/KoPagePreviewWidget.h
  libs/widgets/KoPageWidgetItem.h
  libs/widgets/KoPositionSelector.cpp
  libs/widgets/KoPositionSelector.h
  libs/widgets/KoResourceItemChooser.h
  libs/widgets/KoResourceItemChooserContextMenu.cpp
  libs/widgets/KoResourceItemChooserContextMenu.h
  libs/widgets/KoResourceItemChooserSync.cpp
  libs/widgets/KoResourceItemChooserSync.h
  libs/widgets/KoResourceItemDelegate.h
  libs/widgets/KoResourceItemView.h
  libs/widgets/KoResourceModel.h
  libs/widgets/KoResourceModelBase.h
  libs/widgets/KoResourcePaths.cpp
  libs/widgets/KoResourcePopupAction.cpp
  libs/widgets/KoResourcePopupAction.h
  libs/widgets/KoResourceSelector.h
  libs/widgets/KoResourceServer.h
  libs/widgets/KoResourceServerAdapter.cpp
  libs/widgets/KoResourceServerAdapter.h
  libs/widgets/KoResourceServerProvider.cpp
  libs/widgets/KoResourceServerProvider.h
  libs/widgets/KoResourceTaggingManager.h
  libs/widgets/KoRuler.h
  libs/widgets/KoRulerController_p.h
  libs/widgets/KoRuler_p.h
  libs/widgets/KoShadowConfigWidget.cpp
  libs/widgets/KoSliderCombo.cpp
  libs/widgets/KoSliderCombo.h
  libs/widgets/KoSliderCombo_p.h
  libs/widgets/KoStrokeConfigWidget.cpp
  libs/widgets/KoStrokeConfigWidget.h
  libs/widgets/KoTableView.h
  libs/widgets/KoTagChooserWidget.h
  libs/widgets/KoTagFilterWidget.h
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.cpp
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgets/KoToolDocker.cpp
  libs/widgets/KoToolDocker.h
  libs/widgets/KoTriangleColorSelector.h
  libs/widgets/KoUnitDoubleSpinBox.h
  libs/widgets/KoViewItemContextBar.cpp
  libs/widgets/KoViewItemContextBar.h
  libs/widgets/KoZoomAction.cpp
  libs/widgets/KoZoomAction.h
  libs/widgets/KoZoomController.h
  libs/widgets/KoZoomController_p.h
  libs/widgets/KoZoomHandler.cpp
  libs/widgets/KoZoomHandler.h
  libs/widgets/KoZoomInput.h
  libs/widgets/KoZoomMode.cpp
  libs/widgets/KoZoomWidget.cpp
  libs/widgets/KoZoomWidget.h

To: ognarb
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-18 Thread Carl Schwan

ognarb added a reviewer: Calligra: 3.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-18 Thread Carl Schwan

ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-19 Thread Carl Schwan

ognarb updated this revision to Diff 52119.
ognarb added a comment.


  - Revert foreach modifications
  - Fix some forgotten 0 as nullptr instances

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19132?vs=52008&id=52119

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

AFFECTED FILES
  CMakeLists.txt
  libs/widgets/KoAspectButton.h
  libs/widgets/KoColorPatch.h
  libs/widgets/KoColorPopupAction.h
  libs/widgets/KoColorPopupButton.cpp
  libs/widgets/KoColorPopupButton.h
  libs/widgets/KoColorSetWidget.h
  libs/widgets/KoColorSlider.cpp
  libs/widgets/KoColorSlider.h
  libs/widgets/KoConfigAuthorPage.h
  libs/widgets/KoContextBarButton.cpp
  libs/widgets/KoContextBarButton.h
  libs/widgets/KoCsvImportDialog.h
  libs/widgets/KoDialog.h
  libs/widgets/KoDialog_p.h
  libs/widgets/KoDockWidgetTitleBar.cpp
  libs/widgets/KoDockWidgetTitleBar.h
  libs/widgets/KoDockWidgetTitleBarButton.h
  libs/widgets/KoDocumentInfoDlg.cpp
  libs/widgets/KoDocumentInfoDlg.h
  libs/widgets/KoDocumentInfoPropsPage.cpp
  libs/widgets/KoDocumentInfoPropsPage.h
  libs/widgets/KoDpi.cpp
  libs/widgets/KoDpi.h
  libs/widgets/KoDualColorButton.h
  libs/widgets/KoEditColorSetDialog.cpp
  libs/widgets/KoEditColorSetDialog.h
  libs/widgets/KoFillConfigWidget.cpp
  libs/widgets/KoFillConfigWidget.h
  libs/widgets/KoGenericRegistryModel.h
  libs/widgets/KoGlobal.cpp
  libs/widgets/KoGradientEditWidget.cpp
  libs/widgets/KoGradientEditWidget.h
  libs/widgets/KoIconToolTip.h
  libs/widgets/KoItemToolTip.h
  libs/widgets/KoLineStyleItemDelegate_p.h
  libs/widgets/KoLineStyleModel_p.h
  libs/widgets/KoLineStyleSelector.h
  libs/widgets/KoMarkerItemDelegate.cpp
  libs/widgets/KoMarkerItemDelegate.h
  libs/widgets/KoMarkerModel.cpp
  libs/widgets/KoMarkerModel.h
  libs/widgets/KoMarkerSelector.cpp
  libs/widgets/KoMarkerSelector.h
  libs/widgets/KoModeBoxDocker.cpp
  libs/widgets/KoModeBoxDocker_p.h
  libs/widgets/KoModeBoxFactory.h
  libs/widgets/KoModeBox_p.h
  libs/widgets/KoPageLayoutWidget.h
  libs/widgets/KoPagePreviewWidget.h
  libs/widgets/KoPageWidgetItem.h
  libs/widgets/KoPositionSelector.cpp
  libs/widgets/KoPositionSelector.h
  libs/widgets/KoResourceItemChooser.h
  libs/widgets/KoResourceItemChooserContextMenu.cpp
  libs/widgets/KoResourceItemChooserContextMenu.h
  libs/widgets/KoResourceItemChooserSync.cpp
  libs/widgets/KoResourceItemChooserSync.h
  libs/widgets/KoResourceItemDelegate.h
  libs/widgets/KoResourceItemView.h
  libs/widgets/KoResourceModel.h
  libs/widgets/KoResourceModelBase.h
  libs/widgets/KoResourcePaths.cpp
  libs/widgets/KoResourcePopupAction.cpp
  libs/widgets/KoResourcePopupAction.h
  libs/widgets/KoResourceSelector.h
  libs/widgets/KoResourceServer.h
  libs/widgets/KoResourceServerAdapter.cpp
  libs/widgets/KoResourceServerAdapter.h
  libs/widgets/KoResourceServerProvider.cpp
  libs/widgets/KoResourceServerProvider.h
  libs/widgets/KoResourceTaggingManager.h
  libs/widgets/KoRuler.h
  libs/widgets/KoRulerController_p.h
  libs/widgets/KoRuler_p.h
  libs/widgets/KoShadowConfigWidget.cpp
  libs/widgets/KoSliderCombo.cpp
  libs/widgets/KoSliderCombo.h
  libs/widgets/KoSliderCombo_p.h
  libs/widgets/KoStrokeConfigWidget.cpp
  libs/widgets/KoStrokeConfigWidget.h
  libs/widgets/KoTableView.h
  libs/widgets/KoTagChooserWidget.h
  libs/widgets/KoTagFilterWidget.h
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.cpp
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgets/KoToolDocker.cpp
  libs/widgets/KoToolDocker.h
  libs/widgets/KoTriangleColorSelector.h
  libs/widgets/KoUnitDoubleSpinBox.h
  libs/widgets/KoViewItemContextBar.cpp
  libs/widgets/KoViewItemContextBar.h
  libs/widgets/KoZoomAction.cpp
  libs/widgets/KoZoomAction.h
  libs/widgets/KoZoomController.h
  libs/widgets/KoZoomController_p.h
  libs/widgets/KoZoomHandler.cpp
  libs/widgets/KoZoomHandler.h
  libs/widgets/KoZoomInput.h
  libs/widgets/KoZoomMode.cpp
  libs/widgets/KoZoomWidget.cpp
  libs/widgets/KoZoomWidget.h

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-19 Thread Carl Schwan

ognarb edited the summary of this revision.
ognarb edited the test plan for this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-19 Thread Carl Schwan

ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-19 Thread Carl Schwan

ognarb updated this revision to Diff 52121.
ognarb added a comment.


  Fix build

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19132?vs=52119&id=52121

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

AFFECTED FILES
  CMakeLists.txt
  libs/widgets/KoAspectButton.h
  libs/widgets/KoColorPatch.h
  libs/widgets/KoColorPopupAction.h
  libs/widgets/KoColorPopupButton.cpp
  libs/widgets/KoColorPopupButton.h
  libs/widgets/KoColorSetWidget.h
  libs/widgets/KoColorSlider.cpp
  libs/widgets/KoColorSlider.h
  libs/widgets/KoConfigAuthorPage.h
  libs/widgets/KoContextBarButton.cpp
  libs/widgets/KoContextBarButton.h
  libs/widgets/KoCsvImportDialog.h
  libs/widgets/KoDialog.h
  libs/widgets/KoDialog_p.h
  libs/widgets/KoDockWidgetTitleBar.cpp
  libs/widgets/KoDockWidgetTitleBar.h
  libs/widgets/KoDockWidgetTitleBarButton.h
  libs/widgets/KoDocumentInfoDlg.cpp
  libs/widgets/KoDocumentInfoDlg.h
  libs/widgets/KoDocumentInfoPropsPage.cpp
  libs/widgets/KoDocumentInfoPropsPage.h
  libs/widgets/KoDpi.cpp
  libs/widgets/KoDpi.h
  libs/widgets/KoDualColorButton.h
  libs/widgets/KoEditColorSetDialog.cpp
  libs/widgets/KoEditColorSetDialog.h
  libs/widgets/KoFillConfigWidget.cpp
  libs/widgets/KoFillConfigWidget.h
  libs/widgets/KoGenericRegistryModel.h
  libs/widgets/KoGradientEditWidget.cpp
  libs/widgets/KoGradientEditWidget.h
  libs/widgets/KoIconToolTip.h
  libs/widgets/KoItemToolTip.h
  libs/widgets/KoLineStyleItemDelegate_p.h
  libs/widgets/KoLineStyleModel_p.h
  libs/widgets/KoLineStyleSelector.h
  libs/widgets/KoMarkerItemDelegate.cpp
  libs/widgets/KoMarkerItemDelegate.h
  libs/widgets/KoMarkerModel.cpp
  libs/widgets/KoMarkerModel.h
  libs/widgets/KoMarkerSelector.cpp
  libs/widgets/KoMarkerSelector.h
  libs/widgets/KoModeBoxDocker.cpp
  libs/widgets/KoModeBoxDocker_p.h
  libs/widgets/KoModeBoxFactory.h
  libs/widgets/KoModeBox_p.h
  libs/widgets/KoPageLayoutWidget.h
  libs/widgets/KoPagePreviewWidget.h
  libs/widgets/KoPageWidgetItem.h
  libs/widgets/KoPositionSelector.cpp
  libs/widgets/KoPositionSelector.h
  libs/widgets/KoResourceItemChooser.h
  libs/widgets/KoResourceItemChooserContextMenu.cpp
  libs/widgets/KoResourceItemChooserContextMenu.h
  libs/widgets/KoResourceItemChooserSync.cpp
  libs/widgets/KoResourceItemChooserSync.h
  libs/widgets/KoResourceItemDelegate.h
  libs/widgets/KoResourceItemView.h
  libs/widgets/KoResourceModel.h
  libs/widgets/KoResourceModelBase.h
  libs/widgets/KoResourcePaths.cpp
  libs/widgets/KoResourcePopupAction.cpp
  libs/widgets/KoResourcePopupAction.h
  libs/widgets/KoResourceSelector.h
  libs/widgets/KoResourceServer.h
  libs/widgets/KoResourceServerAdapter.cpp
  libs/widgets/KoResourceServerAdapter.h
  libs/widgets/KoResourceServerProvider.cpp
  libs/widgets/KoResourceServerProvider.h
  libs/widgets/KoResourceTaggingManager.h
  libs/widgets/KoRuler.h
  libs/widgets/KoRulerController_p.h
  libs/widgets/KoRuler_p.h
  libs/widgets/KoShadowConfigWidget.cpp
  libs/widgets/KoSliderCombo.cpp
  libs/widgets/KoSliderCombo.h
  libs/widgets/KoSliderCombo_p.h
  libs/widgets/KoStrokeConfigWidget.cpp
  libs/widgets/KoStrokeConfigWidget.h
  libs/widgets/KoTableView.h
  libs/widgets/KoTagChooserWidget.h
  libs/widgets/KoTagFilterWidget.h
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.cpp
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgets/KoToolDocker.cpp
  libs/widgets/KoToolDocker.h
  libs/widgets/KoTriangleColorSelector.h
  libs/widgets/KoUnitDoubleSpinBox.h
  libs/widgets/KoViewItemContextBar.cpp
  libs/widgets/KoViewItemContextBar.h
  libs/widgets/KoZoomAction.cpp
  libs/widgets/KoZoomAction.h
  libs/widgets/KoZoomController.h
  libs/widgets/KoZoomController_p.h
  libs/widgets/KoZoomHandler.cpp
  libs/widgets/KoZoomHandler.h
  libs/widgets/KoZoomInput.h
  libs/widgets/KoZoomMode.cpp
  libs/widgets/KoZoomWidget.cpp
  libs/widgets/KoZoomWidget.h

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-21 Thread Carl Schwan

ognarb added a comment.


  In D19132#416519 , @danders wrote:
  
  > Ok, I can't say I have scrutinized every change, but...
  >  Could you give a heads up when you continue with other parts or else there 
may be merge problems.
  >  I'm working on karbon and pageapp atm, so please keep off :)
  
  
  Thanks for the review, I will work next on libs/{pigment,version,widgetutils}.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

2019-02-22 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:c32f7ef9bbbf: Update libs/widgets to c++11 (authored by 
ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19132?vs=52121&id=52341

REVISION DETAIL
  https://phabricator.kde.org/D19132

AFFECTED FILES
  CMakeLists.txt
  libs/widgets/KoAspectButton.h
  libs/widgets/KoColorPatch.h
  libs/widgets/KoColorPopupAction.h
  libs/widgets/KoColorPopupButton.cpp
  libs/widgets/KoColorPopupButton.h
  libs/widgets/KoColorSetWidget.h
  libs/widgets/KoColorSlider.cpp
  libs/widgets/KoColorSlider.h
  libs/widgets/KoConfigAuthorPage.h
  libs/widgets/KoContextBarButton.cpp
  libs/widgets/KoContextBarButton.h
  libs/widgets/KoCsvImportDialog.h
  libs/widgets/KoDialog.h
  libs/widgets/KoDialog_p.h
  libs/widgets/KoDockWidgetTitleBar.cpp
  libs/widgets/KoDockWidgetTitleBar.h
  libs/widgets/KoDockWidgetTitleBarButton.h
  libs/widgets/KoDocumentInfoDlg.cpp
  libs/widgets/KoDocumentInfoDlg.h
  libs/widgets/KoDocumentInfoPropsPage.cpp
  libs/widgets/KoDocumentInfoPropsPage.h
  libs/widgets/KoDpi.cpp
  libs/widgets/KoDpi.h
  libs/widgets/KoDualColorButton.h
  libs/widgets/KoEditColorSetDialog.cpp
  libs/widgets/KoEditColorSetDialog.h
  libs/widgets/KoFillConfigWidget.cpp
  libs/widgets/KoFillConfigWidget.h
  libs/widgets/KoGenericRegistryModel.h
  libs/widgets/KoGradientEditWidget.cpp
  libs/widgets/KoGradientEditWidget.h
  libs/widgets/KoIconToolTip.h
  libs/widgets/KoItemToolTip.h
  libs/widgets/KoLineStyleItemDelegate_p.h
  libs/widgets/KoLineStyleModel_p.h
  libs/widgets/KoLineStyleSelector.h
  libs/widgets/KoMarkerItemDelegate.cpp
  libs/widgets/KoMarkerItemDelegate.h
  libs/widgets/KoMarkerModel.cpp
  libs/widgets/KoMarkerModel.h
  libs/widgets/KoMarkerSelector.cpp
  libs/widgets/KoMarkerSelector.h
  libs/widgets/KoModeBoxDocker.cpp
  libs/widgets/KoModeBoxDocker_p.h
  libs/widgets/KoModeBoxFactory.h
  libs/widgets/KoModeBox_p.h
  libs/widgets/KoPageLayoutWidget.h
  libs/widgets/KoPagePreviewWidget.h
  libs/widgets/KoPageWidgetItem.h
  libs/widgets/KoPositionSelector.cpp
  libs/widgets/KoPositionSelector.h
  libs/widgets/KoResourceItemChooser.h
  libs/widgets/KoResourceItemChooserContextMenu.cpp
  libs/widgets/KoResourceItemChooserContextMenu.h
  libs/widgets/KoResourceItemChooserSync.cpp
  libs/widgets/KoResourceItemChooserSync.h
  libs/widgets/KoResourceItemDelegate.h
  libs/widgets/KoResourceItemView.h
  libs/widgets/KoResourceModel.h
  libs/widgets/KoResourceModelBase.h
  libs/widgets/KoResourcePaths.cpp
  libs/widgets/KoResourcePopupAction.cpp
  libs/widgets/KoResourcePopupAction.h
  libs/widgets/KoResourceSelector.h
  libs/widgets/KoResourceServer.h
  libs/widgets/KoResourceServerAdapter.cpp
  libs/widgets/KoResourceServerAdapter.h
  libs/widgets/KoResourceServerProvider.cpp
  libs/widgets/KoResourceServerProvider.h
  libs/widgets/KoResourceTaggingManager.h
  libs/widgets/KoRuler.h
  libs/widgets/KoRulerController_p.h
  libs/widgets/KoRuler_p.h
  libs/widgets/KoShadowConfigWidget.cpp
  libs/widgets/KoSliderCombo.cpp
  libs/widgets/KoSliderCombo.h
  libs/widgets/KoSliderCombo_p.h
  libs/widgets/KoStrokeConfigWidget.cpp
  libs/widgets/KoStrokeConfigWidget.h
  libs/widgets/KoTableView.h
  libs/widgets/KoTagChooserWidget.h
  libs/widgets/KoTagFilterWidget.h
  libs/widgets/KoToolBox.cpp
  libs/widgets/KoToolBoxButton.cpp
  libs/widgets/KoToolBoxDocker_p.h
  libs/widgets/KoToolBoxFactory.cpp
  libs/widgets/KoToolBoxFactory.h
  libs/widgets/KoToolBoxLayout_p.h
  libs/widgets/KoToolBox_p.h
  libs/widgets/KoToolDocker.cpp
  libs/widgets/KoToolDocker.h
  libs/widgets/KoTriangleColorSelector.h
  libs/widgets/KoUnitDoubleSpinBox.h
  libs/widgets/KoViewItemContextBar.cpp
  libs/widgets/KoViewItemContextBar.h
  libs/widgets/KoZoomAction.cpp
  libs/widgets/KoZoomAction.h
  libs/widgets/KoZoomController.h
  libs/widgets/KoZoomController_p.h
  libs/widgets/KoZoomHandler.cpp
  libs/widgets/KoZoomHandler.h
  libs/widgets/KoZoomInput.h
  libs/widgets/KoZoomMode.cpp
  libs/widgets/KoZoomWidget.cpp
  libs/widgets/KoZoomWidget.h

To: ognarb, #calligra:_3.0, leinir, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D25481: Port from qSort to std::sort

2019-11-22 Thread Carl Schwan

ognarb added a reviewer: Calligra: 3.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25481

To: ognarb, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25481: Port from qSort to std::sort

2019-11-22 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  qSort is deprecated now and std::sort is availabe since c++11
  
  grep -re "qSort" doesn't contains cpp files anymore

TEST PLAN
  Compile and run. No visible regression

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25481

AFFECTED FILES
  braindump/src/SectionContainer.cpp
  braindump/src/layouts/ColumnLayout.cpp
  devtools/cstester/visualimagecompare/CSTCompareView.cpp
  filters/karbon/wmf/WmfExport.cpp
  filters/sheets/excel/export/CFBWriter.cpp
  filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp
  filters/stage/kpr2odf/Filterkpr2odf.cpp
  gemini/cloud/dropbox/3rdparty/oauth.cc
  libs/flake/KoShapeContainer.cpp
  libs/flake/KoShapeController.cpp
  libs/flake/KoShapeGroup.cpp
  libs/flake/KoShapeLayer.cpp
  libs/flake/KoShapeManager.cpp
  libs/flake/KoShapeOdfSaveHelper.cpp
  libs/flake/commands/KoPathBreakAtPointCommand.cpp
  libs/flake/commands/KoPathPointRemoveCommand.cpp
  libs/flake/commands/KoShapeGroupCommand.cpp
  libs/flake/commands/KoShapeReorderCommand.cpp
  libs/flake/commands/KoShapeUngroupCommand.cpp
  libs/flake/svg/SvgWriter.cpp
  libs/flake/tests/TestPathShape.cpp
  libs/flake/tests/TestPathTool.cpp
  libs/flake/tests/TestShapeGroupCommand.cpp
  libs/flake/tests/TestShapePainting.cpp
  libs/flake/tests/TestShapeReorderCommand.cpp
  libs/flake/tools/KoPathToolSelection.cpp
  libs/pageapp/KoPADocumentStructureDocker.cpp
  libs/pageapp/KoPAPageBase.cpp
  libs/rdf/KoSopranoTableModel.cpp
  libs/text/BibliographyGenerator.cpp
  libs/text/commands/DeleteAnchorsCommand.cpp
  libs/text/commands/DeleteCommand.cpp
  libs/text/commands/InsertDeleteChangesCommand.cpp
  libs/text/commands/RemoveDeleteChangesCommand.cpp
  libs/text/opendocument/KoTextWriter_p.cpp
  libs/text/styles/KoParagraphStyle.cpp
  libs/textlayout/KoTextLayoutArea.cpp
  libs/textlayout/KoTextLayoutEndNotesArea.cpp
  libs/textlayout/RunAroundHelper.cpp
  libs/textlayout/ToCGenerator.cpp
  libs/widgets/KoModeBox.cpp
  libs/widgets/KoRuler.cpp
  libs/widgets/KoRulerController_p.h
  libs/widgets/KoZoomAction.cpp
  plugins/chartshape/ChartProxyModel.cpp
  plugins/chartshape/dialogs/TableEditorDialog.cpp
  plugins/defaultTools/connectionTool/ConnectionTool.cpp
  plugins/karbonplugins/tools/filterEffectTool/FilterEffectScene.cpp
  plugins/musicshape/Renderer.cpp
  plugins/textshape/FontSizeAction.cpp
  plugins/textshape/TextTool.cpp
  plugins/textshape/commands/ShowChangesCommand.cpp
  plugins/textshape/dialogs/StylesModel.cpp
  sheets/RTree.h
  sheets/database/FilterPopup.cpp
  sheets/dialogs/ShowColRowDialog.cpp
  sheets/functions/statistical.cpp
  stage/part/KPrCustomSlideShowsModel.cpp
  stage/part/pagelayout/KPrPageLayout.cpp
  stage/part/pagelayout/KPrPageLayouts.cpp
  stage/part/tools/animationtool/KPrPageEffectDocker.cpp
  words/part/dialogs/KWPageSettingsDialog.cpp
  words/part/frames/KWCopyShape.cpp
  words/part/tests/TestTextFrameSorting.cpp

To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25481: Port from qSort to std::sort

2019-11-26 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:dd2b51a717f9: Port from qSort to std::sort (authored by 
ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25481?vs=70192&id=70386

REVISION DETAIL
  https://phabricator.kde.org/D25481

AFFECTED FILES
  braindump/src/SectionContainer.cpp
  braindump/src/layouts/ColumnLayout.cpp
  devtools/cstester/visualimagecompare/CSTCompareView.cpp
  filters/karbon/wmf/WmfExport.cpp
  filters/sheets/excel/export/CFBWriter.cpp
  filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp
  filters/stage/kpr2odf/Filterkpr2odf.cpp
  gemini/cloud/dropbox/3rdparty/oauth.cc
  libs/flake/KoShapeContainer.cpp
  libs/flake/KoShapeController.cpp
  libs/flake/KoShapeGroup.cpp
  libs/flake/KoShapeLayer.cpp
  libs/flake/KoShapeManager.cpp
  libs/flake/KoShapeOdfSaveHelper.cpp
  libs/flake/commands/KoPathBreakAtPointCommand.cpp
  libs/flake/commands/KoPathPointRemoveCommand.cpp
  libs/flake/commands/KoShapeGroupCommand.cpp
  libs/flake/commands/KoShapeReorderCommand.cpp
  libs/flake/commands/KoShapeUngroupCommand.cpp
  libs/flake/svg/SvgWriter.cpp
  libs/flake/tests/TestPathShape.cpp
  libs/flake/tests/TestPathTool.cpp
  libs/flake/tests/TestShapeGroupCommand.cpp
  libs/flake/tests/TestShapePainting.cpp
  libs/flake/tests/TestShapeReorderCommand.cpp
  libs/flake/tools/KoPathToolSelection.cpp
  libs/pageapp/KoPADocumentStructureDocker.cpp
  libs/pageapp/KoPAPageBase.cpp
  libs/rdf/KoSopranoTableModel.cpp
  libs/text/BibliographyGenerator.cpp
  libs/text/commands/DeleteAnchorsCommand.cpp
  libs/text/commands/DeleteCommand.cpp
  libs/text/commands/InsertDeleteChangesCommand.cpp
  libs/text/commands/RemoveDeleteChangesCommand.cpp
  libs/text/opendocument/KoTextWriter_p.cpp
  libs/text/styles/KoParagraphStyle.cpp
  libs/textlayout/KoTextLayoutArea.cpp
  libs/textlayout/KoTextLayoutEndNotesArea.cpp
  libs/textlayout/RunAroundHelper.cpp
  libs/textlayout/ToCGenerator.cpp
  libs/widgets/KoModeBox.cpp
  libs/widgets/KoRuler.cpp
  libs/widgets/KoRulerController_p.h
  libs/widgets/KoZoomAction.cpp
  plugins/chartshape/ChartProxyModel.cpp
  plugins/chartshape/dialogs/TableEditorDialog.cpp
  plugins/defaultTools/connectionTool/ConnectionTool.cpp
  plugins/karbonplugins/tools/filterEffectTool/FilterEffectScene.cpp
  plugins/musicshape/Renderer.cpp
  plugins/textshape/FontSizeAction.cpp
  plugins/textshape/TextTool.cpp
  plugins/textshape/commands/ShowChangesCommand.cpp
  plugins/textshape/dialogs/StylesModel.cpp
  sheets/RTree.h
  sheets/database/FilterPopup.cpp
  sheets/dialogs/ShowColRowDialog.cpp
  sheets/functions/statistical.cpp
  stage/part/KPrCustomSlideShowsModel.cpp
  stage/part/pagelayout/KPrPageLayout.cpp
  stage/part/pagelayout/KPrPageLayouts.cpp
  stage/part/tools/animationtool/KPrPageEffectDocker.cpp
  words/part/dialogs/KWPageSettingsDialog.cpp
  words/part/frames/KWCopyShape.cpp
  words/part/tests/TestTextFrameSorting.cpp

To: ognarb, #calligra:_3.0, dfaure
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25481: Port from qSort to std::sort

2019-11-26 Thread Carl Schwan

ognarb added a comment.


  Thanks for the review :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25481

To: ognarb, #calligra:_3.0, dfaure
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25560: refactor: Run clang-tity modernize override

2019-11-26 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  - Reduce significantly the number of warnings during compilation
  - Only manual intervention was in 
filters/sheets/excel/sidewinder/recordsxml2cpp.cpp

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25560

AFFECTED FILES
  components/CalligraComponentsPlugin.h
  components/Document.h
  components/ImageDataItem.h
  components/LinkArea.h
  components/View.h
  components/ViewController.h
  components/impl/ComponentsKoCanvasController.h
  components/impl/DocumentImpl.h
  components/impl/PresentationImpl.h
  components/impl/PresentationKoPAView.h
  components/impl/SpreadsheetImpl.h
  components/impl/TextDocumentImpl.h
  components/models/ContentsModel.h
  components/models/PresentationContentsModelImpl.h
  components/models/SpreadsheetContentsModelImpl.h
  components/models/TextContentsModelImpl.h
  devtools/cstester/CSThumbProviderKarbon.h
  devtools/cstester/CSThumbProviderStage.h
  devtools/cstester/CSThumbProviderTables.h
  devtools/cstester/CSThumbProviderWords.h
  devtools/cstester/cstrunner/CSTProcessRunner.h
  devtools/cstester/visualimagecompare/CSTCompareView.h
  devtools/cstester/visualimagecompare/CompareView.h
  extras/thumbnail/calligracreator.h
  filters/karbon/eps/EpsImport.h
  filters/karbon/eps/PsCommentLexer.h
  filters/karbon/image/ImageExport.h
  filters/karbon/karbon1.x/Karbon1xImport.h
  filters/karbon/pdf/Pdf2OdgImport.h
  filters/karbon/pdf/PdfImport.h
  filters/karbon/pdf/SvgOutputDev.h
  filters/karbon/svg/SvgExport.h
  filters/karbon/svg/SvgImport.h
  filters/karbon/wmf/WmfExport.h
  filters/karbon/wmf/WmfImport.h
  filters/karbon/wmf/WmfImportParser.h
  filters/karbon/wpg/WPGImport.h
  filters/karbon/xfig/XFigDocument.h
  filters/karbon/xfig/XFigImportFilter.h
  filters/libmso/generated/leinputstream.h
  filters/libmsooxml/KoOdfExporter.h
  filters/libmsooxml/MsooXmlCommonReader.h
  filters/libmsooxml/MsooXmlDiagramReader.h
  filters/libmsooxml/MsooXmlDiagramReader_p.h
  filters/libmsooxml/MsooXmlDocPropertiesReader.h
  filters/libmsooxml/MsooXmlDrawingTableStyle.h
  filters/libmsooxml/MsooXmlDrawingTableStyleReader.h
  filters/libmsooxml/MsooXmlImport.h
  filters/libmsooxml/MsooXmlRelationshipsReader.h
  filters/libmsooxml/MsooXmlTheme.h
  filters/libmsooxml/MsooXmlThemesReader.h
  filters/libmsooxml/VmlDrawingReader.h
  filters/libodf2/KoCellStyle.h
  filters/libodf2/KoColumnStyle.h
  filters/libodf2/KoDummyCellValue.h
  filters/libodf2/KoOdfGraphicProperties.h
  filters/libodf2/KoOdfHeaderFooterProperties.h
  filters/libodf2/KoOdfListLevelProperties.h
  filters/libodf2/KoOdfPageLayout.h
  filters/libodf2/KoOdfPageLayoutProperties.h
  filters/libodf2/KoOdfParagraphProperties.h
  filters/libodf2/KoOdfStyle.h
  filters/libodf2/KoOdfTextProperties.h
  filters/libodf2/KoRawCellChild.h
  filters/libodf2/KoRowStyle.h
  filters/libodf2/KoTblStyle.h
  filters/libodf2/chart/Charting.h
  filters/libodfreader/OdsReader.h
  filters/libodfreader/OdsReaderBackend.h
  filters/libodfreader/OdtReader.h
  filters/libodfreader/OdtReaderBackend.h
  filters/odg/visio/import/VSDXImport.cpp
  filters/odg/wpg/import/WPGImport.cpp
  filters/outputhelper/StringDocumentHandler.hxx
  filters/sheets/applixspread/applixspreadimport.h
  filters/sheets/csv/csvexport.h
  filters/sheets/csv/csvexportdialog.h
  filters/sheets/csv/csvimport.h
  filters/sheets/dbase/dbaseimport.h
  filters/sheets/excel/export/CFBWriter.cpp
  filters/sheets/excel/export/ExcelExport.h
  filters/sheets/excel/import/ExcelImport.h
  filters/sheets/excel/import/ODrawClient.h
  filters/sheets/excel/import/excelimporttoods.h
  filters/sheets/excel/sidewinder/chartsubstreamhandler.cpp
  filters/sheets/excel/sidewinder/chartsubstreamhandler.h
  filters/sheets/excel/sidewinder/excel.h
  filters/sheets/excel/sidewinder/globalssubstreamhandler.h
  filters/sheets/excel/sidewinder/objects.h
  filters/sheets/excel/sidewinder/recordsxml2cpp.cpp
  filters/sheets/excel/sidewinder/workbook.h
  filters/sheets/excel/sidewinder/worksheetsubstreamhandler.h
  filters/sheets/excel/sidewinder/xmltk.h
  filters/sheets/gnumeric/gnumericexport.h
  filters/sheets/gnumeric/gnumericimport.h
  filters/sheets/html/exportdialog.h
  filters/sheets/html/htmlexport.h
  filters/sheets/latex/export/cell.h
  filters/sheets/latex/export/column.h
  filters/sheets/latex/export/document.h
  filters/sheets/latex/export/fileheader.h
  filters/sheets/latex/export/format.h
  filters/sheets/latex/export/latexexport.h
  filters/sheets/latex/export/latexexportAdaptor.h
  filters/sheets/latex/export/latexexportdialog.h
  filters/sheets/latex/export/map.h
  filters/sheets/latex/export/pen.h
  filters/sheets/latex/export/row.h
  filters/sheets/latex/export/spreadsheet.h
  filters/sheets/latex/export/table.h
  filters/sheets/opencalc/opencalcexport.h
  filters/sheets/op

D25560: refactor: Run clang-tity modernize override

2019-11-26 Thread Carl Schwan

ognarb added a reviewer: Calligra: 3.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25560

To: ognarb, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25560: refactor: Run clang-tity modernize override

2019-12-01 Thread Carl Schwan

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e82b7dde192b: refactor: Run clang-tity modernize override 
(authored by ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25560?vs=70391&id=70671

REVISION DETAIL
  https://phabricator.kde.org/D25560

AFFECTED FILES
  components/CalligraComponentsPlugin.h
  components/Document.h
  components/ImageDataItem.h
  components/LinkArea.h
  components/View.h
  components/ViewController.h
  components/impl/ComponentsKoCanvasController.h
  components/impl/DocumentImpl.h
  components/impl/PresentationImpl.h
  components/impl/PresentationKoPAView.h
  components/impl/SpreadsheetImpl.h
  components/impl/TextDocumentImpl.h
  components/models/ContentsModel.h
  components/models/PresentationContentsModelImpl.h
  components/models/SpreadsheetContentsModelImpl.h
  components/models/TextContentsModelImpl.h
  devtools/cstester/CSThumbProviderKarbon.h
  devtools/cstester/CSThumbProviderStage.h
  devtools/cstester/CSThumbProviderTables.h
  devtools/cstester/CSThumbProviderWords.h
  devtools/cstester/cstrunner/CSTProcessRunner.h
  devtools/cstester/visualimagecompare/CSTCompareView.h
  devtools/cstester/visualimagecompare/CompareView.h
  extras/thumbnail/calligracreator.h
  filters/karbon/eps/EpsImport.h
  filters/karbon/eps/PsCommentLexer.h
  filters/karbon/image/ImageExport.h
  filters/karbon/karbon1.x/Karbon1xImport.h
  filters/karbon/pdf/Pdf2OdgImport.h
  filters/karbon/pdf/PdfImport.h
  filters/karbon/pdf/SvgOutputDev.h
  filters/karbon/svg/SvgExport.h
  filters/karbon/svg/SvgImport.h
  filters/karbon/wmf/WmfExport.h
  filters/karbon/wmf/WmfImport.h
  filters/karbon/wmf/WmfImportParser.h
  filters/karbon/wpg/WPGImport.h
  filters/karbon/xfig/XFigDocument.h
  filters/karbon/xfig/XFigImportFilter.h
  filters/libmso/generated/leinputstream.h
  filters/libmsooxml/KoOdfExporter.h
  filters/libmsooxml/MsooXmlCommonReader.h
  filters/libmsooxml/MsooXmlDiagramReader.h
  filters/libmsooxml/MsooXmlDiagramReader_p.h
  filters/libmsooxml/MsooXmlDocPropertiesReader.h
  filters/libmsooxml/MsooXmlDrawingTableStyle.h
  filters/libmsooxml/MsooXmlDrawingTableStyleReader.h
  filters/libmsooxml/MsooXmlImport.h
  filters/libmsooxml/MsooXmlRelationshipsReader.h
  filters/libmsooxml/MsooXmlTheme.h
  filters/libmsooxml/MsooXmlThemesReader.h
  filters/libmsooxml/VmlDrawingReader.h
  filters/libodf2/KoCellStyle.h
  filters/libodf2/KoColumnStyle.h
  filters/libodf2/KoDummyCellValue.h
  filters/libodf2/KoOdfGraphicProperties.h
  filters/libodf2/KoOdfHeaderFooterProperties.h
  filters/libodf2/KoOdfListLevelProperties.h
  filters/libodf2/KoOdfPageLayout.h
  filters/libodf2/KoOdfPageLayoutProperties.h
  filters/libodf2/KoOdfParagraphProperties.h
  filters/libodf2/KoOdfStyle.h
  filters/libodf2/KoOdfTextProperties.h
  filters/libodf2/KoRawCellChild.h
  filters/libodf2/KoRowStyle.h
  filters/libodf2/KoTblStyle.h
  filters/libodf2/chart/Charting.h
  filters/libodfreader/OdsReader.h
  filters/libodfreader/OdsReaderBackend.h
  filters/libodfreader/OdtReader.h
  filters/libodfreader/OdtReaderBackend.h
  filters/odg/visio/import/VSDXImport.cpp
  filters/odg/wpg/import/WPGImport.cpp
  filters/outputhelper/StringDocumentHandler.hxx
  filters/sheets/applixspread/applixspreadimport.h
  filters/sheets/csv/csvexport.h
  filters/sheets/csv/csvexportdialog.h
  filters/sheets/csv/csvimport.h
  filters/sheets/dbase/dbaseimport.h
  filters/sheets/excel/export/CFBWriter.cpp
  filters/sheets/excel/export/ExcelExport.h
  filters/sheets/excel/import/ExcelImport.h
  filters/sheets/excel/import/ODrawClient.h
  filters/sheets/excel/import/excelimporttoods.h
  filters/sheets/excel/sidewinder/chartsubstreamhandler.cpp
  filters/sheets/excel/sidewinder/chartsubstreamhandler.h
  filters/sheets/excel/sidewinder/excel.h
  filters/sheets/excel/sidewinder/globalssubstreamhandler.h
  filters/sheets/excel/sidewinder/objects.h
  filters/sheets/excel/sidewinder/recordsxml2cpp.cpp
  filters/sheets/excel/sidewinder/workbook.h
  filters/sheets/excel/sidewinder/worksheetsubstreamhandler.h
  filters/sheets/excel/sidewinder/xmltk.h
  filters/sheets/gnumeric/gnumericexport.h
  filters/sheets/gnumeric/gnumericimport.h
  filters/sheets/html/exportdialog.h
  filters/sheets/html/htmlexport.h
  filters/sheets/latex/export/cell.h
  filters/sheets/latex/export/column.h
  filters/sheets/latex/export/document.h
  filters/sheets/latex/export/fileheader.h
  filters/sheets/latex/export/format.h
  filters/sheets/latex/export/latexexport.h
  filters/sheets/latex/export/latexexportAdaptor.h
  filters/sheets/latex/export/latexexportdialog.h
  filters/sheets/latex/export/map.h
  filters/sheets/latex/export/pen.h
  filters/sheets/latex/export/row.h
  filters/sheets/latex/export/spreadsheet.h
  filters/sheets/latex/export/table.h
  filters/sheets/opencalc/opencalcexport.h
  filters/sheets/opencalc/op

D25664: [WIP]: Port away from QSignalMapper

2019-12-01 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REPOSITORY
  R8 Calligra

BRANCH
  port-away-signalmapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25664

AFFECTED FILES
  libs/widgets/KoDialog.cpp
  libs/widgets/KoDialog_p.h
  plugins/formulashape/KoFormulaTool.cpp
  plugins/formulashape/KoFormulaTool.h
  plugins/textediting/spellcheck/SpellCheckMenu.cpp
  plugins/textediting/spellcheck/SpellCheckMenu.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp
  plugins/textshape/dialogs/SimpleParagraphWidget.cpp
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.h
  words/plugins/scripting/Tool.h

To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25664: [WIP]: Port away from QSignalMapper

2019-12-01 Thread Carl Schwan

ognarb edited the summary of this revision.
ognarb edited the test plan for this revision.
ognarb added reviewers: Calligra: 3.0, KF6.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25664

To: ognarb, #calligra:_3.0, #kf6
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-01 Thread Carl Schwan

ognarb retitled this revision from "[WIP]: Port away from QSignalMapper" to 
"[WIP]: Port away from deprecated QSignalMapper".
ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25664

To: ognarb, #calligra:_3.0, #kf6
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-02 Thread Carl Schwan

ognarb updated this revision to Diff 70755.
ognarb marked 7 inline comments as done.
ognarb added a comment.


  Thanks for the review David. I will now follow your advice and continue 
porting
  away from QSignalMapper.

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25664?vs=70695&id=70755

BRANCH
  arcpatch-D25664

REVISION DETAIL
  https://phabricator.kde.org/D25664

AFFECTED FILES
  libs/widgets/KoDialog.cpp
  libs/widgets/KoDialog_p.h
  plugins/formulashape/KoFormulaTool.cpp
  plugins/formulashape/KoFormulaTool.h
  plugins/textediting/spellcheck/SpellCheckMenu.cpp
  plugins/textediting/spellcheck/SpellCheckMenu.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp
  plugins/textshape/dialogs/SimpleParagraphWidget.cpp
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.h
  words/plugins/scripting/Tool.h

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-02 Thread Carl Schwan

ognarb planned changes to this revision.
ognarb added a comment.


  Planned changes: Port all the QSignalMapper ;)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25664

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-02 Thread Carl Schwan

ognarb added a comment.


  Ok I will replace the qAsConst with koAsConst ;)
  
  I suppose the reason why Calligra needs Qt5.3 is the Qt Quick 1 support?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25664

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-02 Thread Carl Schwan

ognarb updated this revision to Diff 70790.
ognarb added a comment.


  Finish porting away from QSignalMapper

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25664?vs=70755&id=70790

BRANCH
  arcpatch-D25664

REVISION DETAIL
  https://phabricator.kde.org/D25664

AFFECTED FILES
  libs/text/styles/KoParagraphStyle.h
  libs/widgets/KoDialog.cpp
  libs/widgets/KoDialog_p.h
  plugins/formulashape/KoFormulaTool.cpp
  plugins/formulashape/KoFormulaTool.h
  plugins/textediting/spellcheck/SpellCheckMenu.cpp
  plugins/textediting/spellcheck/SpellCheckMenu.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp
  plugins/textshape/dialogs/SimpleCitationBibliographyWidget.h
  plugins/textshape/dialogs/SimpleParagraphWidget.cpp
  plugins/textshape/dialogs/SimpleParagraphWidget.h
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.h
  plugins/textshape/dialogs/StylesModel.cpp
  plugins/textshape/dialogs/StylesModel.h
  words/plugins/scripting/Tool.h

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-02 Thread Carl Schwan

ognarb marked 3 inline comments as done.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25664

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-03 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e29dc97256de: [WIP]: Port away from deprecated 
QSignalMapper (authored by ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25664?vs=70790&id=70818

REVISION DETAIL
  https://phabricator.kde.org/D25664

AFFECTED FILES
  libs/text/styles/KoParagraphStyle.h
  libs/widgets/KoDialog.cpp
  libs/widgets/KoDialog_p.h
  plugins/formulashape/KoFormulaTool.cpp
  plugins/formulashape/KoFormulaTool.h
  plugins/textediting/spellcheck/SpellCheckMenu.cpp
  plugins/textediting/spellcheck/SpellCheckMenu.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp
  plugins/textshape/dialogs/SimpleCitationBibliographyWidget.h
  plugins/textshape/dialogs/SimpleParagraphWidget.cpp
  plugins/textshape/dialogs/SimpleParagraphWidget.h
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp
  plugins/textshape/dialogs/SimpleTableOfContentsWidget.h
  plugins/textshape/dialogs/StylesModel.cpp
  plugins/textshape/dialogs/StylesModel.h
  words/plugins/scripting/Tool.h

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25714: Port away from deprecated KHtml

2019-12-03 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

TEST PLAN
  Compile, but I need to figure out why before and after this change the filter 
doesn't work.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25714

AFFECTED FILES
  CMakeLists.txt
  filters/sheets/html/CMakeLists.txt
  filters/sheets/html/htmlimport.cc
  filters/sheets/html/htmlimport.h

To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25714: Port away from deprecated KHtml

2019-12-03 Thread Carl Schwan

ognarb added a task: T11542: Remove KHTML.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25714: Port away from deprecated KHtml

2019-12-03 Thread Carl Schwan

ognarb edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25714: Port away from deprecated KHtml

2019-12-03 Thread Carl Schwan

ognarb added a reviewer: Calligra: 3.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

Qt version and new website

2019-12-03 Thread Carl Schwan

Hello,

I wanted to know if we could change the Qt dependency from Qt 5.3 to Qt 5.9 at 
least.

I think some parts already depends on Qt 5.7 at least. For example in Calligra 
Gemini, there is
a dependency to Kirigami, that depends on Qt Quick Control 2 introduced in Qt 
5.7.

I suppose there are two possible reasons, we still depend on Qt 5.3:

+ Nobody bothered to change the CMakeLists.txt
+ Some parts of Calligra need a version of Qt <= 5.3

I hope this is the first reason.

In other news, I created a task for Season of KDE to rewrite the Calligra 
website using
KDE branding and a Jekyll theme 
(https://invent.kde.org/websites/jekyll-kde-theme). So that
we have a website looking like kontact.kde.org and cantor.kde.org.

Cheers,

Carl Schwan
https://carlschwan.eu



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

D25714: [WIP]: Port away from deprecated KHtml

2019-12-04 Thread Carl Schwan

ognarb retitled this revision from "Port away from deprecated KHtml" to "[WIP]: 
Port away from deprecated KHtml".

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D26050: Fix build with poppler 82

2019-12-25 Thread Carl Schwan

ognarb added a comment.


  Doesn't compile for me with Poppler 81. So I created a small patch on top of 
your patch
  
  F7835712: poppler-81.patch 

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: ognarb, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, dcaliste, 
cochise, vandenoever

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REVISION SUMMARY
  Replace custom dialog with QQC2 Dialog

TEST PLAN
  Screenshot comming

REPOSITORY
  R8 Calligra

BRANCH
  gemini-dialog

REVISION DETAIL
  https://phabricator.kde.org/D26221

AFFECTED FILES
  gemini/qml/components/Dialog.qml

To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan

ognarb added reviewers: Calligra: 3.0, leinir.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26221

To: ognarb, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan

ognarb updated this revision to Diff 72174.
ognarb added a comment.


  Update look

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26221?vs=72173&id=72174

BRANCH
  gemini-dialog

REVISION DETAIL
  https://phabricator.kde.org/D26221

AFFECTED FILES
  gemini/qml/components/Dialog.qml

To: ognarb, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D26221: Use QQC2 Dialog

2019-12-25 Thread Carl Schwan

ognarb edited the test plan for this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26221

To: ognarb, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D26050: Fix build with poppler 82

2019-12-25 Thread Carl Schwan

ognarb added a comment.


  In D26050#582981 , @asturmlechner 
wrote:
  
  > In D26050#578862 , 
@anthonyfieroni wrote:
  >
  > > Maybe we can drop 62, but not 72.
  >
  >
  > If this is for master I don't see why we could keep anything pre-0.79. 
Distros already have to patch the hell out of 3.1.0 which has led to diverging 
code because several changes are conflicting. That one needs a point release to 
settle that.
  >
  > And meanwhile master needs a fix for 0.83 too.
  
  
  What about releasing Calligra as a part of the Release Service (a release 
every 4 months with some Bugfix release between)? The latest release was almost 
2 years ago, and we have more than 500 commits in master.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list, 
davidllewellynjones, dcaliste, cochise, vandenoever

D26050: Fix build with poppler 82

2019-12-26 Thread Carl Schwan

ognarb added a comment.


  In D26050#583223 , @leinir wrote:
  
  > In D26050#583007 , @ognarb wrote:
  >
  > > In D26050#582981 , 
@asturmlechner wrote:
  > >
  > > > In D26050#578862 , 
@anthonyfieroni wrote:
  > > >
  > > > > Maybe we can drop 62, but not 72.
  > > >
  > > >
  > > > If this is for master I don't see why we could keep anything pre-0.79. 
Distros already have to patch the hell out of 3.1.0 which has led to diverging 
code because several changes are conflicting. That one needs a point release to 
settle that.
  > > >
  > > > And meanwhile master needs a fix for 0.83 too.
  > >
  > >
  > > What about releasing Calligra as a part of the Release Service (a release 
every 4 months with some Bugfix release between)? The latest release was almost 
2 years ago, and we have more than 500 commits in master.
  >
  >
  > To go with this, i'm starting to think that it would perhaps not be the 
worst thing to have Calligra's engine explicitly split out, to allow it to be 
released as a proper Framework, and the applications to be applications based 
on that framework... It would seem like something that'd be worth trying to aim 
for for KF6, because while Calligra might have slowed down, that particular 
reason for Calligra's existence is still a thing, and the monolithic nature of 
the current layout of the codebase does not allow people to use it in the way 
it is intended. So... yup, going to have to spend some time considering this 
and making a formal proposal, but thought i would mention it here and get the 
idea out in the open.
  
  
  +1 and I'm willing to help :)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: leinir, asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list, 
davidllewellynjones, dcaliste, cochise, vandenoever

D26221: Use QQC2 Dialog

2019-12-27 Thread Carl Schwan

ognarb updated this revision to Diff 72240.
ognarb added a comment.


  - Center the loading animation

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26221?vs=72174&id=72240

BRANCH
  gemini-dialog

REVISION DETAIL
  https://phabricator.kde.org/D26221

AFFECTED FILES
  gemini/qml/components/Dialog.qml

To: ognarb, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D26221: Use QQC2 Dialog

2019-12-27 Thread Carl Schwan

ognarb marked an inline comment as done.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26221

To: ognarb, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

New website

2020-01-07 Thread Carl Schwan

Hi,

I already spoke a bit about it with Leinir, but I will mentor a Season of KDE 
project about updating the Calligra website. The idea of updating the Calligra 
website was really popular and I received more than 10 proposals for the 
website. I choose Anuj Bansal since he already contributed to the juk.kde.org 
website and he is familiar with the current KDE web tooling.

The goal of the new website is to bring new users and new contributors to 
Calligra.

The website update will be focused around the content, the design, and the 
infrastructure.

* Content:
  * the screenshots need to be updated to use the Breeze theme
  * the text need be checked to see if it is still actual
  * Url should remain the same for compatibility with the old links
  * Old content needs to be ported. We should not lose any announcements
  * The planet feature is easy to reproduce using the Jekyll planet component.
  * Add get-involved page with links to developer information and other useful 
information to start hacking on Calligra ;)

* Design:
  * The updated website will use the Aether theme. This is the theme used for 
kde.org and was designed for KDE.
  * Potentially we could use some small variation from the main theme to make 
the website more unique.
  * A good example about how the website could look in the future is 
kontact.kde.org
  * New design will be also compatible with mobile phone.

* Infrastructure:
  * The new website will use Jekyll a static site generator (the CI build the 
website and the server only serve plain html content). This means the website 
will be faster to load for the visitor and more secure.
  * All the content is stored in git as markdown files and this makes it easier 
to contribute to the website (we can use gitlab as CMS)

As the first step for Anuj, I think the best would be to set up a repository in 
invent.kde.org and create the base structure with a lot of boilerplate content 
(copied from the existing website) and the basic Jekyll configuration. When we 
can iterate over the content and design until everyone is happy with it. :)

Any questions? or other requirements for the website I forgot to mention?

Regards,

Carl

publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

Re: New website

2020-03-02 Thread Carl Schwan

Hello,
the website progressed a lot during Season of KDE and it was completly updated. 
Thanks a lot to Anuj Bansal for his work on that and in improving the Jekyll 
theme with new components.

It now use the Jekyll KDE theme, the screenshots are all updated with the 
latest version of Calligra and use the Breeze theme. A demo version is 
available at https://irl.carlschwan.eu/. It would be nice, if someone could 
take a look at it and reports any errors or problems found. Particulary if the 
information present on https://irl.carlschwan.eu/old-components/ are correct.

The website git repository is located at 
invent.kde.org/anujbansal/calligra-website/ and will be moved to 
invent.kde.org/websites/calligra-org in the future, after the review.

For the sysadmin request and the deployment, I will need to know who need to 
access the website. From reading the logs, I think it should be at least 
Jarosław Staniek and danders, but if anyone else want access please let me 
know. Just make sure you have an account in invent.kde.org (just login with 
your identity.kde.org identifier one time), otherwise Sysadmin can't grant you 
access :-).

I hope not many problems will be found. My plan will be to deploy the website 
before the end of this month, so that it can appear on my second monthly KDE 
web news :-)

Cheers,

Carl Schwan
https://carlschwan.eu
KDE Web developer

‐‐‐ Original Message ‐‐‐
Le mardi, janvier 7, 2020 9:53 PM, Carl Schwan  a écrit :

> Hi,
> 

> I already spoke a bit about it with Leinir, but I will mentor a Season of KDE 
> project about updating the Calligra website. The idea of updating the 
> Calligra website was really popular and I received more than 10 proposals for 
> the website. I choose Anuj Bansal since he already contributed to the 
> juk.kde.org website and he is familiar with the current KDE web tooling.
> 

> The goal of the new website is to bring new users and new contributors to 
> Calligra.
> 

> The website update will be focused around the content, the design, and the 
> infrastructure.
> 

> -   Content:
> -   the screenshots need to be updated to use the Breeze theme
> -   the text need be checked to see if it is still actual
> -   Url should remain the same for compatibility with the old links
> -   Old content needs to be ported. We should not lose any announcements
> -   The planet feature is easy to reproduce using the Jekyll planet 
> component.
> -   Add get-involved page with links to developer information and other 
> useful information to start hacking on Calligra ;)
> -   Design:
> -   The updated website will use the Aether theme. This is the theme used 
> for kde.org and was designed for KDE.
> -   Potentially we could use some small variation from the main theme to 
> make the website more unique.
> -   A good example about how the website could look in the future is 
> kontact.kde.org
> -   New design will be also compatible with mobile phone.
> -   Infrastructure:
> -   The new website will use Jekyll a static site generator (the CI build 
> the website and the server only serve plain html content). This means the 
> website will be faster to load for the visitor and more secure.
> -   All the content is stored in git as markdown files and this makes it 
> easier to contribute to the website (we can use gitlab as CMS)
> 

> As the first step for Anuj, I think the best would be to set up a 
> repository in invent.kde.org and create the base structure with a lot of 
> boilerplate content (copied from the existing website) and the basic Jekyll 
> configuration. When we can iterate over the content and design until everyone 
> is happy with it. :)
> 

> Any questions? or other requirements for the website I forgot to 
> mention?
> 

> Regards,
> 

> Carl
>



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

Re: New website

2020-03-06 Thread Carl Schwan

Hi,

Le mardi, mars 3, 2020 1:16 PM, Dag  a écrit :

> Great work!
> 

> old-components are propably ok, although we have not actually axed flow and 
> braindump yet. They will however, go on next release, if somebody does not 
> step up to maintain them.
> 

> So, probably we should consider a new release soonish...

Considering how long, there wasn't any Calligra release this is a good idea. I 
create a phab task for that https://phabricator.kde.org/T12787. Please feel 
free to add any other subtasks. The promo team and I can help with writting the 
announcement and promoting it to the social medias. 

 

> As for web site access, probably a couple of more maintainers would like 
> access, but I'm sure they can speak up for themselves :)

I will wait a few more days before creating a sysadmin request, otherwise 
access can still be granted later with a normal sysadmin request.

Cheers,

Carl
 

> ---
> 

> Cheers,
> 

> Dag
> 

> Carl Schwan skrev den 2020-03-02 16:42:
> 

> > Hello,
> > the website progressed a lot during Season of KDE and it was completly 
> > updated. Thanks a lot to Anuj Bansal for his work on that and in improving 
> > the Jekyll theme with new components.
> > 

> > It now use the Jekyll KDE theme, the screenshots are all updated with the 
> > latest version of Calligra and use the Breeze theme. A demo version is 
> > available at https://irl.carlschwan.eu/. It would be nice, if someone could 
> > take a look at it and reports any errors or problems found. Particulary if 
> > the information present on https://irl.carlschwan.eu/old-components/ are 
> > correct.
> > 

> > The website git repository is located at 
> > invent.kde.org/anujbansal/calligra-website/ and will be moved to 
> > invent.kde.org/websites/calligra-org in the future, after the review.
> > 

> > For the sysadmin request and the deployment, I will need to know who need 
> > to access the website. From reading the logs, I think it should be at least 
> > Jarosław Staniek and danders, but if anyone else want access please let me 
> > know. Just make sure you have an account in invent.kde.org (just login with 
> > your identity.kde.org identifier one time), otherwise Sysadmin can't grant 
> > you access :-).
> > 

> > I hope not many problems will be found. My plan will be to deploy the 
> > website before the end of this month, so that it can appear on my second 
> > monthly KDE web news :-)
> > 

> > Cheers,
> > 

> > Carl Schwan
> > https://carlschwan.eu
> > KDE Web developer
> > 

> > ‐‐‐ Original Message ‐‐‐
> > Le mardi, janvier 7, 2020 9:53 PM, Carl Schwan  a écrit 
> > :
> > 

> > > Hi,
> > 

> > > I already spoke a bit about it with Leinir, but I will mentor a Season of 
> > > KDE project about updating the Calligra website. The idea of updating the 
> > > Calligra website was really popular and I received more than 10 proposals 
> > > for the website. I choose Anuj Bansal since he already contributed to the 
> > > juk.kde.org website and he is familiar with the current KDE web tooling.
> > 

> > > The goal of the new website is to bring new users and new contributors to 
> > > Calligra.
> > 

> > > The website update will be focused around the content, the design, and 
> > > the infrastructure.
> > 

> > > -   Content:
> > > -   the screenshots need to be updated to use the Breeze theme
> > > -   the text need be checked to see if it is still actual
> > > -   Url should remain the same for compatibility with the old links
> > > -   Old content needs to be ported. We should not lose any 
> > > announcements
> > > -   The planet feature is easy to reproduce using the Jekyll planet 
> > > component.
> > > -   Add get-involved page with links to developer information and 
> > > other useful information to start hacking on Calligra ;)
> > > -   Design:
> > > -   The updated website will use the Aether theme. This is the theme 
> > > used for kde.org and was designed for KDE.
> > > -   Potentially we could use some small variation from the main theme 
> > > to make the website more unique.
> > > -   A good example about how the website could look in the future is 
> > > kontact.kde.org
> > > -   New design will be also compatible with mobile phone.
> > > -   Infrastructure:
> > > -   The new website will use Jekyll a static site generator (the CI 
> > > build the website and the s

D26221: Use QQC2 Dialog

2020-03-09 Thread Carl Schwan

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:d6cdb21118b2: Use QQC2 Dialog (authored by ognarb).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26221?vs=72240&id=77299

REVISION DETAIL
  https://phabricator.kde.org/D26221

AFFECTED FILES
  gemini/qml/components/Dialog.qml

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D26221: Use QQC2 Dialog

2020-03-09 Thread Carl Schwan

ognarb edited the test plan for this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26221

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

2020-03-13 Thread Carl Schwan

ognarb added a comment.


  +1 on the general idea
  
  Some remarks:
  
  - Do we want to have an abi and api stability in the Calligra frameworks? or 
do we prefer to do it like in PIM and only guaranty that all the package from a 
certain version are compatible? I think the second option is better at least at 
the beginning since we don't have many third parties users and the only one is 
using submodules with a list of patches anyway.
  
  - I don't think we need to wait for KF6 branching to split the repository. We 
could already start doing the split after the next release but more 
progressively by for example create application repository first and later 
split the rest.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: ognarb
Cc: ognarb, Calligra-Devel-list, #calligra:_3.0, leinir, davidllewellynjones, 
dcaliste, cochise, vandenoever

D29242: WIP: redesign sidebar

2020-04-27 Thread Carl Schwan

ognarb created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
ognarb requested review of this revision.

REPOSITORY
  R8 Calligra

BRANCH
  redesign

REVISION DETAIL
  https://phabricator.kde.org/D29242

AFFECTED FILES
  libs/widgets/KoModeBox.cpp
  libs/widgets/KoModeBoxDocker.cpp
  libs/widgets/KoModeBox_p.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/TextTool.h
  plugins/textshape/TextToolFactory.cpp
  plugins/textshape/dialogs/SimpleCharacterWidget.cpp

To: ognarb
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D29242: WIP: redesign sidebar

2020-04-28 Thread Carl Schwan

ognarb added a comment.


  There is a mockup here: T12837  this is 
really WIP I just created the diff because I asked someone to help me with a 
part of the code and I needed to show them the code.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D29242: WIP: redesign sidebar

2020-04-28 Thread Carl Schwan

ognarb planned changes to this revision.
ognarb added a comment.

  In D29242#658883 , @boemann wrote:

  > Well you are definitely in the right class to make such changes.
  >
  > The thing is the current  code was made to adopt to many different user 
wishes - so the user could choose
  >
  > What you are doing is to throw all that away - would it be impossible to 
have this new way as a mode so we don't throw away the old but enhance it with 
something new.
  >
  > I don't mind if the new mode becomes default

  The idea is to remove some of the configuration possibility: for example only 
allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top 
and bottom was completely broken anyway so I don't think many people did it).

  For the TabBar orientation, I'm trying to create only the the one in the 
first mockup from manueljlin and then add then probably the also the one from 
the last mockup. This is really WIP and I didn't thought it would be send to 
the mailing list :/

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29242

To: ognarb, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

2020-04-29 Thread Carl Schwan

ognarb updated this revision to Diff 81490.
ognarb added a comment.


  - More work in progress change
  
  TODO
  
  - don't make KoModeBox public
  - Implement add shapes action
  - Figure out how to draw line seperator
  - Fix some issues found when applying the Breeze ToolArea patch

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29242?vs=81390&id=81490

BRANCH
  redesign

REVISION DETAIL
  https://phabricator.kde.org/D29242

AFFECTED FILES
  libs/widgets/CMakeLists.txt
  libs/widgets/KoModeBox.cpp
  libs/widgets/KoModeBoxDocker.cpp
  libs/widgets/KoModeBoxFactory.cpp
  libs/widgets/KoModeBox_p.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/TextTool.h
  plugins/textshape/TextToolFactory.cpp
  plugins/textshape/dialogs/SimpleCharacterWidget.cpp
  plugins/textshape/dialogs/SimpleCharacterWidget.ui
  words/part/KWGui.cpp
  words/part/KWGui.h
  words/part/KWView.cpp
  words/part/calligrawords.rc

To: ognarb, boemann
Cc: anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D25714: [WIP]: Port away from deprecated KHtml

2020-04-29 Thread Carl Schwan

ognarb added a comment.


  I forgot about this diff. Now that I looked again I found a flaw in the 
migrations: QDomDocument only supports valid XML files but there are valid HTML 
files that aren't valid XML files. So probably QDomDocument is not a solution :(

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D25714: [WIP]: Port away from deprecated KHtml

2021-01-12 Thread Carl Schwan

ognarb abandoned this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, blu-base, 
davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

Re: Minimum dependency versions

2021-02-10 Thread Carl Schwan

Le mercredi, février 10, 2021 7:45 PM, Pierre  a écrit :

> On Wednesday, February 10, 2021 9:30:43 AM CET Adam Pigg wrote:
>
> > I wish!!! ... try qt 5.6!
> > On Wed, 10 Feb 2021 at 08:14, Halla Rempt b...@valdyas.org wrote:
> >
> > > On Wednesday, 10 February 2021 08:44:54 CET Pierre wrote:
> > >
> > > > Is there a lot of people still trying to build Calligra with Qt 5.3 or
> > > > KF5
> > > > 5.7.0 ? These are years old, and I guess building Calligra with them has
> > > > been untested for some time.
> > >
> > > I think that the Jolla people still build the documents application with
> > > Qt 5.9.
> > > --
> > > https://www.krita.org
>
> I created this MR then :
> https://invent.kde.org/office/calligra/-/merge_requests/10
>
> At least it's no longer Qt 5.3 / KF 5.7, and a bunch of deprecated stuff is
> cleaned up (I built locally disabling deprecated Qt APIs).
>
> But Jolla decided to stay at Qt 5.6 out of fear from LGPLv3, as far as I
> understand. Does it means Calligra would have to be stuck in an untested
> setup? I no longer have a Jolla phone, do they update from Calligra
> frequently? And is there a lot of people still building with Qt 5.6 and
> testing so we are sure there is no regressions there?

Hi,

Your MR looks good to me. Concerning the minimum version requirement, I worked
a bit last year to remove a lot of warnings and I was blocked to move further
by the minimum requirements.

Personally, I'm not sure if it is worth continuing to support Qt 5.6. Calligra 
can't
continue to use on Qt 5.6 as the minimum required version for years when we are
moving to Qt 6 in a timespan of 1 or 2 years with the rest of KDE. Also as
you said I'm not sure anyone is testing regressions and the Gemini QML code
is definitively using Qt 5.12 only code. Jolla needs to move forwards with their
LGPLv3 problem or they will end up obsolete compared to the rest of the Qt 
world.

I would propose moving all the way to Qt 5.12 or even 5.15, so we can start
fixing deprecations in time for Qt6. And maybe in the second step, we should
consider moving to C++17 too.

Regards,
Carl

Re: Minimum dependency versions

2021-02-11 Thread Carl Schwan

‐‐‐ Original Message ‐‐‐
Le mercredi, février 10, 2021 11:48 PM, Pierre  a écrit :

> On Wednesday, February 10, 2021 8:45:23 PM CET Camilla Boemann wrote:
>
> > I agree let's move ahead. We can't be defined by what Jolla does and needs
> > However let's only do it if development is going to pick up. No need to
> > annoy Jolla and then for everything to stall.
>
> Well if everything stalls, it won't be an issue for them since they won't have
> much to gain from updating anyway…
>
> Should we proceed one LTS at a time, or just jump to 5.12, disable deprecated
> APIs and move forward from there?

5.12 looks like a good target for me since it is what is supported by both 
Ubuntu
20.04 and openSUSE Leap.

Re: Minimum dependency versions

2021-02-11 Thread Carl Schwan

‐‐‐ Original Message ‐‐‐
Le jeudi, février 11, 2021 10:50 AM, Dan Leinir Turthra Jensen 
 a écrit :

> On Wednesday, 10 February 2021 22:48:53 GMT Pierre wrote:
>
> > On Wednesday, February 10, 2021 8:45:23 PM CET Camilla Boemann wrote:
> >
> > > I agree let's move ahead. We can't be defined by what Jolla does and needs
> > > However let's only do it if development is going to pick up. No need to
> > > annoy Jolla and then for everything to stall.
> >
> > Well if everything stalls, it won't be an issue for them since they won't
> > have much to gain from updating anyway…
> > Should we proceed one LTS at a time, or just jump to 5.12, disable
> > deprecated APIs and move forward from there?
>
> Hm... Not super sure, but given the amount of effort we'll need to pour into
> that anyway, would it make sense for us to split off a Calligra 4 branch for
> Qt6 work at this point (or call master that branch, and put v3 into a branch)?
> Or does that seem premature, and perhaps it would make more sense for
> preparation work to be done on a branch with a Qt 5.15 requirement? (which
> supposedly will make the port to qt6 simpler when it does happen)
> I realise that's not answering any questions, but also it feels like
> probably a decision we'll really want to be making sooner rather than later,
> so we can avoid time passing us by again...

IHMO thinking about porting to Qt 6 is a bit premature considering the state of
Calligra, KF6 and Qt6. Let's first try to port to a recent Qt5 version before
thinking about :)


>
> 
>
> ..dan / leinir..
> http://leinir.dk/

Re: Proposed release calendar

2021-03-21 Thread Carl Schwan

Le dimanche, mars 21, 2021 10:42 PM, Pierre  a écrit :

> Hi everyone
>
> I was looking at our current changelog in master, and while we don't have much
> to show regarding new features, several stability fixes were added, and the Qt
> 5.15 compatibility may come in handy for distributors.
> Since I don't know of any release calendar/planning, I would like to suggest
> the following approximate calendar :
>
> -   end of month : 3.3 alpha 1, targeting 3.3 stable in the following months
> -   end of 2021 : 3.4, switch dependencies to Qt 5.15 / KF 5.80, aka big-jump-
> proofness
>
> From a feature point of view, I have no plan, but I guess moving to Qt 
> 5.15
> won't take that much time so there will be some things to show…
>
> Is this ok for everybody?

Sound good to me. I would additionally propose to already use Qt 5.15 in Gemini
qml code. First, because we are already using stuff from >Qt 5.7 (QQC2/Kirigami)
and also because this code is not important for the downstream user but using
the lastest thing from Kirigami would allows us to build a better UI.

I already did a few cleanup MR:

* https://invent.kde.org/office/calligra/-/merge_requests/25
* https://invent.kde.org/office/calligra/-/merge_requests/26

Cheers,
Carl

>
> Regards
>
> Pierre
>

1 2 >

1 - 100 of 105 matches

Mail list logo