ognarb updated this revision to Diff 70755. ognarb marked 7 inline comments as done. ognarb added a comment.
Thanks for the review David. I will now follow your advice and continue porting away from QSignalMapper. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25664?vs=70695&id=70755 BRANCH arcpatch-D25664 REVISION DETAIL https://phabricator.kde.org/D25664 AFFECTED FILES libs/widgets/KoDialog.cpp libs/widgets/KoDialog_p.h plugins/formulashape/KoFormulaTool.cpp plugins/formulashape/KoFormulaTool.h plugins/textediting/spellcheck/SpellCheckMenu.cpp plugins/textediting/spellcheck/SpellCheckMenu.h plugins/textshape/TextTool.cpp plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp plugins/textshape/dialogs/SimpleParagraphWidget.cpp plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp plugins/textshape/dialogs/SimpleTableOfContentsWidget.h words/plugins/scripting/Tool.h To: ognarb, #calligra:_3.0, #kf6, dfaure Cc: dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever
