Re: [calligra] /: added retina compatible icon support for osx
Am Freitag, 11. Januar 2013, 14:33:49 schrieb Yuë Liu: > On Fri, Jan 11, 2013 at 1:18 PM, Jaroslaw Staniek wrote: > > On 11 January 2013 18:57, Friedrich W. H. Kossebau wrote: > >>> added retina compatible icon support for osx > >>> REVIEW: 107753 > >> > >> after having removed the karbon, kexi, krita app icons from the > >> oxygen-iconset I found out that I, other than thought, had not yet > >> completely removed them: in the subdir scalable/apps/small of the > >> oxygen-iconset there are also SVGs from which the small pixmaps are > >> done, e.g.: > >> scalable/apps/small/48x48/kexi.svgz > >> scalable/apps/small/48x48/krita.svgz > >> scalable/apps/small/48x48/karbon.svgz > >> > >> See > >> http://websvn.kde.org/trunk/kdesupport/oxygen-icons/scalable/apps/small/4 > >> 8x48 > >> > >> Looking into the icons which were added to the Calligra repo in this > >> commit of yours it seems all those svgz for the small icons are missing. > >> > >> So can you tell who did the current icons? > >> Were those small svgz ignored on purpose? Or simply forgotten/unknown? > >> If the latter, could those small-version svgz be copied to Calligra, > >> debranded from KOffice and then used to create the small pixmaps > >> replacing the current ones? > > I didn't realize there are small pixel svgzs. I grabbed calligra icons > from wikipedia. > > >> I think the small icon pixmaps made from the special small svgz files > >> look > >> better, more crispy and less blurred due to less detail and more pixel > >> alignment, cmp. e.g. the old > >> http://websvn.kde.org/*checkout*/branches/KDE/4.10/oxygen- > >> icons/32x32/apps/karbon.png?revision=1328624&pathrev=1328624 > >> with the new > >> https://projects.kde.org/projects/calligra/repository/revisions/master/en > >> try/karbon/pics/app/hi32- app-karbon.png > >> > >> So the additional svgz for the small pixmaps are worth it to keep IMHO. > >> Would you agree? > > Yes those are much better. But a problem is those icons are designed > for koffice, they still have the K logo on top, have to remove that > logo before generate icons. Yes, that is what I meant with "debranded from KOffice" :) I just also removed the svgz icons from the oxygen iconset, with commit http://websvn.kde.org/?view=revision&revision=1333097 so if you want to copy these files you need to do a checkout of trunk/kdesupport/oxygen- icons/scalable with max revision 1333096. The script http://websvn.kde.org/trunk/KDE/kdesdk/scripts/optimizegraphics?view=log to optimize the pngs you know already, right? Just mentioning in case you missed it before :) Cheers Friedrich ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 107913: Kexi: Add "Save As" action for any database object
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107913/#review25640 --- Ship it! looks good for me - Oleg Kukharchuk On Dec. 26, 2012, 12:04 a.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107913/ > --- > > (Updated Dec. 26, 2012, 12:04 a.m.) > > > Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, and > Radosław Wicik. > > > Description > --- > > Kexi: Add "Save As" action for any database object > > - it's long awaited feature > - the operation works on server side if possible > - since the action is less frequently used, its place is in the "Main Menu" > of the object itself, a new feature of Kexi 2.7 GUI > > > Diffs > - > > kexi/core/KexiMainWindowIface.h 7bc7ed0b63a320fbe1bd34b4a69c8398cd5abd7c > kexi/core/KexiView.h 491b0fb69698f369c7b64d50f76c28b4c8bc31c9 > kexi/core/KexiView.cpp 1ad591c6147624128aeaf6901f99bb64c94eb944 > kexi/core/KexiWindow.h ca0cdc601423894241f14fd286e861398beba993 > kexi/core/KexiWindow.cpp fb0a8dc6d21197a22c80bf1e77f9a2435e56bd45 > kexi/core/kexiproject.h 639eff1c5d4abe7cffc7deff0b40fe9ef7a97898 > kexi/core/kexiproject.cpp 239a95e96673ebb144bc2396d33ad820ea002c31 > kexi/main/KexiMainWindow.h cf21691f1298cd70537acf1957ea774ab0dea762 > kexi/main/KexiMainWindow.cpp a6fe369f86b4149d586b2c724d3e30d4a70414ad > kexi/plugins/tables/kexitabledesignerview.h > 2290364712fd619f15fcd4d63ba46e77cb9f465b > kexi/plugins/tables/kexitabledesignerview.cpp > 754dc6c1814dfd13f19f5fcd5a2eb828f34edba7 > kexi/plugins/tables/kexitablepart.cpp > 08842ba07d70095966cabbd21f3894c951235ea9 > kexi/widget/KexiNameDialog.h aededf0034d6edc2924531566e8a8df7d6601e83 > kexi/widget/KexiNameDialog.cpp 91ac5ed259be7cc96dfa5960490b36c09f90 > kexi/widget/KexiNameWidget.h 6430f5be09f6cc7ce88186c062dcfd0d34c4bfe6 > libs/db/connection.h c37119f9fa382b97920328bee010ccb8b94d2bca > libs/db/connection.cpp 97f1234eaf22976961830f9be3f48e58a273cc44 > > Diff: http://git.reviewboard.kde.org/r/107913/diff/ > > > Testing > --- > > Tested with all types of Kexi objects, tested all overwriting cases > > > Screenshots > --- > > Save As action in Table Designer > http://git.reviewboard.kde.org/r/107913/s/930/ > > > Thanks, > > Jarosław Staniek > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 107913: Kexi: Add "Save As" action for any database object
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107913/#review25641 --- Ship it! looks good for me - Oleg Kukharchuk On Dec. 26, 2012, 12:04 a.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107913/ > --- > > (Updated Dec. 26, 2012, 12:04 a.m.) > > > Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, and > Radosław Wicik. > > > Description > --- > > Kexi: Add "Save As" action for any database object > > - it's long awaited feature > - the operation works on server side if possible > - since the action is less frequently used, its place is in the "Main Menu" > of the object itself, a new feature of Kexi 2.7 GUI > > > Diffs > - > > kexi/core/KexiMainWindowIface.h 7bc7ed0b63a320fbe1bd34b4a69c8398cd5abd7c > kexi/core/KexiView.h 491b0fb69698f369c7b64d50f76c28b4c8bc31c9 > kexi/core/KexiView.cpp 1ad591c6147624128aeaf6901f99bb64c94eb944 > kexi/core/KexiWindow.h ca0cdc601423894241f14fd286e861398beba993 > kexi/core/KexiWindow.cpp fb0a8dc6d21197a22c80bf1e77f9a2435e56bd45 > kexi/core/kexiproject.h 639eff1c5d4abe7cffc7deff0b40fe9ef7a97898 > kexi/core/kexiproject.cpp 239a95e96673ebb144bc2396d33ad820ea002c31 > kexi/main/KexiMainWindow.h cf21691f1298cd70537acf1957ea774ab0dea762 > kexi/main/KexiMainWindow.cpp a6fe369f86b4149d586b2c724d3e30d4a70414ad > kexi/plugins/tables/kexitabledesignerview.h > 2290364712fd619f15fcd4d63ba46e77cb9f465b > kexi/plugins/tables/kexitabledesignerview.cpp > 754dc6c1814dfd13f19f5fcd5a2eb828f34edba7 > kexi/plugins/tables/kexitablepart.cpp > 08842ba07d70095966cabbd21f3894c951235ea9 > kexi/widget/KexiNameDialog.h aededf0034d6edc2924531566e8a8df7d6601e83 > kexi/widget/KexiNameDialog.cpp 91ac5ed259be7cc96dfa5960490b36c09f90 > kexi/widget/KexiNameWidget.h 6430f5be09f6cc7ce88186c062dcfd0d34c4bfe6 > libs/db/connection.h c37119f9fa382b97920328bee010ccb8b94d2bca > libs/db/connection.cpp 97f1234eaf22976961830f9be3f48e58a273cc44 > > Diff: http://git.reviewboard.kde.org/r/107913/diff/ > > > Testing > --- > > Tested with all types of Kexi objects, tested all overwriting cases > > > Screenshots > --- > > Save As action in Table Designer > http://git.reviewboard.kde.org/r/107913/s/930/ > > > Thanks, > > Jarosław Staniek > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/ --- Review request for Calligra and C. Boemann. Description --- Hardcoding to gray works with black text on white background, but not so nice with other colors. So I propose to use instead the textcolor with some transparency to paint the background of an inline object. Should have the same effect like the original setting, but also work and look nice with other color conditions. Diffs - libs/textlayout/KoTextDocumentLayout.cpp 15548d7 Diff: http://git.reviewboard.kde.org/r/108439/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/#review25661 --- Cool idea! Can you attach a couple of screenshots so we can see the effect? - Inge Wallin On Jan. 16, 2013, 2:21 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108439/ > --- > > (Updated Jan. 16, 2013, 2:21 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > Hardcoding to gray works with black text on white background, but not so nice > with other colors. > > So I propose to use instead the textcolor with some transparency to paint the > background of an inline object. > Should have the same effect like the original setting, but also work and look > nice with other color conditions. > > > Diffs > - > > libs/textlayout/KoTextDocumentLayout.cpp 15548d7 > > Diff: http://git.reviewboard.kde.org/r/108439/diff/ > > > Testing > --- > > > Thanks, > > Friedrich W. H. Kossebau > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 107913: Kexi: Add "Save As" action for any database object
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107913/#review25673 --- This review has been submitted with commit e2431d4255a539964ecc92c42ce750c3e0d2efe4 by Jaroslaw Staniek to branch master. - Commit Hook On Dec. 26, 2012, 12:04 a.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107913/ > --- > > (Updated Dec. 26, 2012, 12:04 a.m.) > > > Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, and > Radosław Wicik. > > > Description > --- > > Kexi: Add "Save As" action for any database object > > - it's long awaited feature > - the operation works on server side if possible > - since the action is less frequently used, its place is in the "Main Menu" > of the object itself, a new feature of Kexi 2.7 GUI > > > Diffs > - > > kexi/core/KexiMainWindowIface.h 7bc7ed0b63a320fbe1bd34b4a69c8398cd5abd7c > kexi/core/KexiView.h 491b0fb69698f369c7b64d50f76c28b4c8bc31c9 > kexi/core/KexiView.cpp 1ad591c6147624128aeaf6901f99bb64c94eb944 > kexi/core/KexiWindow.h ca0cdc601423894241f14fd286e861398beba993 > kexi/core/KexiWindow.cpp fb0a8dc6d21197a22c80bf1e77f9a2435e56bd45 > kexi/core/kexiproject.h 639eff1c5d4abe7cffc7deff0b40fe9ef7a97898 > kexi/core/kexiproject.cpp 239a95e96673ebb144bc2396d33ad820ea002c31 > kexi/main/KexiMainWindow.h cf21691f1298cd70537acf1957ea774ab0dea762 > kexi/main/KexiMainWindow.cpp a6fe369f86b4149d586b2c724d3e30d4a70414ad > kexi/plugins/tables/kexitabledesignerview.h > 2290364712fd619f15fcd4d63ba46e77cb9f465b > kexi/plugins/tables/kexitabledesignerview.cpp > 754dc6c1814dfd13f19f5fcd5a2eb828f34edba7 > kexi/plugins/tables/kexitablepart.cpp > 08842ba07d70095966cabbd21f3894c951235ea9 > kexi/widget/KexiNameDialog.h aededf0034d6edc2924531566e8a8df7d6601e83 > kexi/widget/KexiNameDialog.cpp 91ac5ed259be7cc96dfa5960490b36c09f90 > kexi/widget/KexiNameWidget.h 6430f5be09f6cc7ce88186c062dcfd0d34c4bfe6 > libs/db/connection.h c37119f9fa382b97920328bee010ccb8b94d2bca > libs/db/connection.cpp 97f1234eaf22976961830f9be3f48e58a273cc44 > > Diff: http://git.reviewboard.kde.org/r/107913/diff/ > > > Testing > --- > > Tested with all types of Kexi objects, tested all overwriting cases > > > Screenshots > --- > > Save As action in Table Designer > http://git.reviewboard.kde.org/r/107913/s/930/ > > > Thanks, > > Jarosław Staniek > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/ --- (Updated Jan. 16, 2013, 6:14 p.m.) Review request for Calligra and C. Boemann. Changes --- Added some screenshots... Description --- Hardcoding to gray works with black text on white background, but not so nice with other colors. So I propose to use instead the textcolor with some transparency to paint the background of an inline object. Should have the same effect like the original setting, but also work and look nice with other color conditions. Diffs - libs/textlayout/KoTextDocumentLayout.cpp 15548d7 Diff: http://git.reviewboard.kde.org/r/108439/diff/ Testing --- File Attachments (updated) Black on white http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedBlackWhite.png Red on white http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedWhite.png Red on blue http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedBlue.png Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/#review25680 --- Ship it! thanks a lot - C. Boemann On Jan. 16, 2013, 6:14 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108439/ > --- > > (Updated Jan. 16, 2013, 6:14 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > Hardcoding to gray works with black text on white background, but not so nice > with other colors. > > So I propose to use instead the textcolor with some transparency to paint the > background of an inline object. > Should have the same effect like the original setting, but also work and look > nice with other color conditions. > > > Diffs > - > > libs/textlayout/KoTextDocumentLayout.cpp 15548d7 > > Diff: http://git.reviewboard.kde.org/r/108439/diff/ > > > Testing > --- > > > File Attachments > > > Black on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedBlackWhite.png > Red on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedWhite.png > Red on blue > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedBlue.png > > > Thanks, > > Friedrich W. H. Kossebau > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/#review25681 --- This review has been submitted with commit cdb84aeb098a582ab32f65143005636b6139e640 by Friedrich W. H. Kossebau to branch master. - Commit Hook On Jan. 16, 2013, 6:14 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108439/ > --- > > (Updated Jan. 16, 2013, 6:14 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > Hardcoding to gray works with black text on white background, but not so nice > with other colors. > > So I propose to use instead the textcolor with some transparency to paint the > background of an inline object. > Should have the same effect like the original setting, but also work and look > nice with other color conditions. > > > Diffs > - > > libs/textlayout/KoTextDocumentLayout.cpp 15548d7 > > Diff: http://git.reviewboard.kde.org/r/108439/diff/ > > > Testing > --- > > > File Attachments > > > Black on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedBlackWhite.png > Red on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedWhite.png > Red on blue > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedBlue.png > > > Thanks, > > Friedrich W. H. Kossebau > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/#review25688 --- Ship it! Good work! BTW: I encourage to keep these screenshots for the visual tour of 2.7 or so. - Jarosław Staniek On Jan. 16, 2013, 6:14 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108439/ > --- > > (Updated Jan. 16, 2013, 6:14 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > Hardcoding to gray works with black text on white background, but not so nice > with other colors. > > So I propose to use instead the textcolor with some transparency to paint the > background of an inline object. > Should have the same effect like the original setting, but also work and look > nice with other color conditions. > > > Diffs > - > > libs/textlayout/KoTextDocumentLayout.cpp 15548d7 > > Diff: http://git.reviewboard.kde.org/r/108439/diff/ > > > Testing > --- > > > File Attachments > > > Black on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedBlackWhite.png > Red on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedWhite.png > Red on blue > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedBlue.png > > > Thanks, > > Friedrich W. H. Kossebau > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 108424: updated modebox for words,sheets,author
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108424/#review25692 --- I agree with Inge that the tabs are too big and it might get even worse with languages which use longer words like german. I'm wondering if it might be better to just show the icons on the tabs or at least have an option for that. Another thing that might be interesting to try would be to move the tabs to the other side of the docker. Usually you don't need to switch between tool that often. Currently you have move over the tabs each time you want to change a setting. - Sven Langkamp On Jan. 15, 2013, 12:34 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108424/ > --- > > (Updated Jan. 15, 2013, 12:34 p.m.) > > > Review request for Calligra, Inge Wallin, Marijn Kruisselbrink, and Thorsten > Zachmann. > > > Description > --- > > I've changed the modebox away from using qtoolbox to a tab bar and stacked > widget > > In the future i hope stage can use this too so that is why i include Thorsten > specfically too. > > > Diffs > - > > libs/main/KoModeBox.cpp 8b49f6e > libs/main/KoModeBox_p.h c437757 > > Diff: http://git.reviewboard.kde.org/r/108424/diff/ > > > Testing > --- > > played with it, without problems > > > Thanks, > > C. Boemann > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 108444: Fix cash on creating new character style
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108444/ --- Review request for Calligra and Friedrich W. H. Kossebau. Description --- When creating a new character style, Words crashed because an null pointer was passed around and used. Also, the name of the style was not updated. This addresses bug 313233. http://bugs.kde.org/show_bug.cgi?id=313233 Diffs - plugins/textshape/dialogs/StylesModel.cpp 80ea48d plugins/textshape/dialogs/StyleManager.cpp c561d35 plugins/textshape/dialogs/StyleManager.h a45a58a plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83 plugins/textshape/dialogs/CharacterGeneral.cpp d3eead6 Diff: http://git.reviewboard.kde.org/r/108444/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
