----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/#review25688 -----------------------------------------------------------
Ship it! Good work! BTW: I encourage to keep these screenshots for the visual tour of 2.7 or so. - Jarosław Staniek On Jan. 16, 2013, 6:14 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108439/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2013, 6:14 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > ------- > > Hardcoding to gray works with black text on white background, but not so nice > with other colors. > > So I propose to use instead the textcolor with some transparency to paint the > background of an inline object. > Should have the same effect like the original setting, but also work and look > nice with other color conditions. > > > Diffs > ----- > > libs/textlayout/KoTextDocumentLayout.cpp 15548d7 > > Diff: http://git.reviewboard.kde.org/r/108439/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Black on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedBlackWhite.png > Red on white > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedWhite.png > Red on blue > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/VariablesMarkedRedBlue.png > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
