Today's calligrasheets crashes

2012-11-30 Thread Philip Van Hoof 
Today's CalligraSheets crashes:

pvanhoof@lors:~/repos/kde4/calligra-build/sheets$ cd ../../calligra
pvanhoof@lors:~/repos/kde4/calligra$ git pull
Already up-to-date.
pvanhoof@lors:~/repos/kde4/calligra$ git branch
* master
pvanhoof@lors:~/repos/kde4/calligra$ 

I have no patches of my own 

pvanhoof@lors:~$ gdb calligrasheets
GNU gdb (GDB) 7.4.1-debian
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i486-linux-gnu".
For bug reporting instructions, please see:
...
Reading symbols from /usr/local/bin/calligrasheets...done.
(gdb) run
Starting program: /usr/local/bin/calligrasheets 
[Thread debugging using libthread_db enabled]
Using host libthread_db library 
"/lib/i386-linux-gnu/i686/cmov/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0xb79c8be7 in KParts::ReadWritePart::isReadWrite() const () from 
/usr/lib/libkparts.so.4
(gdb) bt
#0  0xb79c8be7 in KParts::ReadWritePart::isReadWrite() const () from 
/usr/lib/libkparts.so.4
#1  0xb7e6c632 in KoDocument::setAutoSave (this=0x82c5fb0, delay=300) at 
/home/pvanhoof/repos/kde4/calligra/libs/main/KoDocument.cpp:509
#2  0xaf1fb121 in KoDocument::KoDocument(QWidget*, QObject*, bool, 
KUndo2Stack*) () from /usr/lib/libkomain.so.9
#3  0xaf06a7bf in Calligra::Sheets::DocBase::DocBase(QWidget*, QObject*, bool) 
() from /usr/lib/libcalligrasheetsodf.so.9
#4  0xaf403a05 in Calligra::Sheets::Doc::Doc(QWidget*, QObject*, bool) () from 
/usr/lib/libcalligrasheetscommon.so.9
#5  0xaf408732 in Calligra::Sheets::Factory::create(char const*, QWidget*, 
QObject*, QList const&, QString const&) () from 
/usr/lib/libcalligrasheetscommon.so.9
#6  0xb7e7d6e1 in create (args=..., keyword=..., parent=, parentWidget=, this=) at 
/usr/include/kpluginfactory.h:531
#7  createInstance (error=, args=..., parent=, parentWidget=, this=) at 
/usr/include/kservice.h:559
#8  createInstance (error=, args=..., parent=, this=) at /usr/include/kservice.h:536
#9  KoDocumentEntry::createKoPart (this=0x0, errorMsg=0xb0a4) at 
/home/pvanhoof/repos/kde4/calligra/libs/main/KoDocumentEntry.cpp:53
#10 0xb7e632d5 in KoApplication::start (this=0xb250) at 
/home/pvanhoof/repos/kde4/calligra/libs/main/KoApplication.cpp:194
#11 0xb7fde410 in kdemain (argc=1, argv=0xb344) at 
/home/pvanhoof/repos/kde4/calligra/sheets/part/Main.cpp:41
#12 0x080487ab in main (argc=1, argv=0xb344) at 
/home/pvanhoof/repos/kde4/calligra-build/sheets/calligrasheets_dummy.cpp:3
(gdb) up
#1  0xb7e6c632 in KoDocument::setAutoSave (this=0x82c5fb0, delay=300) at 
/home/pvanhoof/repos/kde4/calligra/libs/main/KoDocument.cpp:509
509 if (d->parentPart->isReadWrite() && d->autoSaveDelay > 0)
(gdb) print d
warning: can't find linker symbol for virtual table for `KoDocument' value
warning:   found `construction vtable for KoDocument-in-Calligra::Sheets::Doc' 
instead
$1 = (KoDocument::Private * const) 0xb7fd4c94
(gdb) print d->parentPart
warning: can't find linker symbol for virtual table for `KoDocument' value
warning:   found `construction vtable for KoDocument-in-Calligra::Sheets::Doc' 
instead
$2 = (KoPart *) 0xb5f55570
(gdb) print * d->parentPart
warning: can't find linker symbol for virtual table for `KoDocument' value
warning:   found `construction vtable for KoDocument-in-Calligra::Sheets::Doc' 
instead
$3 = { = {}, static staticMetaObject = 
{d = {superdata = 0xb79f8e50, stringdata = 0xb7f81ee0 "KoPart", data = 
0xb7f81fa0, extradata = 0xb7fd86c8}}, static staticMetaObjectExtraData = {
objects = 0x0, static_metacall = 0xb7f1a3e0 
}, d = 
0xb48dc3f3}
(gdb) 


pvanhoof@lors:~/repos/kde4/calligra-build$ cd sheets/
pvanhoof@lors:~/repos/kde4/calligra-build/sheets$ gdb ./calligrasheets
GNU gdb (GDB) 7.4.1-debian
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i486-linux-gnu".
For bug reporting instructions, please see:
...
Reading symbols from 
/home/pvanhoof/repos/kde4/calligra-build/sheets/calligrasheets...done.
(gdb) run
Starting program: 
/home/pvanhoof/repos/kde4/calligra-build/sheets/calligrasheets 
[Thread debugging using libthread_db enabled]
Using host libthread_db library 
"/lib/i386-linux-gnu/i686/cmov/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0xb79c8be7 in KParts::ReadWritePart::isReadWrite() const () from 
/usr/lib/libkparts.so.4
(gdb) 




-- 


Philip Van Hoof
Software developer
Codeminded BVBA - http://codemind

Re: Today's calligrasheets crashes

2012-11-30 Thread Philip Van Hoof 

For your information, it's a Debian testing with:

pvanhoof@lors:~/repos/kde4/calligra-build$ dpkg -s libkparts4 | grep Version
Version: 4:4.8.4-4
pvanhoof@lors:~/repos/kde4/calligra-build$ 

On Fri, 2012-11-30 at 09:38 +0100, Philip Van Hoof wrote:
> Today's CalligraSheets crashes:
> 
> pvanhoof@lors:~/repos/kde4/calligra-build/sheets$ cd ../../calligra
> pvanhoof@lors:~/repos/kde4/calligra$ git pull
> Already up-to-date.
> pvanhoof@lors:~/repos/kde4/calligra$ git branch
> * master
> pvanhoof@lors:~/repos/kde4/calligra$ 
> 
> I have no patches of my own 
> 
> pvanhoof@lors:~$ gdb calligrasheets
> GNU gdb (GDB) 7.4.1-debian
> Copyright (C) 2012 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "i486-linux-gnu".
> For bug reporting instructions, please see:
> ...
> Reading symbols from /usr/local/bin/calligrasheets...done.
> (gdb) run
> Starting program: /usr/local/bin/calligrasheets 
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library 
> "/lib/i386-linux-gnu/i686/cmov/libthread_db.so.1".
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0xb79c8be7 in KParts::ReadWritePart::isReadWrite() const () from 
> /usr/lib/libkparts.so.4
> (gdb) bt
> #0  0xb79c8be7 in KParts::ReadWritePart::isReadWrite() const () from 
> /usr/lib/libkparts.so.4
> #1  0xb7e6c632 in KoDocument::setAutoSave (this=0x82c5fb0, delay=300) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoDocument.cpp:509
> #2  0xaf1fb121 in KoDocument::KoDocument(QWidget*, QObject*, bool, 
> KUndo2Stack*) () from /usr/lib/libkomain.so.9
> #3  0xaf06a7bf in Calligra::Sheets::DocBase::DocBase(QWidget*, QObject*, 
> bool) () from /usr/lib/libcalligrasheetsodf.so.9
> #4  0xaf403a05 in Calligra::Sheets::Doc::Doc(QWidget*, QObject*, bool) () 
> from /usr/lib/libcalligrasheetscommon.so.9
> #5  0xaf408732 in Calligra::Sheets::Factory::create(char const*, QWidget*, 
> QObject*, QList const&, QString const&) () from 
> /usr/lib/libcalligrasheetscommon.so.9
> #6  0xb7e7d6e1 in create (args=..., keyword=..., parent= out>, parentWidget=, this=) at 
> /usr/include/kpluginfactory.h:531
> #7  createInstance (error=, args=..., 
> parent=, parentWidget=, this=) 
> at /usr/include/kservice.h:559
> #8  createInstance (error=, args=..., 
> parent=, this=) at /usr/include/kservice.h:536
> #9  KoDocumentEntry::createKoPart (this=0x0, errorMsg=0xb0a4) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoDocumentEntry.cpp:53
> #10 0xb7e632d5 in KoApplication::start (this=0xb250) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoApplication.cpp:194
> #11 0xb7fde410 in kdemain (argc=1, argv=0xb344) at 
> /home/pvanhoof/repos/kde4/calligra/sheets/part/Main.cpp:41
> #12 0x080487ab in main (argc=1, argv=0xb344) at 
> /home/pvanhoof/repos/kde4/calligra-build/sheets/calligrasheets_dummy.cpp:3
> (gdb) up
> #1  0xb7e6c632 in KoDocument::setAutoSave (this=0x82c5fb0, delay=300) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoDocument.cpp:509
> 509   if (d->parentPart->isReadWrite() && d->autoSaveDelay > 0)
> (gdb) print d
> warning: can't find linker symbol for virtual table for `KoDocument' value
> warning:   found `construction vtable for 
> KoDocument-in-Calligra::Sheets::Doc' instead
> $1 = (KoDocument::Private * const) 0xb7fd4c94
> (gdb) print d->parentPart
> warning: can't find linker symbol for virtual table for `KoDocument' value
> warning:   found `construction vtable for 
> KoDocument-in-Calligra::Sheets::Doc' instead
> $2 = (KoPart *) 0xb5f55570
> (gdb) print * d->parentPart
> warning: can't find linker symbol for virtual table for `KoDocument' value
> warning:   found `construction vtable for 
> KoDocument-in-Calligra::Sheets::Doc' instead
> $3 = { = {}, static staticMetaObject = 
> {d = {superdata = 0xb79f8e50, stringdata = 0xb7f81ee0 "KoPart", data = 
> 0xb7f81fa0, extradata = 0xb7fd86c8}}, static staticMetaObjectExtraData = {
> objects = 0x0, static_metacall = 0xb7f1a3e0 
> }, d = 
> 0xb48dc3f3}
> (gdb) 
> 
> 
> pvanhoof@lors:~/repos/kde4/calligra-build$ cd sheets/
> pvanhoof@lors:~/repos/kde4/calligra-build/sheets$ gdb ./calligrasheets
> GNU gdb (GDB) 7.4.1-debian
> Copyright (C) 2012 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "i486-linux-gnu".
> For bug reporting instructions, please see:
> ...
> Reading symbols from 
> /home/pvanhoof/repos/kde4/calligra-build/sheets/calligrasheets...do

Re: Review Request: Move /kdgantt/ to /3rdparty/kdgantt/ and make a real dynamic library out of it.

2012-11-30 Thread Boudewijn Rempt 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107410/#review22803
---


Wasn't this pushed already?

- Boudewijn Rempt


On Nov. 21, 2012, 7:37 p.m., Inge Wallin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107410/
> ---
> 
> (Updated Nov. 21, 2012, 7:37 p.m.)
> 
> 
> Review request for Calligra and Dag Andersen.
> 
> 
> Description
> ---
> 
> This patch moves the kdgantt library that was previously in the top directory 
> into a subdirectory called 3rdparty/. This was suggested in a discussion on 
> IRC as a way to keep 3rdparty library sources collected in one place.
> 
> More importantly it also creates a real dynamically loaded library from it 
> and discards the old method of including the sources wherever the "library" 
> was used. This is specifically in Plan. The reason for doing this is that 
> building Plan totally fails on Windows without this patch.
> 
> After this patch is OK'ed and merged, I will continue with KDChart which is 
> now residing inside the chart shape but which is also used in e.g. Kexi.
> 
> Many thanks go to Ben Cooksley and Stuart McDickson for testing and difficult 
> bugfixing. CMake is tricky :)
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt PRE-CREATION 
>   3rdparty/kdgantt/CMakeLists.txt PRE-CREATION 
>   3rdparty/kdgantt/Mainpage.dox PRE-CREATION 
>   3rdparty/kdgantt/Messages.sh PRE-CREATION 
>   3rdparty/kdgantt/docs.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantt_export.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractgrid.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractgrid.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractgrid_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractrowcontroller.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractrowcontroller.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraint.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraint.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraint_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintgraphicsitem.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintgraphicsitem.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintmodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintmodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintmodel_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintproxy.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintproxy.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttdatetimegrid.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttdatetimegrid.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttdatetimegrid_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttforwardingproxymodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttforwardingproxymodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttglobal.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttglobal.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsitem.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsitem.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsscene.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsscene.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsscene_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsview.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsview.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsview_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttitemdelegate.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttitemdelegate.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttitemdelegate_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlegend.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlegend.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttlegend_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlistviewrowcontroller.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlistviewrowcontroller.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttlistviewrowcontroller_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttproxymodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttproxymodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttproxymodel_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttstyleoptionganttitem.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttstyleoptionganttitem.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttsummaryhandlingproxymodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttsummaryhandlingproxymodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttsummaryhandlingproxymodel_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantttimescalezoomdialog.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantttimescalezoomdialog.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdgantttreeviewrowcontroller.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantttreeviewrowcontroller.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdgantttreeviewrowcontroller_p.h PRE-CREATION 
>   3rdparty/kdga

Re: Review Request: Make it possible to override info from author profile via dbus/c++

2012-11-30 Thread Boudewijn Rempt 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107486/#review22807
---

Ship it!


Looks good to me too, please push :-)

- Boudewijn Rempt


On Nov. 27, 2012, 12:14 p.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107486/
> ---
> 
> (Updated Nov. 27, 2012, 12:14 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> It turns out we used to have a way for dbus to set author information.
> 
> This got broken by the author profile changes, so this patch fixes that, by 
> allowing to override the information fetched from author profiles
> 
> ok to backport as well?
> 
> 
> Diffs
> -
> 
>   libs/main/KoDocumentInfo.h d98cab4 
>   libs/main/KoDocumentInfo.cpp 89bcdbe 
> 
> Diff: http://git.reviewboard.kde.org/r/107486/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Today's calligrasheets crashes

2012-11-30 Thread Boudewijn Rempt 
On Friday 30 November 2012 Nov, Philip Van Hoof wrote:
> Today's CalligraSheets crashes:


Hm... Just checking: do you perhaps have two versions of calligra? One 
installed in /usr, one local?

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Today's calligrasheets crashes

2012-11-30 Thread Philip Van Hoof 
Hi Boudewijn,

Yes, I noticed that too.

But uninstalling the Debian testing one didn't solve the problem. Now I
do have a clean crash with the symbols of gdb at the locations in the
source tree of my calligra.

I also think that a installment of Calligra in /usr/local should favor
plugins in /usr/local and not /usr. Such favoring would allow dual
installs of Calligra (with ABI incompatibilities or not).

After uninstall doesn't calligrasheets work anymore, giving me a error
message about having to add a prefix in /etc/kderc. How do I do this?

What I'm trying to do is setting up a development workstation with a
Calligra that can coexist with Debian packaging (that doesn't write
there where my distribution is also writing its packaged software). For
now it's fine that I have to uninstall Debian's own calligra packages.
But having to install calligra in /usr would be :-(

I'm getting this in a error dialog box:
The service '/usr/local/share/applications/kde4/sheets.desktop' provides
no library or the Library key is missing

And this on the console:
pvanhoof@lors:~/repos/kde4/calligra-build$ calligrasheets 
sheets(21492)/kdecore (services) KServiceFactory::findServiceByDesktopPath: 
"sheetspart.desktop" not found
sheets(21492)/kdecore (services) KServiceFactory::findServiceByDesktopPath: 
"Office/sheets.desktop" not found
sheets(21492)/koffice (lib komain) KoDocumentEntry::createKoPart: "The service 
'/usr/local/share/applications/kde4/sheets.desktop' provides no library or the 
Library key is missing" 

Note:
pvanhoof@lors:~/repos/kde4/calligra-build$ cat /etc/kderc 
[Directories]
prefixes=/usr/local
pvanhoof@lors:~/repos/kde4/calligra-build$ 


Kind regards,

Philip


On Fri, 2012-11-30 at 10:39 +0100, Boudewijn Rempt wrote:
> On Friday 30 November 2012 Nov, Philip Van Hoof wrote:
> > Today's CalligraSheets crashes:
> 
> 
> Hm... Just checking: do you perhaps have two versions of calligra? One 
> installed in /usr, one local?
> 

-- 


Philip Van Hoof
Software developer
Codeminded BVBA - http://codeminded.be

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Today's calligrasheets crashes

2012-11-30 Thread Boudewijn Rempt 

On Fri, 30 Nov 2012, Philip Van Hoof wrote:


Hi Boudewijn,

Yes, I noticed that too.

But uninstalling the Debian testing one didn't solve the problem. Now I
do have a clean crash with the symbols of gdb at the locations in the
source tree of my calligra.

I also think that a installment of Calligra in /usr/local should favor
plugins in /usr/local and not /usr. Such favoring would allow dual
installs of Calligra (with ABI incompatibilities or not).

After uninstall doesn't calligrasheets work anymore, giving me a error
message about having to add a prefix in /etc/kderc. How do I do this?

What I'm trying to do is setting up a development workstation with a
Calligra that can coexist with Debian packaging (that doesn't write
there where my distribution is also writing its packaged software). For
now it's fine that I have to uninstall Debian's own calligra packages.


I'm actually not completely sure how hard it would be make it possible to 
co-install a locally compiled calligra with a global calligra, I guess 
it's a matter of .so versioning and plugin version numbers.



But having to install calligra in /usr would be :-(


No, that's not necessary :-). By playing with a number of environment 
variables you can determine which calligra is used. I've got about a dozen 
co-installed on my development system, in fact.




I'm getting this in a error dialog box:
The service '/usr/local/share/applications/kde4/sheets.desktop' provides
no library or the Library key is missing

And this on the console:
pvanhoof@lors:~/repos/kde4/calligra-build$ calligrasheets
sheets(21492)/kdecore (services) KServiceFactory::findServiceByDesktopPath: 
"sheetspart.desktop" not found
sheets(21492)/kdecore (services) KServiceFactory::findServiceByDesktopPath: 
"Office/sheets.desktop" not found
sheets(21492)/koffice (lib komain) KoDocumentEntry::createKoPart: "The service 
'/usr/local/share/applications/kde4/sheets.desktop' provides no library or the Library 
key is missing"

Note:
pvanhoof@lors:~/repos/kde4/calligra-build$ cat /etc/kderc
[Directories]
prefixes=/usr/local
pvanhoof@lors:~/repos/kde4/calligra-build$



For locally installed versions of calligra, the methods given in

http://community.kde.org/Calligra/Building/Building_Calligra#Running_Calligra_applications

work quite well.

--
Boudewijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Today's calligrasheets crashes

2012-11-30 Thread Philip Van Hoof 
Hi everybody,

Ok, so this issue was a mixture of my own confusion with an already
installed Calligra and the fact that the code that uses Calligra that
I'm working on was not yet setting Part to Doc. In a private mail
Boudewijn hinted me to do this.

Part *part = new Part(0);
Doc *doc = new Doc(part);
part->setDocument(doc);

And now it works.

Unfortunately isn't Part.h of sheets/part being installed at this
moment. So I'll provide a patch to add it to the install files in a
minute.

Kind regards, and thanks Boudewijn for the support

Philip


On Fri, 2012-11-30 at 09:38 +0100, Philip Van Hoof wrote:
> Today's CalligraSheets crashes:
> 
> pvanhoof@lors:~/repos/kde4/calligra-build/sheets$ cd ../../calligra
> pvanhoof@lors:~/repos/kde4/calligra$ git pull
> Already up-to-date.
> pvanhoof@lors:~/repos/kde4/calligra$ git branch
> * master
> pvanhoof@lors:~/repos/kde4/calligra$ 
> 
> I have no patches of my own 
> 
> pvanhoof@lors:~$ gdb calligrasheets
> GNU gdb (GDB) 7.4.1-debian
> Copyright (C) 2012 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "i486-linux-gnu".
> For bug reporting instructions, please see:
> ...
> Reading symbols from /usr/local/bin/calligrasheets...done.
> (gdb) run
> Starting program: /usr/local/bin/calligrasheets 
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library 
> "/lib/i386-linux-gnu/i686/cmov/libthread_db.so.1".
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0xb79c8be7 in KParts::ReadWritePart::isReadWrite() const () from 
> /usr/lib/libkparts.so.4
> (gdb) bt
> #0  0xb79c8be7 in KParts::ReadWritePart::isReadWrite() const () from 
> /usr/lib/libkparts.so.4
> #1  0xb7e6c632 in KoDocument::setAutoSave (this=0x82c5fb0, delay=300) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoDocument.cpp:509
> #2  0xaf1fb121 in KoDocument::KoDocument(QWidget*, QObject*, bool, 
> KUndo2Stack*) () from /usr/lib/libkomain.so.9
> #3  0xaf06a7bf in Calligra::Sheets::DocBase::DocBase(QWidget*, QObject*, 
> bool) () from /usr/lib/libcalligrasheetsodf.so.9
> #4  0xaf403a05 in Calligra::Sheets::Doc::Doc(QWidget*, QObject*, bool) () 
> from /usr/lib/libcalligrasheetscommon.so.9
> #5  0xaf408732 in Calligra::Sheets::Factory::create(char const*, QWidget*, 
> QObject*, QList const&, QString const&) () from 
> /usr/lib/libcalligrasheetscommon.so.9
> #6  0xb7e7d6e1 in create (args=..., keyword=..., parent= out>, parentWidget=, this=) at 
> /usr/include/kpluginfactory.h:531
> #7  createInstance (error=, args=..., 
> parent=, parentWidget=, this=) 
> at /usr/include/kservice.h:559
> #8  createInstance (error=, args=..., 
> parent=, this=) at /usr/include/kservice.h:536
> #9  KoDocumentEntry::createKoPart (this=0x0, errorMsg=0xb0a4) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoDocumentEntry.cpp:53
> #10 0xb7e632d5 in KoApplication::start (this=0xb250) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoApplication.cpp:194
> #11 0xb7fde410 in kdemain (argc=1, argv=0xb344) at 
> /home/pvanhoof/repos/kde4/calligra/sheets/part/Main.cpp:41
> #12 0x080487ab in main (argc=1, argv=0xb344) at 
> /home/pvanhoof/repos/kde4/calligra-build/sheets/calligrasheets_dummy.cpp:3
> (gdb) up
> #1  0xb7e6c632 in KoDocument::setAutoSave (this=0x82c5fb0, delay=300) at 
> /home/pvanhoof/repos/kde4/calligra/libs/main/KoDocument.cpp:509
> 509   if (d->parentPart->isReadWrite() && d->autoSaveDelay > 0)
> (gdb) print d
> warning: can't find linker symbol for virtual table for `KoDocument' value
> warning:   found `construction vtable for 
> KoDocument-in-Calligra::Sheets::Doc' instead
> $1 = (KoDocument::Private * const) 0xb7fd4c94
> (gdb) print d->parentPart
> warning: can't find linker symbol for virtual table for `KoDocument' value
> warning:   found `construction vtable for 
> KoDocument-in-Calligra::Sheets::Doc' instead
> $2 = (KoPart *) 0xb5f55570
> (gdb) print * d->parentPart
> warning: can't find linker symbol for virtual table for `KoDocument' value
> warning:   found `construction vtable for 
> KoDocument-in-Calligra::Sheets::Doc' instead
> $3 = { = {}, static staticMetaObject = 
> {d = {superdata = 0xb79f8e50, stringdata = 0xb7f81ee0 "KoPart", data = 
> 0xb7f81fa0, extradata = 0xb7fd86c8}}, static staticMetaObjectExtraData = {
> objects = 0x0, static_metacall = 0xb7f1a3e0 
> }, d = 
> 0xb48dc3f3}
> (gdb) 
> 
> 
> pvanhoof@lors:~/repos/kde4/calligra-build$ cd sheets/
> pvanhoof@lors:~/repos/kde4/calligra-build/sheets$ gdb ./calligrasheets
> GNU gdb (GDB) 7.4.1-debian
> Copyright (C) 2012 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to

Re: [calligra] plugins/dockers/styledocker: Fix bug 309109: CWOP: Opening a document sets it to Modified

2012-11-30 Thread Friedrich W. H. Kossebau 
Am Dienstag, 13. November 2012, 15:31:58 schrieb Inge Wallin:
> Git commit e07ccbb4d52e609a14aacbddb62f4c74edb59028 by Inge Wallin.
> Committed on 13/11/2012 at 15:28.
> Pushed by ingwa into branch 'master'.
> 
> Fix bug 309109: CWOP: Opening a document sets it to Modified
> 
> BUG: 309109

Backport to 2.6?

Cheers
Friedrich
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [calligra] plugins/dockers/styledocker: Fix bug 309109: CWOP: Opening a document sets it to Modified

2012-11-30 Thread Boudewijn Rempt 

On Fri, 30 Nov 2012, Friedrich W. H. Kossebau wrote:


Am Dienstag, 13. November 2012, 15:31:58 schrieb Inge Wallin:

Git commit e07ccbb4d52e609a14aacbddb62f4c74edb59028 by Inge Wallin.
Committed on 13/11/2012 at 15:28.
Pushed by ingwa into branch 'master'.

Fix bug 309109: CWOP: Opening a document sets it to Modified

BUG: 309109


Backport to 2.6?



I think it should be backported

Boudewijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Making the sheet displaying QGraphicsItem CanvasItem of Calligra transparent on a GraphicsScene

2012-11-30 Thread Philip Van Hoof 
Hi there,

I'm trying to make the cells of a spreadsheet document which I have
loaded using sheets/part/CanvasItem.h, which is a GraphicsItem,
transparent.

I tried the following code, but although the result is that the color of
all cells changes, the color it uses isn't transparent but white. Or
perhaps it is transparent but there is something white behind the cells
anyway.

QGraphicsRectItem rect;

Part *part = new Part(0);
Doc *doc = new Doc(part);
part->setDocument(doc);

CanvasItem *m_canvas = new CanvasItem (doc);
m_canvas->setParentItem(&rect);

Sheet *sheet = m_canvas->activeSheet();

Calligra::Sheets::Region region = Calligra::Sheets::Region(1, 1, KS_colMax, 
KS_rowMax);

Style style;
QBrush brush;
brush.setColor(Qt::transparent);
style.setBackgroundBrush(brush);
style.setBackgroundColor(Qt::transparent);

Sheet::BackgroundImageProperties props = sheet->backgroundImageProperties();
props.opacity = 0;
sheet->setBackgroundImageProperties( props );

CellStorage *cells = sheet->cellStorage();
cells->setStyle(region, style);

scene.addItem(&rect);

Does somebody know how I can make it be truly transparent? Is there
something being drawn behind the CellView instances that is white? Like
a background maybe?

I noticed the existence of the API sheet->setBackgroundImageProperties.
As you can see above I tried using it, but it didn't change much.

If I would have to patch Calligra to make this effect possible, where
should I start looking?

Kind regards,

Philip



-- 


Philip Van Hoof
Software developer
Codeminded BVBA - http://codeminded.be

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Making the sheet displaying QGraphicsItem CanvasItem of Calligra transparent on a GraphicsScene

2012-11-30 Thread Boudewijn Rempt 

On Fri, 30 Nov 2012, Philip Van Hoof wrote:


Hi there,

I'm trying to make the cells of a spreadsheet document which I have
loaded using sheets/part/CanvasItem.h, which is a GraphicsItem,
transparent.



Hm... let's see. The basic painting code is in CanvasBase.cpp, where line 
477 says


painter->fillRect(paintRect, painter->background());

But where is the background on the QPainter object set... I think we need 
Mek to figure that out. You could hack your version of sheets' canvasbase 
here to something like


Qt::BGMode bgMode = painter->backgroundMode();
painter->setBackgroundMode(Qt::TransparentMode();

...

painter->setBackgroundMode(bgMode);

sheet->backgroundImageProperties are something different, I think -- it 
must be meant to show an actual image as specified by the document, like a 
watermark.


QGraphicsItem::setOpacity also isn't what you need, since that would set 
the opacity for everything including the cell foregrounds.




I tried the following code, but although the result is that the color of
all cells changes, the color it uses isn't transparent but white. Or
perhaps it is transparent but there is something white behind the cells
anyway.

QGraphicsRectItem rect;

Part *part = new Part(0);
Doc *doc = new Doc(part);
part->setDocument(doc);

CanvasItem *m_canvas = new CanvasItem (doc);
m_canvas->setParentItem(&rect);

Sheet *sheet = m_canvas->activeSheet();

Calligra::Sheets::Region region = Calligra::Sheets::Region(1, 1, KS_colMax, 
KS_rowMax);

Style style;
QBrush brush;
brush.setColor(Qt::transparent);
style.setBackgroundBrush(brush);
style.setBackgroundColor(Qt::transparent);

Sheet::BackgroundImageProperties props = sheet->backgroundImageProperties();
props.opacity = 0;
sheet->setBackgroundImageProperties( props );

CellStorage *cells = sheet->cellStorage();
cells->setStyle(region, style);

scene.addItem(&rect);

Does somebody know how I can make it be truly transparent? Is there
something being drawn behind the CellView instances that is white? Like
a background maybe?

I noticed the existence of the API sheet->setBackgroundImageProperties.
As you can see above I tried using it, but it didn't change much.

If I would have to patch Calligra to make this effect possible, where
should I start looking?

Kind regards,

Philip



--


Philip Van Hoof
Software developer
Codeminded BVBA - http://codeminded.be

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: enable 3rd-party to have semantic items with stylesheets which do not change the text at all

2012-11-30 Thread Friedrich W. H. Kossebau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107534/
---

Review request for Calligra and C. Boemann.


Description
---

There is some serious 3rd-party user of Calligra who sets KoRdfSemanticItems to 
text ranges, but updates the content itself, because the content is not just 
text, but e.g. charts. He does so because the current KoSemanticStylesheet 
assumes there is just text used to display the content of the item.
The inner systen of the KoRdf* classes assume there is always at least one 
stylesheet set for an item, this assumption is assured with some asserts(). 
Removing this assumption will result in quite some changes which I feel I do 
not oversee, as still not too familiar with all that code.

A simple fix I came now up with and which has been tested successfully with the 
3rd-party code is to set the template string of the stylesheet to a special 
string, which the stylesheet detects and if present then will not do any 
changes to the text belonging to the semantic item.

Not nice, but efficient for 2.6 at least.

Should that string be documented in the API dox?
Any better idea for the string?


Diffs
-

  libs/main/rdf/KoSemanticStylesheet.cpp ed0072c 

Diff: http://git.reviewboard.kde.org/r/107534/diff/


Testing
---


Thanks,

Friedrich W. H. Kossebau

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: enable 3rd-party to have semantic items with stylesheets which do not change the text at all

2012-11-30 Thread Boudewijn Rempt 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107534/#review22817
---

Ship it!


Hackish, but if it does the job, fine with me.

- Boudewijn Rempt


On Nov. 30, 2012, 2:11 p.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107534/
> ---
> 
> (Updated Nov. 30, 2012, 2:11 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> ---
> 
> There is some serious 3rd-party user of Calligra who sets KoRdfSemanticItems 
> to text ranges, but updates the content itself, because the content is not 
> just text, but e.g. charts. He does so because the current 
> KoSemanticStylesheet assumes there is just text used to display the content 
> of the item.
> The inner systen of the KoRdf* classes assume there is always at least one 
> stylesheet set for an item, this assumption is assured with some asserts(). 
> Removing this assumption will result in quite some changes which I feel I do 
> not oversee, as still not too familiar with all that code.
> 
> A simple fix I came now up with and which has been tested successfully with 
> the 3rd-party code is to set the template string of the stylesheet to a 
> special string, which the stylesheet detects and if present then will not do 
> any changes to the text belonging to the semantic item.
> 
> Not nice, but efficient for 2.6 at least.
> 
> Should that string be documented in the API dox?
> Any better idea for the string?
> 
> 
> Diffs
> -
> 
>   libs/main/rdf/KoSemanticStylesheet.cpp ed0072c 
> 
> Diff: http://git.reviewboard.kde.org/r/107534/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: enable 3rd-party to have semantic items with stylesheets which do not change the text at all

2012-11-30 Thread C. Boemann 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107534/#review22818
---

Ship it!


yeah hackish, but sure let's have this

- C. Boemann


On Nov. 30, 2012, 2:11 p.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107534/
> ---
> 
> (Updated Nov. 30, 2012, 2:11 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> ---
> 
> There is some serious 3rd-party user of Calligra who sets KoRdfSemanticItems 
> to text ranges, but updates the content itself, because the content is not 
> just text, but e.g. charts. He does so because the current 
> KoSemanticStylesheet assumes there is just text used to display the content 
> of the item.
> The inner systen of the KoRdf* classes assume there is always at least one 
> stylesheet set for an item, this assumption is assured with some asserts(). 
> Removing this assumption will result in quite some changes which I feel I do 
> not oversee, as still not too familiar with all that code.
> 
> A simple fix I came now up with and which has been tested successfully with 
> the 3rd-party code is to set the template string of the stylesheet to a 
> special string, which the stylesheet detects and if present then will not do 
> any changes to the text belonging to the semantic item.
> 
> Not nice, but efficient for 2.6 at least.
> 
> Should that string be documented in the API dox?
> Any better idea for the string?
> 
> 
> Diffs
> -
> 
>   libs/main/rdf/KoSemanticStylesheet.cpp ed0072c 
> 
> Diff: http://git.reviewboard.kde.org/r/107534/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-11-30 Thread Andrey Inishev 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107515/
---

(Updated Nov. 30, 2012, 2:26 p.m.)


Review request for Calligra and Jarosław Staniek.


Description
---

Patch for kexi/core, 
http://www.google-melange.com/gci/task/view/google/gci2012/8009216


Diffs
-

  kexi/core/kexidataiteminterface.h 4258451 
  kexi/core/kexidataiteminterface.cpp a5ad759 
  kexi/core/kexiinternalpart.h 08178ed 
  kexi/core/kexiinternalpart.cpp 253e77d 
  kexi/core/kexipartmanager.h 9cb2356 
  kexi/core/kexipartmanager.cpp cf17f3a 
  kexi/core/kexiprojectconnectiondata.h b88a1f9 
  kexi/core/kexiprojectconnectiondata.cpp 0df2793 
  kexi/core/kexistartupdata.h 2147465 
  kexi/core/kexistartupdata.cpp 45fdd71 
  kexi/core/kexitextmsghandler.h 29adc64 
  kexi/core/kexitextmsghandler.cpp 71011c9 

Diff: http://git.reviewboard.kde.org/r/107515/diff/


Testing
---


Thanks,

Andrey Inishev

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-11-30 Thread Andrey Inishev 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107515/
---

(Updated Nov. 30, 2012, 2:38 p.m.)


Review request for Calligra and Jarosław Staniek.


Description
---

Patch for kexi/core, 
http://www.google-melange.com/gci/task/view/google/gci2012/8009216


Diffs
-

  kexi/core/kexidataiteminterface.h 4258451 
  kexi/core/kexidataiteminterface.cpp a5ad759 
  kexi/core/kexiinternalpart.h 08178ed 
  kexi/core/kexiinternalpart.cpp 253e77d 
  kexi/core/kexipartmanager.h 9cb2356 
  kexi/core/kexipartmanager.cpp cf17f3a 
  kexi/core/kexiprojectconnectiondata.h b88a1f9 
  kexi/core/kexiprojectconnectiondata.cpp 0df2793 
  kexi/core/kexistartupdata.h 2147465 
  kexi/core/kexistartupdata.cpp 45fdd71 
  kexi/core/kexitextmsghandler.h 29adc64 
  kexi/core/kexitextmsghandler.cpp 71011c9 

Diff: http://git.reviewboard.kde.org/r/107515/diff/


Testing
---


Thanks,

Andrey Inishev

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-11-30 Thread Andrey Inishev 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107515/
---

(Updated Nov. 30, 2012, 2:38 p.m.)


Review request for Calligra and Jarosław Staniek.


Description
---

Patch for kexi/core, 
http://www.google-melange.com/gci/task/view/google/gci2012/8009216


Diffs (updated)
-

  kexi/core/kexidataiteminterface.h 4258451 
  kexi/core/kexidataiteminterface.cpp a5ad759 
  kexi/core/kexiinternalpart.h 08178ed 
  kexi/core/kexiinternalpart.cpp 253e77d 
  kexi/core/kexipartmanager.h 9cb2356 
  kexi/core/kexipartmanager.cpp cf17f3a 
  kexi/core/kexiprojectconnectiondata.h b88a1f9 
  kexi/core/kexiprojectconnectiondata.cpp 0df2793 
  kexi/core/kexistartupdata.h 2147465 
  kexi/core/kexistartupdata.cpp 45fdd71 
  kexi/core/kexitextmsghandler.h 29adc64 
  kexi/core/kexitextmsghandler.cpp 71011c9 

Diff: http://git.reviewboard.kde.org/r/107515/diff/


Testing
---


Thanks,

Andrey Inishev

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: enable 3rd-party to have semantic items with stylesheets which do not change the text at all

2012-11-30 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107534/#review22821
---


This review has been submitted with commit 
5a71ddb36ccdd828a4ca30d1835a470dc2f13cdc by Friedrich W. H. Kossebau to branch 
calligra/2.6.

- Commit Hook


On Nov. 30, 2012, 2:11 p.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107534/
> ---
> 
> (Updated Nov. 30, 2012, 2:11 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> ---
> 
> There is some serious 3rd-party user of Calligra who sets KoRdfSemanticItems 
> to text ranges, but updates the content itself, because the content is not 
> just text, but e.g. charts. He does so because the current 
> KoSemanticStylesheet assumes there is just text used to display the content 
> of the item.
> The inner systen of the KoRdf* classes assume there is always at least one 
> stylesheet set for an item, this assumption is assured with some asserts(). 
> Removing this assumption will result in quite some changes which I feel I do 
> not oversee, as still not too familiar with all that code.
> 
> A simple fix I came now up with and which has been tested successfully with 
> the 3rd-party code is to set the template string of the stylesheet to a 
> special string, which the stylesheet detects and if present then will not do 
> any changes to the text belonging to the semantic item.
> 
> Not nice, but efficient for 2.6 at least.
> 
> Should that string be documented in the API dox?
> Any better idea for the string?
> 
> 
> Diffs
> -
> 
>   libs/main/rdf/KoSemanticStylesheet.cpp ed0072c 
> 
> Diff: http://git.reviewboard.kde.org/r/107534/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix Mobi format problems

2012-11-30 Thread mojtaba shahi 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107526/
---

(Updated Nov. 30, 2012, 7:34 p.m.)


Review request for Calligra.


Description
---

This fixes are becuse that Kindle device couldn't open our Mobi format.
The first problem was about html text content that i used for mobi, it was not 
standard, sor for have a standard Mobi html i create OdtMobiHtmlConverter
a copy of OdtHtmlConverter. I changed it t have a one, for that i neede inline 
attributes in elements no CSS, and i think we can merge it to OdtHtmlConverter.

Now with these fixes we support images, bookmarks (not very well), And Kindle 
can open our mobi correct without any problem.


Diffs (updated)
-

  filters/words/mobi/CMakeLists.txt 88633a7 
  filters/words/mobi/MobiFile.cpp 29c3551 
  filters/words/mobi/MobiHeaderGenerator.h 7864620 
  filters/words/mobi/MobiHeaderGenerator.cpp 378a01a 
  filters/words/mobi/OdtMobiHtmlConverter.h PRE-CREATION 
  filters/words/mobi/OdtMobiHtmlConverter.cpp PRE-CREATION 
  filters/words/mobi/PalmDocCompression.h 2c7ed71 
  filters/words/mobi/PalmDocCompression.cpp 4df0067 
  filters/words/mobi/exportmobi.cpp 455b526 

Diff: http://git.reviewboard.kde.org/r/107526/diff/


Testing (updated)
---

I have tested ebooks in Kidle Desktop Previewer for windows.
And also tested on Kidle device too, no problem :)
There is a mobi that i have converted in attach file, it is about mobi format 
but is not completed yet. :) 


Thanks,

mojtaba shahi

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-11-30 Thread Jarosław Staniek 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107515/#review22839
---


I have indicated general problems, please study the d-pointers technique a bit 
more and apply here. Please test compilation of the entire Kexi (no need to 
'make clean'), and run Kexi before submitting updated patch.


kexi/core/kexidataiteminterface.h


We need tp add  void setHasFocusableWidget(bool), otherwise subclasses 
cannot access the attribute, right?



kexi/core/kexidataiteminterface.h


Please move this to the top of kexidataiteminterface.cpp. Also please 
implement constructor and initialize members in it.



kexi/core/kexiinternalpart.h


Please remove inline - it's no longer inline, right?



kexi/core/kexiinternalpart.cpp


This cannot work, you have two definitions, here and in line 100. 
Also please initialize the members properly.



kexi/core/kexiinternalpart.cpp


This cannot be allowed. Instead please use part->uniqueWidget(). Please fix 
all other cases like this in the whole code.



kexi/core/kexipartmanager.h


please remove this #if 0 block



kexi/core/kexipartmanager.h


No need to move it.



kexi/core/kexipartmanager.h


Again, no definition here allowed.



kexi/core/kexipartmanager.cpp


Please just move lines 50-51.



kexi/core/kexiprojectconnectiondata.h


Please just move, not comment out.



kexi/core/kexiprojectconnectiondata.cpp


Build error here...



kexi/core/kexistartupdata.h


Not in header...



kexi/core/kexistartupdata.cpp


Move to Private's constructor.



kexi/core/kexistartupdata.cpp


Memory leak here, you miss 'delete projectData;' in ~Private()



kexi/core/kexitextmsghandler.h


not in header...



kexi/core/kexitextmsghandler.cpp


crash because you did not initialize these pointers in Private's constructor


- Jarosław Staniek


On Nov. 30, 2012, 2:38 p.m., Andrey Inishev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107515/
> ---
> 
> (Updated Nov. 30, 2012, 2:38 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> ---
> 
> Patch for kexi/core, 
> http://www.google-melange.com/gci/task/view/google/gci2012/8009216
> 
> 
> Diffs
> -
> 
>   kexi/core/kexidataiteminterface.h 4258451 
>   kexi/core/kexidataiteminterface.cpp a5ad759 
>   kexi/core/kexiinternalpart.h 08178ed 
>   kexi/core/kexiinternalpart.cpp 253e77d 
>   kexi/core/kexipartmanager.h 9cb2356 
>   kexi/core/kexipartmanager.cpp cf17f3a 
>   kexi/core/kexiprojectconnectiondata.h b88a1f9 
>   kexi/core/kexiprojectconnectiondata.cpp 0df2793 
>   kexi/core/kexistartupdata.h 2147465 
>   kexi/core/kexistartupdata.cpp 45fdd71 
>   kexi/core/kexitextmsghandler.h 29adc64 
>   kexi/core/kexitextmsghandler.cpp 71011c9 
> 
> Diff: http://git.reviewboard.kde.org/r/107515/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix copy paste to include named styles

2012-11-30 Thread Thorsten Zachmann 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107495/#review22853
---

Ship it!


Good work. Nice idea on how it is implemented.


- Thorsten Zachmann


On Nov. 29, 2012, 9:12 a.m., C. Boemann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107495/
> ---
> 
> (Updated Nov. 29, 2012, 9:12 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> ---
> 
> This patch fixes copy/paste by
>  1) saving the used styles to clipboard as well
>  2) only add a style if another style named the same doesn't exist already
> 
> 
> Diffs
> -
> 
>   libs/kotext/KoTextDrag.cpp 9f2d537 
>   libs/kotext/KoTextOdfSaveHelper.h 39107ef 
>   libs/kotext/KoTextOdfSaveHelper.cpp e01e651 
>   libs/kotext/opendocument/KoTextWriter.cpp 0d52062 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 4439769 
>   libs/kotext/styles/KoStyleManager.h ae2e720 
>   libs/kotext/styles/KoStyleManager.cpp 2aa74fe 
> 
> Diff: http://git.reviewboard.kde.org/r/107495/diff/
> 
> 
> Testing
> ---
> 
> Some basic cut and paste with variations of styles applied
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel