----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107534/#review22817 -----------------------------------------------------------
Ship it! Hackish, but if it does the job, fine with me. - Boudewijn Rempt On Nov. 30, 2012, 2:11 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107534/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2012, 2:11 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > ------- > > There is some serious 3rd-party user of Calligra who sets KoRdfSemanticItems > to text ranges, but updates the content itself, because the content is not > just text, but e.g. charts. He does so because the current > KoSemanticStylesheet assumes there is just text used to display the content > of the item. > The inner systen of the KoRdf* classes assume there is always at least one > stylesheet set for an item, this assumption is assured with some asserts(). > Removing this assumption will result in quite some changes which I feel I do > not oversee, as still not too familiar with all that code. > > A simple fix I came now up with and which has been tested successfully with > the 3rd-party code is to set the template string of the stylesheet to a > special string, which the stylesheet detects and if present then will not do > any changes to the text belonging to the semantic item. > > Not nice, but efficient for 2.6 at least. > > Should that string be documented in the API dox? > Any better idea for the string? > > > Diffs > ----- > > libs/main/rdf/KoSemanticStylesheet.cpp ed0072c > > Diff: http://git.reviewboard.kde.org/r/107534/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
