Re: [Mesa-dev] COMPSIZE function in OpenGL XML registry

2015-06-10 Thread Ian Romanick
On 06/10/2015 11:25 AM, Shervin Sharifi wrote: > Hi, > > This may not be the right forum to ask this, but I didn't know of a > better forum, so I thought I can ask here. > > I'm new to OpenGL. I am looking at XML registry for OpenGL and there > are some parameters with attributes containing a

Re: [Mesa-dev] COMPSIZE function in OpenGL XML registry

2015-06-10 Thread Ian Romanick
functions (via ), but it doesn't look like it has any information about how much data goes along with it. :( > Thanks, >Shervin > > On Wed, Jun 10, 2015 at 2:56 PM, Ian Romanick <mailto:i...@freedesktop.org>> wrote: > > On 06/10/2015 11:25 AM, Shervin Sh

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/x11: Set version of swrastLoader to 2

2015-06-16 Thread Ian Romanick
Gak... I thought we fixed all of those. :( Reviewed-by: Ian Romanick On 06/15/2015 08:08 PM, Boyan Ding wrote: > which it actually implements instead of the newest version defined in > dri_interface.h > > Cc: "10.5 10.6" > Signed-off-by: Boyan Ding > --- > sr

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-18 Thread Ian Romanick
On 06/17/2015 10:53 PM, Julien Isorce wrote: > From: Jon TURNEY > > On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on > linux. > > For the moment, apply a cast to supress the warning > > Possibly this is safe, as for the mesa software renderer the shader program > han

Re: [Mesa-dev] [PATCH 1/2] glsl: Specify the shader stage in linker errors due to too many in/outputs.

2015-06-22 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/19/2015 06:08 AM, Jose Fonseca wrote: > --- > src/glsl/link_varyings.cpp | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp > index 7b2d4

Re: [Mesa-dev] [PATCH 1/2] glsl: handle conversions to double when comparing param matches

2015-06-22 Thread Ian Romanick
This seems believable... is there a piglit test? On 06/17/2015 12:15 PM, Ilia Mirkin wrote: > This allows mod(int, int) to become selected as float mod when doubles > are supported. > > Signed-off-by: Ilia Mirkin > Cc: "10.6" > --- > src/glsl/ir_function.cpp | 8 +--- > 1 file changed, 5 i

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix counting of varyings.

2015-06-22 Thread Ian Romanick
On 06/19/2015 06:08 AM, Jose Fonseca wrote: > When input and output varyings started to be counted separately (commit > 42305fb5) the is_varying_var function wasn't updated to return true for > output varyings or input varyings for stages other than the fragment > shader), effectively making the va

Re: [Mesa-dev] abundance of branches in mesa.git

2015-06-22 Thread Ian Romanick
On 06/22/2015 10:40 AM, Marek Olšák wrote: > I will happily remove the branch after the kernel driver lands. > > I also wonder why all Mesa developers can force-push branches in Mesa > but not libdrm. That's probably just historical. We probably ought to restrict that on Mesa as well. It sounds

Re: [Mesa-dev] [PATCH 00/11] glapi fixes - build whole of mesa with

2015-06-22 Thread Ian Romanick
On 06/22/2015 07:01 AM, Jose Fonseca wrote: > On 19/06/15 23:09, Emil Velikov wrote: >> On 19 June 2015 at 21:26, Jose Fonseca wrote: >>> On 19/06/15 20:56, Emil Velikov wrote: Hi all, A lovely series inspired (more like 'was awaken to send these out') by Pal Rohár, who wa

[Mesa-dev] [PATCH] radeon: Advertise correct GL_SAMPLES_PASSED value.

2015-06-22 Thread Ian Romanick
From: Ian Romanick Commit b765119c changed the default value of all the counter bits to 64. However, older hardware only has 32 counter bits. This has only been build-tested. We don't have any tests that verify the advertised value against implementation behavior, so I don't

Re: [Mesa-dev] [RFC] Compatibility between old dri modules and new loaders, and vice verse

2015-06-22 Thread Ian Romanick
On 06/22/2015 11:54 AM, Dave Airlie wrote: >> >> As kindly hinted by Marek, currently we do have a wide selection of >> supported dri <> loader combinations. >> >> Although we like to think that things never break, we have to admit >> that not many of us test every possible combinations of dri modu

Re: [Mesa-dev] [PATCH] Fix strict-aliasing violations in GLSL shader list implementation

2015-06-23 Thread Ian Romanick
On 06/23/2015 02:36 PM, Thomas Helland wrote: > 2015-06-24 23:05 GMT+02:00 Davin McCall : >> Hi - I'm new here. >> >> I've recently started poking the Mesa codebase for little reason other than >> personal interest. In the "help wanted" section of the website it mentions >> aliasing violations as a

Re: [Mesa-dev] [PATCH] Fix strict-aliasing violations in GLSL shader list implementation

2015-06-23 Thread Ian Romanick
On 06/24/2015 03:59 PM, Davin McCall wrote: > Hi Ian, > > On 23/06/15 23:26, Ian Romanick wrote: >> On 06/23/2015 02:36 PM, Thomas Helland wrote: >>> 2015-06-24 23:05 GMT+02:00 Davin McCall : >>>> Hi - I'm new here. >>>> >>>> I

Re: [Mesa-dev] [PATCH] Fix strict-aliasing violations in GLSL shader list implementation

2015-06-23 Thread Ian Romanick
On 06/23/2015 07:01 PM, Dave Airlie wrote: > On 24 June 2015 at 11:44, Ian Romanick wrote: >> On 06/24/2015 03:59 PM, Davin McCall wrote: >>> Hi Ian, >>> >>> On 23/06/15 23:26, Ian Romanick wrote: >>>> On 06/23/2015 02:36 PM, Thomas Helland wrot

Re: [Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

2015-07-09 Thread Ian Romanick
ion (the > only __DRIversion outside of dri1 land). Should we move it into radeon > and/or bump the min. required drm module version ? > > Cc: Ian Romanick Reviewed-by: Ian Romanick I think the cleanups suggested by Michel and Emil sound like a good idea too, FWIW. > Cc: Ma

Re: [Mesa-dev] [PATCH 04/11] dri_interface: drop __NOT_HAVE_DRM_H magic

2015-07-09 Thread Ian Romanick
On 07/08/2015 10:07 AM, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > include/GL/internal/dri_interface.h | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/include/GL/internal/dri_interface.h > b/include/GL/internal/dri_interface.h > index c827bb6..c0545b1 100644

Re: [Mesa-dev] [PATCH 06/11] loader: use HAVE_LIBDRM instead of ! __NOT_HAVE_DRM_H

2015-07-09 Thread Ian Romanick
I can't really speak to the Android.mk or SConscript changes, but the rest of this patch is Reviewed-by: Ian Romanick You might also see what Jeremy Huddleston Sequoia thinks, since most of this exists to support his platform. :) On 07/08/2015 10:07 AM, Emil Velikov wrote: > Double n

Re: [Mesa-dev] [PATCH 1/6] mesa: move check for no-op glFrontFace call earlier

2015-07-20 Thread Ian Romanick
Patches 1, 2, and 3 are Reviewed-by: Ian Romanick The other patches look correct too, but the whole series is optimizations, so do you have any before / after performance data? On 07/17/2015 05:48 PM, Brian Paul wrote: > If the new mode matches the current mode, there can be no er

Re: [Mesa-dev] [PATCH 4/6] mesa: optimize _math_matrix_set_identity() and return a bool result

2015-07-20 Thread Ian Romanick
On 07/17/2015 05:48 PM, Brian Paul wrote: > Skip memcpy() calls, etc. if the matrix is already the identity. Return > true/false to indicate if we're really changing the matrix or not. > --- > src/mesa/math/m_matrix.c | 23 +++ > src/mesa/math/m_matrix.h | 2 +- > 2 files cha

Re: [Mesa-dev] [PATCH 04/11] dri_interface: drop __NOT_HAVE_DRM_H magic

2015-07-20 Thread Ian Romanick
On 07/09/2015 01:12 PM, Emil Velikov wrote: > On 9 July 2015 at 18:50, Ian Romanick wrote: >> On 07/08/2015 10:07 AM, Emil Velikov wrote: >>> Signed-off-by: Emil Velikov >>> --- >>> include/GL/internal/dri_interface.h | 11 --- >>> 1 file

Re: [Mesa-dev] [PATCH 06/18] i965: Pass the map-mode along to intel_mipmap_tree_map_raw()

2015-07-20 Thread Ian Romanick
On 07/06/2015 03:33 AM, Chris Wilson wrote: > Since we can distinguish when mapping between READ and WRITE, we can > pass along the map mode to avoid stalls and flushes where possible. > > Signed-off-by: Chris Wilson > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28 > ++---

Re: [Mesa-dev] [PATCH v2] dri_interface: drop __NOT_HAVE_DRM_H magic

2015-07-21 Thread Ian Romanick
Reviewed-by: Ian Romanick On 07/21/2015 09:07 AM, Emil Velikov wrote: > v2: use HAVE_LIBDRM macro. > > Cc: Ian Romanick > Signed-off-by: Emil Velikov > --- > include/GL/internal/dri_interface.h | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > &

Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-07-22 Thread Ian Romanick
On 06/26/2015 07:38 AM, Ilia Mirkin wrote: > On Fri, Jun 26, 2015 at 4:18 AM, Tapani Pälli wrote: >> >> >> On 06/26/2015 01:06 AM, Ilia Mirkin wrote: >>> >>> On Thu, Jun 25, 2015 at 4:22 PM, Ilia Mirkin wrote: On Thu, Jun 25, 2015 at 5:08 AM, Marta Lofstedt wrote: > > From

Re: [Mesa-dev] [PATCH 1/9] glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00

2015-10-12 Thread Ian Romanick
On 10/09/2015 07:01 PM, Matt Turner wrote: > On Fri, Oct 9, 2015 at 6:52 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> In d4a24745 (August 2012), Paul made functions calls not be constant >> expressions in GLSL ES 1.00. Since this feature was added in deskto

Re: [Mesa-dev] [PATCH 2/9] ff_fragment_shader: Use binding to set the sampler unit

2015-10-12 Thread Ian Romanick
On 10/09/2015 07:03 PM, Matt Turner wrote: > On Fri, Oct 9, 2015 at 6:52 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This is the way layout(binding=xxx) works from GLSL. The old method >> just happened to work (and significantly predated support for >>

Re: [Mesa-dev] [PATCH 8/9] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

2015-10-12 Thread Ian Romanick
On 10/09/2015 07:14 PM, Matt Turner wrote: > On Fri, Oct 9, 2015 at 6:53 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Fixes: >> ES3-CTS.shaders.negative.constant_sequence >> >> spec/glsl-es-3.00/compiler/global-initializer/from-sequence

[Mesa-dev] [PATCH] i965: Fix is-renderable check in intel_image_target_renderbuffer_storage

2015-10-15 Thread Ian Romanick
From: Ian Romanick Previously we could create a renderbuffer with format MESA_FORMAT_R8G8B8A8_UNORM, convert that renderbuffer to an EGLImage, then FAIL to convert the EGLImage back to a renderbuffer because reasons. Just use the same check in intel_image_target_renderbuffer_storage that

Re: [Mesa-dev] [Mesa-stable] [RFC 01/21] mesa/texcompress: Restrict FXT1 format to desktop GL subset

2015-10-20 Thread Ian Romanick
dteximage2d_width_height_max_cube_neg_z > * > dEQP-GLES2.functional.negative_api.texture.compressedteximage2d_width_height_max_cube_pos_x > * > dEQP-GLES2.functional.negative_api.texture.compressedteximage2d_width_height_max_cube_pos_y > * > dEQP-GLES2.functional.negative_api.texture.compressedteximage2d_width_height_max_cube_pos_z >

Re: [Mesa-dev] [RFC 01/21] mesa/texcompress: Restrict FXT1 format to desktop GL subset

2015-10-20 Thread Ian Romanick
ght_max_cube_neg_y > > * > > dEQP-GLES2.functional.negative_api.texture.compressedteximage2d_width_height_max_cube_neg_z > > * > > dEQP-GLES2.functional.negative_api.texture.compressedteximage2d_width_height_max_cube_pos_x > > * > > dEQP-

Re: [Mesa-dev] [PATCH 1/4] mesa: Draw indirect is not allowed if the default VAO is bound.

2015-10-21 Thread Ian Romanick
On 10/20/2015 10:22 AM, Ilia Mirkin wrote: > On Tue, Oct 20, 2015 at 10:19 AM, Marta Lofstedt > wrote: >> From: Marta Lofstedt >> >> From OpenGL ES 3.1 specification, section 10.5: >> "DrawArraysIndirect requires that all data sourced for the >> command, including the DrawArraysIndirectCommand >>

Re: [Mesa-dev] [PATCH 2/4] mesa: Draw Indirect is not allowed when no vertex array binding exists.

2015-10-21 Thread Ian Romanick
On 10/21/2015 07:32 AM, Lofstedt, Marta wrote: >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On >> Behalf Of Tapani Pälli >> Sent: Wednesday, October 21, 2015 1:25 PM >> To: Marek Olšák >> Cc: mesa-dev@lists.freedesktop.org >> Subject: Re: [Mesa-dev

Re: [Mesa-dev] [PATCH 3/4] mesa: Draw Indirect return wrong error code on unalinged

2015-10-21 Thread Ian Romanick
On 10/20/2015 01:03 PM, Ilia Mirkin wrote: > On Tue, Oct 20, 2015 at 10:19 AM, Marta Lofstedt > wrote: >> From: Marta Lofstedt >> >> From OpenGL 4.4 specification, section 10.4 and >> Open GL Es 3.1 section 10.5: >> "An INVALID_VALUE error is generated if indirect is not a multiple >> of the size

Re: [Mesa-dev] [PATCH v2] mesa/meta: Use interpolateAtOffset for 16x MSAA copy blit

2015-10-21 Thread Ian Romanick
On 09/29/2015 07:57 AM, Neil Roberts wrote: > Previously there was a problem in i965 where if 16x MSAA is used then > some of the sample positions are exactly on the 0 x or y axis. When > the MSAA copy blit shader interpolates the texture coordinates at > these sample positions it was possible that

Re: [Mesa-dev] [PATCH v2] mesa: Draw Indirect return wrong error code on unalinged

2015-10-26 Thread Ian Romanick
Reviewed-by: Ian Romanick On 10/26/2015 03:22 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > From OpenGL 4.4 specification, section 10.4 and > Open GL Es 3.1 section 10.5: > "An INVALID_VALUE error is generated if indirect is not a multiple > of the size, in basic

Re: [Mesa-dev] [PATCH v2] mesa: Draw indirect is not allowed when xfb is active and unpaused

2015-10-26 Thread Ian Romanick
Reviewed-by: Ian Romanick On 10/26/2015 03:50 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > OpenGL ES 3.1 specification, section 10.5: > "An INVALID_OPERATION error is generated if > transform feedback is active and not paused." > > Signed-off-by: Marta L

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Enable ASTC in GLES' [NUM_]COMPRESSED_TEXTURE_FORMATS queries

2015-10-26 Thread Ian Romanick
Reviewed-by: Ian Romanick On 10/21/2015 03:06 PM, Nanley Chery wrote: > From: Nanley Chery > > In OpenGL ES, the COMPRESSED_TEXTURE_FORMATS query returns the set of > supported specific compressed formats. Since ASTC formats fit within > that category, include them in the set

Re: [Mesa-dev] [PATCH 3/5] glsl: Mark gl_ViewportIndex and gl_Layer varyings as flat.

2015-10-26 Thread Ian Romanick
On 10/26/2015 11:03 AM, Kenneth Graunke wrote: > Integer varyings need to be flat qualified - all others were already. > I think we just missed this. Presumably some hardware passes this via > sideband and ignores attribute interpolation, so no one has noticed. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] i965: Set correct field for indirect align16 addrimm.

2015-10-26 Thread Ian Romanick
On 10/26/2015 11:10 AM, Matt Turner wrote: > This has been wrong since the initial import of the i965 driver. That is awesome. Other than using the assembly validator, is there any way to trigger this? I assume you discovered this bug by inspection... > --- > src/mesa/drivers/dri/i965/brw_eu_e

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix error type for GetFramebufferAttachmentParameteriv

2015-10-27 Thread Ian Romanick
On 10/27/2015 12:11 AM, Tapani Pälli wrote: > Fixes following failing dEQP test: >dEQP-GLES3.functional.fbo.api.attachment_query_empty_fbo > > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92649 > Cc: "11.0" > --- > src/mesa/main/fbobject.c | 5 +++-- >

[Mesa-dev] [PATCH] i965: Do legacy userclipping in OpenGL ES 1.x contexts.

2015-10-27 Thread Ian Romanick
From: Ian Romanick Commit fba4823a disabled user clipping for everything except compatibility profile. Core profile and OpenGL ES 2.0+ have all removed the classic, OpenGL 1.0 user clip planes. ES 1.x, however, still has them. Fixes OpenGL ES 1.1 conformance mustpass.c and userclip.c Signed

Re: [Mesa-dev] [PATCH] mesa/teximage: Fix ASTC-caused S3TC regression

2015-10-28 Thread Ian Romanick
On 10/28/2015 09:52 AM, Nanley Chery wrote: > From: Nanley Chery > > The ASTC spec forbids other compressed formats from being used against > the targets: TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Because other I apologize for not paying very much attention to this previously. I think we're taking

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Ian Romanick
On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h | 19 +++ > src/glsl/nir/nir_pass.c | 64 > - > 2 files changed, 82 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h > in

Re: [Mesa-dev] [PATCH 05/11] nir/phis_to_scalar: Use the nir_pass framework internally

2015-10-28 Thread Ian Romanick
On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_lower_phis_to_scalar.c | 25 - > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c > b/src/glsl/nir/nir_lower_phis_to_scalar.c > index aa124d9..9

Re: [Mesa-dev] [PATCH 07/11] nir: Use the nir_pass framework internally for copy_prop, dce, and cse

2015-10-28 Thread Ian Romanick
On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_opt_copy_propagate.c | 17 - > src/glsl/nir/nir_opt_cse.c| 21 - > src/glsl/nir/nir_opt_dce.c| 20 > 3 files changed, 24 insertions(+), 34 deletio

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-28 Thread Ian Romanick
On 10/28/2015 04:43 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir.h | 19 +++ >&g

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] [v3] i965/skl: Add GT4 PCI IDs

2015-10-30 Thread Ian Romanick
On 10/29/2015 05:30 PM, Ben Widawsky wrote: > Like other gen8+ hardware, the hardware automatically scales up thread counts > and URB sizes, so there is no need to do anything but add the PCI IDs. Give the v3 change, is that really true? > FINISHME: This patch still needs testing before merge. >

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-30 Thread Ian Romanick
On 10/28/2015 09:26 PM, Ilia Mirkin wrote: > On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: >> People often complain about the way that open-source projects are so nit >> picky about coding standards. It's a necessary survival tactic. Mesa >> is 22 years

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-30 Thread Ian Romanick
On 10/28/2015 06:30 PM, Kenneth Graunke wrote: > On Wednesday, October 28, 2015 05:04:07 PM Ian Romanick wrote: >> On 10/28/2015 04:43 PM, Connor Abbott wrote: >>> On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >>>> On 10/28/2015 02:32 PM, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-10-30 Thread Ian Romanick
On 10/28/2015 06:15 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: >> On 10/28/2015 04:43 PM, Connor Abbott wrote: >>> On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >>>> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >&

Re: [Mesa-dev] [PATCH 00/11] nir: Add a pass management framework

2015-10-30 Thread Ian Romanick
On 10/28/2015 10:01 PM, Jason Ekstrand wrote: > > On Oct 28, 2015 9:12 PM, "Kenneth Graunke" > wrote: >> >> On Wednesday, October 28, 2015 02:58:07 PM Kristian Høgsberg wrote: >> > On Wed, Oct 28, 2015 at 2:34 PM, Jason Ekstrand > mailto:ja...@jlekstrand.net>> wrote:

Re: [Mesa-dev] [PATCH 3/5] glsl: Mark gl_ViewportIndex and gl_Layer varyings as flat.

2015-10-30 Thread Ian Romanick
On 10/26/2015 05:29 PM, Kenneth Graunke wrote: > On Monday, October 26, 2015 05:02:07 PM Ian Romanick wrote: >> On 10/26/2015 11:03 AM, Kenneth Graunke wrote: >>> Integer varyings need to be flat qualified - all others were already. >>> I think we just missed this. Pres

Re: [Mesa-dev] [PATCH] i965: Replace default case with list of enum values.

2015-10-30 Thread Ian Romanick
On 10/29/2015 05:52 PM, Matt Turner wrote: > If we add a new file type, we'd like to get warnings if it's not > handled. > > Unfortuately, gcc seems to have bugs (see the XXX). Did you submit a GCC bug? Assuming there are not warnings added, this patch is Rev

Re: [Mesa-dev] [PATCH] i965: Clean up FBH code.

2015-10-30 Thread Ian Romanick
BRW_PREDICATE_NORMAL; > + inst->src[0].negate = true; This seems like a separate cleanup? If you choose to split it into a separate patch, that patch is Reviewed-by: Ian Romanick >break; > } > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp > b/

Re: [Mesa-dev] [PATCH] Expose support for OES/EXT_draw_elements_base_vertex to OpenGL ES.

2015-11-02 Thread Ian Romanick
GL_OES_depth_texture_cube_map", >> o(OES_depth_texture_cube_map), ES2, 2012 }, >> + { "GL_OES_draw_elements_base_vertex", >> o(ARB_draw_elements_base_vertex), ES2, 2014 }, >> { &

Re: [Mesa-dev] [PATCH 1/3] mesa: restrict ES2 from 32-bit blending, add GL_EXT_float_blend

2015-11-02 Thread Ian Romanick
On 11/02/2015 04:50 PM, Ilia Mirkin wrote: > GL_EXT_color_buffer_float adds support for float buffers in ES3.0+, but > explicitly disallows 32-bit blending. However this restriction was never > implemented in mesa. > > Add the restriction, and also allow a driver to expose > GL_EXT_float_blend whi

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

2015-11-02 Thread Ian Romanick
On 10/28/2015 04:43 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir.h | 19 +++ >&g

Re: [Mesa-dev] [PATCH] glsl: Relax requirement on Centroid matching between shader stages

2015-11-06 Thread Ian Romanick
On 11/04/2015 01:04 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > In OpenGL 4.4, section 4.5, the requirement for interpolation > qualifiers to match over shader stages was removed. > In OpenGL ES 3.1, section 9.2.1 there is a table showing that > centroid does not have to match between sh

Re: [Mesa-dev] [PATCH v3 1/8] glapi: Add EXT_blend_func_extended XML definitions

2015-11-06 Thread Ian Romanick
On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/mapi/glapi/gen/EXT_gpu_shader4.xml | 3 ++- > src/mapi/glapi/gen/es_EXT.xml | 26 ++ > src/mesa/main/tests/dispatch_sanity.cpp | 8 > 3 files changed, 36 insertions(+), 1 deletion(-) > > diff --gi

Re: [Mesa-dev] [PATCH v3 6/8] mesa: Enable usage of blend_func_extended blend factors

2015-11-06 Thread Ian Romanick
On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/mesa/main/blend.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c > index 20aa498..185e30e 100644 > --- a/src/mesa/main/blend.c > +++ b/src/mesa/main/blend.c > @@ -67,

Re: [Mesa-dev] [PATCH v3 7/8] mesa: Allow MAX_DUAL_SOURCE_DRAW_BUFFERS to be available to ES

2015-11-06 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/mesa/main/get_hash_params.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/get_hash_params.py > b/src/mesa/main/get_hash_params.

Re: [Mesa-dev] [PATCH v3 4/8] glsl: Add GL_EXT_blend_func_extended preprocessor define

2015-11-06 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/glsl/glcpp/glcpp-parse.y | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y > index 4acccf7..10bf83f 100644 >

Re: [Mesa-dev] [PATCH v3 5/8] glsl: Add a parse check to check for the index layout qualifier

2015-11-06 Thread Ian Romanick
On 11/05/2015 06:47 PM, Ryan Houdek wrote: > This can only be used if EXT_blend_func_extended is enabled > --- > src/glsl/glsl_parser.yy | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy > index 4636435..40e60e5 100644 > --- a/src/glsl

Re: [Mesa-dev] [PATCH v3 3/8] glsl: Add support for the new builtins that EXT_blend_func_extended provides.

2015-11-06 Thread Ian Romanick
On 11/05/2015 06:47 PM, Ryan Houdek wrote: > gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported > > Only for ESSL 1.0 it provides two builtins since you can't have user-defined > color output variables > gl_SecondaryFragColorEXT and gl_SecondaryFragDataEXT[MaxDSDrawBuffers] > --- >

Re: [Mesa-dev] FOSDEM16: Graphics DevRoom: call for speakers.

2015-11-09 Thread Ian Romanick
On 10/31/2015 09:43 AM, Luc Verhaegen wrote: > Hi, > > At FOSDEM on sunday 31st of january 2016, there will be another graphics > DevRoom. URL: https://fosdem.org/2016/ > > At first, I wanted to skip another year (like in 2011), as speaker > turn-out was disgracefully low last year. But when i

Re: [Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-09 Thread Ian Romanick
On 11/04/2015 03:55 PM, Jason Ekstrand wrote: > Here's some shader-db numbers: > > total instructions in shared programs: 6236146 -> 6255385 (0.31%) > instructions in affected programs: 203629 -> 222868 (9.45%) > helped:118 > HURT:

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-09 Thread Ian Romanick
On 11/04/2015 03:26 PM, Ryan Houdek wrote: > I'm hoping to potentially convince about lowering the minimum > requirement of EXT_buffer_storage from ES 3.1 to ES 3.0. > The only thing that causes it to require ES 3.1 is glMemoryBarrier, > which shouldn't really be a hard requirement since the extens

[Mesa-dev] [PATCH 00/23] Don't pollute the buffer object namespace in meta

2015-11-09 Thread Ian Romanick
In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-generated names: you can use any name you want for a particular object type until you call the Gen functio

[Mesa-dev] [PATCH 04/23] mesa: Refactor enable_vertex_array_attrib to make _mesa_enable_vertex_array_attrib

2015-11-09 Thread Ian Romanick
From: Ian Romanick Pulls the parts of enable_vertex_array_attrib that aren't just parameter validation out into a function that can be called from other parts of Mesa (e.g., meta). _mesa_enable_vertex_array_attrib can also be used to enable fixed-function arrays. Signed-off-by: Ian Rom

[Mesa-dev] [PATCH 13/23] meta: Track VBO using gl_buffer_object instead of GL API object handle

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c| 69 +++ src/mesa/drivers/common/meta.h| 19 --- src/mesa/drivers/common/meta_blit.c | 11 ++-- src/mesa/drivers/common

[Mesa-dev] [PATCH 20/23] meta: Don't pollute the buffer object namespace in _mesa_meta_DrawTex

2015-11-09 Thread Ian Romanick
From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-gene

[Mesa-dev] [PATCH 15/23] meta: Use internal functions for buffer object and VAO access

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 76 -- 1 file changed, 43 insertions(+), 33 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 8cf0bf9..3507927 100644 --- a

[Mesa-dev] [PATCH 22/23] meta: Don't save or restore the VBO binding

2015-11-09 Thread Ian Romanick
From: Ian Romanick Nothing left in meta does anything with the VBO binding, so we don't need to save or restore it. The VAO binding is still modified. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 6 -- src/mesa/drivers/common/meta.h | 1 - 2 files changed, 7 dele

[Mesa-dev] [PATCH 16/23] meta: Don't pollute the buffer object namespace in _mesa_meta_setup_vertex_objects

2015-11-09 Thread Ian Romanick
From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-gene

[Mesa-dev] [PATCH 01/23] i965: Silence unused parameter warnings in get_buffer_rect

2015-11-09 Thread Ian Romanick
From: Ian Romanick brw_meta_fast_clear.c: In function 'get_buffer_rect': brw_meta_fast_clear.c:318:37: warning: unused parameter 'brw' [-Wunused-parameter] get_buffer_rect(struct brw_context *brw, struct gl_framebuffer *fb, ^ brw_meta

[Mesa-dev] [PATCH 21/23] meta/TexSubImage: Don't pollute the buffer object namespace

2015-11-09 Thread Ian Romanick
From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-gene

[Mesa-dev] [PATCH 07/23] i965: Use internal functions for buffer object access

2015-11-09 Thread Ian Romanick
From: Ian Romanick Instead of going through the GL API implementation functions, use the lower-level functions. This means that we have to keep track of a pointer to the gl_buffer_object and the gl_vertex_array_object. This has two advantages. First, it avoids a bunch of CPU overhead in

[Mesa-dev] [PATCH 14/23] meta: Use DSA functions for VBOs in _mesa_meta_setup_vertex_objects

2015-11-09 Thread Ian Romanick
From: Ian Romanick The fixed-function attribute paths don't get the DSA treatment because there are no DSA entry-points for fixed-function attributes. These could have been added, but this is a temporary patch intended to make later patches easier to review. Signed-off-by: Ian Rom

[Mesa-dev] [PATCH 18/23] meta: Track VBO using gl_buffer_object instead of GL API object handle in _mesa_meta_DrawTex

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 23 ++- src/mesa/drivers/common/meta.h | 2 +- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 1bf3d52

[Mesa-dev] [PATCH 08/23] i965: Don't pollute the buffer object namespace in brw_meta_fast_clear

2015-11-09 Thread Ian Romanick
From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match generated names and non-gene

[Mesa-dev] [PATCH 09/23] meta: Use DSA functions for PBO in create_texture_for_pbo

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_tex_subimage.c | 30 +++-- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c index

[Mesa-dev] [PATCH 23/23] meta: Don't save or restore the active client texture

2015-11-09 Thread Ian Romanick
From: Ian Romanick This setting is only used by glTexCoordPointer and related glEnable calls. Since the preceeding commits removed all of those, it is not necessary to save, reset to default, or restore this state. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 3 --- src

[Mesa-dev] [PATCH 03/23] mesa: Refactor update_array_format to make _mesa_update_array_format_public

2015-11-09 Thread Ian Romanick
From: Ian Romanick Pulls the parts of update_array_format that aren't just parameter validation out into a function that can be called from other parts of Mesa (e.g., meta). Signed-off-by: Ian Romanick --- src/mesa/main/varray.c | 68 --

[Mesa-dev] [PATCH 05/23] i965: Pass brw_context instead of gl_context to brw_draw_rectlist

2015-11-09 Thread Ian Romanick
From: Ian Romanick Future patches will use the brw_context instead. Keeping this non-functional change separate should make the function changes easier to review. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 9 + 1 file changed, 5 insertions(+), 4

[Mesa-dev] [PATCH 10/23] meta: Use _mesa_NamedBufferData and _mesa_NamedBufferSubData for users of _mesa_meta_setup_vertex_objects

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 12 +--- src/mesa/drivers/common/meta_blit.c| 2 +- src/mesa/drivers/common/meta_generate_mipmap.c | 4 ++-- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a

[Mesa-dev] [PATCH 06/23] i965: Use DSA functions for VBOs in brw_meta_fast_clear

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c index 847824c

[Mesa-dev] [PATCH 02/23] mesa: Make bind_vertex_buffer avilable outside varray.c

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/varray.c | 29 +++-- src/mesa/main/varray.h | 7 +++ 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 887d0c0..5e0534a 100644

[Mesa-dev] [PATCH 12/23] meta: Don't leave the VBO bound after _mesa_meta_setup_vertex_objects

2015-11-09 Thread Ian Romanick
From: Ian Romanick Meta currently does this, but future changes will make this impossible. Explicitly do it as a step in the patch series now to catch any possible kinks. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c| 42 +++ src/mesa

[Mesa-dev] [PATCH 19/23] meta: Use internal functions for buffer object and VAO access in _mesa_meta_DrawTex

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 6927ae9..57993cf 100644 --- a/src/mesa

[Mesa-dev] [PATCH 17/23] meta: Partially convert _mesa_meta_DrawTex to DSA

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 8249eda..1bf3d52 100644 --- a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 11/23] i965: Use _mesa_NamedBufferSubData for users of _mesa_meta_setup_vertex_objects

2015-11-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c b/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c index cbbb919

Re: [Mesa-dev] [PATCH 00/23] Don't pollute the buffer object namespace in meta

2015-11-09 Thread Ian Romanick
Also on the meta-cannot-use-Gen branch of my fd.o Mesa tree. This branch will contain all of the current work... including patches beyond this series. On 11/09/2015 04:55 PM, Ian Romanick wrote: > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't h

Re: [Mesa-dev] [PATCH] i965: Map GL_PATCHES to 3DPRIM_PATCHLIST_n.

2015-11-10 Thread Ian Romanick
prim->mode)); > > - const uint32_t hw_prim = get_hw_prim_for_gl_prim(prim->mode); > + if (prim->mode == GL_PATCHES) > + hw_prim = _3DPRIM_PATCHLIST(ctx->TessCtrlProgram.patch_vertices); > + else > + hw_prim = get_hw_prim_for_gl_prim(prim->mode); > + I&#

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-10 Thread Ian Romanick
On 11/09/2015 04:10 PM, Ian Romanick wrote: > On 11/04/2015 03:26 PM, Ryan Houdek wrote: >> I'm hoping to potentially convince about lowering the minimum >> requirement of EXT_buffer_storage from ES 3.1 to ES 3.0. >> The only thing that causes it to require ES 3.1 is

Re: [Mesa-dev] Potential spec change request for EXT_buffer_storage

2015-11-10 Thread Ian Romanick
On 11/09/2015 04:29 PM, Ilia Mirkin wrote: > On Mon, Nov 9, 2015 at 7:10 PM, Ian Romanick wrote: >> On 11/04/2015 03:26 PM, Ryan Houdek wrote: >>> I'm hoping to potentially convince about lowering the minimum >>> requirement of EXT_buffer_storage from ES 3.1 to

Re: [Mesa-dev] [PATCH v3 1/8] glapi: Add EXT_blend_func_extended XML definitions

2015-11-10 Thread Ian Romanick
GLES generally has a "one way to do things" guiding principle, so glBindFragDataLocation had to go. Nice to see NVIDIA sneak it back in with a mostly unrelated extension. :) This patch is Reviewed-by: Ian Romanick On 11/06/2015 10:41 AM, Ryan Houdek wrote: > Yes this is correct. T

Re: [Mesa-dev] [PATCH v3 2/8] glsl: Add required variables to _mesa_glsl_parse_state for EXT_blend_func_extended

2015-11-10 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > This adds a state for the maximum dual source draw variables available > and the variable for determining if the extension has been enabled > in the program shaders. > --- > src/glsl/glsl_parser

Re: [Mesa-dev] [PATCH v3 8/8] mesa: Enable EXT_blend_func_extended if the driver supports the ARB version

2015-11-10 Thread Ian Romanick
Once all the others are ready, this patch is also Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > docs/relnotes/11.1.0.html | 1 + > src/mesa/main/extensions.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/docs/relnotes/11.1.0.ht

Re: [Mesa-dev] [PATCH] mesa/copyimage: allow width/height to not be multiples of block

2015-11-10 Thread Ian Romanick
idth + xoffset is not equal to the value of TEXTURE_WIDTH. • height is not a multiple of four, and height + yoffset is not equal to the value of TEXTURE_HEIGHT. With the above spec quotations added somewhere (either the commit message or the code), this patch is Reviewe

[Mesa-dev] [PATCH] meta/generate_mipmap: Don't leak the sampler object

2015-11-10 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/mesa/drivers/common/meta_generate_mipmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/common/meta_generate_mipmap.c b/src/mesa/drivers/common/meta_generate_mipmap.c index 480027

Re: [Mesa-dev] [PATCH] texgetimage: consolidate 1D array handling code.

2015-11-10 Thread Ian Romanick
Reviewed-by: Ian Romanick On 11/10/2015 06:34 PM, Dave Airlie wrote: > From: Dave Airlie > > This should fix the getteximage-depth test that currently asserts. > > I was hitting problem with virgl as well in this area. > > This moves the 1D array handling code to a sing

  1   2   3   4   5   6   7   8   9   10   >