[Lldb-commits] [clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89480 Addresses issue #85984 >From fba4b0556340a00c1e059a8abdba5fdd1b0e38ea Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 25 Mar 2024 13:28:45 -0400 Subject: [PATCH 1/4] [LLVM][LIB] Refactor Redundant Cond

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler closed https://github.com/llvm/llvm-project/pull/89480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Troy Butler via lldb-commits
Troy-Butler wrote: I apologize - I'm not sure how this happened. I was careful to refresh my fork/clone before starting on this issue, but somehow not all of the files were updated, and now my PR requests are getting wires crossed. I think it would be safest for me to close this issue, delete

[Lldb-commits] [lldb] [lldb][Core] Fix pointless if conditon (PR #89650)

2024-04-22 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89650 Addresses #85984 >From 8aed7cb301347db507de10106ed41f9c6be50b1b Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 22 Apr 2024 14:56:11 -0400 Subject: [PATCH] [lldb][Core] Fix pointless if conditon Sign

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89685 Addresses issue #87243. >From 20c093a1cd51adab9387e9a15fca7c8b592f3f21 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 22 Apr 2024 19:17:08 -0400 Subject: [PATCH] [lldb] Replace always-false condition

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler edited https://github.com/llvm/llvm-project/pull/89685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Troy Butler via lldb-commits
Troy-Butler wrote: > Otherwise this LGTM! > Even though you link the issue, I would recommend also summarizing the issue > in the commit. Something like "The current code is checking the validity of > `obj` twice, instead of checking the new `str_obj` pointer." > > Otherwise this LGTM! I a