[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-07 Thread Mariusz Ceier via Phabricator via lldb-commits
mceier created this revision. mceier added a reviewer: LLVM. Herald added a subscriber: mgorny. mceier requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLVM_ENABLE_ZLIB is ON gdb-remote should link with ZLIB::ZLIB. Fixes https://review

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-07 Thread Mariusz Ceier via Phabricator via lldb-commits
mceier added a comment. In D119186#3302612 , @JDevlieghere wrote: > We should add this to `LLDB_SYSTEM_LIBS` like we do in > `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for > `lldbPluginProcessGDBRemote`. So should I add: if

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-07 Thread Mariusz Ceier via Phabricator via lldb-commits
mceier updated this revision to Diff 406706. mceier added a comment. Updated diff to use LLDB_SYSTEM_LIBS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 Files: lldb/source/Plugins/Process/gdb-remote/CM

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-07 Thread Mariusz Ceier via Phabricator via lldb-commits
mceier accepted this revision. mceier added a comment. I need someone to merge it for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 ___ lldb-commits maili

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-08 Thread Mariusz Ceier via Phabricator via lldb-commits
mceier added a comment. In D119186#3303744 , @sylvestre.ledru wrote: > Log: > https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console I downloaded build artifacts and it doesn't