[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

[Mariusz Ceier via Phabricator via lldb-commits]

mceier added a comment.

In D119186#3302612 <https://reviews.llvm.org/D119186#3302612>, @JDevlieghere 
wrote:

> We should add this to `LLDB_SYSTEM_LIBS` like we do in 
> `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for 
> `lldbPluginProcessGDBRemote`.

So should I add:

  if(LLVM_ENABLE_ZLIB)
    list(APPEND LLDB_SYSTEM_LIBS ZLIB::ZLIB)
  endif()

to `lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt` or do you have 
different CMakeLists.txt file in mind ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119186/new/

https://reviews.llvm.org/D119186

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits