[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

aadsm added a comment. Would it be possible to have a test for this? We would have probably found this, if we had a test at the time I rewrote this logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134842/new/ https://reviews.llvm.org/D134842

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm created this revision. aadsm added reviewers: mgorny, labath, emaste. aadsm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This issue was introduced in https://reviews.llvm.org/D92187. The guard I'm changing were is supposed to act w

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace, kusmour. aadsm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. VSCode was not being informed whenever a location had been resolved (after being initated as non-

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. > We should have a test for this. how do you recommend doing this? I spent a couple of hours on this but got no where. From what I understood we should prefer lit tests, so I was thinking of creating a binary that dlopens a module. However, I wasn't able to create a bina

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 324864. aadsm added a comment. Add api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/test/API/fun

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 324865. aadsm added a comment. revert last amend: added the test to the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/tools/lldb-vscode/lldb-vs

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm updated this revision to Diff 324866. aadsm added a comment. Add api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96637/new/ https://reviews.llvm.org/D96637 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/source/Plugi

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. > I don't think this does what you think it does. The $() doesn't give you the > process id of anything -- it substitutes a string by the result of running > that string as a shell command. So, the PID variable would get the (entire) > stdout of %s.out I'm confused here,

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 325117. aadsm added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/test/API/tools/lldb-vscode/breakpoint-events/Makefile lldb/test/A

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

aadsm updated this revision to Diff 325118. aadsm added a comment. Removed unnecessary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96680/new/ https://reviews.llvm.org/D96680 Files: lldb/test/API/tools/lldb-vscode/breakpoint-events/Make

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added inline comments. Comment at: lldb/test/API/functionalities/module_load_attach/TestModuleLoadAttach.py:28 +def test_x(self): +process = self.build_launch_and_attach() +thread = process.GetSelectedThread() clayborg wrote: > Is this

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added inline comments. Comment at: lldb/test/API/functionalities/module_load_attach/TestModuleLoadAttach.py:32-33 +# Continue so that dlopen is called. +breakpoint = self.target().BreakpointCreateBySourceRegex( +"// break after dlopen", lldb.SBF

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm updated this revision to Diff 325221. aadsm added a comment. Checks the module is not loaded right after we attach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96637/new/ https://reviews.llvm.org/D96637 Files: lldb/packages/Python/lldbsui

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa83a825e9902: Make sure the interpreter module was loaded before m

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. oh no, I picked the wrong commit to land :(. I think this is fine because I already addressed the comments, but if there's still something I should work on here, I'll put another diff up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f21d488bd79: [lldb-vscode] Emit the breakpoint changed event on location resolved (authored by aadsm). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm created this revision. aadsm added reviewers: JDevlieghere, wallace, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. LLVM install component targets needs to be in the form of: install-{target}[-stripped] I tes

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm added a comment. @JDevlieghere thanks for the quick review, but on the name I mean the actual `finish_swig_python_scripts`, this sounds like a step name and not a component distributed by llvm like `liblldb` ot `lldb-server`. That was the reason at the time I named it `lldb-python-scripts

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

aadsm added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + labath wrote: > Could you also `= delete` the copy operations to make sure nothing funny > happens with those. The `= delete` is unsupported in SWIG 2, only in 3:

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

aadsm added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + lawrence_danna wrote: > lawrence_danna wrote: > > aadsm wrote: > > > labath wrote: > > > > Could you also `= delete` the copy operations to make sure nothing > > >

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

aadsm updated this revision to Diff 287106. aadsm edited the summary of this revision. aadsm added a comment. Updated to use more friendly component name `lldb-python-scripts` name instead of `finish_swig_python_scripts` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bf5632a94d: Fix swig scripts install target name (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm created this revision. aadsm added reviewers: clayborg, wallace, lawrence_danna. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm requested review of this revision. Herald added a subscriber: JDevlieghere. `struct Py_buffer_RAII` definition uses explicit deleted f

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287144. aadsm added a comment. Added include guards, clang-format and python include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/ https://reviews.llvm.org/D86381 Files: lldb/bindings/python/python-

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287149. aadsm added a comment. Moved the header file to be in Plugins/ScriptInterpreter/Python so clang-tidy doesn't get confused solving include paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/ h

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

aadsm updated this revision to Diff 287160. aadsm added a comment. After reading a bit more how clang-tidy works this isn't fixable because it actually needs to compile it. I also didn't find a way to exclude a file from it. My plan is to just land this and then make a PR to add this file to ht

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

aadsm created this revision. aadsm added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. This addresses the issue raised here https://reviews.llvm.org/rG02bf5632a94da6c3570df002804f8d3f79c11bfc The `f

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8eedee917d: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

aadsm added a comment. Sounds good, will update. In my mind it would be easier to just install all configured python scripts by specifying a single distribution component. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/new/ https://reviews.ll

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

aadsm updated this revision to Diff 287211. aadsm added a comment. Update to create 2 separate install targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/new/ https://reviews.llvm.org/D86402 Files: lldb/CMakeLists.txt lldb/bindings/py

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

This revision was automatically updated to reflect the committed changes. Closed by commit rG52381938bcc8: Create ${swig_target}-scripts target instead of lldb-python-scripts (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/ne

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm created this revision. aadsm added reviewers: clayborg, labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. I found a few cases whe

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:441 + if (first_code_section_sp) +m_first_code_address = first_code_section_sp->GetFileAddress(); +} I'm actually not 100% sure about this, can there be new cod

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm created this revision. aadsm added reviewers: clayborg, labath. Herald added a reviewer: shafik. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm requested review of this revision. Herald added a subscriber: JDevlieghere. This is a similar patch to https://reviews

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:1 +# int foo() { +# return 42; I should rename this to `test-invalid-addresses.yaml` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:520 + Data:0 +... clayborg wrote: > aadsm wrote: > > I generated this yaml with the code that is at the top, and then changed it > > to

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2265-2267 +auto base_address = func_range.GetBaseAddress(); +if (base_address.IsSectionOffset() && +base_address.GetSection()->GetType() == eSectionTypeCode) { -

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:74 // codes that start at 1, that we get O(1) access. - + const auto byte_order = eByteOrderLittle; clayborg wrote: > remove whitespace only changes please.

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm updated this revision to Diff 290112. aadsm added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/s

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm updated this revision to Diff 290113. aadsm added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Check lowest code address instead of checking if the section is code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm created this revision. aadsm added reviewers: clayborg, jingham, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aadsm requested review of this revision. I found an issue where the expression evaluation doesn't work (for non trivial exprs) when the leak

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:520 std::vector m_lldb_cu_to_dwarf_unit; + lldb::addr_t m_first_code_address = LLDB_INVALID_ADDRESS; }; labath wrote: > clayborg wrote: > > A lengthy comment woul

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm added a comment. > Why would we be doing something (particularly a thing which will be hard to > do in a cross-platform manner, and will very likely border on, or downright > cross into, undefined behavior territory), if we get that from vscode for > free? I'm not sure what you mean with

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added a comment. > It seems like calling any 'mmap' definition should work. Is the interposed > mmap implementation failing and correctly returning -1, or is it succeeding > and incorrectly returning -1? In either case, it seems like it's worth > digging into why it's failing / returnin

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm updated this revision to Diff 296220. aadsm added a comment. I explored Greg's suggestion of checking if the functions were external symbols. As suspected the overriden mmap is not external, so we can use this check to avoid calling it! It does look to me that Pavel's suggestion is the wa

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = clayborg wrote: > W

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = labath wrote: > cla

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:36 bool lldb_private::InferiorCallMmap(Process *process, addr_t &allocated_addr, addr_t addr, addr_t length, unsigned prot,

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm updated this revision to Diff 298906. aadsm added a comment. Addressed all comments: - Moved initialization code to InitializeObject - Moved to lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. > Not everyone has both of these things enabled (particularly having lld is > less common), but they are things that one _can_ enable no matter what is his > host or target architecture, so I am not worried by that. And as tests like > these become more common, I expect

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. > (substituting llvm-mc for as and ld.lld for linker). I was not able to figure out how to generate the object file with llvm-mc correctly. I've tried a few variations of the triple (e.g.: `armv7-eabi`) but I never end up with the same code that I have in the assembly:

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222490. aadsm added a comment. Add lit test to check dissassembly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/dissassemble-entry-point.s

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222680. aadsm added a comment. Update tests and fix logic to correctly add the symtab entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. I actually just completely missed the first comment on the .s test and forgot about the comment 😇. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 _

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222848. aadsm added a comment. Update comment and test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/dissassemble-entry-point.s lldb/sour

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

aadsm created this revision. aadsm added reviewers: labath, xiaobai, clayborg, lanza. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. I'd like to install lldb using the install-distribution target with LLVM_DISTRIBUTION_COMPONENTS but this is currently not possible a

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222967. aadsm added a comment. Remove .global _Start Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/lit/SymbolFile/dissassemble-entry-point.s lldb/source

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

aadsm updated this revision to Diff 223094. aadsm added a comment. Rename lldb-scripts to lldb-python-scripts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68370/new/ https://reviews.llvm.org/D68370 Files: lldb/scripts/CMakeLists.txt Index: ll

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

This revision was automatically updated to reflect the committed changes. Closed by commit rL373680: Explicitly set entry point arch when it's thumb (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. I ended reverting this because of SymbolFile/Breakpad/symtab.test. It seems that in this test we add symbols after the synthetic entry point symbol is added creating confusion. I think I'll need to change the code that adds symbols in Symtab to explicitly check if we're o

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. Ok. Initially I thought that with the entry point we were making big assumptions there but after reading the parse unwind symbols I guess it's really no big difference. I guess my main concern is that the user can no longer create symbols within the span of the entry poi

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rL373768: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace, espindola. aadsm added a project: LLDB. This is a redo of D68069 because I reverted it due to some concerns that were now addressed along with the new comments that @labath added. I

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm updated this revision to Diff 223707. aadsm added a comment. Don't destroy the Breakpad test purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 Files: lldb/lit/SymbolFile/Breakpad/Inputs/basic

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

This revision was automatically updated to reflect the committed changes. Closed by commit rGad6690afa3e6: Explicitly set entry point arch when it's thumb [Second Try] (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ htt

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik thanks, checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik I just pushed a fix, the issue was because on mac there are more unnamed symbols so the number didn't match, I changed it to match any number since this can easily change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm requested changes to this revision. aadsm added a comment. This revision now requires changes to proceed. I'm sorry to reject but this diff breaks `install-distribution` on Darwin. Here's how to repro: $ mkdir -p ~/Projects/llvm-build/Release && cd ~/Projects/llvm-build/Release $ cmake

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm accepted this revision. aadsm added a comment. This revision is now accepted and ready to land. This is great! it's so much better. Thank so much for looking into this and fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ h

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm added a comment. @hhb fwiw, I still get the same error with this diff (after applying it on top of D69834 ). But D69834 by itself works great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm added a comment. @hhb I just did, and get the same error as well :( `ninja: error: 'bin/LLDB.framework/LLDB', needed by 'bin/LLDB.framework/Resources/Python/lldb/_lldb.so', missing and no known rule to make it` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

aadsm added a comment. Yeah, weird. I wonder if this is something cmake does implicitly when the target is defined as `FRAMEWORK`: https://cmake.org/cmake/help/latest/prop_tgt/FRAMEWORK.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm created this revision. aadsm added reviewers: hhb, sgraenitz, xiaobai, smeenai. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. I want to be able to specify which python framework to use for lldb in macos. With python2.7 we could just rely on the MacOS one but

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm added a comment. That should work fine yeah. It should be a matter of adding `"@loader_path/../../../"` to the rpath. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/ https://reviews.llvm.org/D69931 ___

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm added a comment. > The proposed path in this patch, -rpath "@loader_path/../../../", uses the > @loader_path expansion which is the directory containing the binary that the > load command is in (in this case liblldb's directory). Popping 3 directories > up from that is likely not sane in

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm updated this revision to Diff 228634. aadsm added a comment. Updating to only add an rpath that points to the directory where LLDB.frameworks gets installed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

aadsm updated this revision to Diff 228765. aadsm edited the summary of this revision. aadsm added a comment. Clarify the point of the install_path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/ https://reviews.llvm.org/D69931 Files: l

[Lldb-commits] [PATCH] D70252: [Docs] Add Python caveats under the development section

aadsm added a comment. Thank you for writing this up! I was thinking how I would find this.. I don't see myself clicking on the "Caveats" link (could also be a me problem though). Could we also add a link to it in this section? https://lldb.llvm.org/resources/build.html#id22. Something like "NO

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm updated this revision to Diff 211241. aadsm added a comment. Handle error returned by GetLoadedModuleList Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64013/new/ https://reviews.llvm.org/D64013 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D65129: Test load unloading of modules with libraries-svr4

aadsm created this revision. aadsm added reviewers: labath, clayborg, xiaobai. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. This doubles the 3 tests running right now on linux by also executing each test with libraries-svr4 enabled. Not sure if there's a better w

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

aadsm added a comment. @jankratochvil interesting, we're also not able to run the lldb-vscode tests and it was on my todo list to take a look. Although I didn't realize it was a common think I thought it was specific to the environment where I was trying to run them. /cc @xiaobai. Thanks for lo

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

aadsm added a comment. @Hui what do you mean? the history is still there: $ git log lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py commit a61c247ce189efe7641dccb8ad7f85f60fc72220 (master) Author: Antonio Afonso Date: Mon Jul 22 23:35:05 2019 +

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm added a comment. I've just done these 2 steps: - Revert rL364751 (which is a revert itself) - Revert 9c10b620c061 (will re-apply this one) Should be fine since now we have an option

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

aadsm created this revision. aadsm added reviewers: clayborg, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This might be an edge case in regular use but if you're shipping an lldb version with no debugserver lldb will try to use the System one. However, lld

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm updated this revision to Diff 211661. aadsm added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64013/new/ https://reviews.llvm.org/D64013 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/DynamicLoader/POSI

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

This revision was automatically updated to reflect the committed changes. Closed by commit rL367020: Correctly use GetLoadedModuleList to take advantage of libraries-svr4 (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

aadsm added a comment. @clayborg, yes, I made sure of that, we always first check the Xcode path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65171/new/ https://reviews.llvm.org/D65171 ___ lldb-commi

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL367052: [LLDB] Find debugserver in Command Line Tools as well (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[Lldb-commits] [PATCH] D65129: Test load unloading of modules with libraries-svr4

This revision was automatically updated to reflect the committed changes. Closed by commit rL367247: Test load unloading of modules with libraries-svr4 (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D65949: unittests: Use yaml2obj as a library instead of an external process

aadsm added a comment. I can see the appeal of having the contents next to the logic that is testing it, but I'm somewhat concerned for the cases where it includes +1000 lines of YAML in the test file. I think for those cases it might make sense to consider these fixtures and be in their own fi

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace. Herald added subscribers: lldb-commits, MaskRay, kristof.beyls, arichardson, emaste, srhines. Herald added a reviewer: espindola. Herald added a project: LLDB. I found a case where the main android binary (app_process3

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm marked an inline comment as done. aadsm added a comment. > For the test, what would you say to writing that as a lit test instead > (testing the address class deduction via the disassemble command you > mentioned)? I was actually keen on this since lit is the only type of test I haven't u

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm updated this revision to Diff 222063. aadsm added a comment. Use GetNextSyntheticSymbolName() to generate the symbol name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68069/new/ https://reviews.llvm.org/D68069 Files: lldb/source/Plugins/O

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm created this revision. aadsm added a reviewer: clayborg. Herald added subscribers: lldb-commits, abidh, jfb, erik.pilkington, aprantl. Herald added a project: LLDB. The `log timer dump` is showing the time of the function itself minus any function that is called from this one that also happ

[Lldb-commits] [PATCH] D61247: Add more information to the log timer dump

aadsm created this revision. Herald added subscribers: lldb-commits, jfb, erik.pilkington, aprantl. Herald added a project: LLDB. aadsm abandoned this revision. The `log timer dump` is showing the time of the function itself minus any function that is called from this one that also happens to be

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197048. aadsm added a comment. Fix and add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer.h lldb/source/Utility/Time

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197049. aadsm added a comment. Move struct to anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer.h lldb/source

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, co

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm planned changes to this revision. aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/source/Utility/Timer.cpp:110-123 +namespace { +struct Stats { + uint64_t nanos; + uint64_t nanos_total; + uint64_t nanos_child; + uint64_t count; +};

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, co

  1   2   3   >