@@ -969,6 +969,66 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+lldb_private::DataBufferHeap &data_buffer,
+const lldb_private::CoreFileMemoryRange &range, uint64_t &bytes_read) {
+
+
@@ -969,6 +969,66 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+lldb_private::DataBufferHeap &data_buffer,
+const lldb_private::CoreFileMemoryRange &range, uint64_t &bytes_read) {
+
+
@@ -1589,6 +1589,51 @@ class Process : public
std::enable_shared_from_this,
size_t ReadMemoryFromInferior(lldb::addr_t vm_addr, void *buf, size_t size,
Status &error);
+ // Callback definition for read Memory in chunks
+ //
+ // Status, th
@@ -2233,6 +2233,49 @@ size_t Process::ReadMemoryFromInferior(addr_t addr, void
*buf, size_t size,
return bytes_read;
}
+size_t Process::ReadMemoryInChunks(lldb::addr_t vm_addr, void *buf,
+ lldb::addr_t chunk_size, size_t size,
+
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1589,6 +1589,51 @@ class Process : public
std::enable_shared_from_this,
size_t ReadMemoryFromInferior(lldb::addr_t vm_addr, void *buf, size_t size,
Status &error);
+ // Callback definition for read Memory in chunks
+ //
+ // Status, th
labath wrote:
> Trying to add unit tests with this patch. We already have a big test suite
> that came from `lldb-eval`, and I don't see much reason to rewrite them into
> Python tests.
> I didn't find an existing way to build the binary for debugging using in-tree
> compiler and libc++, so
clayborg wrote:
So the issue from only the lldb-dap side here is VS Code is sending a threads
request, but we have resumed the process upon attach after sending the
configuration done request. So the race condition happens like:
- send configuration done
- send continue to process if stop on e
@@ -391,8 +392,13 @@ bool Debugger::SetTerminalWidth(uint64_t term_width) {
if (auto handler_sp = m_io_handler_stack.Top())
handler_sp->TerminalSizeChanged();
- if (m_statusline)
-m_statusline->TerminalSizeChanged();
+
+ {
+// This might get called from a signa
@@ -391,8 +392,13 @@ bool Debugger::SetTerminalWidth(uint64_t term_width) {
if (auto handler_sp = m_io_handler_stack.Top())
handler_sp->TerminalSizeChanged();
- if (m_statusline)
-m_statusline->TerminalSizeChanged();
+
+ {
+// This might get called from a signa
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/134778
This fixes 3 warnings from compiling the DILParser:
DILParser.h:53:12: warning: returning address of local temporary object
[-Wreturn-stack-address]
DILParser.h:119:8: warning: private field 'm_fragile_ivar' is
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/131609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4,6 +4,7 @@
"""
import os
+import signal
labath wrote:
I guess this isn't used anymore.
https://github.com/llvm/llvm-project/pull/131609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
da-viper wrote:
Another solution I could think of is prioritising, the repl command type
instead of the repl variable type.
in
https://github.com/llvm/llvm-project/blob/4607d39c7eded3ff6d425cbc502e30349078365c/lldb/tools/lldb-dap/DAP.cpp#L553-L558
or add the previously defined aliases in doc
@@ -969,6 +969,64 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+lldb_private::DataBufferHeap &data_buffer,
+const lldb_private::CoreFileMemoryRange &range, uint64_t &bytes_read) {
+
+
https://github.com/labath approved this pull request.
> So, I will move LoadPlugin lambda to SystemInitializerFull.
Thanks, this LGTM now, but do wait for @JDevlieghere's review as well.
> Note lldbInitialization depends on lldbPluginProcessGDBRemote,
> lldbPluginProcessPOSIX and lldbPluginPro
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -222,6 +222,21 @@ ObjCLanguage::GetMethodNameVariants(ConstString
method_name) const {
return variant_names;
}
+std::pair
+ObjCLanguage::GetFunctionNameInfo(ConstString name) const {
+ FunctionNameType func_name_type = eFunctionNameTypeNone;
+
+ if (ObjCLanguage::IsPos
https://github.com/labath commented:
I like the version a lot, but I'd like to leave to final approval to @bulbazord
and/or @JDevlieghere.
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
@@ -71,6 +71,7 @@ json::Value ModuleStats::ToJSON() const {
module.try_emplace("debugInfoHadIncompleteTypes",
debug_info_had_incomplete_types);
module.try_emplace("symbolTableStripped", symtab_stripped);
+ module.try_emplace("symbolDownloadTime", symbo
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -188,17 +188,27 @@ GetFileForModule(const ModuleSpec &module_spec,
std::string cache_file_name = llvm::toHex(build_id, true);
if (!file_name.empty())
cache_file_name += "-" + file_name.str();
- llvm::Expected result = llvm::getCachedOrDownloadArtifact(
- cache_
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:21:25 +0100
Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to
OutputB
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstr
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/134626
>From 6c8b0a3dcb33eeb2fe57325a792ff5a70225d18e Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Mon, 7 Apr 2025 10:24:02 +0100
Subject: [PATCH 1/3] [lldb] Fix SBTarget::ReadInstruction
The disassemblyBytes par
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
`GetLSDAAddress` and `GetPersonalityRoutinePtrAddress` are unused and they
create a bit of a problem for discontinuous functions, because the unwind plan
for these consists of multiple eh_frame descriptors and
compnerd wrote:
UTF-8 is a multibyte encoding, and if there is existing content in the output
string, the generated result may not be a valid string, if you passed in a
buffer with `\xe0` and then convert the input of `a`, we would get something
that is invalid.
https://github.com/llvm/llvm-p
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:21:25 +0100
Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to
OutputB
labath wrote:
I agree with everything Jonas said here (and that's why I am very reluctant to
approve #132274). The layering should be between libraries (like they are in
the rest of llvm), not individual object files. My mental model for a
"dependency" from library `A` to library `B` is "libra
labath wrote:
I see this is just a draft, but in order to save time for everyone, I want to
say this as early as possible.
With this patch, the biggest question you will have to answer is "why is the
implementation of `&` more complicated than `inner_value->AddressOf()`" (and a
similar questi
@@ -58,3 +59,45 @@ def test_platform_process_launch_gdb_server(self):
self.runCmd("target create {}".format(self.getBuildArtifact("a.out")))
self.expect("run", substrs=["unable to launch a GDB server on"],
error=True)
+
+@skipIfRemote
+@skipUnlessPlatf
https://github.com/yuvald-sweet-security updated
https://github.com/llvm/llvm-project/pull/131609
>From 6f2d070facaced221295a5b0c48ccb3a41a5048d Mon Sep 17 00:00:00 2001
From: Yuval Deutscher
Date: Mon, 17 Mar 2025 14:37:26 +0200
Subject: [PATCH 1/2] [lldb] Use correct path for debugserver
---
@@ -58,3 +59,45 @@ def test_platform_process_launch_gdb_server(self):
self.runCmd("target create {}".format(self.getBuildArtifact("a.out")))
self.expect("run", substrs=["unable to launch a GDB server on"],
error=True)
+
+@skipIfRemote
+@skipUnlessPlatf
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/134626
When you call the `SBTarget::ReadInstructions` with flavor from lldb crashes.
This is because the wrong order of the `DisassemblyBytes` constructor this
fixes that
>From 6c8b0a3dcb33eeb2fe57325a792ff5a70225d1
da-viper wrote:
I was also wondering if this should be backported as it also affects llvm 20.x
branch
https://github.com/llvm/llvm-project/pull/134626
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
jimingham wrote:
The lldb command line was designed so that it always does shortest complete
match, and there are a lot of common commands that people only type partially.
Adding one more expr alias isn't such a big deal, but adding special purpose
aliases for all the shortenings people want
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -969,6 +969,64 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+lldb_private::DataBufferHeap &data_buffer,
+const lldb_private::CoreFileMemoryRange &range, uint64_t &bytes_read) {
+
+
clayborg wrote:
> Either no one is going to use this except experts, or people will start
> cargo-culting "turn off plugin X and lldb will be faster" and then we get
> "Why doesn't 'obvious thing'" work bug reports, to which the answer would be
> "turn on plugin X" but people may not even know
@@ -422,6 +422,11 @@ class SymbolFile : public PluginInterface {
/// hasn't been indexed yet, or a valid duration if it has.
virtual StatsDuration::Duration GetDebugInfoIndexTime() { return {}; }
+ /// Return the time it took to download any extra symbol files.
+ ///
+
@@ -391,6 +398,7 @@ llvm::json::Value DebuggerStats::ReportStatistics(
}
json::Object global_stats{
+ {"totalSymbolDownloadTime", symbol_download_time},
youngd007 wrote:
And this key is new.
https://github.com/llvm/llvm-project/pull/134563
_
@@ -188,17 +188,27 @@ GetFileForModule(const ModuleSpec &module_spec,
std::string cache_file_name = llvm::toHex(build_id, true);
if (!file_name.empty())
cache_file_name += "-" + file_name.str();
- llvm::Expected result = llvm::getCachedOrDownloadArtifact(
- cache_
https://github.com/youngd007 commented:
Overall seems fine to me. Will let the others take a crack. Please confirm
the duration is accurately getting calculated.
https://github.com/llvm/llvm-project/pull/134563
___
lldb-commits mailing list
lldb-com
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:21:25 +0100
Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to
OutputB
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:21:25 +0100
Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to
OutputB
@@ -0,0 +1,175 @@
+//===-- WriteMemoryRequestHandler.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:21:25 +0100
Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to
OutputB
@@ -0,0 +1,175 @@
+//===-- WriteMemoryRequestHandler.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
When you call the `SBTarget::ReadInstructions` with flavor from lldb crashes.
This is because the wrong order of the `DisassemblyBytes` constructor this
fixes that
---
Full diff: https://github.com/llvm/llvm
Author: Julian Lettner
Date: 2025-04-07T08:33:27-07:00
New Revision: 4b90f24db81fb4378d9f4816f31e16195d8adb0f
URL:
https://github.com/llvm/llvm-project/commit/4b90f24db81fb4378d9f4816f31e16195d8adb0f
DIFF:
https://github.com/llvm/llvm-project/commit/4b90f24db81fb4378d9f4816f31e16195d8adb0f.diff
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/134323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1589,6 +1589,48 @@ class Process : public
std::enable_shared_from_this,
size_t ReadMemoryFromInferior(lldb::addr_t vm_addr, void *buf, size_t size,
Status &error);
+ // Callback definition for read Memory in chunks
+ //
+ // Status, th
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/134314
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2025-04-07T11:11:31-07:00
New Revision: 21d912121c9f41385b165a736be787527f5bd7c2
URL:
https://github.com/llvm/llvm-project/commit/21d912121c9f41385b165a736be787527f5bd7c2
DIFF:
https://github.com/llvm/llvm-project/commit/21d912121c9f41385b165a736be787527f5bd7c2.diff
@@ -188,17 +188,27 @@ GetFileForModule(const ModuleSpec &module_spec,
std::string cache_file_name = llvm::toHex(build_id, true);
if (!file_name.empty())
cache_file_name += "-" + file_name.str();
- llvm::Expected result = llvm::getCachedOrDownloadArtifact(
- cache_
slydiman wrote:
> and that's why I am very reluctant to approve #132274
#132274 is most important now because it gives the significant effect.
I have refactored `CPlusPlusLanguage::MethodName` and don't just splite a CU
now. RichManglingContext.cpp uses auto
`Language::FindPlugin(eLanguageTyp
@@ -0,0 +1,175 @@
+//===-- WriteMemoryRequestHandler.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:21:25 +0100
Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to
OutputB
slydiman wrote:
@labath
> The only thing which makes that difficult is that the callback is a lambda
> defined in SBDebugger.cpp. However, there's no reason it has to be defined
> there -- the lambda itself doesn't depend on anything, and it could easily be
> moved to SystemInitializerFull.c
https://github.com/GeorgeHuyubo edited
https://github.com/llvm/llvm-project/pull/134563
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2233,6 +2233,40 @@ size_t Process::ReadMemoryFromInferior(addr_t addr, void
*buf, size_t size,
return bytes_read;
}
+size_t Process::ReadMemoryInChunks(lldb::addr_t vm_addr, DataBufferHeap &data,
clayborg wrote:
There is no need to pass in a DataBuffer
@@ -1589,6 +1589,48 @@ class Process : public
std::enable_shared_from_this,
size_t ReadMemoryFromInferior(lldb::addr_t vm_addr, void *buf, size_t size,
Status &error);
+ // Callback definition for read Memory in chunks
+ //
+ // Status, th
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+#define LLDB_OPTIONS_plugin_list
+#include "CommandOptions.inc"
+
+// These option definitions are shared by the plugin list/enable/disable
+// commands.
+class PluginListCo
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+#define LLDB_OPTIONS_plugin_list
+#include "CommandOptions.inc"
+
+// These option definitions are shared by the plugin list/enable/disable
+// commands.
+class PluginListCo
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+#define LLDB_OPTIONS_plugin_list
+#include "CommandOptions.inc"
+
+// These option definitions are shared by the plugin list/enable/disable
+// commands.
+class PluginListCo
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+#define LLDB_OPTIONS_plugin_list
+#include "CommandOptions.inc"
+
+// These option definitions are shared by the plugin list/enable/disable
+// commands.
+class PluginListCo
@@ -188,17 +188,27 @@ GetFileForModule(const ModuleSpec &module_spec,
std::string cache_file_name = llvm::toHex(build_id, true);
if (!file_name.empty())
cache_file_name += "-" + file_name.str();
- llvm::Expected result = llvm::getCachedOrDownloadArtifact(
- cache_
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/134722
Ensure the disassembly respects the "target.x86-disassembly-flavor" setting for
x86 and x86_64 targets.
Depends on #134626
>From c3b28161884d44d1c0c0e45ef4025bea24bc3bc3 Mon Sep 17 00:00:00 2001
From: Ebuka E
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
Ensure the disassembly respects the "target.x86-disassembly-flavor" setting for
x86 and x86_64 targets.
Depends on #134626
---
Full diff: https://github.com/llvm/llvm-project/pull/134722.diff
1 Files Affec
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/134383
>From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 4 Apr 2025 17:49:07 +0400
Subject: [PATCH 1/3] [LLDB][NFC] Remove Debugger dependency in
SystemLifetimeM
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
These are needed for functions whose entry point is not their lowest address.
---
Full diff: https://github.com/llvm/llvm-project/pull/134662.diff
5 Files Affected:
- (modified) lldb/include/lldb/Symbol/Unwi
72 matches
Mail list logo
