================ @@ -422,6 +422,11 @@ class SymbolFile : public PluginInterface { /// hasn't been indexed yet, or a valid duration if it has. virtual StatsDuration::Duration GetDebugInfoIndexTime() { return {}; } + /// Return the time it took to download any extra symbol files. + /// + /// \returns 0.0 if no extra symbol files need to be downloaded ---------------- youngd007 wrote:
not sure of standard for sentinel values in LLVM nor LLDB, but using 0.0 can be tricky if a file downloads so fast that it is effectively zero. Can we have it be null? Might make the C++ a little rougher, but a thought. Other option is -1, which has its own drawbacks if just logged. need to filter out those greater than -1 before any average or other aggregation. If zero is standard, I am fine with that. https://github.com/llvm/llvm-project/pull/134563 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits