https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From c08879c346a1f127324669fc6b74ce5a7407a30d Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127661
>From 40a29a7ba10caeae2a02355abddb9469246cdd3e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 18 Feb 2025 16:14:30 +0100
Subject: [PATCH] [lldb] Prepare UnwindPlans for discontinuous functions
The main c
https://github.com/labath approved this pull request.
A slightly unusual setup, but I sort of like it.
https://github.com/llvm/llvm-project/pull/128893
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128750
>From b3f60a464deedae59d902f7417c74a64c5cbf5a1 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 24 Feb 2025 15:07:13 -0800
Subject: [PATCH 1/4] [lldb-dap] Use existing lldb::IOObjectSP for IO (NFC).
This
ashgti wrote:
> To reliably force termination, I'd suggest changing the read thread to use a
> MainLoop object reading from the socket, and then terminating it via
> `loop.AddPendingCallback([&](MainLoopBase &loop) {
> loop.RequestTermination(); });`. It sounds a bit like overkill, but the
Author: Jonas Devlieghere
Date: 2025-02-26T11:56:23-06:00
New Revision: 317461ed61002de7f6e54ab0a26780c6d2726bb0
URL:
https://github.com/llvm/llvm-project/commit/317461ed61002de7f6e54ab0a26780c6d2726bb0
DIFF:
https://github.com/llvm/llvm-project/commit/317461ed61002de7f6e54ab0a26780c6d2726bb0.d
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 01/15] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details
@@ -40,7 +40,10 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
- m_opaque_up->Increment(amount, description);
+ std::optional description_opt;
+ if (description)
-
@@ -41,8 +41,136 @@ def test_output(self):
for event in self.dap_server.progress_events:
event_type = event["event"]
if "progressStart" in event_type:
+title = event["body"]["title"]
+self.assertIn("Progress tester
@@ -40,7 +40,10 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
- m_opaque_up->Increment(amount, description);
+ std::optional description_opt;
+ if (description)
-
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux`
running on `ppc64le-sanitizer` while building `lldb,llvm,utils` at step 2
"annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/72/builds/8614
Here is the relevant piec
adrian-prantl wrote:
It might be worth exploring a SourceManager subclass that has in addition to a
MemoryBuffer-backed location also a source file type that is a file/line
variant that is only converted into a MemoryBuffer-backed location if we do an
operation that really needs it.
https://g
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/124648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: John Harrison
Date: 2025-02-26T11:29:13-08:00
New Revision: 1e246704e23e3dcae16adbf68cc10b668a8db680
URL:
https://github.com/llvm/llvm-project/commit/1e246704e23e3dcae16adbf68cc10b668a8db680
DIFF:
https://github.com/llvm/llvm-project/commit/1e246704e23e3dcae16adbf68cc10b668a8db680.diff
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/128750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
> Is it worth keeping `InputStream` and `OutputStream` around? Can we use a
> `(Stream)File` directly?
I'll take a look at removing them as part of the refactoring to support
'cancel' requests. I think it makes sense.
https://github.com/llvm/llvm-project/pull/128750
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 1/7] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related
metho
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 0587ba8239dbbd22aa40bde23d61f9504975817d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/9] Only include title on the first message
---
lldb/include/l
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel`
running on `ppc64le-clang-rhel-test` while building `lldb,llvm,utils` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/145/builds/5321
Here is the r
oontvoo wrote:
I think this is ready for review now. New changes:
- Incorporate the enable-telemetry flag from the other PR to get rid of all
the ifdefs
- remove process-exit/startup data from this - stick to debugger's
exit/startup only.
+ I'd like to find the right place to report de
https://github.com/JDevlieghere approved this pull request.
⬅️
https://github.com/llvm/llvm-project/pull/128874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 01/11] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 01/12] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details
@@ -835,7 +835,8 @@ option (LLVM_ENABLE_DOXYGEN "Use doxygen to generate llvm
API documentation." OF
option (LLVM_ENABLE_SPHINX "Use Sphinx to generate llvm documentation." OFF)
option (LLVM_ENABLE_OCAMLDOC "Build OCaml bindings documentation." ON)
option (LLVM_ENABLE_BINDINGS
@@ -21,6 +21,8 @@ void TelemetryInfo::serialize(Serializer &serializer) const {
}
Error Manager::dispatch(TelemetryInfo *Entry) {
+ assert(Config::BuildTimeEnableTelemetry &&
+ "Telemetry should have been enabled");
oontvoo wrote:
done
https://githu
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 01/14] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 01/13] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff eacbcbe47744a496ad1651ebd65914f9e6a66f85
a72c7db93aa9c04fbe48e058f5e2c829a608252f --e
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/128893
The LLDB SB API headers should be -Wdocumentation clean as they might get
included by projects building with -Wdocumentation. Although I'd love for all
of LLDB to be clean, we're pretty far removed from th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The LLDB SB API headers should be -Wdocumentation clean as they might get
included by projects building with -Wdocumentation. Although I'd love for all
of LLDB to be clean, we're pretty far removed
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/128874
>From 51e6692e62331b801fe23217c21657e6365179d1 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 26 Feb 2025 14:42:14 +0100
Subject: [PATCH 1/2] [lldb] Deindent UnwindAssemblyInstEmulation
by two levels usi
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/128874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/128874
by two levels using early returns.
>From 901fc9d22499bc67d9da944fea138e29c803c44d Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 26 Feb 2025 14:42:14 +0100
Subject: [PATCH] [lldb] Deindent UnwindAssembly
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/128874
>From 51e6692e62331b801fe23217c21657e6365179d1 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 26 Feb 2025 14:42:14 +0100
Subject: [PATCH] [lldb] Deindent UnwindAssemblyInstEmulation
by two levels using e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
by two levels using early returns.
---
Patch is 22.17 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/128874.diff
1 Files Affected:
- (modified)
lldb/source/Plug
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 01/15] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details
@@ -462,6 +462,10 @@ void Thread::ResetStopInfo() {
}
void Thread::SetStopInfo(const lldb::StopInfoSP &stop_info_sp) {
+ if (stop_info_sp &&
+ stop_info_sp->GetStopReason() == lldb::eStopReasonBreakpoint)
+SetThreadHitBreakpointSite();
JDevlieghere w
Author: Jonas Devlieghere
Date: 2025-02-26T10:23:28-06:00
New Revision: 15ee9d91fbb55a507a8f0bce7d3d66a825c6ec30
URL:
https://github.com/llvm/llvm-project/commit/15ee9d91fbb55a507a8f0bce7d3d66a825c6ec30
DIFF:
https://github.com/llvm/llvm-project/commit/15ee9d91fbb55a507a8f0bce7d3d66a825c6ec30.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/128893
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/128957
This adds support for launching lldb-dap in server mode. The extension will
start lldb-dap in server mode on-demand and retain the server until the VSCode
window is closed (when the extension context is disposed
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds support for launching lldb-dap in server mode. The extension will
start lldb-dap in server mode on-demand and retain the server until the VSCode
window is closed (when the extension context is dispo
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128957
>From e95459a73ad5a1448841ed6c2422f66b23f6b486 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 26 Feb 2025 14:56:10 -0800
Subject: [PATCH 1/2] [lldb-dap] Adding server mode support to lldb-dap VSCode
ext
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/128949
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/128971
This fixes the obvious, but untested case of sending None/Null to SBProgress.
This was an oversight on my part.
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date:
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/128966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
This fixes the obvious, but untested case of sending None/Null to SBProgress.
This was an oversight on my part.
---
Full diff: https://github.com/llvm/llvm-project/pull/128971.diff
2 Files Affected:
- (mo
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an
associated
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an
associated
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/128972
This removes the previous 'OutputStream' and 'InputStream' objects and the new
'Transport' class takes on the responsibility of serializing and encoding
messages.
The new Protocol.h file has a dedicated namespa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128972
>From 397c479a8238a06e81c53c2735aa361ae12a5f42 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 26 Feb 2025 11:29:46 -0800
Subject: [PATCH] [lldb-dap] Creating a dedicated Transport mechnaism for
handling
@@ -40,7 +40,10 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
- m_opaque_up->Increment(amount, description);
+ std::optional description_opt;
+ if (description && des
@@ -40,7 +40,10 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
- m_opaque_up->Increment(amount, description);
+ std::optional description_opt;
+ if (description && des
@@ -33,3 +33,15 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_with_external_bit_set(self):
+"
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/128971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128971
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:48:14 -0800
Subject: [PATCH 1/2] Fix bad optional access in sbprogress
---
lldb/source/API/
@@ -33,3 +33,15 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_with_external_bit_set(self):
+"
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/128966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -33,3 +33,17 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_progress_finalize(self):
+"""Te
@@ -33,3 +33,17 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_progress_finalize(self):
--
@@ -59,6 +59,11 @@ class LLDB_API SBProgress {
void Increment(uint64_t amount, const char *description = nullptr);
+ /// Explicitly finalize an SBProgress, this can be used to terminate a
+ /// progress on command instead of waiting for a garbage collection or other
+ //
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when
Progress::Increment() is called, and also will make sure that a progress
completed update is reported even if the user doesn't explicitly cause one
to be sent.") lldb::SBProgress;
@@ -40,7 +40,10 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
- m_opaque_up->Increment(amount, description);
+ std::optional description_opt;
+ if (description && des
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/128971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dmpots approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/128971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-02-26T18:34:21-06:00
New Revision: f409340cc217c55c3960a375054a17b2bc927e53
URL:
https://github.com/llvm/llvm-project/commit/f409340cc217c55c3960a375054a17b2bc927e53
DIFF:
https://github.com/llvm/llvm-project/commit/f409340cc217c55c3960a375054a17b2bc927e53.d
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128971
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:48:14 -0800
Subject: [PATCH 1/3] Fix bad optional access in sbprogress
---
lldb/source/API/
@@ -33,3 +33,22 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_with_external_bit_set(self):
+"
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an
associated
@@ -33,3 +33,17 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_progress_finalize(self):
+"""Te
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when
Progress::Increment() is called, and also will make sure that a progress
completed update is reported even if the user doesn't explicitly cause one
to be sent.") lldb::SBProgress;
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/128949
>From 679e038a2322fdf884eb22baafe9167904e27dd7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 26 Feb 2025 16:29:26 -0600
Subject: [PATCH 1/2] [lldb-dap] Gardening in lldb-dap.cpp (NFC)
- Remo
@@ -40,7 +40,17 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
+ if (!m_opaque_up)
+return;
+
m_opaque_up->Increment(amount, description);
}
+void SBProgress::
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/128951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/128986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-02-26T13:01:53-05:00
New Revision: 159b872b37363511a359c800bcc9230bb09f2457
URL:
https://github.com/llvm/llvm-project/commit/159b872b37363511a359c800bcc9230bb09f2457
DIFF:
https://github.com/llvm/llvm-project/commit/159b872b37363511a359c800bcc9230bb09f2457.diff
LOG
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/128534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 1/5] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related
metho
kazutakahirata wrote:
@oontvoo I've landed 5a5a9e79369ae6cf320fc7b79a48d3e8b60f19a9 to fix a warning.
Thanks!
https://github.com/llvm/llvm-project/pull/128534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/128750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM.
Since you're here... how would you feel about a little renaissance and
returning a `std::optional` to eliminate the `index_ptr`?
https://github.com/llvm/llvm-project/pull/127799
___
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 1/8] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related
metho
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 0587ba8239dbbd22aa40bde23d61f9504975817d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/9] Only include title on the first message
---
lldb/include/l
jasonmolenda wrote:
Felipe and I have been discussing these mechanisms all this week, and one edge
case would be a thread that hits a breakpoint instruction, and the bp has a
thread ID match requirement which this thread doesn't satisfy. In that
scenario, the thread will not have an eStopReas
jasonmolenda wrote:
I'm not sure if this edge case can come up with this MemoryThread use cases.
https://github.com/llvm/llvm-project/pull/128726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -226,13 +227,45 @@ lldb::SBError SBDebugger::InitializeWithErrorHandling() {
return error;
}
+#if LLVM_ENABLE_TELEMETRY
+#if ENABLE_BACKTRACES
+static void TelemetryHandler(void *) {
+ // TODO: get the bt into the msg?
+ // Also need to pre-alloc the memory for this ent
https://github.com/matthewbastien created
https://github.com/llvm/llvm-project/pull/128943
Adds a process picker command to the LLDB DAP extension that will prompt the
user to select a process running on their machine. It is hidden from the
command palette, but can be used in an `"attach"` deb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Matthew Bastien (matthewbastien)
Changes
Adds a process picker command to the LLDB DAP extension that will prompt the
user to select a process running on their machine. It is hidden from the
command palette, but can be used in an `"attach"
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 1/3] add a process picker for attaching by PID
---
lld
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/128726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Yup, as Jason said, we have been thinking about this and we believe there may
be a better way of doing this! I'm going to close this PR for now
https://github.com/llvm/llvm-project/pull/128726
___
lldb-commits mailing list
lldb-c
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 1/4] add a process picker for attaching by PID
---
lld
@@ -12,6 +12,41 @@
class TestDAP_progress(lldbdap_testcase.DAPTestCaseBase):
+def verify_progress_events(
+self,
+expected_title,
+expected_message=None,
+expected_not_in_message=None,
+only_verify_first_update=False,
+):
+
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/124648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -37,7 +37,11 @@ def create_options(cls):
)
parser.add_option(
-"--total", dest="total", help="Total to count up.", type="int"
+"--total",
+dest="total",
+help="Total to count up, use None to identify as indeter
https://github.com/clayborg requested changes to this pull request.
Reading Progress.h/.cpp, I see that Increment will do nothing for non
deterministic progress objects. We really should add a dedicated `void
SBProgress::Finished()` to allow objects to say when they are done, there are
no guar
@@ -35,14 +59,47 @@ static void ProgressEventThreadFunction(DAP &dap) {
done = true;
}
} else {
-uint64_t progress_id = 0;
-uint64_t completed = 0;
-uint64_t total = 0;
-bool is_debugger_specific = false;
-const ch
JDevlieghere wrote:
It's a little unfortunate that listing processes is not part of the Debug
Adapter Protocol. LLDB already knows how to do this through the host platform.
I guess even more unfortunate is that neither node nor VSCode provides a cross
platform API to do this.
I was expecting
matthewbastien wrote:
Yeah, the CodeLLDB extension uses `lldb` to print the processes for the current
platform (which could be a possibility as well, though then you'd also have to
have an option to specify the `lldb` executable alongside `lldb-dap`). I'd
rather have a NodeJS approach if only
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/128986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-02-26T19:14:49-08:00
New Revision: 354eb88285c0d803b0674a3b2961b4109905383a
URL:
https://github.com/llvm/llvm-project/commit/354eb88285c0d803b0674a3b2961b4109905383a
DIFF:
https://github.com/llvm/llvm-project/commit/354eb88285c0d803b0674a3b2961b4109905383a.diff
LOG:
1 - 100 of 122 matches
Mail list logo
