https://github.com/clayborg requested changes to this pull request.

Reading Progress.h/.cpp, I see that Increment will do nothing for non 
deterministic progress objects. We really should add a dedicated `void 
SBProgress::Finished()` to allow objects to say when they are done, there are 
no guarantees of when the object will be destroyed. So we should do that here 
to clean this issue up and guarantee we don't cause these tests to run longer 
than needed.

https://github.com/llvm/llvm-project/pull/124648
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to