[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Assert correct values in APInt constructor (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 7467ecf67c706ffdfa79eaebdc9528002b74c5af Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fix bitwidth (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
nikic wrote: I think this is ready for review now. I've landed many parts of this PR separately already, and am happy to land this in parts (or split as needed). https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Matt Arsenault via lldb-commits
@@ -4377,7 +4377,7 @@ AMDGPUInstructionSelector::selectGlobalSAddr(MachineOperand &Root) const { // instructions to perform VALU adds with immediates or inline literals. unsigned NumLiterals = !TII.isInlineConstant(APInt(32, ConstOffset & 0xfff

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Matt Arsenault via lldb-commits
@@ -1806,7 +1806,7 @@ bool AMDGPUDAGToDAGISel::SelectGlobalSAddr(SDNode *N, // instructions to perform VALU adds with immediates or inline literals. unsigned NumLiterals = !TII->isInlineConstant(APInt(32, COffsetVal & 0x)) + - !TII->isInli

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0f97b4824a8cf040bd3ce7b644dee9d60065ac61 5588503e8b8f225d142681cdf21a2b7f8fc0a734 --e

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-20 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/106950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-20 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/106950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Introduce `ScriptedStopHook{, Python}Interface` & make use of it (PR #105449)

2024-09-20 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/5268 Here is the relevant piece of the bu

[Lldb-commits] [lldb] [lldb/Interpreter] Introduce `ScriptedStopHook{, Python}Interface` & make use of it (PR #105449)

2024-09-20 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/4137 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Pavel Labath via lldb-commits
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType( m_fallback.GetFullyQualifiedType(context, callback); } +bool DebugNamesDWARFIndex::SameAsEntryATName( +llvm::StringRef query_name, const DebugNames::Entry &entry) const { + auto maybe_dieoffset = en

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread Abhina Sree via lldb-commits
@@ -323,10 +325,11 @@ ErrorOr RealFileSystem::status(const Twine &Path) { } ErrorOr> -RealFileSystem::openFileForRead(const Twine &Name) { +RealFileSystem::openFileForRead(const Twine &Name, bool IsText) { SmallString<256> RealName, Storage; Expected FDOrErr = sys::fs::

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Pavel Labath via lldb-commits
labath wrote: > Is it worth splitting this into two PRs (one for the type lookup and one for > namespaces)? Maybe, but I think it may even be better to split it along the optimization-type axis (the die offset thingy vs. the parent chain). https://github.com/llvm/llvm-project/pull/108907

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Pavel Labath via lldb-commits
labath wrote: > > I'm also not sure where's the " NameEntry> mapping > > table" you mention in the description. Could you point me to it? > > @labath, that is the first prototype I tried, but benchmark shows it did not > improve any performance because the time to build this mapping offsets an

[Lldb-commits] [lldb] [lldb/Interpreter] Introduce `ScriptedStopHook{, Python}Interface` & make use of it (PR #105449)

2024-09-20 Thread David Spickett via lldb-commits
@@ -269,21 +274,7 @@ void *lldb_private::python::SWIGBridge::LLDBSWIGPython_GetDynamicSetting( } python::PythonObject -lldb_private::python::SWIGBridge::LLDBSwigPythonCreateScriptedStopHook( -lldb::TargetSP target_sp, const char *python_class_name, -const char *sessio

[Lldb-commits] [lldb] 76b827b - [lldb] Fix SWIG wrapper compilation error

2024-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-09-20T09:41:07Z New Revision: 76b827bb4d5b4cc4d3229c4c6de2529e8b156810 URL: https://github.com/llvm/llvm-project/commit/76b827bb4d5b4cc4d3229c4c6de2529e8b156810 DIFF: https://github.com/llvm/llvm-project/commit/76b827bb4d5b4cc4d3229c4c6de2529e8b156810.diff LOG

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 511445e35376c904be454ed987786cb6faa70a81 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/4] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes Sometimes you only want to temporarily disable a frame recognizer instead of deleting it. In particular, when dealing with one of the builtin frame recognizers, which cannot be restored after dele

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/5] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread kadir çetinkaya via lldb-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/107906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread kadir çetinkaya via lldb-commits
https://github.com/kadircet commented: hi sorry for missing this during the review time, i believe this change is changing some of the core support library interfaces in a way that's not justified. this is an interface implemented by quite a lot of both upstream and downstream clients, but th

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread kadir çetinkaya via lldb-commits
@@ -121,8 +121,18 @@ ContentCache::getBufferOrNone(DiagnosticsEngine &Diag, FileManager &FM, // Start with the assumption that the buffer is invalid to simplify early // return paths. IsBufferInvalid = true; - - auto BufferOrError = FM.getBufferForFile(*ContentsEntry, I

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread kadir çetinkaya via lldb-commits
@@ -323,10 +325,11 @@ ErrorOr RealFileSystem::status(const Twine &Path) { } ErrorOr> -RealFileSystem::openFileForRead(const Twine &Name) { +RealFileSystem::openFileForRead(const Twine &Name, bool IsText) { SmallString<256> RealName, Storage; Expected FDOrErr = sys::fs::

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread kadir çetinkaya via lldb-commits
kadircet wrote: i've also just noticed https://github.com/llvm/llvm-project/commit/3b3accb598ec87a6a30b0e18ded06071030bb78f, which seem to be pushed without review and any tests, changing behavior more in a non-obvious way. Please not that logic you have in: ``` Expected FDOrErr = sys::fs::o

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
@@ -1806,7 +1806,7 @@ bool AMDGPUDAGToDAGISel::SelectGlobalSAddr(SDNode *N, // instructions to perform VALU adds with immediates or inline literals. unsigned NumLiterals = !TII->isInlineConstant(APInt(32, COffsetVal & 0x)) + - !TII->isInli

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread Abhina Sree via lldb-commits
abhina-sree wrote: > 3b3accb Hi, sure I will revert the two changes so we can discuss further. The OF_Text flag only affects the z/OS platform behaviour, the OF_TextWithCRLF will affect z/OS and Windows. On other platforms, the flag doesn't show any difference in behaviour that I'm aware of

[Lldb-commits] [lldb] efdb3ae - Revert "[SystemZ][z/OS] Propagate IsText parameter to open text files as text (#107906)"

2024-09-20 Thread Abhina Sreeskantharajan via lldb-commits
Author: Abhina Sreeskantharajan Date: 2024-09-20T08:18:16-04:00 New Revision: efdb3ae23247850d3886e3708400f0d991ed59e1 URL: https://github.com/llvm/llvm-project/commit/efdb3ae23247850d3886e3708400f0d991ed59e1 DIFF: https://github.com/llvm/llvm-project/commit/efdb3ae23247850d3886e3708400f0d991ed

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang ready_for_review https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
@@ -76,6 +76,79 @@ using namespace lldb; using namespace lldb_private; +namespace { + +struct ExecutableInstaller { + + ExecutableInstaller(PlatformSP platform, ModuleSP module) + : m_platform{platform}, m_module{module}, +m_local_file{m_module->GetFileSpec()}, +

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Found by @tschuett on https://github.com/llvm/llvm-project/issues/109119. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This got deleted in e078c9507c3abb4d9bb2265c366b26557880a3e3, I presume accidentally, because it didn't have a corresponding rst file for it. So I've brought it back and converted it into Markdown. Th

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread kadir çetinkaya via lldb-commits
kadircet wrote: thanks a lot for the swift response! I can see how none of these implementations are not using those flags _today_, but we're changing the observable behavior for them as well, and if some of those implementations decides to give meaning to these flags, it might be impossible

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType( m_fallback.GetFullyQualifiedType(context, callback); } +bool DebugNamesDWARFIndex::SameAsEntryATName( +llvm::StringRef query_name, const DebugNames::Entry &entry) const { + auto maybe_dieoffset = en

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/109427 This got deleted in e078c9507c3abb4d9bb2265c366b26557880a3e3, I presume accidentally, because it didn't have a corresponding rst file for it. So I've brought it back and converted it into Markdown. The co

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Thorsten Schütt via lldb-commits
tschuett wrote: Thanks! https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1553714 - Revert "[lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)"

2024-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-09-20T15:18:45+01:00 New Revision: 1553714b0093a8ef907faf3b3145c224caa7364a URL: https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a DIFF: https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a.diff

[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-20 Thread via lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: I've reverted this https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a. I feel like the solution isn't that complicated but it's close to end of the work day for me and I'd like to see the bot green again. If you have a suggestion on how t

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Output from the 2 failures: ``` FAIL: test_file_fail (TestGDBRemotePlatformFile.TestGDBRemotePlatformFile.test_file_fail) Test mocked failures of remote operations -- Traceback (most recent call last)

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -444,6 +492,98 @@ void DebugNamesDWARFIndex::GetNamespaces( m_fallback.GetNamespaces(name, callback); } +void DebugNamesDWARFIndex::GetNamespacesWithParents( +ConstString name, llvm::ArrayRef parent_names, +llvm::function_ref callback) { + Progress progress("Get

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType( m_fallback.GetFullyQualifiedType(context, callback); } +bool DebugNamesDWARFIndex::SameAsEntryATName( +llvm::StringRef query_name, const DebugNames::Entry &entry) const { + auto maybe_dieoffset = en

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread Abhina Sree via lldb-commits
abhina-sree wrote: > thanks a lot for the swift response! > > I can see how none of these implementations are not using those flags > _today_, but we're changing the observable behavior for them as well, and if > some of those implementations decides to give meaning to these flags, it > might

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-20 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain( return true; } +bool DebugNamesDWARFIndex::WithinParentChain( +llvm::ArrayRef query_parent_names, +llvm::ArrayRef parent_chain) const { + if (parent_chain.size() < query_parent_names.size()) +retur

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Thorsten Schütt via lldb-commits
tschuett wrote: LLDB docs seem to rst. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor Target::Install function (PR #108996)

2024-09-20 Thread via lldb-commits
dlav-sc wrote: > Looks good to me. Thank you for the review. I haven't merge rights yet, so could you press the button, please. https://github.com/llvm/llvm-project/pull/108996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Mostly RST yes, but we have a few recent documents in Markdown which I enabled support for in https://github.com/llvm/llvm-project/pull/89716. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-09-20 Thread via lldb-commits
satmandu wrote: Worth noting that this affects mesa too: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11896 https://github.com/llvm/llvm-project/pull/97824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Thorsten Schütt via lldb-commits
@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 17ba7e8538a2a4cc7b17322d26e8ea83ce27d617 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -1 +0,0 @@ -objc vogelsgesang wrote: The intended test coverage of this test case seems to be to test the frame recognizers as indicated by the file path. Making making it run also on non-Mac platforms, we are hence gaining test coverage on other systems. T

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread John Harrison via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread John Harrison via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread John Harrison via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Module test comments, LGTM https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
@@ -395,6 +389,138 @@ def test_frame_recognizer_not_only_first_instruction(self): variables.GetValueAtIndex(1).GetValueType(), lldb.eValueTypeVariableArgument ) +def test_frame_recognizer_disable(self): +self.build() +exe = self.getBui

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/8] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I think this page leaves a lot to be desired but it's a good start. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: I can't really say if the content is correct, but this was definitely an informative read https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/109440 When running a oneliner script expression, if the script interpreter returned a value, that value would be printed to the debugger standard output straight from the interpreter instead of being propagated

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes When running a oneliner script expression, if the script interpreter returned a value, that value would be printed to the debugger standard output straight from the interpreter instead of being pro

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
@@ -1 +0,0 @@ -objc Michael137 wrote: Yea that's fair, there doesn't seem to be anything objc specific here, so seems ok to turn it into C and enable it on all platforms. The original change that introduced these did mention Objective-C as one of the motivator

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 65c5706 - [lldb-dap][docs] Improve README (#109266)

2024-09-20 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-20T22:18:19+02:00 New Revision: 65c57066e099fe7f1357485cd6c4fb068bc82323 URL: https://github.com/llvm/llvm-project/commit/65c57066e099fe7f1357485cd6c4fb068bc82323 DIFF: https://github.com/llvm/llvm-project/commit/65c57066e099fe7f1357485cd6c4fb068bc82323

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d8d252f - [lldb] Add support for disabling frame recognizers (#109219)

2024-09-20 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-20T22:17:42+02:00 New Revision: d8d252fe96877f9fdbf6b0b6c19da543e796bb84 URL: https://github.com/llvm/llvm-project/commit/d8d252fe96877f9fdbf6b0b6c19da543e796bb84 DIFF: https://github.com/llvm/llvm-project/commit/d8d252fe96877f9fdbf6b0b6c19da543e796bb84

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From a7876a20b5caa53dace056c84a1b7f1e798088f0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/3] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/109477 This patch adds the support to `Process.cpp` to automatically save off TLS sections, either via loading the memory region for the module, or via reading `fs_base` via generic register. Then when Minidumps are l

[Lldb-commits] [lldb] 2011cbc - [lldb-dap] Add feature to remember last non-empty expression. (#107485)

2024-09-20 Thread via lldb-commits
Author: cmtice Date: 2024-09-20T14:04:44-07:00 New Revision: 2011cbcd84102236dd6d58e2079ac676a3403f25 URL: https://github.com/llvm/llvm-project/commit/2011cbcd84102236dd6d58e2079ac676a3403f25 DIFF: https://github.com/llvm/llvm-project/commit/2011cbcd84102236dd6d58e2079ac676a3403f25.diff LOG: [

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-20 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/107485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes This patch adds the support to `Process.cpp` to automatically save off TLS sections, either via loading the memory region for the module, or via reading `fs_base` via generic register. Then when Minidumps ar

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben converted_to_draft https://github.com/llvm/llvm-project/pull/109440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109485 The `readMemory` request used the `MemoryRegionInfo` so it could also support short reads. Since #106532, this is no longer necessary, as mentioned by @labath in a comment on #104317. We no longer set the

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes The `readMemory` request used the `MemoryRegionInfo` so it could also support short reads. Since #106532, this is no longer necessary, as mentioned by @labath in a comment on #104317. We no longe

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread via lldb-commits
jimingham wrote: Now that successful results show up in the command return object, it's a little strange that if the expression fails - a parse error or whatever - that is not available in the command result. It would be more consistent if we did SetError on the command result object with the

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Thanks for that thoughtful write-up! #109485 should address your points > The method I'd recommend is to call `ReadMemory` I assume I should prefer `Target::ReadMemory` over `Process::readMemory`, right? https://github.com/llvm/llvm-project/pull/104317

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 65c57066e099fe7f1357485cd6c4fb068bc82323 48718649469aae62b2945e7de22cf7280316b757 --e

  1   2   >