Michael137 wrote:
> I'm not sure I understand because this will break the logic that is currently
> in place. Many nuances in post-processing wouldn't be possible to implement
> with a simple short-circuit. If a symbol is found in the hinted module, it
> might be internal. `IRExecutionUnit::Fi
tru wrote:
This was suggested in https://github.com/llvm/llvm-project/pull/91856 and the
suggestion there was that we need to split it up per sub-project which is
something @e-kwsm has been doing:
https://github.com/llvm/llvm-project/pulls/e-kwsm so I don't think this one is
needed.
https://
@@ -4082,6 +4084,260 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "SetInstructionBreakpointsRequest" : {
+// "allOf" : [
+// {"$ref" : "#/definitions/Request"}, {
+//
@@ -766,6 +766,102 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame) {
return llvm::json::Value(std::move(object));
}
+// Response to `setInstructionBreakpoints` request.
+// "Breakpoint": {
+// "type": "object",
+// "description": "Response to `setInstructionB
@@ -53,10 +54,32 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
public:
LibCXXFrameRecognizer()
- : m_hidden_function_regex(
-R"(^std::__1::(__function.*::operator\(\)|__invoke))"
-R"((\[.*\])?)"// ABI tag.
-R"(( c
@@ -196,8 +197,8 @@
AbortWithPayloadFrameRecognizer::RecognizeFrame(lldb::StackFrameSP frame_sp) {
abort_dict_sp->AddStringItem(reason_key, reason_string);
abort_dict_sp->AddIntegerItem(flags_key, flags_val);
- // This will overwrite the abort_with_payload information in
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/5] [lldb-dap] Add frame recognizers for libc++ `std:
tuliom wrote:
> Is there an out-of-tree scenario where CLANG_RESOURCE_DIR needs to be
> replaced with something else at runtime, i.e. a real use-case for the
> optional CustomResourceDir optional argument I removed?
@kimgr I have also looked for this and I haven't found an use-case where this
tuliom wrote:
> Do we need anything more to make progress with this PR?
@kimgr Do you have committer permission? Would you like some help to get this
merged?
https://github.com/llvm/llvm-project/pull/103388
___
lldb-commits mailing list
lldb-commits@
labath wrote:
I think that having fewer knobs that one needs to remember to set to correct
values is better. Sometimes that's unavoidable, but I wanted to make sure this
is one of those cases. Embedding this information into the swig bindings sounds
like a good idea.
https://github.com/llvm/l
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/104787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DmT021 updated
https://github.com/llvm/llvm-project/pull/106030
>From 9cc21bfd87a7836e9264ed6ef958ac5246c5ed53 Mon Sep 17 00:00:00 2001
From: Dmitrii Galimzianov
Date: Mon, 26 Aug 2024 15:52:17 +0200
Subject: [PATCH] Add logs for SymbolFileDWARF::FindTypes
---
.../SymbolFil
DmT021 wrote:
@Michael137 Ok, added another message after the search
https://github.com/llvm/llvm-project/pull/106030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-08-26T18:26:46+04:00
New Revision: 06ccd32bb7b26b84448036c18e7191d9e56adc82
URL:
https://github.com/llvm/llvm-project/commit/06ccd32bb7b26b84448036c18e7191d9e56adc82
DIFF:
https://github.com/llvm/llvm-project/commit/06ccd32bb7b26b84448036c18e7191d9e56adc82.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/104787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
santhoshe447 wrote:
Hi Everyone,
Thanks for everyone's valuable feedback. Pls let me know if all are ok with the
changes.
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
labath wrote:
Thanks.
https://github.com/llvm/llvm-project/pull/104896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dlav-sc closed
https://github.com/llvm/llvm-project/pull/99045
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,107 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -213,7 +229,7 @@ endif
LIMIT_DEBUG_INFO_FLAGS =
NO_LIMIT_DEBUG_INFO_FLAGS =
MODULE_DEBUG_INFO_FLAGS =
-ifneq (,$(findstring clang,$(CC)))
+ifeq ($(CCC), clang)
labath wrote:
What does CCC stand for?
https://github.com/llvm/llvm-project/pull/102185
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -102,15 +102,33 @@ endif
# If you change the defaults of CC, be sure to also change it in the file
# test/builders/builder_base.py, which provides a Python way to return the
# value of the make variable CC -- getCompiler().
-#
-# See also these functions:
-# o cxx_compiler
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 1d4949f447ab4e2855dd17bcfa250cb2749aab68 Mon Sep 17 00:00:00 2001
From: Dmitry Vassiliev
Date: Mon, 26 Aug 2024 19:35:55 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen
https://github.com/slydiman deleted
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/105990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1193f7d6487d2d94009f8d8d27da3907136482b9...e9ffeeaf7a0bf70c58a04315e451ba4553765586
.gith
https://github.com/adrian-prantl approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
This LGTM. I'd just want a rename from `instructionReference` to
`addressReference` or `instructionAddressReference` for clarity.
https://github.com/llvm/llvm-project/pull/105278
___
lldb
@@ -0,0 +1,36 @@
+//===-- InstructionBreakpoint.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifi
@@ -4082,6 +4084,254 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "SetInstructionBreakpointsRequest" : {
+// "allOf" : [
+// {"$ref" : "#/definitions/Request"}, {
+//
@@ -893,7 +957,13 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
body.try_emplace("reason", "exception");
EmplaceSafeString(body, "description", exc_bp->label);
} else {
- body.try_emplace("reason", "breakpoint");
+ InstructionBreakp
@@ -996,4 +996,33 @@ void DAP::SetThreadFormat(llvm::StringRef format) {
}
}
+InstructionBreakpoint *
+DAP::GetInstructionBreakpoint(const lldb::break_id_t bp_id) {
+
walter-erquinigo wrote:
remove this line
https://github.com/llvm/llvm-project/pull/105278
negril wrote:
> This was suggested in #91856 and the suggestion there was that we need to
> split it up per sub-project which is something @e-kwsm has been doing:
> https://github.com/llvm/llvm-project/pulls/e-kwsm so I don't think this one
> is needed.
That PR is 3 months old? What are the o
https://github.com/walter-erquinigo approved this pull request.
This LGTM, and thank you for your diligence with writing tests.
https://github.com/llvm/llvm-project/pull/105905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
boomanaiden154 wrote:
> That PR is 3 months old? What are the odds or the timeline of it getting
> merged?
Probably whenever the author gets back to reviewers. There might be a couple
rounds of review before things get pushed through, but patches for two
subprojects have landed already.
The
ashgti wrote:
@jeffreytan81 I moved the expensive call into the `exceptionInfo` request, this
is only going to be triggered if a thread has the stop event = 'exception', so
it shouldn't be triggered while stepping. This does remove the option you added
in the prior commit, since I think this i
negril wrote:
> > That PR is 3 months old? What are the odds or the timeline of it getting
> > merged?
>
> Probably whenever the author gets back to reviewers. There might be a couple
> rounds of review before things get pushed through, but patches for two
> subprojects have landed already.
>
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
mbucko wrote:
> Let me know if you guys don't want this patch in. I will closed it and apply
> it to our local branch. @jasonmolenda @labath
@labath just a friendly ping
https://github.com/llvm/llvm-project/pull/102536
___
lldb-commits mailing list
l
https://github.com/thesamesam edited
https://github.com/llvm/llvm-project/pull/105990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-08-26T10:05:30-07:00
New Revision: bbf2781bc49aee4d7ee8ec40dcf7316db360c454
URL:
https://github.com/llvm/llvm-project/commit/bbf2781bc49aee4d7ee8ec40dcf7316db360c454
DIFF:
https://github.com/llvm/llvm-project/commit/bbf2781bc49aee4d7ee8ec40dcf7316db360c454.diff
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 1/3] [lldb][test] Improve toolchain detection in
Makef
jimingham wrote:
This is compiling the "get me extended backtrace info function". That's a
ClangFunction, so we should only compile it once and then reuse it for the rest
of the session. Is it possible we aren't reusing this? After all, this is a
compile of a function that's pretty careful
kimgr wrote:
> > Is there an out-of-tree scenario where CLANG_RESOURCE_DIR needs to be
> > replaced with something else at runtime, i.e. a real use-case for the
> > optional CustomResourceDir optional argument I removed?
>
> @kimgr I have also looked for this and I haven't found an use-case wh
kimgr wrote:
> > Do we need anything more to make progress with this PR?
>
> @kimgr Do you have committer permission? Would you like some help to get this
> merged?
Oh, no, I don't, I would need someone to merge this for me. It's still pretty
early in the v.20 cycle, right, so maybe this is a
tuliom wrote:
Agreed. Let me merge this.
https://github.com/llvm/llvm-project/pull/103388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kim Gräsman
Date: 2024-08-26T14:49:56-03:00
New Revision: 924a7d83b4287b3b85dd1ca29d2d3e1f0a10ea68
URL:
https://github.com/llvm/llvm-project/commit/924a7d83b4287b3b85dd1ca29d2d3e1f0a10ea68
DIFF:
https://github.com/llvm/llvm-project/commit/924a7d83b4287b3b85dd1ca29d2d3e1f0a10ea68.diff
L
https://github.com/tuliom closed
https://github.com/llvm/llvm-project/pull/103388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -996,4 +996,33 @@ void DAP::SetThreadFormat(llvm::StringRef format) {
}
}
+InstructionBreakpoint *
+DAP::GetInstructionBreakpoint(const lldb::break_id_t bp_id) {
+
santhoshe447 wrote:
I did not understand this.
https://github.com/llvm/llvm-project/pull/
@@ -0,0 +1,36 @@
+//===-- InstructionBreakpoint.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifi
@@ -996,4 +996,33 @@ void DAP::SetThreadFormat(llvm::StringRef format) {
}
}
+InstructionBreakpoint *
+DAP::GetInstructionBreakpoint(const lldb::break_id_t bp_id) {
+
walter-erquinigo wrote:
The empty line :) Just to keep consistency with the rest of the co
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/106030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kimgr wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/103388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Santhosh Kumar Ellendula
Date: 2024-08-27T00:19:39+05:30
New Revision: 89c27d6b07dd03a71e5692caa4e20ab14f948921
URL:
https://github.com/llvm/llvm-project/commit/89c27d6b07dd03a71e5692caa4e20ab14f948921
DIFF:
https://github.com/llvm/llvm-project/commit/89c27d6b07dd03a71e5692caa4e20ab14f9
https://github.com/santhoshe447 closed
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
I don't know much about the documentation but I added the two people who touch
it more frequently than anyone else.
https://github.com/llvm/llvm-project/pull/104847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -2779,7 +2788,19 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
return !results.Done(query); // Keep iterating if we aren't done.
});
- if (results.Done(query))
+ auto CheckIsDoneAndLog = [&results, &query, log, type_basename, th
@@ -2779,7 +2788,19 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
return !results.Done(query); // Keep iterating if we aren't done.
});
- if (results.Done(query))
+ auto CheckIsDoneAndLog = [&results, &query, log, type_basename, th
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/106030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
petrhosek wrote:
@vogelsgesang Can we please merge this PR to unbreak the builders that were
broken by #104523?
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/1866
Here is the relevant piece of t
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/104847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> Requires myst_parser 0.19.0 (specifically
> [executablebooks/MyST-Parser#696](https://github.com/executablebooks/MyST-Parser/pull/696))
> which is over a year old by now. Do we mandate any minimum version for these
> dependencies?
Kinda:
[llvm/docs/requirements.txt](htt
medismailben wrote:
Nice! Please make sure to run the python formatter (`darker`) before landing
this.
https://github.com/llvm/llvm-project/pull/105990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/106157
Without calling `dyld_process_dispose`, LLDB will leak the memory associated
with the `dyld_process_t`.
rdar://134738265
>From 62bd1e90ea84cfb7bd6d18529918be544d036221 Mon Sep 17 00:00:00 2001
From: Alex Lan
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
Without calling `dyld_process_dispose`, LLDB will leak the memory associated
with the `dyld_process_t`.
rdar://134738265
---
Full diff: https://github.com/llvm/llvm-project/pull/106157.diff
1 Files Affe
@@ -1085,6 +1084,17 @@ std::string
VariableDescription::GetResult(llvm::StringRef context) {
return description.trim().str();
}
+std::optional GetMemoryReference(lldb::SBValue v) {
+ if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType())
+return std::nullopt;
https://github.com/DmT021 updated
https://github.com/llvm/llvm-project/pull/106030
>From a370fbb7b497eb12ca9faf9a760db3c023ee6052 Mon Sep 17 00:00:00 2001
From: Dmitrii Galimzianov
Date: Tue, 27 Aug 2024 01:32:49 +0200
Subject: [PATCH] Add logs for SymbolFileDWARF::FindTypes
---
.../SymbolFil
@@ -2779,7 +2788,19 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
return !results.Done(query); // Keep iterating if we aren't done.
});
- if (results.Done(query))
+ auto CheckIsDoneAndLog = [&results, &query, log, type_basename, th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This patch removes all of the Set.* methods from Status.
This cleanup is part of a series of patches that make it harder use the
anti-pattern of keeping a long-lives Status object around and updating i
https://github.com/jasonmolenda approved this pull request.
Good catch, LGTM.
https://github.com/llvm/llvm-project/pull/106157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben commented:
Cool stuff! I think this is fine except for the python files.
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -15,7 +15,7 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args:
lldb.SBStructuredData
def read_memory_at_address(
self, addr: int, size: int, error: lldb.SBError
) -> lldb.SBData:
-error.SetErrorString("This is an invalid scripted process!"
@@ -56,19 +56,41 @@ class Status {
///
/// \param[in] type
/// The type for \a err.
- explicit Status(ValueType err,
- lldb::ErrorType type = lldb::eErrorTypeGeneric);
+ explicit Status(ValueType err, lldb::ErrorType type =
lldb::eErrorTypeGeneric,
jimingham wrote:
This seems an okay solution for now. We really don't want to miss breakpoint
hits if we can at all avoid it.
This isn't a regression, it's just one case where the proposed enhancement to
stepping doesn't enhance stepping.
We haven't had many (any?) reports of single steppi
jimingham wrote:
> > When we were talking about this originally I thought that StackFrames would
> > get an "ImplementationFrame" property, and we would use that to determine
> > whether to hide the frame in bt (when not passing --unfiltered). Then the
> > frame recognizers when they are run o
CheapMeow wrote:
It still has bug in VSCode: The editor could not be opened due to an unexpected
error: Invalid arguments
My llvm version is
```
lldb version 18.1.8
clang version 18.1.8
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: E:\software\LLVM\bin
Found HIP installation
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
I wonder if this needs to default to column 1? We might end up adding column
zero.
```
/**
* Start position of the range covered by the stack frame. It is measured in
* UTF-16 code units and the client capability `columnsStartAt1` determines
* whether it is 0- or 1-ba
https://github.com/clayborg commented:
I worry the assert will kill the LLDB library and cause issues. Can we add a
temporary setting that can override this in case it does cause crashes? I
really don't want LLDB crashing if we can help it. It will be hard to test all
of the error code paths t
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/106030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
91 matches
Mail list logo
