[Lldb-commits] [lldb] [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (PR #104617)

@@ -120,7 +121,10 @@ TEST_F(ElfCoreTest, PopulatePrpsInfoTest) { ASSERT_EQ(prpsinfo_opt->pr_state, 0); ASSERT_EQ(prpsinfo_opt->pr_sname, 'R'); ASSERT_EQ(prpsinfo_opt->pr_zomb, 0); - ASSERT_EQ(prpsinfo_opt->pr_nice, 0); + int priority = getpriority(PRIO_PROCESS, getpid()

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/104679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff aad27bf534b59645f47a92f072af798687b1dd0d e72ceaada170354aa322b4c6a1787152ac72c65b --e

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

DavidSpickett wrote: These seem fine but can you provide some details why this might have happened in your build and not in others? Like: * Are these tid_t and offset_t defined differently on AIX? * Are you building with the system compiler or clang? Include issues are not always easily explai

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

DavidSpickett wrote: Normally I would advise you to ignore the formatter for changes like this, but this is small enough and the intent will be clear even with the formatting changes. So please follow the guidance in the formatting comment to fix it. https://github.com/llvm/llvm-project/pull/1

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

DavidSpickett wrote: And I edited the commit title slightly. The usual format is `[sub-project][area] `, so if you could keep to that form. Not a hard rule but it is useful for skimming logs later. https://github.com/llvm/llvm-project/pull/104679 ___

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

DavidSpickett wrote: And for the formatting, I usually use the clang-format in my llvm build dir. You don't have to go hunt down another specific version. https://github.com/llvm/llvm-project/pull/104679 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

DhruvSrivastavaX wrote: Ok Great, @DavidSpickett I was hoping for some feedback to get more clarity about llvm PRs. 1. Yes, the definition of tid_t and offset_t can differ in certain scenarios in AIX when compared to lldb, so trying to avoid such conflicts. 2. We have used ibm-clang which is a

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

vogelsgesang wrote: Here the screen recording of a fully functional, non-remote session: https://github.com/user-attachments/assets/64b36078-a57b-440a-85f8-0e73f88c5a56 https://github.com/llvm/llvm-project/pull/104589 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

https://github.com/Michael137 commented: Haven't thoroughly reviewed the latest callback-based approach but wonder if it is just more straightforward to keep the original plan of adding a`search_hint` to the `FindFunctions` APIs, and add a flag to `ModuleFunctionSearchOptions` that indicates w

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

DmT021 wrote: The tricky part is in the post-processing. IRExecutionUnit::FindInSymbols wants an external symbol and falls back to an internal one after all the modules are scanned. SymbolContext::FindBestGlobalDataSymbol prefers an internal symbol if it is found in the hinted module. Also res

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/104238 >From 8491aa073ae240eb5e31df12ac278c70fc9515e7 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 16 Aug 2024 17:03:37 +0400 Subject: [PATCH 1/4] [lldb] Removed gdbserver ports map from lldb-server List

[Lldb-commits] [lldb] [lldb][NFC] Moved the SharedSocket class to Socket.* (PR #104787)

https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/104787 This is prerequisite for #104238. >From 8c92e7b3df1c76c3c092dcd9c6fc90889192dc8b Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Mon, 19 Aug 2024 16:37:10 +0400 Subject: [PATCH] [lldb][NFC] Moved the Shar

[Lldb-commits] [lldb] [lldb][NFC] Moved the SharedSocket class to Socket.* (PR #104787)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is prerequisite for #104238. --- Full diff: https://github.com/llvm/llvm-project/pull/104787.diff 3 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+24) - (modified) lldb/source/Host

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (PR #104617)

@@ -120,7 +121,10 @@ TEST_F(ElfCoreTest, PopulatePrpsInfoTest) { ASSERT_EQ(prpsinfo_opt->pr_state, 0); ASSERT_EQ(prpsinfo_opt->pr_sname, 'R'); ASSERT_EQ(prpsinfo_opt->pr_zomb, 0); - ASSERT_EQ(prpsinfo_opt->pr_nice, 0); + int priority = getpriority(PRIO_PROCESS, getpid()

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/104711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -1,4 +1,5 @@ import * as vscode from "vscode"; +import * as fs from "node:fs/promises"; walter-erquinigo wrote: don't use this https://github.com/llvm/llvm-project/pull/104711 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

ilovepi wrote: I think the need to add _GNU_SOURCE depends on your libc, it it’s probably reasonable to add it based on the platform. I’d think you’d want to use an ifdef here to define _GNU_SOURCE if needed. I based on the target platform. You could also probably do something similar in CM

[Lldb-commits] [lldb] [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (PR #104617)

@@ -120,7 +121,10 @@ TEST_F(ElfCoreTest, PopulatePrpsInfoTest) { ASSERT_EQ(prpsinfo_opt->pr_state, 0); ASSERT_EQ(prpsinfo_opt->pr_sname, 'R'); ASSERT_EQ(prpsinfo_opt->pr_zomb, 0); - ASSERT_EQ(prpsinfo_opt->pr_nice, 0); + int priority = getpriority(PRIO_PROCESS, getpid()

[Lldb-commits] [lldb] [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (PR #104617)

https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/104617 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Updated TCPSocket to listen multiple ports on the same single thread (PR #104797)

https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/104797 This is prerequisite for #104238. >From c14f06278aff93f0c7433f6d13c3d9d944d7a1cf Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Mon, 19 Aug 2024 18:56:36 +0400 Subject: [PATCH] [lldb] Updated TCPSocket t

[Lldb-commits] [lldb] [lldb] Updated TCPSocket to listen multiple ports on the same single thread (PR #104797)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is prerequisite for #104238. --- Full diff: https://github.com/llvm/llvm-project/pull/104797.diff 3 Files Affected: - (modified) lldb/include/lldb/Host/common/TCPSocket.h (+3) - (modified) lldb/so

[Lldb-commits] [lldb] b1d75fe - [lldb][test] Fix cast dropping const warnin in TestBreakpointSetCallback.cpp

Author: David Spickett Date: 2024-08-19T15:16:04Z New Revision: b1d75fe48c940ba677614db3d891fbebcb8a41a2 URL: https://github.com/llvm/llvm-project/commit/b1d75fe48c940ba677614db3d891fbebcb8a41a2 DIFF: https://github.com/llvm/llvm-project/commit/b1d75fe48c940ba677614db3d891fbebcb8a41a2.diff LOG

[Lldb-commits] [lldb] c7a54bf - [lldb][ASTUtils] Remove unused SemaSourceWithPriorities::addSource API

Author: Michael Buch Date: 2024-08-19T16:19:44+01:00 New Revision: c7a54bfd1d25330199c96dd0a46cef1644b1b1ce URL: https://github.com/llvm/llvm-project/commit/c7a54bfd1d25330199c96dd0a46cef1644b1b1ce DIFF: https://github.com/llvm/llvm-project/commit/c7a54bfd1d25330199c96dd0a46cef1644b1b1ce.diff

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/104799 When we use `SemaSourceWithPriorities` as the `ASTContext`s ExternalASTSource, we allocate a `ClangASTSourceProxy` (via `CreateProxy`) and two `ExternalASTSourceWrapper`. Then we push these sources into a ve

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When we use `SemaSourceWithPriorities` as the `ASTContext`s ExternalASTSource, we allocate a `ClangASTSourceProxy` (via `CreateProxy`) and two `ExternalASTSourceWrapper`. Then we push these sources into a

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/104799 >From 0c23c427f7154dabadbca65f64973ec2dbe365d9 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 19 Aug 2024 15:40:07 +0100 Subject: [PATCH 1/2] [lldb][ClangExpressionParser] Don't leak memory when mult

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

hawkinsw wrote: Interestingly enough, I just checked at `gettid` _is_ defined in `unistd.h` in Bionic. See [here](https://android.googlesource.com/platform/bionic/+/master/libc/include/unistd.h). Although I am not the original author here, I will definitely take a look at seeing what is wrong

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c7a54bfd1d25330199c96dd0a46cef1644b1b1ce 0c23c427f7154dabadbca65f64973ec2dbe365d9 --e

[Lldb-commits] [lldb] 08201cb - [lldb][test] Fix GCC warnings in TestGetControlFlowKindX86.cpp

Author: David Spickett Date: 2024-08-19T16:35:47+01:00 New Revision: 08201cb4245b0a03e1af664e00a22ea4db1fc2fb URL: https://github.com/llvm/llvm-project/commit/08201cb4245b0a03e1af664e00a22ea4db1fc2fb DIFF: https://github.com/llvm/llvm-project/commit/08201cb4245b0a03e1af664e00a22ea4db1fc2fb.diff

[Lldb-commits] [lldb] 7a06ebd - [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (#104617)

Author: Fred Grim Date: 2024-08-19T08:41:11-07:00 New Revision: 7a06ebdeb6440d80fbcaeccd33314c6e039c6795 URL: https://github.com/llvm/llvm-project/commit/7a06ebdeb6440d80fbcaeccd33314c6e039c6795 DIFF: https://github.com/llvm/llvm-project/commit/7a06ebdeb6440d80fbcaeccd33314c6e039c6795.diff LOG

[Lldb-commits] [lldb] [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (PR #104617)

https://github.com/feg208 closed https://github.com/llvm/llvm-project/pull/104617 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/104799 >From 0c23c427f7154dabadbca65f64973ec2dbe365d9 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 19 Aug 2024 15:40:07 +0100 Subject: [PATCH 1/4] [lldb][ClangExpressionParser] Don't leak memory when mult

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/104679 >From e72ceaada170354aa322b4c6a1787152ac72c65b Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 17 Aug 2024 12:16:09 -0500 Subject: [PATCH 1/2] Using lldb's internal typedefs to avoid namespac

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/104799 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/104799 >From 0c23c427f7154dabadbca65f64973ec2dbe365d9 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 19 Aug 2024 15:40:07 +0100 Subject: [PATCH 1/5] [lldb][ClangExpressionParser] Don't leak memory when mult

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/104679 >From e72ceaada170354aa322b4c6a1787152ac72c65b Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 17 Aug 2024 12:16:09 -0500 Subject: [PATCH] Using lldb's internal typedefs to avoid namespace co

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

DavidSpickett wrote: Assuming the formatting is fine I'll merge this tomorrow. Before I do, please turn off private email addresses in your GitHub settings so that we record a proper commit email and you'll get buildbot notifications to the right place. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] 0ee0857 - [lldb][Python] Silence GCC warning for modules error workaround

Author: David Spickett Date: 2024-08-19T17:03:58+01:00 New Revision: 0ee0857363aadf9ce0f403e7e0da10f0a9d94887 URL: https://github.com/llvm/llvm-project/commit/0ee0857363aadf9ce0f403e7e0da10f0a9d94887 DIFF: https://github.com/llvm/llvm-project/commit/0ee0857363aadf9ce0f403e7e0da10f0a9d94887.diff

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/104679 >From e72ceaada170354aa322b4c6a1787152ac72c65b Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 17 Aug 2024 12:16:09 -0500 Subject: [PATCH 1/2] Using lldb's internal typedefs to avoid namespac

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

mbucko wrote: Let me know if you guys don't want this patch in. I will closed it and apply it to our local branch. https://github.com/llvm/llvm-project/pull/102536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/104799 >From 0c23c427f7154dabadbca65f64973ec2dbe365d9 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 19 Aug 2024 15:40:07 +0100 Subject: [PATCH 1/6] [lldb][ClangExpressionParser] Don't leak memory when mult

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

DhruvSrivastavaX wrote: Great!! Yes, I have turned off private email addresses now. Just a general question. Is it a one time thing or it is advisable to keep it off in future as well? https://github.com/llvm/llvm-project/pull/104679 ___ lldb-comm

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

ilovepi wrote: > Update: I see that what we are really compiling for is fuchsia! Interesting. > I will investigate further! No, this is targeting linux for x86_64: The command line doesn't list a different target, and we don't try to test LLDB on Fuchsia targets to my knowledge. We do run th

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

hawkinsw wrote: Thanks, @ilovepi ! Again, I'm just trying to help, so I appreciate the backstory. I will keep looking! https://github.com/llvm/llvm-project/pull/104109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/102708 >From b451c1630a9799180a3a976a4ecd86c8d4ec35da Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 8 Aug 2024 08:58:52 -0700 Subject: [PATCH 01/14] Initial attempt at new classes Summary statistics in Summa

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Implement ExternalSemaSource::ReadUndefinedButUsed (PR #104817)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/104817 While parsing an expression, Clang tries to diagnose usage of decls (with possibly non-external linkage) for which it hasn't been provided with a definition. This is the case, e.g., for functions with parame

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Implement ExternalSemaSource::ReadUndefinedButUsed (PR #104817)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes While parsing an expression, Clang tries to diagnose usage of decls (with possibly non-external linkage) for which it hasn't been provided with a definition. This is the case, e.g., for functions with para

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Implement ExternalSemaSource::ReadUndefinedButUsed (PR #104817)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/104817 >From 4bb7f6495a2fbf46e01b9f01c46d335d2b680afd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 19 Aug 2024 17:39:44 +0100 Subject: [PATCH 1/2] [lldb][ClangExpressionParser] Implement ExternalSemaSourc

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Don't leak memory when multiplexing ExternalASTSources (PR #104799)

@@ -1224,15 +1224,15 @@ ClangExpressionParser::ParseInternal(DiagnosticManager &diagnostic_manager, clang::ExternalASTSource *ast_source = decl_map->CreateProxy(); if (ast_context.getExternalSource()) { - auto module_wrapper = + auto *module_wrapper =

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -175,6 +177,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -615,7 +615,19 @@ bool ValueObject::GetSummaryAsCString(TypeSummaryImpl *summary_ptr, m_synthetic_value->UpdateValueIfNeeded(); // the summary might depend on // the synthetic children being

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -174,6 +176,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -0,0 +1,35 @@ +// Test that the lldb command `statistics` works. Michael137 wrote: Not aware of anything like this off-the-top. We'd want a test that access the same `Target` from multiple threads and formats types. Maybe having some callback tied to several

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -175,6 +177,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations Michael137 wrote: Can you put a note here that all members of this class need to be acces

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -175,6 +177,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -615,7 +615,19 @@ bool ValueObject::GetSummaryAsCString(TypeSummaryImpl *summary_ptr, m_synthetic_value->UpdateValueIfNeeded(); // the summary might depend on // the synthetic children being

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -175,6 +177,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

jasonmolenda wrote: My comment about hoping to crack open the Target/Process ReadMemory API shouldn't have anything to do with this patch, I don't think. I saw the discussion going in to areas of "the ReadMemory API could behave differently", and I wanted to note that I'm hoping to start a pr

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -175,6 +177,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] Fix StartDebuggingRequestHandler/ReplModeRequestHandler in lldb-dap (PR #104824)

https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/104824 `SBCommand::AddCommand()` requires `SBCommandPluginInterface` to be heap based because it will be stored inside `std::shared_ptr` later for reference counting. But lldb-dap passes `StartDebuggingRequestHa

[Lldb-commits] [lldb] Fix StartDebuggingRequestHandler/ReplModeRequestHandler in lldb-dap (PR #104824)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes `SBCommand::AddCommand()` requires `SBCommandPluginInterface` to be heap based because it will be stored inside `std::shared_ptr` later for reference counting. But lldb-dap passe

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -175,6 +177,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations Jlalond wrote: Great idea https://github.com/llvm/llvm-project/pull/102708 _

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

hawkinsw wrote: > Our bots and sysroot are based on the oldest supported versions of Debian, > based on the project's stated minimum requirements. @ilovepi Could you say which of the versions that you are using? That would help, I think. https://github.com/llvm/llvm-project/pull/104109 _

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

@@ -175,6 +177,82 @@ struct StatisticsOptions { std::optional m_include_transcript; }; +/// A class that represents statistics about a TypeSummaryProviders invocations +class SummaryStatistics { +public: + explicit SummaryStatistics(std::string name, std::string impl_type)

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/102708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

https://github.com/hawkinsw created https://github.com/llvm/llvm-project/pull/104831 Only Linux systems do not have gettid. Provide our own gettid in these cases. Fixes a build failure caused by #104109. >From 10bc5a512b56238328b025303345e47708927d6e Mon Sep 17 00:00:00 2001 From: Will Hawkins

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Will Hawkins (hawkinsw) Changes Only Linux systems do not have gettid. Provide our own gettid in these cases. Fixes a build failure caused by #104109. --- Full diff: https://github.com/llvm/llvm-project/pull/104831.diff 1 Files Affected:

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

https://github.com/hawkinsw edited https://github.com/llvm/llvm-project/pull/104831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

hawkinsw wrote: @ilovepi If you can, try https://github.com/llvm/llvm-project/pull/104831. I think that the problem is your builder is running with a version of glibc that does not provide `gettid`. If the hack implemented in that PR fixes the problem, I will work on a nicer fix. https://gith

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

hawkinsw wrote: FYI: I understand that the code in this PR is _not_ going to be the final answer. I am just hoping to confirm that it does, actually, fix the problem. If it does, then I will work on a "better" solution. Will https://github.com/llvm/llvm-project/pull/104831 _

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e0fc155782ff5307245a85c7b037a2998ec6c86 10bc5a512b56238328b025303345e47708927d6e --e

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

petrhosek wrote: > > Our bots and sysroot are based on the oldest supported versions of Debian, > > based on the project's stated minimum requirements. > > @ilovepi Could you say which of the versions that you are using? That would > help, I think. It's Ubuntu 14.04 which uses glibc 2.19. ht

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

https://github.com/hawkinsw updated https://github.com/llvm/llvm-project/pull/104831 >From 76f01132b7667be48967b8d9788f610cf1a539d4 Mon Sep 17 00:00:00 2001 From: Will Hawkins Date: Mon, 19 Aug 2024 14:43:45 -0400 Subject: [PATCH] WIP: [lldb][test] Workaround older systems that lack gettid Old

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,10 +18,32 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

hawkinsw wrote: > > > Our bots and sysroot are based on the oldest supported versions of > > > Debian, based on the project's stated minimum requirements. > > > > > > @ilovepi Could you say which of the versions that you are using? That would > > help, I think. > > It's Ubuntu 14.04 which us

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/104711 >From 0b84d36d320a58a13ca98bd1b1c186c72bbe63e2 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 18 Aug 2024 15:26:11 +0100 Subject: [PATCH 1/3] [lldb-dap] vscode now shows a dialog when the dab-executable

[Lldb-commits] [lldb] [llvm] [Docs] Use cacheable myst_heading_slug_func value (PR #104847)

https://github.com/slinder1 created https://github.com/llvm/llvm-project/pull/104847 Avoid creating an uncacheable conf variable by using a string instead of a function reference. Also has the effect of avoiding triggering the "config.cache" sphinx warning. Requires myst_parser 0.19.0 (specific

[Lldb-commits] [lldb] [llvm] [Docs] Use cacheable myst_heading_slug_func value (PR #104847)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Scott Linder (slinder1) Changes Avoid creating an uncacheable conf variable by using a string instead of a function reference. Also has the effect of avoiding triggering the "config.cache" sphinx warning. Requires myst_parser 0.19.0 (specif

[Lldb-commits] [lldb] Fix StartDebuggingRequestHandler/ReplModeRequestHandler in lldb-dap (PR #104824)

@@ -192,8 +192,6 @@ struct DAP { std::mutex call_mutex; std::map inflight_reverse_requests; - StartDebuggingRequestHandler start_debugging_request_handler; - ReplModeRequestHandler repl_mode_request_handler; walter-erquinigo wrote: btw, do you use

[Lldb-commits] [lldb] Fix StartDebuggingRequestHandler/ReplModeRequestHandler in lldb-dap (PR #104824)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/104824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

https://github.com/vogelsgesang commented: Thanks for looking into this! The patch already looks very good! https://github.com/llvm/llvm-project/pull/104711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/104711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

vogelsgesang wrote: please rebase onto `main`. This unfortunately has a merge conflict with another change which I recently merged https://github.com/llvm/llvm-project/pull/104711 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,14 +17,46 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -17,14 +17,46 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { const path = vscode.workspace .getConfiguration("lldb-dap", session.workspaceFolder) .get("executable-path"); - if (path) { -return new vscode.DebugAdapterExecutable(

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

@@ -23,31 +22,41 @@ function createDefaultLLDBDapOptions(): LLDBDapOptions { return packageJSONExecutable; } - try { -const fileStats = await fs.stat(path); -if (!fileStats.isFile() && !fileStats.isSymbolicLink()) { - throw new Error

[Lldb-commits] [lldb] [lldb-dap] show dialog when executable is not found (PR #104711)

walter-erquinigo wrote: @Da-Viper , a better way to do this is that, instead of checking for the path upon initialization, you add this checking logic in the `createDebugAdapterDescriptor` function, which only gets triggered when you launch the debugger. This will be less annoying to users who

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

@@ -691,6 +691,19 @@ def request_disassemble( for inst in instructions: self.disassembled_instructions[inst["address"]] = inst +def request_read_memory(self, memoryReference, offset, count): mbucko wrote: for consistency this should be

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

@@ -4028,6 +4046,161 @@ void request_disassemble(const llvm::json::Object &request) { response.try_emplace("body", std::move(body)); g_dap.SendJSON(llvm::json::Value(std::move(response))); } + +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" },

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

petrhosek wrote: I think a more idiomatic approach would be to use CMake to check if `gettid` is available: ``` check_symbol_exists(gettid "unistd.h" HAVE_GETTID) ``` Then in `lldb/unittests/Process/elf-core/ThreadElfCoreTest.cpp` you'd define `gettid` only `#if !HAVE_GETTID`. https://github.c

  1   2   >