DavidSpickett wrote:
> It's somewhat implied, but is the goal to (continue to) avoid that
> dependency? Other parts of LLDB do rely on libxml2 but I can see how you'd
> want to limit the dependencies of lldb-server.
Yeah I agree with how lldb-server does it now, and don't want to change that.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-10-24T09:39:44Z
New Revision: 2325b3cfdadf266651294ff469ce600a8ee402ce
URL:
https://github.com/llvm/llvm-project/commit/2325b3cfdadf266651294ff469ce600a8ee402ce
DIFF:
https://github.com/llvm/llvm-project/commit/2325b3cfdadf266651294ff469ce600a8ee402ce.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/69951
>From 5c8b9538e1e5646f19d5bb40ab19afaf2c68e804 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 9 Oct 2023 10:33:08 +0100
Subject: [PATCH 1/4] [lldb][lldb-server] Enable sending registerflags as XML
@@ -175,3 +175,35 @@ std::string RegisterFlags::AsTable(uint32_t max_width)
const {
return table;
}
+
+void RegisterFlags::ToXML(StreamString &strm) const {
+ // Example XML:
+ //
+ //
+ //
+ strm.Indent();
+ strm << "";
+ for (const Field &field : m_fields) {
+
@@ -3113,6 +3119,10 @@ GDBRemoteCommunicationServerLLGS::BuildTargetXml() {
if (!format.empty())
response << "format=\"" << format << "\" ";
+if (reg_info->flags_type) {
+ response << "type=\"" << reg_info->flags_type->GetID() << "\" ";
+}
--
@@ -10,6 +10,7 @@
#define LLDB_TARGET_REGISTERFLAGS_H
#include "lldb/Utility/Log.h"
+#include "lldb/Utility/StreamString.h"
DavidSpickett wrote:
Done.
https://github.com/llvm/llvm-project/pull/69951
___
lldb-commit
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/69951
>From 5c8b9538e1e5646f19d5bb40ab19afaf2c68e804 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 9 Oct 2023 10:33:08 +0100
Subject: [PATCH 1/5] [lldb][lldb-server] Enable sending registerflags as XML
Author: David Spickett
Date: 2023-10-24T10:36:20Z
New Revision: febc4ff74a4e0311c3663fa5d690c59f7f692583
URL:
https://github.com/llvm/llvm-project/commit/febc4ff74a4e0311c3663fa5d690c59f7f692583
DIFF:
https://github.com/llvm/llvm-project/commit/febc4ff74a4e0311c3663fa5d690c59f7f692583.diff
LOG
https://github.com/PortalPete updated
https://github.com/llvm/llvm-project/pull/69989
>From fe1bc418f4404e1201da388be46a37d40b6af038 Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Thu, 19 Oct 2023 18:59:57 -1000
Subject: [PATCH] [lldb] Part 1 of 2 - Refactor `CommandObject::Execute(...)`
t
@@ -1541,18 +1539,18 @@ class CommandObjectMemoryWrite : public
CommandObjectParsed {
if (!buffer.GetString().empty()) {
Status error;
- if (process->WriteMemory(addr, buffer.GetString().data(),
- buffer.GetString().size(),
-
@@ -429,11 +428,12 @@ llvm::StringRef CommandObjectProxy::GetUnsupportedError()
{
return "command is not implemented";
}
-bool CommandObjectProxy::Execute(const char *args_string,
+void CommandObjectProxy::Execute(const char *args_string,
C
@@ -769,10 +768,10 @@ bool CommandObjectRaw::Execute(const char *args_string,
handled = InvokeOverrideCallback(argv, result);
}
if (!handled) {
-if (CheckRequirements(result))
- handled = DoExecute(args_string, result);
+if (CheckRequirements(result)) {
---
@@ -429,11 +428,12 @@ llvm::StringRef CommandObjectProxy::GetUnsupportedError()
{
return "command is not implemented";
}
-bool CommandObjectProxy::Execute(const char *args_string,
+void CommandObjectProxy::Execute(const char *args_string,
C
DavidSpickett wrote:
ping!
I know you're very busy at the moment, but if you have time to review this week
this is the most important patch I've got queued.
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@li
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/69989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Endilll wrote:
@clayborg Thank you for extensive feedback! Can you clarify where do you want
me to put the changes?
---
You expected the following:
> v.SetFormat(lldb.eFormatDecimal)
v.GetValue()
`1(1)`
But my patch doesn't seem to alter the behavior of `eFormatDecimal`. The code
and LLDB out
AaronBallman wrote:
> What IDE are you using for the screenshot above?
Visual Studio
> The issue you might run into is that IDE might only be showing the value
> string and not the summary string. XCode and Visual Studio code will show the
> value if there is one _and_ the summary if there i
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/70054
As ReadRegister always read into a uint64_t, when it called operator= with
uint64_t it was setting the RegisterValue's type to eTypeUInt64 regardless of
its size.
This mostly works because most registers
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
As ReadRegister always read into a uint64_t, when it called operator= with
uint64_t it was setting the RegisterValue's type to eTypeUInt64 regardless of
its size.
This mostly works because most regis
Author: jeffreytan81
Date: 2023-10-24T08:44:34-07:00
New Revision: 00d3ed6deadb1d647b70ab37ac66ada6a550c1ba
URL:
https://github.com/llvm/llvm-project/commit/00d3ed6deadb1d647b70ab37ac66ada6a550c1ba
DIFF:
https://github.com/llvm/llvm-project/commit/00d3ed6deadb1d647b70ab37ac66ada6a550c1ba.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/69614
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -769,10 +768,10 @@ bool CommandObjectRaw::Execute(const char *args_string,
handled = InvokeOverrideCallback(argv, result);
}
if (!handled) {
-if (CheckRequirements(result))
- handled = DoExecute(args_string, result);
+if (CheckRequirements(result)) {
---
Author: Augusto Noronha
Date: 2023-10-24T09:27:08-07:00
New Revision: 3b897943045c00509af586a7fbe95fbeaf32c12e
URL:
https://github.com/llvm/llvm-project/commit/3b897943045c00509af586a7fbe95fbeaf32c12e
DIFF:
https://github.com/llvm/llvm-project/commit/3b897943045c00509af586a7fbe95fbeaf32c12e.dif
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/70062
When moving the GetTypeForDIE function from DWARFASTParserClang to
DWARFASTParser, I kept the signature as-is. To match the rest of the function
signatures in DWARFASTParser, remove the full name
(lldb_priv
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
When moving the GetTypeForDIE function from DWARFASTParserClang to
DWARFASTParser, I kept the signature as-is. To match the rest of the function
signatures in DWARFASTParser, remove the full name
(lld
Author: Augusto Noronha
Date: 2023-10-24T09:49:08-07:00
New Revision: e3476f68af5dd5e7ed672ac688396d6d6fba09b4
URL:
https://github.com/llvm/llvm-project/commit/e3476f68af5dd5e7ed672ac688396d6d6fba09b4
DIFF:
https://github.com/llvm/llvm-project/commit/e3476f68af5dd5e7ed672ac688396d6d6fba09b4.dif
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/70062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/69989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -769,10 +768,10 @@ bool CommandObjectRaw::Execute(const char *args_string,
handled = InvokeOverrideCallback(argv, result);
}
if (!handled) {
-if (CheckRequirements(result))
- handled = DoExecute(args_string, result);
+if (CheckRequirements(result)) {
+
https://github.com/JDevlieghere approved this pull request.
A few small nits but overall this LGTM.
https://github.com/llvm/llvm-project/pull/69989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -715,7 +715,7 @@ Thread *CommandObject::GetDefaultThread() {
return nullptr;
}
-bool CommandObjectParsed::Execute(const char *args_string,
+void CommandObjectParsed::Execute(const char *args_string,
CommandReturnObject &result) {
bo
@@ -429,11 +428,13 @@ llvm::StringRef CommandObjectProxy::GetUnsupportedError()
{
return "command is not implemented";
}
-bool CommandObjectProxy::Execute(const char *args_string,
+void CommandObjectProxy::Execute(const char *args_string,
C
@@ -19,11 +19,11 @@
namespace lldb_private {
class ScriptedPlatformInterface : virtual public ScriptedInterface {
public:
- StructuredData::GenericSP
+ virtual llvm::Expected
CreatePluginObject(llvm::StringRef class_name, ExecutionContext &exe_ctx,
St
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef cla
@@ -56,14 +56,17 @@ ScriptedThread::Create(ScriptedProcess &process,
}
ExecutionContext exe_ctx(process);
- StructuredData::GenericSP owned_script_object_sp =
- scripted_thread_interface->CreatePluginObject(
- thread_class_name, exe_ctx, process.m_scripted_m
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef cla
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef cla
hiraditya added a comment.
Herald added subscribers: wangpc, jobnoorman, luke.
We should close this as it has been pushed upstream as part of
https://reviews.llvm.org/rG847de9c332775d1841fec9fea5cb5c41592a4c8f
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
https://github.com/bulbazord approved this pull request.
Since this bug only really manifests with later changes, I think it's fine to
fix it without a test for now. Please make sure there is a test that exercises
this behavior in your follow-up.
https://github.com/llvm/llvm-project/pull/700
clayborg wrote:
Is there a way to have Visual Studio change the display format of the enum
values?
I currently like the way that enum values are displayed without any changes
where we try to show the enum value as an integer because I can change the
format if that is needed, or use the comma
https://github.com/bulbazord approved this pull request.
LGTM with everyone else's comments. Thanks for working on this!
https://github.com/llvm/llvm-project/pull/69989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/69981
>From 367431f51f5f75b2035e6bac7944fc0a03ca3cc0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 23 Oct 2023 15:55:40 -0700
Subject: [PATCH] Expose DWARFDIE::GetDeclContext() in lldb_private::Function
@@ -34,7 +34,7 @@ struct CompilerContext {
}
bool operator!=(const CompilerContext &rhs) const { return !(*this == rhs); }
- void Dump() const;
+ void Dump(Stream *s) const;
adrian-prantl wrote:
Sounds good to me!
https://github.com/llvm/llvm-project/p
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/69981
>From b60b12b15d431d291032427a76473eb5f3661cb4 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 23 Oct 2023 15:55:40 -0700
Subject: [PATCH] Expose DWARFDIE::GetDeclContext() in lldb_private::Function
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/69981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2023-10-24T10:55:23-07:00
New Revision: 49504674dbca6f753771f790ea4062bcbc9cc829
URL:
https://github.com/llvm/llvm-project/commit/49504674dbca6f753771f790ea4062bcbc9cc829
DIFF:
https://github.com/llvm/llvm-project/commit/49504674dbca6f753771f790ea4062bcbc9cc829.diff
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69991
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
I think I looked at every changed line, looks good to me overall. Found one
place with a small style issue but it's not a blocker. Thanks!
https://github.com/llvm/llvm-project/pull/69991
___
lld
@@ -34,16 +34,17 @@ CommandObjectMultipleThreads::CommandObjectMultipleThreads(
m_arguments.push_back({thread_arg});
}
-bool CommandObjectIterateOverThreads::DoExecute(Args &command,
+void CommandObjectIterateOverThreads::DoExecute(Args &command,
@@ -9,10 +9,16 @@
#ifndef LLDB_TARGET_REGISTERFLAGS_H
#define LLDB_TARGET_REGISTERFLAGS_H
-#include "lldb/Utility/Log.h"
+#include
+#include
+#include
+#include
clayborg wrote:
Not needed in this header, move to .cpp if needed there?
https://github.com/l
@@ -9,10 +9,16 @@
#ifndef LLDB_TARGET_REGISTERFLAGS_H
#define LLDB_TARGET_REGISTERFLAGS_H
-#include "lldb/Utility/Log.h"
+#include
clayborg wrote:
Not needed in this header, move to .cpp if needed there?
https://github.com/llvm/llvm-project/pull/69951
_
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/68052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef cla
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef cla
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef cla
https://github.com/bulbazord commented:
Works for me generally. I'm curious to know if some of these can be pure
virtual function as Jonas mentioned.
https://github.com/llvm/llvm-project/pull/68052
___
lldb-commits mailing list
lldb-commits@lists.llvm
AaronBallman wrote:
> Is there a way to have Visual Studio change the display format of the enum
> values?
Sort of. You can specify you want to view values in hex and then you'll get
`EK_ParenAggInitMember (0x0015)` instead of `EK_ParenAggInitMember (21)`,
but that all the more formatting
@@ -5771,84 +5779,63 @@ OpenMPIRBuilder::createTeams(const LocationDescription
&Loc,
BasicBlock *AllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "teams.alloca");
+ // Generate the body of teams.
+ InsertPointTy AllocaIP(AllocaBB, AllocaBB->begin());
+ InsertPoin
@@ -1736,26 +1750,20 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
StaleCI->eraseFromParent();
-// Emit the body for wrapper function
-BasicBlock *WrapperEntryBB =
-BasicBlock::Create(M.getContext(), "", WrapperFunc);
-Builder.SetInse
@@ -1523,41 +1560,31 @@ OpenMPIRBuilder::createTask(const LocationDescription
&Loc,
BasicBlock *TaskAllocaBB =
splitBB(Builder, /*CreateBranch=*/true, "task.alloca");
+ InsertPointTy TaskAllocaIP =
+ InsertPointTy(TaskAllocaBB, TaskAllocaBB->begin());
+ InsertP
@@ -715,7 +715,7 @@ Thread *CommandObject::GetDefaultThread() {
return nullptr;
}
-bool CommandObjectParsed::Execute(const char *args_string,
+void CommandObjectParsed::Execute(const char *args_string,
CommandReturnObject &result) {
bo
https://github.com/PortalPete updated
https://github.com/llvm/llvm-project/pull/69989
>From d18c6e2fd2200ec14a8ef9f0a525bb2da6a4a968 Mon Sep 17 00:00:00 2001
From: Pete Lawrence
Date: Thu, 19 Oct 2023 18:59:57 -1000
Subject: [PATCH] [lldb] Part 1 of 2 - Refactor `CommandObject::Execute(...)`
t
@@ -429,11 +428,13 @@ llvm::StringRef CommandObjectProxy::GetUnsupportedError()
{
return "command is not implemented";
}
-bool CommandObjectProxy::Execute(const char *args_string,
+void CommandObjectProxy::Execute(const char *args_string,
C
@@ -769,10 +768,10 @@ bool CommandObjectRaw::Execute(const char *args_string,
handled = InvokeOverrideCallback(argv, result);
}
if (!handled) {
-if (CheckRequirements(result))
- handled = DoExecute(args_string, result);
+if (CheckRequirements(result)) {
+
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef cla
clayborg wrote:
> > Is there a way to have Visual Studio change the display format of the enum
> > values?
>
> Sort of. You can specify you want to view values in hex and then you'll get
> `EK_ParenAggInitMember (0x0015)` instead of `EK_ParenAggInitMember (21)`,
> but that all the more fo
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -491,14 +491,13 @@ static StopInfoSP GetStopInfoForHardwareBP(Thread
&thread, Target *target,
uint64_t exc_sub_sub_code) {
// Try hardware watchpoint.
if (target) {
+// LWP_TODO: We need to find the WatchpointResource that
@@ -839,11 +841,11 @@ std::optional
ProcessWindows::GetWatchpointSlotCount() {
return RegisterContextWindows::GetNumHardwareBreakpointSlots();
}
-Status ProcessWindows::EnableWatchpoint(Watchpoint *wp, bool notify) {
+Status ProcessWindows::EnableWatchpoint(WatchpointSP wp_
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 09cd46a63b1fb68e3c5c03273cbc90825b09d027 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/68052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
PortalPete wrote:
> I think I looked at every changed line, looks good to me overall. Found one
> place with a small style issue but it's not a blocker. Thanks!
Thanks @bulbazord!
Do you know why the `code_formatter` check/bot didn't flag that or the other
one-line `if` statements?
https://gi
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/68052
>From 4942cb5209298b5e4a1819885d1f680381c0bb16 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 24 Oct 2023 20:39:34 -0700
Subject: [PATCH] [lldb/Interpreter] Make ScriptedInterface Object creati
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/68052
>From ef90c8a7f2f555cf312807d2bc83ffda45e8c2af Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 24 Oct 2023 20:40:43 -0700
Subject: [PATCH] [lldb/Interpreter] Make ScriptedInterface Object creati
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg wi
https://github.com/omjavaid approved this pull request.
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/omjavaid approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/69689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Walter Erquinigo
Date: 2023-10-25T00:05:54-04:00
New Revision: 10664813fca8d5ccbfd90bae9e791b7062dabd7c
URL:
https://github.com/llvm/llvm-project/commit/10664813fca8d5ccbfd90bae9e791b7062dabd7c
DIFF:
https://github.com/llvm/llvm-project/commit/10664813fca8d5ccbfd90bae9e791b7062dabd7c.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/70157
This effectively moves a few functions from protected to public. In any case,
for the sake of having a cleaner SymbolFileDWARF API, it's better if it's not a
friend of a one of its consumers, DWARFASTPa
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/70157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
This effectively moves a few functions from protected to public. In any case,
for the sake of having a cleaner SymbolFileDWARF API, it's better if it's not a
friend of a one of its consumers, DWA
medismailben wrote:
LGTM!
https://github.com/llvm/llvm-project/pull/69989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
medismailben wrote:
> > I think I looked at every changed line, looks good to me overall. Found one
> > place with a small style issue but it's not a blocker. Thanks!
>
> Thanks @bulbazord! Do you know why the `code_formatter` check/bot didn't flag
> that or the other one-line `if` statements?
94 matches
Mail list logo
