================ @@ -0,0 +1,140 @@ +//===-- WatchpointResource.h ------------------------------------*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef LLDB_BREAKPOINT_WATCHPOINTRESOURCE_H +#define LLDB_BREAKPOINT_WATCHPOINTRESOURCE_H + +#include "lldb/Breakpoint/WatchpointCollection.h" +#include "lldb/lldb-public.h" + +#include <set> + +namespace lldb_private { + +class WatchpointResource + : public std::enable_shared_from_this<WatchpointResource> { + +public: + // Constructors and Destructors + WatchpointResource(lldb::addr_t addr, size_t size, bool read, bool write); + + ~WatchpointResource(); + + void GetMemoryRange(lldb::addr_t &addr, size_t &size) const; + + lldb::addr_t GetAddress() const; + + size_t GetByteSize() const; + + void GetType(bool &read, bool &write) const; ---------------- jasonmolenda wrote:
idk about this one, `GetType(bool &read, bool &write)` makes the order easy to see, and matches the `SetType (bool read, bool write)` whereas the pair would be less explicitly named. I should follow the Watchpoint class method and have `bool WatchpointResourceRead()`, `bool WatchpointResourceWrite()`. https://github.com/llvm/llvm-project/pull/68845 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
