sunshaoce wrote:
> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
>
> You can test this locally with the following command:
> ```shell
> git-clang-format --diff b8b4ee6b450766796b162b4811a6b3f723d07268
> d07486764071679c8cbcd5e7c4905eb41b4770b3 --
> clang/utils/TableGen/Cl
rengolin wrote:
> Is this suggestion correct?
Doesn't look right to me. I seems it's suggesting 4 spaces tabs, which isn't
what we normally use. Something wrong with the clang-format job, maybe?
@tru @tstellar
https://github.com/llvm/llvm-project/pull/65744
__
tru wrote:
No I don't think it's job's fault. I ran clang-format on this file and it's not
formatted at all, so I think when we ask it to just format a patch like we do
in the job, it gets a bit confused and give you a bit of non-sense formatting.
This is just a limitation of not running forma
tru wrote:
Looking at it - it seems like none of Tablegen is correctly clang-formatted. If
that's not desired, maybe it should have a local .clang-format file to disable
the formatting of these files.
Do we have a clang-tblgen maintainer? Couldn't find anything in the codeowners
and git log h
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/67309
It is a first of three patches neded for adding an ability to update
std::string/wstring/etc during debug process. This patch adds to the synthetic
child interface a “change value” method which goes back to the syn
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
It is a first of three patches neded for adding an ability to update
std::string/wstring/etc during debug process. This patch adds to the synthetic
child interface a “change value” method which goes back to the synthetic child
provider and
cor3ntin wrote:
@tru I'd ask @AaronBallman. My vote would be to reformat.
https://github.com/llvm/llvm-project/pull/65744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rengolin wrote:
> @tru I'd ask @AaronBallman. My vote would be to reformat.
Not as a requirement for this patch, I imagine?
https://github.com/llvm/llvm-project/pull/65744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
AaronBallman wrote:
> > @tru I'd ask @AaronBallman. My vote would be to reformat.
>
> Not as a requirement for this patch, I imagine?
If we wanted to reformat the file as an NFC commit (before or after this
patch), that would be fine. But let's please not reformat as part of this patch
(that
https://github.com/AaronBallman approved this pull request.
LGTM (fine to land without tests as it only adds comments to generated header
files)
https://github.com/llvm/llvm-project/pull/65744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: David Truby
Date: 2023-09-25T14:32:52+01:00
New Revision: 247b7d068497de085b7fd66c6531034afa9709f0
URL:
https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0
DIFF:
https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0.diff
L
https://github.com/DavidTruby closed
https://github.com/llvm/llvm-project/pull/67125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -59,4 +60,8 @@ void llvm::emitSourceFileHeader(StringRef Desc, raw_ostream
&OS) {
printLine(OS, Prefix, ' ', Suffix);
printLine(OS, "\\*===", '-', "===*/");
OS << '\n';
+
+ // Print the path of source file
+ if (!Record.getInputFilename().empty())
+OS << "// Gen
https://github.com/chapuni requested changes to this pull request.
Hang on, would it expose build paths to installed headers?
https://github.com/llvm/llvm-project/pull/65744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
@@ -59,4 +60,8 @@ void llvm::emitSourceFileHeader(StringRef Desc, raw_ostream
&OS) {
printLine(OS, Prefix, ' ', Suffix);
printLine(OS, "\\*===", '-', "===*/");
OS << '\n';
+
+ // Print the path of source file
+ if (!Record.getInputFilename().empty())
+OS << "// Gen
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl unresolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sunshaoce wrote:
I am not sure how to keep only the `llvm-project//Filename` path except by
hard-coding. Or how to keep only the base file name? This could limit it to
within 80 characters.
https://github.com/llvm/llvm-project/pull/65744
___
lldb
AaronBallman wrote:
> I am not sure how to keep only the `llvm-project//Filename` path except
> by hard-coding. Or how about only keeping the base file name? This could
> limit it to within 80 characters.
I'd recommend using this API:
https://github.com/llvm/llvm-project/blob/2f23666ae7e4
" + sys::path::filename(Record.getInputFilename()),"
In-Reply-To:
https://github.com/sunshaoce updated
https://github.com/llvm/llvm-project/pull/65744
>From 23d0b738bf40ea44e159f4f8d7355d4d6bc0688d Mon Sep 17 00:00:00 2001
From: Shao-Ce SUN
Date: Sat, 23 Sep 2023 11:38:33 +0800
Subject: [PATC
" + sys::path::filename(Record.getInputFilename()),"
In-Reply-To:
sunshaoce wrote:
Addressed. Thanks! Now it is
```
/*===- TableGen'erated file -*- C++ -*-===*\
|**|
|* ValueTypes Sou
jimingham wrote:
Getting the SyntheticFrontEnd to try updating the synthetic value is a good
addition. But I'm not sure that ValueObject should be the one that should
provide access directly to the FrontEnd? Why isn't it enough to have the
ValueObjectSynthetic's SetValueFromCString do this?
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/5] [lldb][Commands] Show symbol change bit in SB API
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/66144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Augusto Noronha
Date: 2023-09-25T11:17:42-07:00
New Revision: 962ef991da2836775191435fb732fc61ec07d5e6
URL:
https://github.com/llvm/llvm-project/commit/962ef991da2836775191435fb732fc61ec07d5e6
DIFF:
https://github.com/llvm/llvm-project/commit/962ef991da2836775191435fb732fc61ec07d5e6.dif
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at main function
+
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
Author: Alex Langford
Date: 2023-09-25T13:11:39-07:00
New Revision: d3505c28a770fabd77d7483afbca383d453bef02
URL:
https://github.com/llvm/llvm-project/commit/d3505c28a770fabd77d7483afbca383d453bef02
DIFF:
https://github.com/llvm/llvm-project/commit/d3505c28a770fabd77d7483afbca383d453bef02.diff
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/67190
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ted updated this revision to Diff 557321.
ted added a comment.
Remove disabling JIT and enabling IR Interpreter function calls, as requested
by Jason Molenda.
Added default unwind plan as suggested by Jason Molenda.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi
ted updated this revision to Diff 557322.
ted marked 3 inline comments as done.
ted added a comment.
Change "word_size = m_is_rv64 ? 8 : 4" to "word_size = reg_size"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159101/new/
https://reviews.llvm.org
ted updated this revision to Diff 557323.
ted marked 4 inline comments as done.
ted added a comment.
Fix comment about "a" registers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159101/new/
https://reviews.llvm.org/D159101
Files:
lldb/source/Pl
https://github.com/bulbazord requested changes to this pull request.
I echo Jim's sentiments here, not sure if this is the right way to go about it.
Independent of that, I have one concern about the implementation and a few
minor points.
https://github.com/llvm/llvm-project/pull/67309
@@ -1535,7 +1535,12 @@ bool ValueObject::SetValueFromCString(const char
*value_str, Status &error) {
}
} else {
// We don't support setting things bigger than a scalar at present.
-error.SetErrorString("unable to write aggregate data type");
+// But maybe our
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/67309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -75,6 +77,10 @@ class SyntheticChildrenFrontEnd {
// display purposes
virtual ConstString GetSyntheticTypeName() { return ConstString(); }
+ virtual bool SetValueFromCString(const char *value_str, Status &error) {
+return false;
+ }
+
bulbazord wr
@@ -34,7 +34,9 @@ class SyntheticChildrenFrontEnd {
public:
SyntheticChildrenFrontEnd(ValueObject &backend)
- : m_backend(backend), m_valid(true) {}
+ : m_backend(backend), m_valid(true) {
+backend.SetSyntheticFrontend(this);
+ }
bulbazord wro
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/3] [lldb] add command start
---
lldb/
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/4] [lldb] add command start
---
lldb/
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at main function
+ {
+TargetSP target_sp =
+execution_context
junior-jl wrote:
Thank you @bulbazord & @clayborg for the step-by-step, it was really helpful. I
reverted the first commit, removed the shell modification you mentioned and the
created breakpoint is now one-shot, @jimingham.
https://github.com/llvm/llvm-project/pull/67019
_
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -675,6 +675,8 @@ let Command = "platform shell" in {
let Command = "process launch" in {
def process_launch_stop_at_entry : Option<"stop-at-entry", "s">,
De
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg commented:
See my inline comments. I am wondering if we want to get the platform involved
here so they can do the right thing for any platform and it might
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
@@ -132,6 +132,84 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+/// Create a short summary for a container that contains the summary of its
+/// first children, so that the user can get a glimpse of its contents at a
+/// glance.
+static std::opti
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/67384
In https://reviews.llvm.org/D136620 I changed debugserver to stop using the
kernel-provided functions
arm_thread_state64_get_{pc,lr,sp,fp} to postprocess those four registers on
aarch64 systems after we thr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
In https://reviews.llvm.org/D136620 I changed debugserver to stop using the
kernel-provided functions
arm_thread_state64_get_{pc,lr,sp,fp} to postprocess those four registers on
aarch64 systems after we thread_get_state() them. The kernel s
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/67384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff feb7b1914d513c709b9e024dfed709bb889cc853
5e588f4163c5d6790ac6b8836558aa3a5bf1ccfc --
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/67384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2023-09-25T17:02:25-07:00
New Revision: b7961f2cb97556bfc50f7828d5f869d96ab9352e
URL:
https://github.com/llvm/llvm-project/commit/b7961f2cb97556bfc50f7828d5f869d96ab9352e
DIFF:
https://github.com/llvm/llvm-project/commit/b7961f2cb97556bfc50f7828d5f869d96ab9352e.diff
@@ -132,6 +132,84 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+/// Create a short summary for a container that contains the summary of its
+/// first children, so that the user can get a glimpse of its contents at a
+/// glance.
+static std::opti
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -675,6 +675,8 @@ let Command = "platform shell" in {
let Command = "process launch" in {
def process_launch_stop_at_entry : Option<"stop-at-entry", "s">,
De
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg commented:
After Jim's recent comments sounds like the Platform is not the right place to
set the breakpoint. So please ignore my comments suggesting to us
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntr
" + sys::path::filename(Record.getInputFilename()),"
In-Reply-To:
https://github.com/chapuni approved this pull request.
Looks good.
At the moment, this doesn't emit `path` but `file name`.
Since I'll push reformatting, could you rebase, squash, and retitle before
pushing?
I guess we could e
" + sys::path::filename(Record.getInputFilename()),"
In-Reply-To:
https://github.com/sunshaoce edited
https://github.com/llvm/llvm-project/pull/65744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
" + sys::path::filename(Record.getInputFilename()),"
In-Reply-To:
https://github.com/sunshaoce updated
https://github.com/llvm/llvm-project/pull/65744
>From 8fd7007fa437a0eefb66015861f76f65095c31bc Mon Sep 17 00:00:00 2001
From: Shao-Ce SUN
Date: Sat, 23 Sep 2023 11:38:33 +0800
Subject: [PATC
" + sys::path::filename(Record.getInputFilename()),"
In-Reply-To:
https://github.com/sunshaoce closed
https://github.com/llvm/llvm-project/pull/65744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: Shao-Ce SUN
Date: 2023-09-26T13:40:56+08:00
New Revision: b0e28eb832710964067a17d845de15ada2da2b9c
URL:
https://github.com/llvm/llvm-project/commit/b0e28eb832710964067a17d845de15ada2da2b9c
DIFF:
https://github.com/llvm/llvm-project/commit/b0e28eb832710964067a17d845de15ada2da2b9c.diff
L
@@ -75,6 +77,10 @@ class SyntheticChildrenFrontEnd {
// display purposes
virtual ConstString GetSyntheticTypeName() { return ConstString(); }
+ virtual bool SetValueFromCString(const char *value_str, Status &error) {
+return false;
+ }
+
kpdev wrote:
https://github.com/kpdev edited https://github.com/llvm/llvm-project/pull/67309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
79 matches
Mail list logo
