[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135827/new/ https://reviews.llvm.org/D135827

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

DavidSpickett added a comment. > With -f(un)signed-char, the die corresponding to "char" may be the wrong > DW_ATE_(un)signed_char. As the producer of the DWARF (so, clang for example) is this correct by the existing rules? As I understand it so far, if the compiler is using "char" (no sign ch

[Lldb-commits] [lldb] 66763b2 - Revert "[lldb] Use std::underlying_type_t (NFC)"

Author: David Spickett Date: 2022-10-17T10:55:19Z New Revision: 66763b287007ac4a2fd19b8db2bdd8b52d503666 URL: https://github.com/llvm/llvm-project/commit/66763b287007ac4a2fd19b8db2bdd8b52d503666 DIFF: https://github.com/llvm/llvm-project/commit/66763b287007ac4a2fd19b8db2bdd8b52d503666.diff LOG

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

labath added a comment. In D136011#3860637 , @dblaikie wrote: > I think the place where this will go wrong is in terms of how lldb renders > `char` values on non-default-char-signedness programs (it'll render them as > the default-char-signedness, which

[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/posix/MainLoopPosix.cpp:399-402 + if (m_triggering) +return; + m_triggering = true; + Maybe something like `if (m_trig

[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

mgorny marked an inline comment as done. mgorny added a comment. Thanks. I'll do a fresh test run on the updated version and push if it passes. Comment at: lldb/source/Host/posix/MainLoopPosix.cpp:399-402 + if (m_triggering) +return; + m_triggering = true; + -

[Lldb-commits] [lldb] e8ee0f1 - [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

Author: Michał Górny Date: 2022-10-17T17:48:44+02:00 New Revision: e8ee0f121dbc2dc20a9de326531c4d4d061a20d8 URL: https://github.com/llvm/llvm-project/commit/e8ee0f121dbc2dc20a9de326531c4d4d061a20d8 DIFF: https://github.com/llvm/llvm-project/commit/e8ee0f121dbc2dc20a9de326531c4d4d061a20d8.diff

[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGe8ee0f121dbc: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 569be95 - [lldb] Print newline between found types

Author: Arthur Eubanks Date: 2022-10-17T14:24:21-07:00 New Revision: 569be95a40893041f8cadf2907a5970a19b1155f URL: https://github.com/llvm/llvm-project/commit/569be95a40893041f8cadf2907a5970a19b1155f DIFF: https://github.com/llvm/llvm-project/commit/569be95a40893041f8cadf2907a5970a19b1155f.diff

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

This revision was automatically updated to reflect the committed changes. Closed by commit rG569be95a4089: [lldb] Print newline between found types (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135827/new/ https://reviews.llv

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. It's a bit wrong that UserExpression::Evaluate takes an error and a result_valobj_sp. What would it mean if result_valobj_sp->GetError() was something, but something different from t

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jasonmolenda, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Currently,

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468337. augusto2112 added a comment. Remote extra semi-colon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://reviews.llvm.org/D136114 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFCo

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

aprantl added a comment. > It's a bit wrong that UserExpression::Evaluate takes an error and a > result_valobj_sp. I agree. I might be fixing that in a follow-up commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135998/new/ https://reviews.llvm.org/D135998 ___

[Lldb-commits] [lldb] a31a5da - Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

Author: Adrian Prantl Date: 2022-10-17T15:21:41-07:00 New Revision: a31a5da3c7d7393749a43dbc678fd28fb94d07f6 URL: https://github.com/llvm/llvm-project/commit/a31a5da3c7d7393749a43dbc678fd28fb94d07f6 DIFF: https://github.com/llvm/llvm-project/commit/a31a5da3c7d7393749a43dbc678fd28fb94d07f6.diff

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31a5da3c7d7: Make sure Target::EvaluateExpression() passes up an error instead of silently… (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Fix ParseAllNamespacesPlusChildrenOf and avoid duplicate iteration on symbol stream

zequanwu updated this revision to Diff 468362. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136006/new/ https://reviews.llvm.org/D136006 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp lldb/

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

stella.stamenova added a comment. Herald added subscribers: Michael137, JDevlieghere. I think this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135998/new/

[Lldb-commits] [lldb] 2c9093e - Revert "Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it."

Author: Adrian Prantl Date: 2022-10-17T17:27:54-07:00 New Revision: 2c9093e649c4078c1083f489b72dda7ad54baea5 URL: https://github.com/llvm/llvm-project/commit/2c9093e649c4078c1083f489b72dda7ad54baea5 DIFF: https://github.com/llvm/llvm-project/commit/2c9093e649c4078c1083f489b72dda7ad54baea5.diff

[Lldb-commits] [lldb] dd5c5f7 - Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

Author: Adrian Prantl Date: 2022-10-17T17:27:54-07:00 New Revision: dd5c5f72e00dca0e2458139fec09b1a715cfb238 URL: https://github.com/llvm/llvm-project/commit/dd5c5f72e00dca0e2458139fec09b1a715cfb238 DIFF: https://github.com/llvm/llvm-project/commit/dd5c5f72e00dca0e2458139fec09b1a715cfb238.diff

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

aprantl added a comment. Turns out this did have an effect on the test suite: There was one test that expected a failing expression to have an invalid SBValue and an Error: diff --git a/lldb/test/API/commands/expression/context-object/TestContextObject.py b/lldb/test/API/c ommands/expressi

[Lldb-commits] [PATCH] D136034: [lldb][trace] Add a basic function call dump [3] - Add a JSON dumper

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. nice! using this in conjunction with trace cursor we'll be able to produce some nice visualizations - lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } zequanwu wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:55 - if (debug_aranges->GetNumRanges() == num_debug_aranges) { + if (debug_aranges->GetNumRanges() == num_debug_aranges && cu_offset == 0) { // We got nothing from the deb

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } zequanwu wrote: > zequanwu wrote: > >

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

labath added a comment. Is this purely a performance optimization, or does it have some impact on operation (its correctness) as well? E.g. does it prevent duplicate construction of some types or something like that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems fine to me. Jim, Med, do you want to add anything? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135648/new/ https://reviews.llvm.org/D135648 __