[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

Turns out this did have an effect on the test suite: There was one test that 
expected a failing expression to have an invalid SBValue and an Error:

  diff --git 
a/lldb/test/API/commands/expression/context-object/TestContextObject.py 
b/lldb/test/API/c
  ommands/expression/context-object/TestContextObject.py
  index 45f7a003837b..7c963ebd846c 100644
  --- a/lldb/test/API/commands/expression/context-object/TestContextObject.py
  +++ b/lldb/test/API/commands/expression/context-object/TestContextObject.py
  @@ -67,7 +67,7 @@ class ContextObjectTestCase(TestBase):
   
           # Test an expression evaluation
           value = obj_val.EvaluateExpression("1")
  -        self.assertFalse(value.IsValid())
  +        self.assertTrue(value.IsValid())
           self.assertFalse(value.GetError().Success())
   
           #


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135998/new/

https://reviews.llvm.org/D135998

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits