[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett updated this revision to Diff 430276. DavidSpickett added a comment. Correct "addr" -> "fixed_addr" in a couple of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 Files: lldb/sou

[Lldb-commits] [lldb] 7d8ec4d - [lldb] const a couple of getters on MemoryRegionInfo

Author: David Spickett Date: 2022-05-18T09:00:00Z New Revision: 7d8ec4dc4461102bafed8063977a66e40562bbb3 URL: https://github.com/llvm/llvm-project/commit/7d8ec4dc4461102bafed8063977a66e40562bbb3 DIFF: https://github.com/llvm/llvm-project/commit/7d8ec4dc4461102bafed8063977a66e40562bbb3.diff LOG

[Lldb-commits] [PATCH] D125786: [lldb] const a couple of getters on MemoryRegionInfo

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7d8ec4dc4461: [lldb] const a couple of getters on MemoryRegionInfo (authored by DavidSpickett). Repository: rG LLVM Git

[Lldb-commits] [PATCH] D125786: [lldb] const a couple of getters on MemoryRegionInfo

DavidSpickett added a comment. Landed as obvious as I'll shortly land the follow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125786/new/ https://reviews.llvm.org/D125786 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430293. DavidSpickett added a comment. Fixup the tagged memory region test (it doesn't care about the content of the usage just that the command eventually fails) and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett updated this revision to Diff 430312. DavidSpickett added a comment. Fixup the loop on systems that have more non-address bits than just top byte ignore. With only top byte ignore: - We ask the remote for the last region - It says ok it's unmapped and it ends at 0xFF - Then we

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e648f195c3d: [lldb] Add --all option to "memory region" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [lldb] 8e648f1 - [lldb] Add --all option to "memory region"

Author: David Spickett Date: 2022-05-18T10:33:39Z New Revision: 8e648f195c3d57e573fdd8023edcfd80e0516c61 URL: https://github.com/llvm/llvm-project/commit/8e648f195c3d57e573fdd8023edcfd80e0516c61 DIFF: https://github.com/llvm/llvm-project/commit/8e648f195c3d57e573fdd8023edcfd80e0516c61.diff LOG

[Lldb-commits] [lldb] 3e928c4 - Revert "[lldb] Add --all option to "memory region""

Author: David Spickett Date: 2022-05-18T11:57:20Z New Revision: 3e928c4b9dfb01efd2cb968795e605760828e873 URL: https://github.com/llvm/llvm-project/commit/3e928c4b9dfb01efd2cb968795e605760828e873 DIFF: https://github.com/llvm/llvm-project/commit/3e928c4b9dfb01efd2cb968795e605760828e873.diff LOG

[Lldb-commits] [lldb] d9398a9 - [lldb] Remove non-address bits from read/write addresses in lldb

Author: David Spickett Date: 2022-05-18T12:59:34+01:00 New Revision: d9398a91e2a6b8837a47a5fda2164c9160e86199 URL: https://github.com/llvm/llvm-project/commit/d9398a91e2a6b8837a47a5fda2164c9160e86199 DIFF: https://github.com/llvm/llvm-project/commit/d9398a91e2a6b8837a47a5fda2164c9160e86199.diff

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9398a91e2a6: [lldb] Remove non-address bits from read/write addresses in lldb (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118

[Lldb-commits] [lldb] 00a1258 - [lldb][AArch64] Fix corefile memory reads when there are non-address bits

Author: David Spickett Date: 2022-05-18T14:13:42+01:00 New Revision: 00a12585933ef63ff1204bf5cd265f0071d04642 URL: https://github.com/llvm/llvm-project/commit/00a12585933ef63ff1204bf5cd265f0071d04642 DIFF: https://github.com/llvm/llvm-project/commit/00a12585933ef63ff1204bf5cd265f0071d04642.diff

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG00a12585933e: [lldb][AArch64] Fix corefile memory reads when there are non-address bits (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 430357. PatriosTheGreat marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/sourc

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat added a comment. Hi Greg, Sorry for a delay had an issue with tests local run. I fixed the previous feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D125089: [lldb] Change implementation of memory read --show-tags option

This revision was automatically updated to reflect the committed changes. Closed by commit rG29e556fc2ba9: [lldb] Change implementation of memory read --show-tags option (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12508

[Lldb-commits] [lldb] 29e556f - [lldb] Change implementation of memory read --show-tags option

Author: David Spickett Date: 2022-05-18T16:49:09+01:00 New Revision: 29e556fc2ba93028f0dc45c4c2636da6283e9c28 URL: https://github.com/llvm/llvm-project/commit/29e556fc2ba93028f0dc45c4c2636da6283e9c28 DIFF: https://github.com/llvm/llvm-project/commit/29e556fc2ba93028f0dc45c4c2636da6283e9c28.diff

[Lldb-commits] [PATCH] D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Add collection of context switches per cpu grouped with the per-cpu intel pt traces. -

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

jingham added a comment. Addressed review comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:80-111 +// Static Variables +static uint32_t g_initialize_count = 0; + +void PlatformDarwin::Initialize() { + Platform::Initialize(); + + if (g_initialize_co

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

jingham updated this revision to Diff 430435. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125434/new/ https://reviews.llvm.org/D125434 Files: lldb/include/lldb/Interpreter/OptionValueString.h

[Lldb-commits] [lldb] bff4673 - Add a darwin platform setting to specify which exceptions debugserver

Author: Jim Ingham Date: 2022-05-18T10:16:11-07:00 New Revision: bff4673b41781ec5bff6b96b52cf321d2271726c URL: https://github.com/llvm/llvm-project/commit/bff4673b41781ec5bff6b96b52cf321d2271726c DIFF: https://github.com/llvm/llvm-project/commit/bff4673b41781ec5bff6b96b52cf321d2271726c.diff LO

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbff4673b4178: Add a darwin platform setting to specify which exceptions debugserver (authored by jingham). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new `use_colors` argument to the PExpect.launch method. As the name suggests, it

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib updated this revision to Diff 430465. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 Files: lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/test/API/functionalities/progress_

[Lldb-commits] [PATCH] D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125915/new/ https://reviews.llvm.org/D125915 ___

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:29-30 +self.launch(use_colors=True) +# Set the terminal to a random width +term_width = random.randint(10, 42) +self.e

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. Still a few places where we have a dedicated assert Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:25 +debugger.HandleCommand(f"break set -a {main_address:#x}") +self.assertTrue(

[Lldb-commits] [PATCH] D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

wallace updated this revision to Diff 430490. wallace edited the summary of this revision. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125897/new/ https://reviews.llvm.org/D125897 Files: lldb/docs/lldb-gdb-remote.t

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch substracts 1 to the pc of any frame about frame 0 to get the previous line entry and dis

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 430502. zequanwu added a comment. Add missing sort. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/lldb/Expression/DWARFExpression.h lldb/in

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:118-119 -# Any frame above frame zero and we have to subtract one to -# get the previous line entry. +# We should substract 1 to every frame's pc abo

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the changes. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ lldb-commi

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

mib updated this revision to Diff 430505. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. Updated comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125928/new/ https://reviews.llvm.org/D125928 Files: lldb/examples/python/crashlo

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125928/new/ https://reviews.llvm.org/D125928 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Add a warnings field in the jLLDBGetState response, for warnings to be delivered to th

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

JDevlieghere added a comment. Separating the notion of an expression and an expression list seems worthwhile. I did a very high level pass but I'll take a more detailed look tomorrow. Comment at: lldb/include/lldb/Expression/DWARFExpressionList.h:1-2 +//===-- DWARFExpressionLi

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib updated this revision to Diff 430548. mib added a comment. Address @JDevlieghere comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 Files: lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/test/API/fun

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:49-50 +self.do_test(80, ['Locating external symbol file for a.out...', + 'Loading Apple DWARF index for a.out...', +

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the decorator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 ___ lldb-co

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:49-50 +self.do_test(80, ['Locating external symbol file for a.out...', + 'Loading Apple

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib updated this revision to Diff 430552. mib marked an inline comment as done. mib added a comment. Only run test on Darwin platforms CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 Files: lldb/include/lldb/Core/DebuggerEvents.h lldb/sour

[Lldb-commits] [lldb] d71d1a9 - [lldb/Test] Add `use_colors` argument to the PExpect.launch wrapper

Author: Med Ismail Bennani Date: 2022-05-18T18:22:46-07:00 New Revision: d71d1a947bee1247e952f22c13ad3ed3d041e36a URL: https://github.com/llvm/llvm-project/commit/d71d1a947bee1247e952f22c13ad3ed3d041e36a DIFF: https://github.com/llvm/llvm-project/commit/d71d1a947bee1247e952f22c13ad3ed3d041e36a.

[Lldb-commits] [lldb] 3e54ea0 - [lldb/crashlog] Fix line entries resolution in interactive mode

Author: Med Ismail Bennani Date: 2022-05-18T18:22:47-07:00 New Revision: 3e54ea0cfa3074e36ebee11848e072785437a8b9 URL: https://github.com/llvm/llvm-project/commit/3e54ea0cfa3074e36ebee11848e072785437a8b9 DIFF: https://github.com/llvm/llvm-project/commit/3e54ea0cfa3074e36ebee11848e072785437a8b9.

[Lldb-commits] [lldb] 051a5ae - [lldb/Core] Fix "sticky" long progress messages

Author: Med Ismail Bennani Date: 2022-05-18T18:22:46-07:00 New Revision: 051a5ae99824fab879d9aade9d794e60ebc5c2e5 URL: https://github.com/llvm/llvm-project/commit/051a5ae99824fab879d9aade9d794e60ebc5c2e5 DIFF: https://github.com/llvm/llvm-project/commit/051a5ae99824fab879d9aade9d794e60ebc5c2e5.

[Lldb-commits] [PATCH] D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGd71d1a947bee: [lldb/Test] Add `use_colors` argument to the PExpect.launch wrapper (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125915/new

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG051a5ae99824: [lldb/Core] Fix "sticky" long progress messages (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.l

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e54ea0cfa30: [lldb/crashlog] Fix line entries resolution in interactive mode (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125928/new/ h

[Lldb-commits] [lldb] 80589f2 - [lldb/test] Make some tests as XFAIL while I investigate the issue

Author: Med Ismail Bennani Date: 2022-05-18T18:51:10-07:00 New Revision: 80589f272c200798b57a5151680a993bc2cc00a7 URL: https://github.com/llvm/llvm-project/commit/80589f272c200798b57a5151680a993bc2cc00a7 DIFF: https://github.com/llvm/llvm-project/commit/80589f272c200798b57a5151680a993bc2cc00a7.

[Lldb-commits] [lldb] 821ee17 - dyld patch

Author: Med Ismail Bennani Date: 2022-05-18T18:46:00-07:00 New Revision: 821ee172cdcd7196b6130321b53b6cc66bf1222b URL: https://github.com/llvm/llvm-project/commit/821ee172cdcd7196b6130321b53b6cc66bf1222b DIFF: https://github.com/llvm/llvm-project/commit/821ee172cdcd7196b6130321b53b6cc66bf1222b.

[Lldb-commits] [lldb] fd25ad5 - Revert 821ee172cdcd7196b6130321b53b6cc66bf1222b

Author: Med Ismail Bennani Date: 2022-05-18T19:07:47-07:00 New Revision: fd25ad51224e0558328cc9dfc6bf4533fd54403b URL: https://github.com/llvm/llvm-project/commit/fd25ad51224e0558328cc9dfc6bf4533fd54403b DIFF: https://github.com/llvm/llvm-project/commit/fd25ad51224e0558328cc9dfc6bf4533fd54403b.

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

wallace created this revision. wallace added a reviewer: jj10306. Herald added a subscriber: pengfei. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Add logging for when the live state of the process

[Lldb-commits] [lldb] 1351a9b - [lldb/test] Fix failures caused by a previous PExpect.launch change

Author: Med Ismail Bennani Date: 2022-05-18T21:12:44-07:00 New Revision: 1351a9b19ecf48ebb2caad8ae6d8776a6dc1786d URL: https://github.com/llvm/llvm-project/commit/1351a9b19ecf48ebb2caad8ae6d8776a6dc1786d DIFF: https://github.com/llvm/llvm-project/commit/1351a9b19ecf48ebb2caad8ae6d8776a6dc1786d.

[Lldb-commits] [lldb] fbf0c42 - Revert "[lldb/test] Make some tests as XFAIL while I investigate the issue"

Author: Med Ismail Bennani Date: 2022-05-18T21:12:43-07:00 New Revision: fbf0c4229410fb17842cc0c0db882eeba6252ae8 URL: https://github.com/llvm/llvm-project/commit/fbf0c4229410fb17842cc0c0db882eeba6252ae8 DIFF: https://github.com/llvm/llvm-project/commit/fbf0c4229410fb17842cc0c0db882eeba6252ae8.