mib marked an inline comment as done.
mib added inline comments.

================
Comment at: 
lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:49-50
+        self.do_test(80, ['Locating external symbol file for a.out...',
+                          'Loading Apple DWARF index for a.out...',
+                          'Parsing symbol table for dyld...'])
----------------
JDevlieghere wrote:
> These two things are pretty Apple specific so maybe use the 
> `skipUnlessDarwin` decorator? I think the locating symbol files will be 
> printed on all platforms, but if we need to skip the test on Linux anyway 
> that doesn't really buy us much to reduce the test coverage.
Indeed! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124785/new/

https://reviews.llvm.org/D124785

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to