[Lldb-commits] [PATCH] D123015: handle Ctrl+C to stop a running process

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. This is essentially the same as IOHandlerEditline:

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett added a comment. > It sounds like we should figure out a way to enable all extensions with a > single stroke. Totally. llvm-objdump could do with a `-mcpu=max` equivalent too. I think it's possible to get all extension names right now, but not the newest arch version. I'll look i

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. Valgrind makes everything run much slower, so don'

[Lldb-commits] [lldb] 434b545 - [lldb][AArch64] Update disassembler feature list and add tests for all extensions

Author: David Spickett Date: 2022-04-04T11:21:01Z New Revision: 434b545d4fc7824cf03976a8844020e33040855e URL: https://github.com/llvm/llvm-project/commit/434b545d4fc7824cf03976a8844020e33040855e DIFF: https://github.com/llvm/llvm-project/commit/434b545d4fc7824cf03976a8844020e33040855e.diff LOG

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG434b545d4fc7: [lldb][AArch64] Update disassembler feature list and add tests for all… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

nidefawl created this revision. nidefawl added a reviewer: wallace. nidefawl added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. nidefawl requested review of this revision. Herald added a subscriber: lldb-commits. This patch implements stderr/stdout forward

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

mstorsjo added a reviewer: labath. mstorsjo added inline comments. Comment at: lldb/tools/lldb-vscode/OutputRedirector.cpp:12 +#else +#include +#include Minor style issue - I guess it'd be less of double negation, if we'd change the ifdef to `#if defined(_WIN3

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

labath added a comment. Seems reasonable, but I don't know much about pdb's. @rnk, do you want to take a look? Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:54 struct FindMembersSize : public TypeVisitorCallbacks { - FindMembersSize(std::vector> &members_i

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

labath added a comment. Yes, that's the general idea, but you forgot the `CreateMemoryInstance` callback -- we should fix that too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122944/new/ https://reviews.llvm.org/D122944 ___ lldb-commits m

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

labath added subscribers: dblaikie, labath. labath added a reviewer: dblaikie. labath added a comment. In principle, I like this a lot, though I'm not sure if this is the best way to integrate with with the StringMap class. Adding @dblaikie for thoughts on that. Some background: LLDB uses a stri

[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

labath accepted this revision. labath added a comment. In D122980#3424636 , @JDevlieghere wrote: > I feel like this came up in the past and there was a reason an unordered map > couldn't work? Maybe I'm confusing this with something else. Added Pavel as

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. > BTW, does it make sense to get even things like this reviewed, or is it ok if > I push these directly if I'm reasonably certain I know what I'm doing? I feel > like I'm spamming you by now. Generally, I would say yes. I'm not even sure that some of your other patches

[Lldb-commits] [PATCH] D123001: make 'step out' step out of the selected frame

labath added a comment. This should definitely have a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123001/new/ https://reviews.llvm.org/D123001 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

JDevlieghere updated this revision to Diff 420193. JDevlieghere added a comment. Update `CreateMemoryInstance` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122944/new/ https://reviews.llvm.org/D122944 Files: lldb/include/lldb/lldb-private-interfaces.h lldb/source/Plugins/ObjectFil

[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

JDevlieghere accepted this revision. JDevlieghere added a comment. In D122980#3426196 , @labath wrote: > In D122980#3424636 , @JDevlieghere > wrote: > >> I feel like this came up in the past and there was a reaso

[Lldb-commits] [lldb] cf3e401 - Prevent GetAugmentedArchSpec() from attaching "unknown" environments

Author: Adrian Prantl Date: 2022-04-04T08:56:58-07:00 New Revision: cf3e4011b57b07d88e3e577295c3327b07c15922 URL: https://github.com/llvm/llvm-project/commit/cf3e4011b57b07d88e3e577295c3327b07c15922 DIFF: https://github.com/llvm/llvm-project/commit/cf3e4011b57b07d88e3e577295c3327b07c15922.diff

[Lldb-commits] [PATCH] D122946: Prevent HostInfoBase::GetAugmentedArchSpec() from attaching "unknown" environments

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf3e4011b57b: Prevent GetAugmentedArchSpec() from attaching "unknown" environments (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. Is this really something we want to hardcode at all? It seems like this should be a setting that is configured by the test harness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123020/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This is an interesting area for optimisation, but I don't think it's going to be that easy. A couple of years ago, I experimented with a similar approach, but I could not come up wit

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

labath added a comment. If it's just a matter of setting the default timeout value, then I don't think it would be that bad -- we already set a different timeout for debug and release builds, so it we could conceivably put this there. But yes, my "setting the initial timeout value to a reasonab

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew updated this revision to Diff 420205. andrew added a comment. Add support for the PAC test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/ https://reviews.llvm.org/D120485 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

This revision was automatically updated to reflect the committed changes. Closed by commit rGc69307e5eeb5: [lldb] Prevent object file plugins from changing the data buffer (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D122944?vs=4201

[Lldb-commits] [lldb] c69307e - [lldb] Prevent object file plugins from changing the data buffer

Author: Jonas Devlieghere Date: 2022-04-04T09:24:24-07:00 New Revision: c69307e5eeb585203a68b24f020d17ad75821c8a URL: https://github.com/llvm/llvm-project/commit/c69307e5eeb585203a68b24f020d17ad75821c8a DIFF: https://github.com/llvm/llvm-project/commit/c69307e5eeb585203a68b24f020d17ad75821c8a.d

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

llunak added a comment. In D122975#3426575 , @labath wrote: > I'd like to understand what is the precise thing that you're trying to > optimise. If there is like a single hot piece of code that we want to > optimise, then we might be able to come up wit

[Lldb-commits] [lldb] 9a6a0df - [lldb] make ConstStringTable use DenseMap rather than std::map

Author: Luboš Luňák Date: 2022-04-04T18:46:22+02:00 New Revision: 9a6a0dfa06a5acd01f6b55f8a1ba9f0f5109e02c URL: https://github.com/llvm/llvm-project/commit/9a6a0dfa06a5acd01f6b55f8a1ba9f0f5109e02c DIFF: https://github.com/llvm/llvm-project/commit/9a6a0dfa06a5acd01f6b55f8a1ba9f0f5109e02c.diff L

[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a6a0dfa06a5: [lldb] make ConstStringTable use DenseMap rather than std::map (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122980/new/

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak added a comment. In D123020#3426252 , @labath wrote: >> BTW, does it make sense to get even things like this reviewed, or is it ok >> if I push these directly if I'm reasonably certain I know what I'm doing? I >> feel like I'm spamming you by now

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3426839 , @llunak wrote: > In D123020#3426252 , @labath wrote: > >>> BTW, does it make sense to get even things like this reviewed, or is it ok >>> if I push these directl

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

clayborg added a comment. I had tried something similar with the thread pools when trying to parallelize similar stuff. The solution I made was to have a global thread pool for the entire LLDB process, but then the LLVM thread pool stuff needed to be modified to handle different groups of threa

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

zrthxn updated this revision to Diff 420245. zrthxn added a comment. Change in memory use is appreciable. thread #1: tid = 40371 Raw trace size: 4 KiB Total number of instructions: 145011 Total approximate memory usage: 1840.96 KiB Average memory usage per instruction: 13.00 byt

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

labath added inline comments. Comment at: lldb/include/lldb/Utility/DataBuffer.h:58 + /// if the object contains no bytes. + virtual const uint8_t *GetBytesImpl() const = 0; + Are you sure this should be public? Comment at: lldb/include/l

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

zrthxn updated this revision to Diff 420256. zrthxn added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122991/new/ https://reviews.llvm.org/D122991 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp lldb/sour

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere updated this revision to Diff 420262. JDevlieghere marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122856/new/ https://reviews.llvm.org/D122856 Files: lldb/include/lldb/Core/ValueObject.h lldb/include/lldb/Host/FileSystem.h lldb/include/

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:361 // Update the data to contain the entire file if it doesn't already if (data_sp->GetByteSize() < length) { +data_sp = MapFileDataWritable(*file, length, file_offset)

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

llunak added a comment. In D122975#3427008 , @clayborg wrote: > I had tried something similar with the thread pools when trying to > parallelize similar stuff. The solution I made was to have a global thread > pool for the entire LLDB process, but then

[Lldb-commits] [PATCH] D123073: [lldb] Change CreateMemoryInstance to take a WritableDataBuffer

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added subscribers: pmatos, asb, sbc100, emaste. Herald added a project: All. JDevlieghere requested review of this revision. Herald added subscribers: MaskRay, aheejin. Change CreateMemoryInstance to take a WritableD

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:382 ObjectFile *ObjectFileELF::CreateMemoryInstance( const lldb::ModuleSP &module_sp, DataBufferSP &data_sp, const lldb::ProcessSP &process_sp, lldb::addr_t header_addr

[Lldb-commits] [PATCH] D122660: [lldb] Avoid duplicate vdso modules when opening core files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Well, I don't see anything wrong with it and it doesn't seem to cause any regressions on FreeBSD. I wouldn't call myself an expert on this though. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D122716: [lldb/linux] Handle main thread exits

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122716/new/ https://reviews.llvm.org/D122716 ___

[Lldb-commits] [PATCH] D123001: make 'step out' step out of the selected frame

llunak updated this revision to Diff 420295. llunak added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123001/new/ https://reviews.llvm.org/D123001 Files: lldb/include/lldb/Target/Thread.h lldb/source/Core/IOHandlerCursesGUI.cpp lldb/source/Target/Thread

[Lldb-commits] [PATCH] D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step

jasonmolenda updated this revision to Diff 420303. jasonmolenda added a comment. Update patch to remove unnecessary temporary std::string when dumping a string into its JSON representation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122882/new/

[Lldb-commits] [lldb] 7ebcd88 - Add DumpBinaryEscaped method to JSONGenerator, avoid extra copy

Author: Jason Molenda Date: 2022-04-04T14:14:02-07:00 New Revision: 7ebcd8891a7acc265cee4996d55a287a035f8771 URL: https://github.com/llvm/llvm-project/commit/7ebcd8891a7acc265cee4996d55a287a035f8771 DIFF: https://github.com/llvm/llvm-project/commit/7ebcd8891a7acc265cee4996d55a287a035f8771.diff

[Lldb-commits] [PATCH] D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7ebcd8891a7a: Add DumpBinaryEscaped method to JSONGenerator, avoid extra copy (authored by jasonmolenda). Repository: r

[Lldb-commits] [PATCH] D122660: [lldb] Avoid duplicate vdso modules when opening core files

clayborg accepted this revision. clayborg added a comment. We have seen this issue as well in linux, so thanks for fixing it. I never did any of the work on the posix dyld loader so I had been avoiding trying to fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It fixes the following case: 0602 line 1 (+1) 0315 code 0x15 (+0x15) 0B2B code 0x20 (+0xB) line 2 (+

[Lldb-commits] [PATCH] D123098: [lldb] Fix undefined behavior: left shift of negative value

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Fix undefined behavior in AppleObjCRuntimeV2 where we were left shifting a signed value. rdar://91242879 https://review

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

aganea added a comment. There's a typo in the title, `s/descirbes/describes/` Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:54 struct FindMembersSize : public TypeVisitorCallbacks { - FindMembersSize(std::vector> &members_info, + FindMembersSize(llvm::Smal

[Lldb-commits] [PATCH] D123098: [lldb] Fix undefined behavior: left shift of negative value

shafik added a comment. Note, in C++20 this was made well-defined see godbolt the paper that did this was P0907R4 Signed Integers are Two’s Complement CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D122991: [lldb][intelpt] Remove `IntelPTInstruction` and move methods to `DecodedThread`

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. only mostly cosmetic changes needed. Thanks for this. I'm glad that we are bringing the usage down Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.c

[Lldb-commits] [PATCH] D123098: [lldb] Fix undefined behavior: left shift of negative value

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM but `unobfuscated` is a uint64_t, does this cast do anything now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123098/new/ https://reviews.llvm.org/D123098

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/OutputRedirector.cpp:12 +#else +#include +#include mstorsjo wrote: > Minor style issue - I guess it'd be less of double negation, if we'd change > the ifdef to `#if defined(_WIN32) .. #else` fee

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As we soon will need to decode multiple raw tra

[Lldb-commits] [lldb] aaca2ac - [lldb][gui] do not show the help window on first gui startup

Author: Luboš Luňák Date: 2022-04-05T08:29:13+02:00 New Revision: aaca2acd5f3434ccd1d568596161628ce53d9066 URL: https://github.com/llvm/llvm-project/commit/aaca2acd5f3434ccd1d568596161628ce53d9066 DIFF: https://github.com/llvm/llvm-project/commit/aaca2acd5f3434ccd1d568596161628ce53d9066.diff L

[Lldb-commits] [lldb] f90fa55 - [lldb][gui] use just '#2' instead of 'frame #2' in the threads/frame view

Author: Luboš Luňák Date: 2022-04-05T08:29:13+02:00 New Revision: f90fa55569fc8fc3b44512823ed9e2a0d1243826 URL: https://github.com/llvm/llvm-project/commit/f90fa55569fc8fc3b44512823ed9e2a0d1243826 DIFF: https://github.com/llvm/llvm-project/commit/f90fa55569fc8fc3b44512823ed9e2a0d1243826.diff L

[Lldb-commits] [lldb] 76bc772 - [lldb][gui] make 'step out' step out of the selected frame

Author: Luboš Luňák Date: 2022-04-05T08:29:13+02:00 New Revision: 76bc7729208976e6ff6bc28b08e460d97cab5bb3 URL: https://github.com/llvm/llvm-project/commit/76bc7729208976e6ff6bc28b08e460d97cab5bb3 DIFF: https://github.com/llvm/llvm-project/commit/76bc7729208976e6ff6bc28b08e460d97cab5bb3.diff L

[Lldb-commits] [PATCH] D122997: do not show the help window on first gui startup

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaca2acd5f34: [lldb][gui] do not show the help window on first gui startup (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122997/new/ h

[Lldb-commits] [PATCH] D122998: use just '#' instead of 'frame #2' in the threads/frame view

This revision was automatically updated to reflect the committed changes. Closed by commit rGf90fa55569fc: [lldb][gui] use just '#2' instead of 'frame #2' in the threads/frame view (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D123001: make 'step out' step out of the selected frame

This revision was automatically updated to reflect the committed changes. Closed by commit rG76bc77292089: [lldb][gui] make 'step out' step out of the selected frame (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123001/new/ htt

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

wallace updated this revision to Diff 420395. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123106/new/ https://reviews.llvm.org/D123106 Files: lldb/source/Plugins/Trace/intel-pt/CMakeLists.txt lldb/source/Plugins