labath added a comment.

Seems reasonable, but I don't know much about pdb's. @rnk, do you want to take 
a look?



================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:54
 struct FindMembersSize : public TypeVisitorCallbacks {
-  FindMembersSize(std::vector<std::pair<RegisterId, uint32_t>> &members_info,
+  FindMembersSize(llvm::SmallVector<std::pair<RegisterId, uint32_t>> 
&members_info,
                   TpiStream &tpi)
----------------
I think `SmallVectorImpl` is still the official way to take SmallVector 
references.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122943/new/

https://reviews.llvm.org/D122943

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to