[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

wallace accepted this revision. wallace added a comment. Nice! I'll land this for you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. @DavidSpickett Lets merge this patch series (if it is working on your desk) but we should add information in LLDB wiki or any other appropriate place about how to reliably test mte feature

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett added a comment. Great. The QEMU testing docs https://lldb.llvm.org/use/qemu-testing.html include MTE options. Apart from having a compatible toolchain there's no difference to SVE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10518

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d27230de333: [lldb][AArch64] Add memory tag writing to lldb-server (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [lldb] 7d27230 - [lldb][AArch64] Add memory tag writing to lldb-server

Author: David Spickett Date: 2021-07-27T12:02:17+01:00 New Revision: 7d27230de3336b8c79bfdc90f59858f6dad28fa5 URL: https://github.com/llvm/llvm-project/commit/7d27230de3336b8c79bfdc90f59858f6dad28fa5 DIFF: https://github.com/llvm/llvm-project/commit/7d27230de3336b8c79bfdc90f59858f6dad28fa5.diff

[Lldb-commits] [lldb] 43e45f0 - [lldb] Wait in TestGuiBasicDebug for the interface to open before quitting the welcome screen

Author: Raphael Isemann Date: 2021-07-27T13:58:49+02:00 New Revision: 43e45f0ec920b45d6073c0aff47597c44948f52c URL: https://github.com/llvm/llvm-project/commit/43e45f0ec920b45d6073c0aff47597c44948f52c DIFF: https://github.com/llvm/llvm-project/commit/43e45f0ec920b45d6073c0aff47597c44948f52c.dif

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 added a comment. In D106584#2901529 , @vsk wrote: > Hey Augusto, thanks for tackling this, I'm just now slowly paging things in. > > Is this a correct statement of the problem: LLDB is failing to disable its > file cache optimization when rea

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 updated this revision to Diff 361991. augusto2112 added a comment. Keep only filecache and live memory equality assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Files: lldb/include/

[Lldb-commits] [lldb] 5ea091a - [lldb][AArch64] Add memory tag writing to lldb

Author: David Spickett Date: 2021-07-27T15:18:42+01:00 New Revision: 5ea091a8174bcce78839156bd044831cb5211d06 URL: https://github.com/llvm/llvm-project/commit/5ea091a8174bcce78839156bd044831cb5211d06 DIFF: https://github.com/llvm/llvm-project/commit/5ea091a8174bcce78839156bd044831cb5211d06.diff

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea091a8174b: [lldb][AArch64] Add memory tag writing to lldb (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D106880: [lldb][AArch64] Mark mismatched tags in tag read output

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The "memory tag read" command will now tell you when the allocation tag read does not ma

[Lldb-commits] [PATCH] D106880: [lldb][AArch64] Mark mismatched tags in tag read output

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. This gives us the equivalent of GDB's "mtag check" but with some more flexibility and no extra command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106880/new/ https://revi

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

DavidSpickett updated this revision to Diff 362055. DavidSpickett added a comment. Add a link to intrinsics documentation in the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105182/new/ https://reviews.llvm.org/D105182 Files: lldb/so

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

jasonmolenda added a comment. Looks good! Maybe we should add a setting like target.file-cache-memory-reads-verify (a boolean) to enable/disable this check instead of keying off NDEBUG. We can turn it on in the testsuite, and we can optionally have people with release installs of lldb enable

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

JDevlieghere added a comment. In D106584#2907898 , @jasonmolenda wrote: > Looks good! Maybe we should add a setting like > target.file-cache-memory-reads-verify (a boolean) to enable/disable this > check instead of keying off NDEBUG. We can turn it o

[Lldb-commits] [lldb] 0018c71 - Fix "break delete --disabled" with no arguments.

Author: Jim Ingham Date: 2021-07-27T13:38:09-07:00 New Revision: 0018c7123be3e090ba546fb730ed316fa2567655 URL: https://github.com/llvm/llvm-project/commit/0018c7123be3e090ba546fb730ed316fa2567655 DIFF: https://github.com/llvm/llvm-project/commit/0018c7123be3e090ba546fb730ed316fa2567655.diff LO

[Lldb-commits] [lldb] 910353c - When calculating the "currently selected thread" in

Author: Jim Ingham Date: 2021-07-27T13:38:09-07:00 New Revision: 910353c1048e5efac64b639a65b4d968aba3aa81 URL: https://github.com/llvm/llvm-project/commit/910353c1048e5efac64b639a65b4d968aba3aa81 DIFF: https://github.com/llvm/llvm-project/commit/910353c1048e5efac64b639a65b4d968aba3aa81.diff LO

[Lldb-commits] [PATCH] D106623: Fix a logic error in "break delete --disabled" when no "protected" breakpoints are specified.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0018c7123be3: Fix "break delete --disabled" with no arguments. (au

[Lldb-commits] [lldb] 6952928 - Add a test for top-level expressions using "expr --top-level".

Author: Jim Ingham Date: 2021-07-27T13:38:09-07:00 New Revision: 69529286ce2dcd90563bca97537ce570c6d115b4 URL: https://github.com/llvm/llvm-project/commit/69529286ce2dcd90563bca97537ce570c6d115b4 DIFF: https://github.com/llvm/llvm-project/commit/69529286ce2dcd90563bca97537ce570c6d115b4.diff LO

[Lldb-commits] [PATCH] D106712: Remember to check whether the current thread is stopped for a no-stop signal

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG910353c1048e: When calculating the "currently selected thread" in

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev updated this revision to Diff 362189. OmarEmaraDev added a comment. - Rebase on main. - Add basic remote debugging support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 Files: lldb/sourc

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. I still can't get remote debugging to work unfortunately, or maybe I don't understand it really. The way I understand it is as follows: - If the remote file is specified, then that means we are creating a target for remote debugging. - If the remote file doesn't ex

[Lldb-commits] [lldb] 0a74fbb - [lldb][NFC] Fix incorrect log and comment

Author: Alex Langford Date: 2021-07-27T14:43:42-07:00 New Revision: 0a74fbb7b1d3e04ac03389f1fc455ac593c2e5ee URL: https://github.com/llvm/llvm-project/commit/0a74fbb7b1d3e04ac03389f1fc455ac593c2e5ee DIFF: https://github.com/llvm/llvm-project/commit/0a74fbb7b1d3e04ac03389f1fc455ac593c2e5ee.diff

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added inline comments. Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArguments) { -return GetDemangledNameWithoutArguments(m_mangled, demangled); +if (Language *lang = Language::FindPlugin(GuessLanguage())) { + ret

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

clayborg added a comment. My comments were mostly about how we should refactor in a perfect world. Not sure we need to solve that right away. I am ok with this patch as it is if Jim is. Jim? What do you think about this patch? OK? I am good if you are. Comment at: lldb/sourc

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I still think the "Demangled" part of the GetDemangledFunctionNameWithoutArguments is redundant. I'm not sure what sense it would make to get a mangled name without arguments? And you coul

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Many inline comments with simple fixes! Very close. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2658 + TargetCreateFormDelegate(Debugger &debugger) : m

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 362229. kastiglione added a comment. Re-simplify following discussion with Adrian and Jim. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 Files: lldb/source/Ta

[Lldb-commits] [lldb] ec1a491 - Create synthetic symbol names on demand to improve memory consumption and startup times.

Author: Greg Clayton Date: 2021-07-27T16:51:12-07:00 New Revision: ec1a49170129ddb62f268ff0b3f12b3d09987a7e URL: https://github.com/llvm/llvm-project/commit/ec1a49170129ddb62f268ff0b3f12b3d09987a7e DIFF: https://github.com/llvm/llvm-project/commit/ec1a49170129ddb62f268ff0b3f12b3d09987a7e.diff

[Lldb-commits] [PATCH] D106837: Create synthetic symbol names on demand to improve memory consumption and startup times.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec1a49170129: Create synthetic symbol names on demand to improve memory consumption and… (authored by clayborg). Repository: rG LLVM Github Monore

[Lldb-commits] [lldb] 3c45476 - Fix a thinko in the parsing of substitutions in CommandObjectRegexCommand.

Author: Jim Ingham Date: 2021-07-27T18:58:56-07:00 New Revision: 3c4547692368239fca21ec294a5a406ea5a44889 URL: https://github.com/llvm/llvm-project/commit/3c4547692368239fca21ec294a5a406ea5a44889 DIFF: https://github.com/llvm/llvm-project/commit/3c4547692368239fca21ec294a5a406ea5a44889.diff LO

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh updated this revision to Diff 362287. kimanh marked an inline comment as done. kimanh added a comment. Remove braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106355/new/ https://reviews.llvm.org/D106355 Files: lldb/source/Plugins/Sy