[Lldb-commits] [PATCH] D89181: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*

2020-10-10 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: emaste, krytarowski. Herald added subscribers: atanasyan, nemanjai. mgorny requested review of this revision. https://reviews.llvm.org/D89181 Files: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h lldb/source/P

[Lldb-commits] [PATCH] D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL

2020-10-10 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: emaste, labath, krytarowski. mgorny requested review of this revision. Use PT_KILL to kill the stopped process. This ensures that the process termination is reported properly and fixes delay/error on killing it. https://reviews.llvm.org/D891

[Lldb-commits] [lldb] d83cd73 - [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*

2020-10-10 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2020-10-10T18:52:23+02:00 New Revision: d83cd73e9ddf9ba4cc5754560ef9a2abaaa30749 URL: https://github.com/llvm/llvm-project/commit/d83cd73e9ddf9ba4cc5754560ef9a2abaaa30749 DIFF: https://github.com/llvm/llvm-project/commit/d83cd73e9ddf9ba4cc5754560ef9a2abaaa30749.diff

[Lldb-commits] [lldb] 9a37587 - [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL

2020-10-10 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2020-10-10T18:54:05+02:00 New Revision: 9a37587ee33bcf2fe27b49f48c9ddd8128f8ac13 URL: https://github.com/llvm/llvm-project/commit/9a37587ee33bcf2fe27b49f48c9ddd8128f8ac13 DIFF: https://github.com/llvm/llvm-project/commit/9a37587ee33bcf2fe27b49f48c9ddd8128f8ac13.diff

[Lldb-commits] [lldb] 8dc2faf - [lldb] [Process/FreeBSDRemote] Fix double semicolon

2020-10-10 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2020-10-10T18:54:52+02:00 New Revision: 8dc2faf642b720c7abad06fd4cea51e6b4333cfe URL: https://github.com/llvm/llvm-project/commit/8dc2faf642b720c7abad06fd4cea51e6b4333cfe DIFF: https://github.com/llvm/llvm-project/commit/8dc2faf642b720c7abad06fd4cea51e6b4333cfe.diff

[Lldb-commits] [PATCH] D89181: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*

2020-10-10 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd83cd73e9ddf: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext* (authored by mgorny). Herald added a subscriber: jrtc27. Herald added a project: LLDB. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL

2020-10-10 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9a37587ee33b: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D89155: [lldb] Minidump: check for .text hash match with directory

2020-10-10 Thread Joseph Tremoulet via Phabricator via lldb-commits
JosephTremoulet updated this revision to Diff 297422. JosephTremoulet added a comment. - Handle finding wrong version before right one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89155/new/ https://reviews.llvm.org/D89155 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D89155: [lldb] Minidump: check for .text hash match with directory

2020-10-10 Thread Joseph Tremoulet via Phabricator via lldb-commits
JosephTremoulet marked an inline comment as done. JosephTremoulet added a comment. Thanks for the speedy review! I've updated it to include a testcase that shows the problem you described, and include the fix you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [lldb] 5d330f4 - [lldb] [Windows] Remove unused functions. NFC.

2020-10-10 Thread Martin Storsjö via lldb-commits
Author: Martin Storsjö Date: 2020-10-10T20:47:40+03:00 New Revision: 5d330f435e12d4a7f97cde406d29ce7413f96b47 URL: https://github.com/llvm/llvm-project/commit/5d330f435e12d4a7f97cde406d29ce7413f96b47 DIFF: https://github.com/llvm/llvm-project/commit/5d330f435e12d4a7f97cde406d29ce7413f96b47.diff

[Lldb-commits] [lldb] abaca23 - [lldb] [Windows] Add missing 'override', silencing warnings. NFC.

2020-10-10 Thread Martin Storsjö via lldb-commits
Author: Martin Storsjö Date: 2020-10-10T20:47:40+03:00 New Revision: abaca237c519a406ab00606b0464c32079831803 URL: https://github.com/llvm/llvm-project/commit/abaca237c519a406ab00606b0464c32079831803 DIFF: https://github.com/llvm/llvm-project/commit/abaca237c519a406ab00606b0464c32079831803.diff

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

2020-10-10 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Add a framework for reading/writing extended register sets via PT_GETXSTATE/PT_GETXSTATE_INFO/PT_SETXSTATE, and use it to support YMM0..YMM15. The code is prepared to handl

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

2020-10-10 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:479 + case XSaveRegSet: +// TODO: can WriteRegisterSet() ever be called without ReadRegisterSet()? +assert(m_xsave.size() > 0); @

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

2020-10-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a reviewer: bsdjhb. krytarowski added a subscriber: bsdjhb. krytarowski added a comment. + @bsdjhb John, could you have a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89193/new/ https://reviews.llvm.org/D89193 ___ lld

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

2020-10-10 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 297431. mgorny added a comment. Remove accidental reformatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89193/new/ https://reviews.llvm.org/D89193 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp l