mgorny added inline comments.

================
Comment at: 
lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:479
+  case XSaveRegSet:
+    // TODO: can WriteRegisterSet() ever be called without ReadRegisterSet()?
+    assert(m_xsave.size() > 0);
----------------
@labath, is this a safe assumption to make? Generally, if `ReadRegisterSet()` 
is not called, `m_xsave` will be zero-sized.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89193/new/

https://reviews.llvm.org/D89193

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to