[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. HI @labath Do you have any comments or suggestions for this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D89019: Change the default handling of SIGCONT to nostop/noprint

labath added a comment. I believe we should at least print/notify about the fact that the process has received a SIGCONT (like we do with SIGCHLD, which happens a lot more often). As for stopping, I don't really have a strong opinion. One reason for keeping the existing behavior would be compat

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine. Thanks. Comment at: lldb/unittests/Utility/StatusTest.cpp:76 + ULONG langs = 0; + ULONG nameLen = sizeof(name) / sizeof(WCHAR); + GetUserPreferredUILangua

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

labath added a comment. /me parachutes into the discussion. On the topic of interfaces, I'd like to say that eventually I'd like to have the ability to choose the format for the core file that lldb generates (so that one can generate minidump files on mac or linux). There's no direct implicati

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:82 void ProcessFreeBSD::Initialize() { - static llvm::once_flag g_once_flag; + if (!getenv("FREEBSD_REMOTE_PLUGIN")) { +static llvm::once_flag g_once_flag; lab

[Lldb-commits] [lldb] 1a60026 - [lldb] Initial version of FreeBSD remote process plugin

Author: Michał Górny Date: 2020-10-08T16:03:00+02:00 New Revision: 1a600266c3ad1193d41ebb08a5a87c00cf726b1b URL: https://github.com/llvm/llvm-project/commit/1a600266c3ad1193d41ebb08a5a87c00cf726b1b DIFF: https://github.com/llvm/llvm-project/commit/1a600266c3ad1193d41ebb08a5a87c00cf726b1b.diff

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a600266c3ad: [lldb] Initial version of FreeBSD remote process plugin (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

labath added a comment. I like this. A lot of comments, but they're all cosmetic. Comment at: lldb/include/lldb/Target/Trace.h:96-98 protected: Trace() {} delete completely. As this is an abstract class, making the constructor protected does not do anyth

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea marked 2 inline comments as done. aganea added a comment. Thank you all for your time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88975/new/ https://reviews.llvm.org/D88975 ___ lldb-commits mai

[Lldb-commits] [lldb] 79809f5 - [LLDB] On Windows, fix tests

Author: Alexandre Ganea Date: 2020-10-08T11:46:59-04:00 New Revision: 79809f58b02419a5d1bfb6c9a59dbd13cd038c77 URL: https://github.com/llvm/llvm-project/commit/79809f58b02419a5d1bfb6c9a59dbd13cd038c77 DIFF: https://github.com/llvm/llvm-project/commit/79809f58b02419a5d1bfb6c9a59dbd13cd038c77.dif

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79809f58b024: [LLDB] On Windows, fix tests (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D88975?vs=296809&id=296982#toc

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. I haven't looked at the new version of the patch yet, partly because I'm busy (sorry), and partly because I'm not sure we have reached a consensus yet (or at least, I don't know what that consensus is). Here's some questions/comments to what was earlier said, as I try to

[Lldb-commits] [PATCH] D88967: [lldb] Add a cmake warning about the python/swig incompatibility

labath added a comment. In D88967#2317851 , @amccarth wrote: > In D88967#2317545 , @labath wrote: > >> In D88967#2317522 , @amccarth wrote: >> >>> If I recall correctly, the

Re: [Lldb-commits] [lldb] 81b11c9 - Fix a macOS build break caused by 3dfb94986170.

On 08/10/2020 00:01, Jim Ingham via lldb-commits wrote: Author: Jim Ingham Date: 2020-10-07T15:01:27-07:00 New Revision: 81b11c91070f3a969b64b2c2e6011b02450fa75f URL: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f DIFF: https://github.com/llvm/llvm-projec

[Lldb-commits] [PATCH] D88992: [lldb] Fix "frame var" for large bitfields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19d64138e6a7: [lldb] Fix "frame var" for large bitfields (authored by labath). Changed prior to commit: https://reviews.llvm.org/D88992?vs=296749&

[Lldb-commits] [lldb] d4a7c70 - [lldb] Add a cmake warning about the python/swig incompatibility

Author: Pavel Labath Date: 2020-10-08T18:42:50+02:00 New Revision: d4a7c70751cf5c0b0ce344555e3966ddc80290d2 URL: https://github.com/llvm/llvm-project/commit/d4a7c70751cf5c0b0ce344555e3966ddc80290d2 DIFF: https://github.com/llvm/llvm-project/commit/d4a7c70751cf5c0b0ce344555e3966ddc80290d2.diff

[Lldb-commits] [PATCH] D88967: [lldb] Add a cmake warning about the python/swig incompatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4a7c70751cf: [lldb] Add a cmake warning about the python/swig incompatibility (authored by labath). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 19d6413 - [lldb] Fix "frame var" for large bitfields

Author: Pavel Labath Date: 2020-10-08T18:42:50+02:00 New Revision: 19d64138e6a708d1d0571da3ac51e1b4777c2b47 URL: https://github.com/llvm/llvm-project/commit/19d64138e6a708d1d0571da3ac51e1b4777c2b47 DIFF: https://github.com/llvm/llvm-project/commit/19d64138e6a708d1d0571da3ac51e1b4777c2b47.diff

[Lldb-commits] [PATCH] D89019: Change the default handling of SIGCONT to nostop/noprint

jingham updated this revision to Diff 297029. jingham added a comment. Adopt Pavel's suggestion to do "nosuppress/nostop/notify" for SIGCONT instead of "nosuppress/nostop/nonotify". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89019/new/ https://

Re: [Lldb-commits] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hello bot owners, I see a lot of builders went down and not connecting back to the production buildbot. Could you check your bots to make sure they are up and running, please? And report connectivity issues if any with quotes from the logs directly to me. Thanks Galina On Thu, Oct 8, 2020 at

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

jasonmolenda added a comment. Thanks for the feedback Pavel. Good point on piping the dirty pages list through the memory region command and adding tests for that. And good thoughts on different memory types that could be included in the corefile. I think we may revisit how the 'process save

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM. Pavel please chime in if you have any issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88769/new/ https://reviews.llvm.org/D88769

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Core/PluginManager.h:342 + static const char *GetTraceSchema(ConstString name); + This is fine if we have

[Lldb-commits] [lldb] 97e7fbb - [LLDB] More Windows non-English locales fixes

Author: Alexandre Ganea Date: 2020-10-08T17:22:42-04:00 New Revision: 97e7fbb343e2a4ea913686254105b9965c5468f8 URL: https://github.com/llvm/llvm-project/commit/97e7fbb343e2a4ea913686254105b9965c5468f8 DIFF: https://github.com/llvm/llvm-project/commit/97e7fbb343e2a4ea913686254105b9965c5468f8.dif

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. I've commited one more fix here: https://reviews.llvm.org/rG97e7fbb343e2 - This didn't occur locally on my machine, but only on another machine. But in essence, the issue was the same, an accentuated Windows-1252 codepage character that was being decoded as UTF-8 by the

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

jasonmolenda added a comment. In D82863#2319568 , @labath wrote: > In D82863#2313676 , @jasonmolenda > wrote: > >> (about g packets...) they cause so many problems if there is a >> mis-coordination between the rem

[Lldb-commits] [lldb] a68ffb1 - Change the default handling of SIGCONT to nosuppress/nostop/notify

Author: Jim Ingham Date: 2020-10-08T15:24:19-07:00 New Revision: a68ffb19d392c6d52f6e42925217a77b4cd71cee URL: https://github.com/llvm/llvm-project/commit/a68ffb19d392c6d52f6e42925217a77b4cd71cee DIFF: https://github.com/llvm/llvm-project/commit/a68ffb19d392c6d52f6e42925217a77b4cd71cee.diff LO

[Lldb-commits] [PATCH] D89019: Change the default handling of SIGCONT to nostop/noprint

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa68ffb19d392: Change the default handling of SIGCONT to nosuppress

[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

wallace updated this revision to Diff 297075. wallace added a comment. - Added “trace schema all”, following the pattern from "trace all", and added a test for this. - Created a non-static version of GetSchema in Trace.h - Cannot delete Trace() {}, as there’s a compilation error. Could be becaus

Re: [Lldb-commits] [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hi Paula, This error is fine. The buildbot has tested the worker version. 0.8.x apparently does not have that method. The error gets handled gracefully on the server side. At least it seems so so far. That should not prevent your bot from connecting. Thanks Galina On Thu, Oct 8, 2020 at 2:11 P

[Lldb-commits] [lldb] 9d7b08b - [lldb] Format remaining signal table (NFC)

Author: Jonas Devlieghere Date: 2020-10-08T21:51:41-07:00 New Revision: 9d7b08bd0657688c186b5b3d39512c484e8c37f5 URL: https://github.com/llvm/llvm-project/commit/9d7b08bd0657688c186b5b3d39512c484e8c37f5 DIFF: https://github.com/llvm/llvm-project/commit/9d7b08bd0657688c186b5b3d39512c484e8c37f5.d

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace updated this revision to Diff 297127. wallace added a comment. Rebase and made some cosmetic fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88769/new/ https://reviews.llvm.org/D88769 Files: lldb/include/lldb/Target/Target.h lldb/