labath added a comment.
/me parachutes into the discussion.
On the topic of interfaces, I'd like to say that eventually I'd like to have
the ability to choose the format for the core file that lldb generates (so that
one can generate minidump files on mac or linux). There's no direct
implications of that for this patch, as the two choices are likely to be
orthogonal (full or "skinny" minidumps make sense too), it would just be good
to leave room for this extension in the future (e.g. in the SB API).
As for the flag discussion, it might be interesting to note that the linux
coredump_filter is a set of flags
bit 0 Dump anonymous private mappings.
bit 1 Dump anonymous shared mappings.
bit 2 Dump file-backed private mappings.
bit 3 Dump file-backed shared mappings.
bit 4 (since Linux 2.6.24)
Dump ELF headers.
bit 5 (since Linux 2.6.28)
Dump private huge pages.
bit 6 (since Linux 2.6.28)
Dump shared huge pages.
bit 7 (since Linux 4.4)
Dump private DAX pages.
bit 8 (since Linux 4.4)
Dump shared DAX pages.
I have no plans on doing anything with that, though someone theoretically
might. However, I think that even if we do have the ability to fine-tune the
core contents via individual flags, we should probably still have some way to
select some reasonable set of predefined flags.
Lastly, I think it would be good to extend the `memory region` command to show
the new MemoryRegionInfo contents. If for nothing else, then to enable the
testing of this (pretty large) patch in a more granular way. Having this in the
output of `memory region` would enable splitting the gdb-remote part of this
into a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88387/new/
https://reviews.llvm.org/D88387
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
