[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

clayborg added a comment. In D78801#2004501 , @paolosev wrote: > I am adding all the pieces to this patch to make the whole picture clearer; I > thought to add a piece at the time to simplify reviews, but probably it ended > up making things more obscure

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. It may be interesting to tack a couple of resume/step-over/etc commands at the end of the test to make just the whole thing doesn't go berserk when those operations fail. In D7883

[Lldb-commits] [lldb] f07f2ce - [lldb/unittest] Adjust CheckIPSupport function to avoid double-consume of llvm::Error

Author: Pavel Labath Date: 2020-04-28T13:35:07+02:00 New Revision: f07f2cee9b4e19df78a19c9b2b552e2e5ba9d478 URL: https://github.com/llvm/llvm-project/commit/f07f2cee9b4e19df78a19c9b2b552e2e5ba9d478 DIFF: https://github.com/llvm/llvm-project/commit/f07f2cee9b4e19df78a19c9b2b552e2e5ba9d478.diff

[Lldb-commits] [lldb] 5cee8dd - [lldb-vscode] A couple of small style fixes

Author: Pavel Labath Date: 2020-04-28T13:35:07+02:00 New Revision: 5cee8ddcc7535c95e4dd00fc428d2a52630eaa31 URL: https://github.com/llvm/llvm-project/commit/5cee8ddcc7535c95e4dd00fc428d2a52630eaa31 DIFF: https://github.com/llvm/llvm-project/commit/5cee8ddcc7535c95e4dd00fc428d2a52630eaa31.diff

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

labath added a comment. > I don't have a way to write a C-based test for this as I don't know how to > craft a user expression in C that will make such a thing. I asked around a > bit and nobody had an easy way to do this. Grepping clang's tests for `weak_odr` was very educational. The most por

[Lldb-commits] [PATCH] D74892: [lldb][cmake] Also use local submodule visibility on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG8baa0b9439b5: [lldb][cmake] Also use local submodule visibility on Darwin (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74892/new/

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

labath added a comment. In D78801#2007083 , @clayborg wrote: > It would be fine to ask the lldb_private::Process class to evaluate any > unknown DWARF expression opcodes like DW_OP_WASM_location and return the > result. While that idea has occurred to

[Lldb-commits] [PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

This revision was automatically updated to reflect the committed changes. Closed by commit rGa58b62b4a2b9: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand(). (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

dblaikie accepted this revision. dblaikie added a comment. Looks great - thanks for the pointer type fixup(s) along the way too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78882/new/ https://reviews.llvm.org/D78882 ___

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham added a comment. In D78972#2007493 , @labath wrote: > > I don't have a way to write a C-based test for this as I don't know how to > > craft a user expression in C that will make such a thing. I asked around a > > bit and nobody had an easy way t

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77843/new/ https://reviews.llvm.org/D77843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

wallace updated this revision to Diff 260731. wallace added a comment. added the test suggested by @labath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78839/new/ https://reviews.llvm.org/D78839 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [lldb] 8372582 - [lldb-vscode] Add an option for loading core files

Author: Walter Erquinigo Date: 2020-04-28T13:03:02-07:00 New Revision: 83725822c52535c239b1a7991023f96bfbc95568 URL: https://github.com/llvm/llvm-project/commit/83725822c52535c239b1a7991023f96bfbc95568 DIFF: https://github.com/llvm/llvm-project/commit/83725822c52535c239b1a7991023f96bfbc95568.di

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

This revision was automatically updated to reflect the committed changes. Closed by commit rG83725822c525: [lldb-vscode] Add an option for loading core files (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D78839?vs=260731&id=260748#toc Re

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib updated this revision to Diff 260751. mib edited the summary of this revision. mib added a comment. Removed the introduced `FileSystem::ReadableByCurrentUser` to rely only `FileSystem::Open` as Pavel suggested. Updated the tests to reflect the changes introduced. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

JDevlieghere added a comment. I also prefer this approach, seems less fragile from a testing perspective and reduces the different code paths. Comment at: lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:102 + llvm::toString(file.takeEr

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

shafik added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:175 + constexpr unsigned max_buffer_size = 7; + uint8_t *data = new uint8_t[max_buffer_size]; + switch (escape_style) { I really wish we could get ride of the naked `new`. I

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. In D78801#2007083 , @clayborg wrote: > So is there memory to be read from the WASM runtime? Couldn't > DW_OP_WASM_location 0x0 +8 be turned into an address that can be used to read > the variable? It is also unclear what DW_OP_s

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

clayborg added a comment. In D78801#2007795 , @labath wrote: > In D78801#2007083 , @clayborg wrote: > > > It would be fine to ask the lldb_private::Process class to evaluate any > > unknown DWARF expression opcodes

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

clayborg added a comment. Thanks for the explanations if everything WASM related. I now understand much better what you have. > Read Wasm memory. > IN : $qWasmMem:frame_index;addr;len > OUT: $xx..xx frame index seems weird in a memory read packet. Seems like the module ID should be passed in

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

clayborg added a comment. Could we just always use memory reading and have the address contain more info? Right now you have the top 32 bits for the module ID. Could it be something like: struct WasmAddress { uint64_t module_id:16; uint64_t space:4; // 0 == code, 1 == data, 2 == globa

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. In D78801#2009103 , @clayborg wrote: > Thanks for the explanations if everything WASM related. I now understand much > better what you have. > > > Read Wasm memory. > > IN : $qWasmMem:frame_index;addr;len > > OUT: $xx..xx > > f

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. In D78801#2009128 , @clayborg wrote: > Could we just always use memory reading and have the address contain more > info? Right now you have the top 32 bits for the module ID. Could it be > something like: > > struct WasmAddres

[Lldb-commits] [lldb] 6e69338 - [lldb/Host] Pass a StringRef to the FileSpec ctor

Author: Jonas Devlieghere Date: 2020-04-28T19:21:58-07:00 New Revision: 6e693386afedab5237b42679d94ca6c72684621d URL: https://github.com/llvm/llvm-project/commit/6e693386afedab5237b42679d94ca6c72684621d DIFF: https://github.com/llvm/llvm-project/commit/6e693386afedab5237b42679d94ca6c72684621d.d

[Lldb-commits] [lldb] 75c3d6f - [lldb/Platform] Synchronize access to SDK String Map.

Author: Jonas Devlieghere Date: 2020-04-28T19:21:58-07:00 New Revision: 75c3d6f49c450a8b522a6731c317e75b73a2f5a3 URL: https://github.com/llvm/llvm-project/commit/75c3d6f49c450a8b522a6731c317e75b73a2f5a3 DIFF: https://github.com/llvm/llvm-project/commit/75c3d6f49c450a8b522a6731c317e75b73a2f5a3.d

[Lldb-commits] [lldb] b14c37a - [lldb/Platform] Return a std::string from GetSDKPath

Author: Jonas Devlieghere Date: 2020-04-28T19:21:58-07:00 New Revision: b14c37a29a5455853419f5fe0605f6023c51de89 URL: https://github.com/llvm/llvm-project/commit/b14c37a29a5455853419f5fe0605f6023c51de89 DIFF: https://github.com/llvm/llvm-project/commit/b14c37a29a5455853419f5fe0605f6023c51de89.d

[Lldb-commits] [lldb] 9f8b447 - Extend max register size to accommodate AArch64 SVE vector regs

Author: Muhammad Omair Javaid Date: 2020-04-29T07:51:30+05:00 New Revision: 9f8b4472fb601fcee84613a558f8d734314d98b5 URL: https://github.com/llvm/llvm-project/commit/9f8b4472fb601fcee84613a558f8d734314d98b5 DIFF: https://github.com/llvm/llvm-project/commit/9f8b4472fb601fcee84613a558f8d734314d98

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f8b4472fb60: Extend max register size to accommodate AArch64 SVE vector regs (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

Re: [Lldb-commits] [lldb] b14c37a - [lldb/Platform] Return a std::string from GetSDKPath

Actually the statement in the commit message is incorrect, it looks like StringMap does guarantee both key and value to be stable. The patch is still correct though, because GetXcodeSDK does return a std::string, so we were returning a reference to a temporary. On Tue, Apr 28, 2020 at 7:22 PM Jona

Re: [Lldb-commits] [lldb] b14c37a - [lldb/Platform] Return a std::string from GetSDKPath

My previous message is also bogus, I was looking at the updated code instead of the original code. I think it's time to call it a day before I say more nonsense. I'll take a fresh look tomorrow :-) On Tue, Apr 28, 2020 at 8:01 PM Jonas Devlieghere wrote: > Actually the statement in the commit me

[Lldb-commits] [lldb] 7c8fa95 - lldb: use the newer `find_package` if available

Author: Saleem Abdulrasool Date: 2020-04-29T03:54:33Z New Revision: 7c8fa95395e719f9a2c211ee0f574ac9ef88a19d URL: https://github.com/llvm/llvm-project/commit/7c8fa95395e719f9a2c211ee0f574ac9ef88a19d DIFF: https://github.com/llvm/llvm-project/commit/7c8fa95395e719f9a2c211ee0f574ac9ef88a19d.diff

[Lldb-commits] [lldb] e35dbb3 - Fix LLDB elf core dump register access for ARM/AArch64

Author: Muhammad Omair Javaid Date: 2020-04-29T09:24:39+05:00 New Revision: e35dbb3c8878236754c4ec127591d9ef4665bdf8 URL: https://github.com/llvm/llvm-project/commit/e35dbb3c8878236754c4ec127591d9ef4665bdf8 DIFF: https://github.com/llvm/llvm-project/commit/e35dbb3c8878236754c4ec127591d9ef4665bd

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

This revision was automatically updated to reflect the committed changes. omjavaid marked an inline comment as done. Closed by commit rGe35dbb3c8878: Fix LLDB elf core dump register access for ARM/AArch64 (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://rev