labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks good. It may be interesting to tack a couple of resume/step-over/etc commands at the end of the test to make just the whole thing doesn't go berserk when those operations fail. In D78839#2006698 <https://reviews.llvm.org/D78839#2006698>, @wallace wrote: > I also removed that bad use of auto. It seems that all StringRefs gotten from > the JSON object are null-terminated. Ok, json::parse is documented to return "self-contained" json object which owns its strings. It's not a big stretch to assume that those owned strings will also be null terminated, though it still seems moderately dangerous... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78839/new/ https://reviews.llvm.org/D78839 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
