JDevlieghere added a comment.
ping
https://reviews.llvm.org/D51934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
I am fine with this, Jim or Jason should ok this too just to be sure
https://reviews.llvm.org/D51934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
shafik updated this revision to Diff 166144.
shafik added a comment.
Updating LibcxxVariantGetIndexValidity() to no longer do type check of __index.
It was left over from the old method of checking for an empty variant and was
also breaking clang 5.
https://reviews.llvm.org/D51520
Files:
ll
sgraenitz created this revision.
sgraenitz added reviewers: vsk, davide, aprantl.
When LLDB successfully parses a command (like "expression" in this case) and
determines incomplete input, the user can continue typing on multiple lines (in
this case "2+3"). This should provide the correct result.
aprantl added inline comments.
Comment at: lit/Expr/TestMultilineExpr.test:3
+
+# In terminal sessions LLDB reverts input from subsequent lines so it doesn't
show up in the output we check below.
+expression
aprantl wrote:
> "reverts" -> "joins"?
or did you mean
aprantl added inline comments.
Comment at: lit/Expr/TestMultilineExpr.test:3
+
+# In terminal sessions LLDB reverts input from subsequent lines so it doesn't
show up in the output we check below.
+expression
"reverts" -> "joins"?
Comment at: l
Author: shafik
Date: Wed Sep 19 11:07:05 2018
New Revision: 342563
URL: http://llvm.org/viewvc/llvm-project?rev=342563&view=rev
Log:
[DataFormatters] Add formatter for C++17 std::variant
rdar://problem/43691454
Patch by Shafik Yaghmour.
Differential Revision: https://reviews.llvm.org/D51520
Ad
sgraenitz updated this revision to Diff 166151.
sgraenitz added a comment.
Addressing Adrian's comments
https://reviews.llvm.org/D52270
Files:
lit/Expr/TestMultilineExpr.test
Index: lit/Expr/TestMultilineExpr.test
===
--- /dev/
aprantl added a comment.
Does that mean we can remove
./packages/Python/lldbsuite/test/expression_command/multiline/TestMultilineExpressions.py
?
https://reviews.llvm.org/D52270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
sgraenitz marked 3 inline comments as done.
sgraenitz added inline comments.
Comment at: lit/Expr/TestMultilineExpr.test:9
+# CHECK: (lldb) expression
+# CHECK-NEXT: Enter expressions, then terminate with an empty line to evaluate:
+# CHECK-NEXT: (int) {{.*}} = 5
teemperor added a comment.
Can't you just check for '5', as this is the only information we actually
actually care about here?
https://reviews.llvm.org/D52270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
sgraenitz updated this revision to Diff 166155.
sgraenitz added a comment.
Remove old Python test in
./packages/Python/lldbsuite/test/expression_command/multiline/
https://reviews.llvm.org/D52270
Files:
lit/Expr/TestMultilineExpr.test
packages/Python/lldbsuite/test/expression_command/multi
aprantl added a comment.
For those following at home: the point of this exercise is to get rid of the
-expect-based TestMultilineExpressions.py testcase that kept failing on build
bots.
https://reviews.llvm.org/D52270
___
lldb-commits mailing list
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
A typo and probably something copied from another test case, other than that
this looks good.
Comment at:
packages/Python/lldbsuite/test/functionalities/target_create_dep
aprantl added inline comments.
Comment at: lit/Expr/TestMultilineExpr.test:9
+# CHECK: (lldb) expression
+# CHECK-NEXT: Enter expressions, then terminate with an empty line to evaluate:
+# CHECK-NEXT: (int) {{.*}} = 5
sgraenitz wrote:
> Maybe it's nitpicking, but
sgraenitz added a comment.
In https://reviews.llvm.org/D52270#1239641, @teemperor wrote:
> Can't you just check for '5', as this is the only information we actually
> actually care about here?
Yes that would be the simplest way, but as LLDB still echoes all commands
including comments, all CH
aprantl added a comment.
> LLDB still echoes all commands including comments
What do you think about fixing that before landing this patch? Then we don't
need to work around it.
https://reviews.llvm.org/D52270
___
lldb-commits mailing list
lldb-co
sgraenitz added a comment.
In https://reviews.llvm.org/D52270#1239685, @aprantl wrote:
> What do you think about fixing that before landing this patch? Then we don't
> need to work around it.
Hm, we didn't finally decide for the fix and I don't want to raise the pressure
on it artificially.
I
Pavel, I guess this one is yours.
http://green.lab.llvm.org/green/job/lldb-cmake-clang-6.0.1//484/console
Mind to fix?
FAILED: tools/lldb/unittests/ObjectFile/ELF/ObjectFileELFTests : &&
/Users/buildslave/jenkins/workspace/lldb-cmake-clang-6.0.1/host-compiler/bin/clang++
-fPIC -fvisibility-inline
Nevermind, wrong commit.
On Wed, Sep 19, 2018 at 2:26 PM Davide Italiano wrote:
>
> Pavel, I guess this one is yours.
> http://green.lab.llvm.org/green/job/lldb-cmake-clang-6.0.1//484/console
>
> Mind to fix?
>
> FAILED: tools/lldb/unittests/ObjectFile/ELF/ObjectFileELFTests : &&
> /Users/buildsla
shafik updated this revision to Diff 166194.
shafik marked 6 inline comments as done.
shafik added a comment.
Addressing comments:
- Adding documentation to FindVariable()
- Using ConstString instead of const char *
https://reviews.llvm.org/D52247
Files:
include/lldb/Target/StackFrame
shafik added a comment.
@jingham @clayborg @davide addressed comments w/ the exception of the lambda
one which I politely disagree with.
Comment at: source/Target/StackFrame.cpp:1733-1738
+if (sc.block->AppendVariables(
+can_create, get_parent_variables,
stop_
jingham accepted this revision.
jingham added a comment.
This is fine by me.
https://reviews.llvm.org/D52247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide accepted this revision.
davide added a comment.
Sure.
https://reviews.llvm.org/D52247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Just a documentation suggestion, but looks good.
Comment at: include/lldb/Target/StackFrame.h:508
+ /// Attempt to reconstruct the ValueObject for a variable with a give
25 matches
Mail list logo
