shafik added a comment.
@jingham @clayborg @davide addressed comments w/ the exception of the lambda
one which I politely disagree with.
================
Comment at: source/Target/StackFrame.cpp:1733-1738
+ if (sc.block->AppendVariables(
+ can_create, get_parent_variables,
stop_if_block_is_inlined_function,
+ [this](Variable *v) { return v->IsInScope(this); },
+ &variable_list)) {
+ var_sp = variable_list.FindVariable(ConstString(name));
+ }
----------------
davide wrote:
> This is fairly unreadable IMHO. If I were you, I would hoist the lambda out.
This is exactly the case lambda were meant to address, moving it out would just
add boilerplate code :-(
https://reviews.llvm.org/D52247
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
