[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

labath added a comment. Thank you. PS: I will need someone to update the XCode project after this. https://reviews.llvm.org/D44306 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r329677 - Move Args::StringTo*** functions to a new OptionArgParser class

Author: labath Date: Tue Apr 10 02:03:59 2018 New Revision: 329677 URL: http://llvm.org/viewvc/llvm-project?rev=329677&view=rev Log: Move Args::StringTo*** functions to a new OptionArgParser class Summary: The idea behind this is to move the functionality which depend on other lldb classes into a

[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

This revision was automatically updated to reflect the committed changes. Closed by commit rL329677: Move Args::StringTo*** functions to a new OptionArgParser class (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44306

[Lldb-commits] [lldb] r329679 - Move OptionElementVector helper structs from Args to Options

Author: labath Date: Tue Apr 10 02:48:05 2018 New Revision: 329679 URL: http://llvm.org/viewvc/llvm-project?rev=329679&view=rev Log: Move OptionElementVector helper structs from Args to Options These are not used anywhere in the Args class. They should have been moved as a part of r327110 (Moving

[Lldb-commits] [lldb] r329682 - Args: replace isprint8 usage with isprint

Author: labath Date: Tue Apr 10 03:07:22 2018 New Revision: 329682 URL: http://llvm.org/viewvc/llvm-project?rev=329682&view=rev Log: Args: replace isprint8 usage with isprint It looks like we introduced isprint8 way back in r169417 to be used on getopt's short_options, which we sometimes set to v

[Lldb-commits] [PATCH] D45480: Move Args.cpp from Interpreter to Utility

labath created this revision. labath added reviewers: zturner, jingham, davide. Herald added a subscriber: mgorny. The Args class is used in plenty of places besides the command interpreter (e.g., anything requiring an argc+argv combo, such as when launching a process), so it needs to be in a lowe

[Lldb-commits] [lldb] r329697 - s/LLVM_ON_WIN32/_WIN32/, lldb

Author: nico Date: Tue Apr 10 06:33:45 2018 New Revision: 329697 URL: http://llvm.org/viewvc/llvm-project?rev=329697&view=rev Log: s/LLVM_ON_WIN32/_WIN32/, lldb LLVM_ON_WIN32 is set exactly with MSVC and MinGW (but no

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

> On Apr 7, 2018, at 2:04 AM, Jan Kratochvil wrote: > > On Sat, 07 Apr 2018 00:52:26 +0200, Greg Clayton wrote: >> Take look at how LLVM does it. I believe my changes mirror that approach. > > LLVM does not support partial units so there is nothing to look at there. > > >> DWARFUnit should b

[Lldb-commits] [PATCH] D45480: Move Args.cpp from Interpreter to Utility

zturner added a comment. > This removes the last (direct) dependency from the Host module to > Interpreter, so I remove the Interpreter module from Host's dependency list. Big milestone! Kudos https://reviews.llvm.org/D45480 ___ lldb-commits mail

[Lldb-commits] [lldb] r329722 - Fix the Xcode build for the addition of OptionArgsParser.

Author: jingham Date: Tue Apr 10 10:20:27 2018 New Revision: 329722 URL: http://llvm.org/viewvc/llvm-project?rev=329722&view=rev Log: Fix the Xcode build for the addition of OptionArgsParser. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/lldb.xcworkspace/contents.xcworksp

[Lldb-commits] [lldb] r329727 - Fix a typo in the gtest build target for Debug configuration.

Author: jingham Date: Tue Apr 10 10:49:56 2018 New Revision: 329727 URL: http://llvm.org/viewvc/llvm-project?rev=329727&view=rev Log: Fix a typo in the gtest build target for Debug configuration. I usually run DebugClang... Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/l

[Lldb-commits] [PATCH] D45497: Don't assume the backing thread shares a Protocol ID

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg. When we're dealing with virtual (memory) threads created by the OS plugins, there's no guarantee that the real thread and the backing thread share a protocol ID. Instead, we should iterate over the memory threads

[Lldb-commits] [PATCH] D45497: Don't assume the backing thread shares a Protocol ID

JDevlieghere added a comment. (I'll update the diff once I've figured out how to test this) Repository: rL LLVM https://reviews.llvm.org/D45497 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D45497: Don't assume the backing thread shares a Protocol ID

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1826-1827 +for (size_t i = 0; i < num_threads; ++i) { + ThreadSP mem_thr

[Lldb-commits] [lldb] r329745 - Convert an absolute to a group relative reference for TestOptionArgParser.cpp.

Author: jingham Date: Tue Apr 10 12:29:37 2018 New Revision: 329745 URL: http://llvm.org/viewvc/llvm-project?rev=329745&view=rev Log: Convert an absolute to a group relative reference for TestOptionArgParser.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.x

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

ok, so I was able to create a DWZ example and see how this is laid out and I now understand the format. I will see if I can modify this patch in a way that will work for DWZ and for .debug_types. > On Apr 10, 2018, at 8:46 AM, Greg Clayton wrote: > > > >> On Apr 7, 2018, at 2:04 AM, Jan Kr

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. In https://reviews.llvm.org/D32167#1062618, @clayborg wrote: > we should be using the AST importer to import the type from that file into > the AST for the current DWARF file. We do have done this with -gmodules > already, so DWZ shouldn't be that different. Is

Re: [Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

> On Apr 10, 2018, at 2:13 PM, Jan Kratochvil via Phabricator > wrote: > > jankratochvil added a comment. > > In https://reviews.llvm.org/D32167#1062618, @clayborg wrote: > >> we should be using the AST importer to import the type from that file into >> the AST for the current DWARF file. W

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. In https://reviews.llvm.org/D32167#1062614, @clayborg wrote: > Found the DWZ stuff: > http://www.dwarfstd.org/ShowIssue.php?issue=120604.1&type=open BTW the current DWZ tool supports only DWARF-4 and the DWZ tags are non-s

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

On Tue, 10 Apr 2018 17:46:55 +0200, Greg Clayton wrote: > > On Apr 7, 2018, at 2:04 AM, Jan Kratochvil > > wrote: > > DW_TAG_partial_unit gets read in (by > > DWARFDebugInfo::ParseCompileUnitHeadersIfNeeded) as DWARFCompileUnit because > > there is no quick enough way to find the difference. It

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:595 + uint64_t debug_info_size = get_debug_info_data().GetByteSize(); + data_segment.m_data.OffsetData(debug_info_size); +} jankratochvil wrote: > c

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

> On Apr 10, 2018, at 2:38 PM, Jan Kratochvil wrote: > > On Tue, 10 Apr 2018 17:46:55 +0200, Greg Clayton wrote: >>> On Apr 7, 2018, at 2:04 AM, Jan Kratochvil >>> wrote: >>> DW_TAG_partial_unit gets read in (by >>> DWARFDebugInfo::ParseCompileUnitHeadersIfNeeded) as DWARFCompileUnit because

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

On Wed, 11 Apr 2018 00:22:45 +0200, Greg Clayton wrote: > > On Apr 10, 2018, at 2:38 PM, Jan Kratochvil > > wrote: > > Not only that. Even when DWZ does not use any external file then one > > DW_TAG_partial_unit is included into many DW_TAG_compile_unit and so DIEs > > from > > that DW_TAG_parti

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

On Wed, 11 Apr 2018 00:53:20 +0200, Jan Kratochvil wrote: > On Wed, 11 Apr 2018 00:22:45 +0200, Greg Clayton wrote: > > If this is all in the same file, then the offsets are all in the > > .debug_info? What am I missing? > > LLVM was asserting when I reported the same lldb::user_id_t referenced by