labath added a subscriber: ted.
labath added a comment.
It looks reasonable to me, but I don't know the full context, so I'd wait until
others can comment on this as well.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2590
+(arch.GetTriple().isOSB
Author: labath
Date: Mon Dec 5 05:15:36 2016
New Revision: 288661
URL: http://llvm.org/viewvc/llvm-project?rev=288661&view=rev
Log:
Clean up some use of __ANDROID_NDK__ in the cmake files
Rationale:
scripts/Python/modules: android is excluded at a higher level, so no point in
checking here
too
Author: labath
Date: Mon Dec 5 08:57:23 2016
New Revision: 288674
URL: http://llvm.org/viewvc/llvm-project?rev=288674&view=rev
Log:
Remove superfluous android include
This file is not in the include path when building with a non-standalone
toolchain. In does not seem to be necessary anyway.
Mod
Author: labath
Date: Mon Dec 5 08:57:19 2016
New Revision: 288673
URL: http://llvm.org/viewvc/llvm-project?rev=288673&view=rev
Log:
Remove one more if(__ANDROID_NDK__) I missed
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
Modified: lldb/trunk/cmake/LLDBDependencies.cmake
URL:
http://l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just remove hexagon from the if and this is good to go.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2590
+(arch.GetTriple().isOS
clayborg added a reviewer: spyffe.
clayborg added a comment.
I am going to include Sean Callanan in on this one to see what he thinks. We
might just want to fix the AST importer so that it can handle types in a
BlockDecl.
https://reviews.llvm.org/D27394
_
alexshap updated this revision to Diff 80278.
alexshap added a comment.
Address comments
Repository:
rL LLVM
https://reviews.llvm.org/D27380
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Index: source/Plugins/SymbolFile/DWARF
ted added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2590
+(arch.GetTriple().isOSBinFormatELF() ||
arch.GetMachine() == llvm::Triple::hexagon)) {
SymbolContextList temp_sc_list;
clayborg w
jingham added a comment.
This is legal C++:
#include
int main(int argc, char **argv)
{
if (argc > 1)
{
struct foo
{
long int value;
};
foo my_foo = {10};
printf ("Foo: %ld.\n", my_foo.value);
}
else
{
jingham added a comment.
At present clang produces correct debug info, and lldb correctly debugs this
code.
https://reviews.llvm.org/D27394
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
As Jim said, we can't move stuff around because types will conflict. Marking as
request changes.
https://reviews.llvm.org/D27394
_
spyffe added a subscriber: aprantl.
spyffe added a comment.
How does Clang-emitted debug information express the region in which a type is
declared if it has been moved to the containing Decl? I'm thinking
specifically of this case:
int foo() {
return
[]() { struct A { int a; } a1;
Author: alexshap
Date: Mon Dec 5 12:42:21 2016
New Revision: 288687
URL: http://llvm.org/viewvc/llvm-project?rev=288687&view=rev
Log:
[lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions
This diff
1. Adds a comment to ObjectFileELF.cpp about the current
approach to dete
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288687: [lldb] Update the check for Linux or FreeBSD in
SymbolFileDWARF::FindFunctions (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D27380?vs=80278&id=80295#toc
Repository:
Author: kuba.brecka
Date: Fri Dec 2 15:00:32 2016
New Revision: 288535
URL: http://llvm.org/viewvc/llvm-project?rev=288535&view=rev
Log:
Support more report types in AddressSanitizerRuntime.cpp, re-word existing ones.
In r288065, we added more report types into ASan that will be reported via the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287848: Fix a comparison of integers of different signs
warning. (authored by ttsugrii).
Changed prior to commit:
https://reviews.llvm.org/D27081?vs=79173&id=79180#toc
Repository:
rL LLVM
https://re
I like the version without "function" in it; you might be returning from a
method.
On Fri, Dec 2, 2016 at 12:15 PM, Filipe Cabecinhas <
filcab+llvm.phabrica...@gmail.com> wrote:
> .Case("stack-use-after-return", "Use of returned stack memory")
>
>
> Maybe "Use of stack memory after (function) ret
bryant added inline comments.
Comment at: CMakeLists.txt:46
+COMMAND
+ ${PYTHON_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
+ --srcRoot=${LLDB_SOURCE_DIR}
You can reduce diff noise by leaving format
bryant added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:222
+)
+logging.info("running swig with: %r", command)
ldrumm wrote:
> bryant wrote:
> > You can reduce diff noise by limiting your changes to removing the %s. So,
> >
>
bryant added inline comments.
Comment at: CMakeLists.txt:53
+ --lldbLibDir=lib${LLVM_LIBDIR_SUFFIX}
+ ${FINISH_EXTRA_ARGS}
+VERBATIM
The indentation here could match the above.
https://reviews.llvm.org/D26757
_
Author: cbieneman
Date: Mon Dec 5 13:40:34 2016
New Revision: 288691
URL: http://llvm.org/viewvc/llvm-project?rev=288691&view=rev
Log:
[CMake] Don't add gtest if it is already there
LLVM build trees export the gtest library through a special export set. If
you're building against a build tree y
21 matches
Mail list logo
