bryant added inline comments.
================
Comment at: scripts/Python/prepare_binding_Python.py:222
+ )
+ logging.info("running swig with: %r", command)
----------------
ldrumm wrote:
> bryant wrote:
> > You can reduce diff noise by limiting your changes to removing the %s. So,
> >
> > ```python
> > # Build the SWIG args list
> > options.swig_executable,
> > "-c++",
> > "-shadow",
> > "-python",
> > "-threads",
> > "-I" + os.path.normcase(
> > os.path.join(options.src_root, "include")),
> > "-I" + os.path.normcase("./."),
> > "-D__STDC_LIMIT_MACROS",
> > "-D__STDC_CONSTANT_MACROS"]
> > if options.target_platform == "Darwin":
> > command.append("-D__APPLE__")
> > if options.generate_dependency_file:
> > command.extend(["-MMD", " -MF", temp_dep_file_path])
> > command.extend([
> > "-outdir", config_build_dir,
> > "-o", settings.output_file,
> > settings.input_file
> > ])
> > logging.info("running swig with: %s", command)
> > ```
> But `logging.info` is not a pretty printer - if the command fails for some
> reason we need to see why. `repr` allows this, and the diff noise is again
> minimal because that line is changing anyway and command is now a list, not a
> string
Yes, that was a typo. Keep %r too.
https://reviews.llvm.org/D26757
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
