labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:224
+ // If all else fails force the first thread to be SIGSTOP
+ m_thread_data.begin()->signo = SIGSTOP;
+}
You should not use signal numbers from the host
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Cool.
https://reviews.llvm.org/D26697
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
labath added a comment.
Yes, I'd like to do similar refactorings to other contexts as well.
I'll wait until next week so Ed can give this a shot -- I am busy with other
stuff these days anyway.
Ed, if I may suggest, while you are playing with the arm machine, could you
grab us a core file or t
Author: labath
Date: Wed Nov 16 04:54:17 2016
New Revision: 287095
URL: http://llvm.org/viewvc/llvm-project?rev=287095&view=rev
Log:
Fix printf warning I introduced in ModuleSpec.h
Modified:
lldb/trunk/include/lldb/Core/ModuleSpec.h
Modified: lldb/trunk/include/lldb/Core/ModuleSpec.h
URL:
h
Author: labath
Date: Wed Nov 16 04:54:22 2016
New Revision: 287096
URL: http://llvm.org/viewvc/llvm-project?rev=287096&view=rev
Log:
Remove TimeValue class
Summary:
All usages have been replaced by appropriate std::chrono funcionality, and the
class is now unused. The only used part of the cpp fi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287096: Remove TimeValue class (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D26451?vs=77346&id=78159#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26451
Files:
lldb/
hhellyer updated this revision to Diff 78163.
hhellyer added a comment.
Update with fixes from review comments.
I've run clang-format, fixed the use of iterators and added const qualifiers.
I removed the use of the SIGSTOP constant and use GetUnixSignals instead.
I've also moved that block down a
hhellyer updated this revision to Diff 78173.
hhellyer added a comment.
Update patch due to two missing changes.
https://reviews.llvm.org/D26676
Files:
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/ThreadElfCore.cpp
source/Plugins/Process/elf-core/Thre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287113: Remove Windows-specific minidump plugin (authored by
amccarth).
Changed prior to commit:
https://reviews.llvm.org/D26697?vs=78065&id=78194#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: amccarth
Date: Wed Nov 16 10:04:14 2016
New Revision: 287113
URL: http://llvm.org/viewvc/llvm-project?rev=287113&view=rev
Log:
Remove Windows-specific minidump plugin
With the cross-platform minidump plugin working, the Windows-specific one is no
longer needed. This eliminates the unnece
Thanks for working on this! I love seeing code get deleted almost as much
as I love seeing it get added :)
On Wed, Nov 16, 2016 at 3:04 AM Pavel Labath wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL287096: Remove TimeValue class (authore
tfiala added a comment.
Hi Zachary,
I'm uploading a file of diffs I needed to get the macOS build to compile and
link. There were a small handful of macOS-only paths that needed an
adjustment. You'll want to look those over to see if I did them the right way.
I'm now in the process of runnin
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
tfiala added a comment.
TestTerminal.py's test_launch_in_terminal() is timing out consistently with the
current change + my diff attached above.
I'm looking into it now. (It quite possibly is due to the build fixes I did
above).
I'm attaching the 'sample' (callstack sampling) from the failure
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Here is the adjusted patch that fixes the issue I was seeing on
TestTerminal.py. My first set of changes had a lifetime issue where I needed a
const char* that was synthesized on the fly and
tfiala added a comment.
I'm going to test this one now, stacked on top of the final macOS-working
version of https://reviews.llvm.org/D26698. Tell me now if you want it tested
independently of https://reviews.llvm.org/D26698.
https://reviews.llvm.org/D26721
Either way is fine, I think you might have hit a merge conflict if you
stacked them, but if you've already worked through it, then no big deal.
On Wed, Nov 16, 2016 at 11:30 AM Todd Fiala wrote:
> tfiala added a comment.
>
> I'm going to test this one now, stacked on top of the final macOS-worki
ldrumm created this revision.
ldrumm added reviewers: zturner, granata.enrico.
ldrumm added a subscriber: LLDB.
Herald added a subscriber: mgorny.
A combination of broken escaping in CMake and in the python swig generation
scripts meant that the swig generation step would fail whenever there were
Sweet. Glad to see that such a large patch had only minor implications.
Thanks for the help!
On Wed, Nov 16, 2016 at 11:28 AM Todd Fiala wrote:
> tfiala accepted this revision.
> tfiala added a comment.
> This revision is now accepted and ready to land.
>
> Here is the adjusted patch that fixes
granata.enrico added a reviewer: beanz.
granata.enrico added a comment.
Chris, can you take a look at this? I am far from a CMake expert
https://reviews.llvm.org/D26757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
granata.enrico added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:229
stderr=subprocess.PIPE,
-shell=True)
+)
# Wait for SWIG process to terminate
This worries me a little bit.. Are we sure we are not in any way
BTW, I would still like to get Chris to take a look at my usage of
llvm::Twine. Even if it works, I'm not sure if I used it correctly.
On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner wrote:
> Either way is fine, I think you might have hit a merge conflict if you
> stacked them, but if you've al
ldrumm added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:229
stderr=subprocess.PIPE,
-shell=True)
+)
# Wait for SWIG process to terminate
granata.enrico wrote:
> This worries me a little bit.. Are we sure we are
What revision should I apply this on top of? It doesn't apply cleanly for
me at tip. I think it's my fault because of the original patch, but now
I'm having trouble getting this modified patch to work. Can you give me a
diff that I can apply on top of my original patch, which is applied on a
cle
(A full patch works too if it's easier, as long as it applies cleanly on
ToT)
On Wed, Nov 16, 2016 at 11:46 AM Zachary Turner wrote:
> What revision should I apply this on top of? It doesn't apply cleanly for
> me at tip. I think it's my fault because of the original patch, but now
> I'm havin
ldrumm added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:229
stderr=subprocess.PIPE,
-shell=True)
+)
# Wait for SWIG process to terminate
bryant wrote:
> ldrumm wrote:
> > granata.enrico wrote:
> > > This worrie
ldrumm added inline comments.
Comment at: CMakeLists.txt:46
+COMMAND
+ ${PYTHON_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
+ --srcRoot=${LLDB_SOURCE_DIR}
bryant wrote:
> You can reduce diff noise b
ldrumm added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:222
+)
+logging.info("running swig with: %r", command)
bryant wrote:
> You can reduce diff noise by limiting your changes to removing the %s. So,
>
> ```python
> # B
ldrumm added inline comments.
Comment at: scripts/CMakeLists.txt:38
+ COMMAND
+${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/prepare_bindings.py
+ ${framework_arg}
bryant wrote:
> Move this back up.
Will do
https://reviews.llvm.org/D26757
__
ldrumm added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:222
+)
+logging.info("running swig with: %r", command)
bryant wrote:
> ldrumm wrote:
> > bryant wrote:
> > > You can reduce diff noise by limiting your changes to removin
Yep - I followed that. I'm just doing the "build + test" verification on
macOS.
On Wed, Nov 16, 2016 at 11:41 AM, Zachary Turner wrote:
> BTW, I would still like to get Chris to take a look at my usage of
> llvm::Twine. Even if it works, I'm not sure if I used it correctly.
>
> On Wed, Nov 16
I got it applied, comitting shortly.
On Wed, Nov 16, 2016 at 11:48 AM Zachary Turner wrote:
> (A full patch works too if it's easier, as long as it applies cleanly on
> ToT)
>
> On Wed, Nov 16, 2016 at 11:46 AM Zachary Turner
> wrote:
>
> What revision should I apply this on top of? It doesn't
Author: zturner
Date: Wed Nov 16 15:34:22 2016
New Revision: 287155
URL: http://llvm.org/viewvc/llvm-project?rev=287155&view=rev
Log:
Update GenerateAdditionalHelpAvenues to take StringRef.
Modified:
lldb/trunk/source/Commands/CommandObjectCommands.cpp
lldb/trunk/source/Commands/CommandOb
Author: zturner
Date: Wed Nov 16 15:45:04 2016
New Revision: 287157
URL: http://llvm.org/viewvc/llvm-project?rev=287157&view=rev
Log:
Make Apropos functions accept StringRefs.
Modified:
lldb/trunk/include/lldb/Core/UserSettingsController.h
lldb/trunk/include/lldb/Interpreter/CommandInterp
Author: zturner
Date: Wed Nov 16 15:45:11 2016
New Revision: 287158
URL: http://llvm.org/viewvc/llvm-project?rev=287158&view=rev
Log:
Fix some unit test compilation failures.
Modified:
lldb/trunk/unittests/Core/TimerTest.cpp
lldb/trunk/unittests/ScriptInterpreter/Python/PythonDataObjectsT
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
The big thing to be aware of about Twines is that they are designed so that
when you construct one the underlying string storage can vanish after the Twine
goes out of scope. Here it look
Hey Todd, Did you run the tests earlier? If so what was the result? No
worries if you didn't run them yet, but it sounded like you were already
kicking it off at 11:30. Just want to make sure you didn't finish and
forget to update with the result :)
On Wed, Nov 16, 2016 at 12:38 PM Todd Fiala
Hey Zachary,
I had to run home unexpectedly. The build worked but I left before the test
results came out.
If you ran it on Linux and the Linux tests passed, we can address issues
that show up on the macOS side.
I will also try it at home on macOS, but I don't think you need to hold up
with the
It's no problem, I actually found a few functions I forgot to convert, so
I'm making some additional changes. Nothing that requires additional
testing, but at the very least I won't be able to get this in until
tomorrow at the earliest, so it's no biggie.
On Wed, Nov 16, 2016 at 3:17 PM Todd Fial
Okay cool. I'm building against this now. Should I hold off testing?
On Wed, Nov 16, 2016 at 3:41 PM, Zachary Turner wrote:
> It's no problem, I actually found a few functions I forgot to convert, so
> I'm making some additional changes. Nothing that requires additional
> testing, but at the
No you can go ahead. The new changes I found are not specific to Mac, I
should find problems if there's any with the additional changes.
On Wed, Nov 16, 2016 at 3:42 PM Todd Fiala wrote:
> Okay cool. I'm building against this now. Should I hold off testing?
>
> On Wed, Nov 16, 2016 at 3:41 PM
Great. Back soon...
On Wed, Nov 16, 2016 at 3:50 PM, Zachary Turner wrote:
> No you can go ahead. The new changes I found are not specific to Mac, I
> should find problems if there's any with the additional changes.
>
> On Wed, Nov 16, 2016 at 3:42 PM Todd Fiala wrote:
>
>> Okay cool. I'm bu
beanz added a comment.
The CMake all LGTM.
https://reviews.llvm.org/D26757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
LGTM! All tests passed on macOS 10.12.2 public beta with Xcode 8.1.
https://reviews.llvm.org/D26721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: zturner
Date: Wed Nov 16 19:37:42 2016
New Revision: 287188
URL: http://llvm.org/viewvc/llvm-project?rev=287188&view=rev
Log:
Convert AutoComplete related code to StringRef.
Differential Revision: https://reviews.llvm.org/D26721
Modified:
lldb/trunk/include/lldb/Core/ArchSpec.h
l
Author: zturner
Date: Wed Nov 16 19:37:52 2016
New Revision: 287189
URL: http://llvm.org/viewvc/llvm-project?rev=287189&view=rev
Log:
Make GetValueForVariableExpression use StringRef.
Also significantly reduced the indentation level by use of
early returns, and simplified some of the logic by usi
Author: zturner
Date: Wed Nov 16 19:38:02 2016
New Revision: 287190
URL: http://llvm.org/viewvc/llvm-project?rev=287190&view=rev
Log:
Convert UriParser to use StringRef.
Modified:
lldb/trunk/include/lldb/Core/UUID.h
lldb/trunk/source/Core/UUID.cpp
lldb/trunk/source/Interpreter/OptionV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287188: Convert AutoComplete related code to StringRef.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D26721?vs=78110&id=78299#toc
Repository:
rL LLVM
https://reviews.llvm
Probably just an oversight, but changing var_expr_cstr to a StringRef, but
leaving it called "_cstr" will cause confusion.
Jim
> On Nov 16, 2016, at 5:37 PM, Zachary Turner via lldb-commits
> wrote:
>
> Author: zturner
> Date: Wed Nov 16 19:37:52 2016
> New Revision: 287189
>
> URL: http://l
Looks like this broke some bots, i can fix it up in about 30 minutes
On Wed, Nov 16, 2016 at 5:47 PM Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: zturner
> Date: Wed Nov 16 19:38:02 2016
> New Revision: 287190
>
> URL: http://llvm.org/viewvc/llvm-project?rev=2871
Author: zturner
Date: Wed Nov 16 23:14:32 2016
New Revision: 287208
URL: http://llvm.org/viewvc/llvm-project?rev=287208&view=rev
Log:
Fix warnings and errors introduced with UUID changes.
Modified:
lldb/trunk/source/Interpreter/OptionValueUUID.cpp
lldb/trunk/source/Target/StackFrame.cpp
Author: zturner
Date: Thu Nov 17 00:13:54 2016
New Revision: 287212
URL: http://llvm.org/viewvc/llvm-project?rev=287212&view=rev
Log:
Fix one more build error with lldb-server.
Modified:
lldb/trunk/tools/lldb-server/Acceptor.cpp
Modified: lldb/trunk/tools/lldb-server/Acceptor.cpp
URL:
http:
52 matches
Mail list logo
